OpeningHour::getWeekDays() - Code Metrics - Inspection of "III-1635 Importing calendar from CdbXml." - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#243)

by Luc

created 2016-11-30 10:56 UTC

OpeningHour::getWeekDays() A

↳ Parent: OpeningHour

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

namespace CultuurNet\UDB3;

use ValueObjects\DateTime\Time;
use ValueObjects\DateTime\WeekDay;

class OpeningHour
{
    /**
     * @var WeekDay[]
     */
    private $weekDays;

    /**
     * @var Time
     */
    private $opens;

    /**
     * @var Time
     */
    private $closes;

    /**
     * OpeningHour constructor.
     * @param WeekDay $weekDay
     * @param Time $opens
     * @param Time $closes
     */
    public function __construct(
        WeekDay $weekDay,
        Time $opens,
        Time $closes
    ) {
        $this->weekDays[] = $weekDay;
        $this->opens = $opens;
        $this->closes = $closes;
    }

    /**
     * @param OpeningHour $otherOpeningHour
     * @return bool
     */
    public function equalHours(OpeningHour $otherOpeningHour)
    {
        return $otherOpeningHour->getOpens()->sameValueAs($this->getOpens()) &&
            $otherOpeningHour->getCloses()->sameValueAs($this->getCloses());
    }

    /**
     * @param OpeningHour $otherOpeningHour
     */
    public function mergeWeekday(OpeningHour $otherOpeningHour)
    {
        $this->weekDays[] = $otherOpeningHour->getWeekDays()[0];
    }

    /**
     * @return WeekDay[]
     */
    public function getWeekDays()
    {
        return $this->weekDays;
    }

    /**
     * @return Time
     */
    public function getOpens()
    {
        return $this->opens;
    }

    /**
     * @return Time
     */
    public function getCloses()
    {
        return $this->closes;
    }
}


1			<?php
2
3			namespace CultuurNet\UDB3;
4
5			use ValueObjects\DateTime\Time;
6			use ValueObjects\DateTime\WeekDay;
7
8			class OpeningHour
9			{
10			/**
11			* @var WeekDay[]
12			*/
13			private $weekDays;
14
15			/**
16			* @var Time
17			*/
18			private $opens;
19
20			/**
21			* @var Time
22			*/
23			private $closes;
24
25			/**
26			* OpeningHour constructor.
27			* @param WeekDay $weekDay
28			* @param Time $opens
29			* @param Time $closes
30			*/
31			public function __construct(
32			WeekDay $weekDay,
33			Time $opens,
34			Time $closes
35			) {
36			$this->weekDays[] = $weekDay;
37			$this->opens = $opens;
38			$this->closes = $closes;
39			}
40
41			/**
42			* @param OpeningHour $otherOpeningHour
43			* @return bool
44			*/
45			public function equalHours(OpeningHour $otherOpeningHour)
46			{
47			return $otherOpeningHour->getOpens()->sameValueAs($this->getOpens()) &&
48			$otherOpeningHour->getCloses()->sameValueAs($this->getCloses());
49			}
50
51			/**
52			* @param OpeningHour $otherOpeningHour
53			*/
54			public function mergeWeekday(OpeningHour $otherOpeningHour)
55			{
56			$this->weekDays[] = $otherOpeningHour->getWeekDays()[0];
57			}
58
59			/**
60			* @return WeekDay[]
61			*/
62			public function getWeekDays()
63			{
64			return $this->weekDays;
65			}
66
67			/**
68			* @return Time
69			*/
70			public function getOpens()
71			{
72			return $this->opens;
73			}
74
75			/**
76			* @return Time
77			*/
78			public function getCloses()
79			{
80			return $this->closes;
81			}
82			}
83

cultuurnet / udb3-php

Pull Request — master (#243)

OpeningHour::getWeekDays() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like