Conditions | 7 |
Paths | 4 |
Total Lines | 293 |
Code Lines | 152 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
53 | public static function createSerializer(ReadRepositoryInterface $labelRepository) |
||
54 | { |
||
55 | $payloadManipulatingSerializer = new PayloadManipulatingSerializer( |
||
56 | new SimpleInterfaceSerializer() |
||
57 | ); |
||
58 | |||
59 | /* |
||
60 | * CREATE EVENTS |
||
61 | * |
||
62 | */ |
||
63 | |||
64 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
65 | 'CultuurNet\UDB3\Event\Events\EventCreated', |
||
66 | function (array $serializedObject) { |
||
67 | return self::addDefaultMainLanguage($serializedObject); |
||
68 | } |
||
69 | ); |
||
70 | |||
71 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
72 | 'CultuurNet\UDB3\Place\Events\PlaceCreated', |
||
73 | function (array $serializedObject) { |
||
74 | return self::addDefaultMainLanguage($serializedObject); |
||
75 | } |
||
76 | ); |
||
77 | |||
78 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
79 | 'CultuurNet\UDB3\Organizer\Events\OrganizerCreatedWithUniqueWebsite', |
||
80 | function (array $serializedObject) { |
||
81 | return self::addDefaultMainLanguage($serializedObject); |
||
82 | } |
||
83 | ); |
||
84 | |||
85 | /* |
||
86 | * TRANSLATION EVENTS |
||
87 | */ |
||
88 | |||
89 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
90 | 'CultuurNet\UDB3\Event\TitleTranslated', |
||
91 | function (array $serializedObject) { |
||
92 | $serializedObject['class'] = TitleTranslated::class; |
||
93 | |||
94 | $serializedObject = self::replaceEventIdWithItemId($serializedObject); |
||
95 | |||
96 | return $serializedObject; |
||
97 | } |
||
98 | ); |
||
99 | |||
100 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
101 | 'CultuurNet\UDB3\Event\DescriptionTranslated', |
||
102 | function (array $serializedObject) { |
||
103 | $serializedObject['class'] = DescriptionTranslated::class; |
||
104 | |||
105 | $serializedObject = self::replaceEventIdWithItemId($serializedObject); |
||
106 | |||
107 | return $serializedObject; |
||
108 | } |
||
109 | ); |
||
110 | |||
111 | /* |
||
112 | * LABEL EVENTS |
||
113 | */ |
||
114 | |||
115 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
116 | 'CultuurNet\UDB3\Label\Events\MadeInvisible', |
||
117 | function (array $serializedObject) use ($labelRepository) { |
||
118 | return self::addLabelName($serializedObject, $labelRepository); |
||
119 | } |
||
120 | ); |
||
121 | |||
122 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
123 | 'CultuurNet\UDB3\Label\Events\MadeVisible', |
||
124 | function (array $serializedObject) use ($labelRepository) { |
||
125 | return self::addLabelName($serializedObject, $labelRepository); |
||
126 | } |
||
127 | ); |
||
128 | |||
129 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
130 | 'CultuurNet\UDB3\Label\Events\MadePrivate', |
||
131 | function (array $serializedObject) use ($labelRepository) { |
||
132 | return self::addLabelName($serializedObject, $labelRepository); |
||
133 | } |
||
134 | ); |
||
135 | |||
136 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
137 | 'CultuurNet\UDB3\Label\Events\MadePublic', |
||
138 | function (array $serializedObject) use ($labelRepository) { |
||
139 | return self::addLabelName($serializedObject, $labelRepository); |
||
140 | } |
||
141 | ); |
||
142 | |||
143 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
144 | 'CultuurNet\UDB3\Organizer\Events\LabelAdded', |
||
145 | function (array $serializedObject) use ($labelRepository) { |
||
146 | return self::fixOrganizerLabelEvent($serializedObject, $labelRepository); |
||
147 | } |
||
148 | ); |
||
149 | |||
150 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
151 | 'CultuurNet\UDB3\Organizer\Events\LabelRemoved', |
||
152 | function (array $serializedObject) use ($labelRepository) { |
||
153 | return self::fixOrganizerLabelEvent($serializedObject, $labelRepository); |
||
154 | } |
||
155 | ); |
||
156 | |||
157 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
158 | 'CultuurNet\UDB3\Event\Events\EventWasLabelled', |
||
159 | function (array $serializedObject) { |
||
160 | $serializedObject['class'] = LabelAdded::class; |
||
161 | |||
162 | $serializedObject = self::replaceEventIdWithItemId($serializedObject); |
||
163 | |||
164 | return $serializedObject; |
||
165 | } |
||
166 | ); |
||
167 | |||
168 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
169 | 'CultuurNet\UDB3\Event\EventWasTagged', |
||
170 | function (array $serializedObject) { |
||
171 | $serializedObject['class'] = LabelAdded::class; |
||
172 | |||
173 | $serializedObject = self::replaceEventIdWithItemId($serializedObject); |
||
174 | |||
175 | $serializedObject = self::replaceKeywordWithLabel($serializedObject); |
||
176 | |||
177 | return $serializedObject; |
||
178 | } |
||
179 | ); |
||
180 | |||
181 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
182 | 'CultuurNet\UDB3\Event\TagErased', |
||
183 | function (array $serializedObject) { |
||
184 | $serializedObject['class'] = LabelRemoved::class; |
||
185 | |||
186 | $serializedObject = self::replaceEventIdWithItemId($serializedObject); |
||
187 | |||
188 | $serializedObject = self::replaceKeywordWithLabel($serializedObject); |
||
189 | |||
190 | return $serializedObject; |
||
191 | } |
||
192 | ); |
||
193 | |||
194 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
195 | 'CultuurNet\UDB3\Event\Events\Unlabelled', |
||
196 | function (array $serializedObject) { |
||
197 | $serializedObject['class'] = LabelRemoved::class; |
||
198 | |||
199 | $serializedObject = self::replaceEventIdWithItemId($serializedObject); |
||
200 | |||
201 | return $serializedObject; |
||
202 | } |
||
203 | ); |
||
204 | |||
205 | /** |
||
206 | * UBD2 IMPORT |
||
207 | */ |
||
208 | |||
209 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
210 | 'CultuurNet\UDB3\Event\EventImportedFromUDB2', |
||
211 | function (array $serializedObject) { |
||
212 | $serializedObject['class'] = EventImportedFromUDB2::class; |
||
213 | |||
214 | return $serializedObject; |
||
215 | } |
||
216 | ); |
||
217 | |||
218 | /** |
||
219 | * PLACE FACILITIES EVENT |
||
220 | */ |
||
221 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
222 | 'CultuurNet\UDB3\Place\Events\FacilitiesUpdated', |
||
223 | function (array $serializedObject) { |
||
224 | $serializedObject = self::replacePlaceIdWithItemId($serializedObject); |
||
225 | |||
226 | return $serializedObject; |
||
227 | } |
||
228 | ); |
||
229 | |||
230 | /** |
||
231 | * GEOCOORDINATES UPDATED EVENT |
||
232 | */ |
||
233 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
234 | 'CultuurNet\UDB3\Place\Events\GeoCoordinatesUpdated', |
||
235 | function (array $serializedObject) { |
||
236 | $serializedObject = self::replacePlaceIdWithItemId($serializedObject); |
||
237 | |||
238 | return $serializedObject; |
||
239 | } |
||
240 | ); |
||
241 | |||
242 | /** |
||
243 | * BOOKING INFO EVENT |
||
244 | */ |
||
245 | $manipulateAvailability = function (array $serializedBookingInfo, $propertyName) { |
||
246 | if (!isset($serializedBookingInfo[$propertyName]) || empty($serializedBookingInfo[$propertyName])) { |
||
247 | $serializedBookingInfo[$propertyName] = null; |
||
248 | return $serializedBookingInfo; |
||
249 | } |
||
250 | |||
251 | $dateTimeString = $serializedBookingInfo[$propertyName]; |
||
252 | |||
253 | // The new serialized date time format is a string according the ISO 8601 format. |
||
254 | // If this is so return without modifications. |
||
255 | $dateTimeFromAtom = \DateTimeImmutable::createFromFormat(\DATE_ATOM, $dateTimeString); |
||
256 | if ($dateTimeFromAtom) { |
||
257 | return $serializedBookingInfo; |
||
258 | } |
||
259 | |||
260 | // For older format a modification is needed to ISO 8601 format. |
||
261 | $dateTimeFromAtomWithMilliseconds = \DateTimeImmutable::createFromFormat( |
||
262 | 'Y-m-d\TH:i:s.uP', |
||
263 | $dateTimeString |
||
264 | ); |
||
265 | if ($dateTimeFromAtomWithMilliseconds) { |
||
266 | $serializedBookingInfo[$propertyName] = $dateTimeFromAtomWithMilliseconds->format(\DATE_ATOM); |
||
267 | return $serializedBookingInfo; |
||
268 | } |
||
269 | |||
270 | // In case of unknown format clear the available date property. |
||
271 | unset($serializedBookingInfo[$propertyName]); |
||
272 | return $serializedBookingInfo; |
||
273 | }; |
||
274 | |||
275 | $manipulateBookingInfoEvent = function (array $serializedEvent) use ($manipulateAvailability) { |
||
276 | $serializedEvent = self::replaceEventIdWithItemId($serializedEvent); |
||
277 | $serializedEvent = self::replacePlaceIdWithItemId($serializedEvent); |
||
278 | |||
279 | $serializedBookingInfo = $serializedEvent['payload']['bookingInfo']; |
||
280 | $serializedBookingInfo = $manipulateAvailability($serializedBookingInfo, 'availabilityStarts'); |
||
281 | $serializedBookingInfo = $manipulateAvailability($serializedBookingInfo, 'availabilityEnds'); |
||
282 | $serializedEvent['payload']['bookingInfo'] = $serializedBookingInfo; |
||
283 | |||
284 | return $serializedEvent; |
||
285 | }; |
||
286 | |||
287 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
288 | EventBookingInfoUpdated::class, |
||
289 | $manipulateBookingInfoEvent |
||
290 | ); |
||
291 | |||
292 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
293 | PlaceBookingInfoUpdated::class, |
||
294 | $manipulateBookingInfoEvent |
||
295 | ); |
||
296 | |||
297 | /** |
||
298 | * EventEvent to AbstractEvent (Offer) |
||
299 | */ |
||
300 | $refactoredEventEvents = [ |
||
301 | EventTypicalAgeRangeDeleted::class, |
||
302 | EventTypicalAgeRangeUpdated::class, |
||
303 | EventContactPointUpdated::class, |
||
304 | MajorInfoUpdated::class, |
||
305 | EventOrganizerUpdated::class, |
||
306 | EventOrganizerDeleted::class, |
||
307 | EventDescriptionUpdated::class, |
||
308 | EventDeleted::class, |
||
309 | ]; |
||
310 | |||
311 | foreach ($refactoredEventEvents as $refactoredEventEvent) { |
||
312 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
313 | $refactoredEventEvent, |
||
314 | function (array $serializedObject) { |
||
315 | $serializedObject = self::replaceEventIdWithItemId($serializedObject); |
||
316 | return $serializedObject; |
||
317 | } |
||
318 | ); |
||
319 | } |
||
320 | |||
321 | /** |
||
322 | * PlaceEvent to AbstractEvent (Offer) |
||
323 | */ |
||
324 | $refactoredPlaceEvents = [ |
||
325 | PlaceOrganizerUpdated::class, |
||
326 | PlaceOrganizerDeleted::class, |
||
327 | PlaceTypicalAgeRangeDeleted::class, |
||
328 | PlaceTypicalAgeRangeUpdated::class, |
||
329 | PlaceContactPointUpdated::class, |
||
330 | PlaceDescriptionUpdated::class, |
||
331 | PlaceDeleted::class, |
||
332 | ]; |
||
333 | |||
334 | foreach ($refactoredPlaceEvents as $refactoredPlaceEvent) { |
||
335 | $payloadManipulatingSerializer->manipulateEventsOfClass( |
||
336 | $refactoredPlaceEvent, |
||
337 | function (array $serializedObject) { |
||
338 | $serializedObject = self::replacePlaceIdWithItemId($serializedObject); |
||
339 | return $serializedObject; |
||
340 | } |
||
341 | ); |
||
342 | } |
||
343 | |||
344 | return $payloadManipulatingSerializer; |
||
345 | } |
||
346 | |||
449 |