CultuurNet\UDB3\OpeningHours

Complexity

Total Complexity

9

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	2
A	addOpeningHour()	0	4	1
A	getOpeningHours()	0	4	1
A	getWeekDays()	0	10	2
A	equalOpeningHour()	0	13	3

<?php

namespace CultuurNet\UDB3;

use ValueObjects\DateTime\WeekDay;

class OpeningHours
{
    /**
     * @var OpeningHour[]
     */
    private $openingHours;

    /**
     * OpeningHours constructor.
     * @param OpeningHour[]|null $openingHours
     */
    public function __construct(array $openingHours = null)
    {
        $this->openingHours = $openingHours ? $openingHours : null;

It seems like $openingHours ? $openingHours : null can be null. However, the property $openingHours is declared as array. Maybe change the type of the property to array|null or add a type check?

    }

    /**
     * @param OpeningHour $openingHour
     */
    public function addOpeningHour(OpeningHour $openingHour)
    {
        $this->openingHours[] = $openingHour;
    }

    /**
     * @return OpeningHour[]
     */
    public function getOpeningHours()
    {
        return $this->openingHours;
    }

    /**
     * @return Weekday[]
     */
    public function getWeekDays()
    {
        $weekdays = [];
        
        foreach ($this->openingHours as $openingHour) {
            $weekdays[] = $openingHour->getWeekDay();
        }
        
        return $weekdays;
    }

    /**
     * @param OpeningHour $otherOpeningHour
     * @return bool
     */
    public function equalOpeningHour(OpeningHour $otherOpeningHour)
    {
        $equal = false;

        foreach ($this->openingHours as $openingHour) {
            if ($openingHour->equalHours($otherOpeningHour)) {
                $equal = true;
                break;
            }
        }

        return $equal;
    }
}