CreateOrganizer::getMainLanguage() - Code Metrics - Inspection of "Feature/iii 2522" - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#345)

unknown

created 2018-03-16 15:28 UTC

CreateOrganizer::getMainLanguage() A

↳ Parent: CreateOrganizer

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

namespace CultuurNet\UDB3\Organizer\Commands;

use CultuurNet\UDB3\Language;
use CultuurNet\UDB3\Title;
use ValueObjects\Web\Url;

class CreateOrganizer extends AbstractOrganizerCommand
{
    /**
     * @var Language
     */
    private $mainLanguage;

    /**
     * @var Url
     */
    private $website;

    /**
     * @var Title
     */
    private $title;

    /**
     * @param string $id
     * @param Language $mainLanguage
     * @param Url $website
     * @param Title $title
     */
    public function __construct(

        $id,
        Language $mainLanguage,
        Url $website,
        Title $title
    ) {
        parent::__construct($id);

        $this->website = $website;
        $this->mainLanguage = $mainLanguage;
        $this->title = $title;
    }

    /**
     * @return Language
     */
    public function getMainLanguage()
    {
        return $this->mainLanguage;
    }

    /**
     * @return Url
     */
    public function getWebsite()
    {
        return $this->website;
    }

    /**
     * @return Title
     */
    public function getTitle()
    {
        return $this->title;
    }
}


1		<?php
2
3		namespace CultuurNet\UDB3\Organizer\Commands;
4
5		use CultuurNet\UDB3\Language;
6		use CultuurNet\UDB3\Title;
7		use ValueObjects\Web\Url;
8
9		class CreateOrganizer extends AbstractOrganizerCommand
10		{
11		/**
12		* @var Language
13		*/
14		private $mainLanguage;
15
16		/**
17		* @var Url
18		*/
19		private $website;
20
21		/**
22		* @var Title
23		*/
24		private $title;
25
26		/**
27		* @param string $id
28		* @param Language $mainLanguage
29		* @param Url $website
30		* @param Title $title
31		*/
32	View Code Duplication	public function __construct(
		0 ignored issues – show Duplication introduced 2018-03-12 16:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		$id,
34		Language $mainLanguage,
35		Url $website,
36		Title $title
37		) {
38		parent::__construct($id);
39
40		$this->website = $website;
41		$this->mainLanguage = $mainLanguage;
42		$this->title = $title;
43		}
44
45		/**
46		* @return Language
47		*/
48		public function getMainLanguage()
49		{
50		return $this->mainLanguage;
51		}
52
53		/**
54		* @return Url
55		*/
56		public function getWebsite()
57		{
58		return $this->website;
59		}
60
61		/**
62		* @return Title
63		*/
64		public function getTitle()
65		{
66		return $this->title;
67		}
68		}
69

cultuurnet / udb3-php

Pull Request — master (#345)

CreateOrganizer::getMainLanguage() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like