Completed
Pull Request — master (#240)
by Kristof
04:48
created
src/Role/Events/AbstractConstraintEvent.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace CultuurNet\UDB3\Role\Commands;
4 4
 
5 5
 use ValueObjects\Identity\UUID;
6
-use ValueObjects\String\String as stringLiteral;
7 6
 
8 7
 class RenameRole extends AbstractCommand
9 8
 {
Please login to merge, or discard this patch.
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
     /**
16 16
      * AbstractPermissionEvent constructor.
17 17
      * @param UUID $uuid
18
-     * @param StringLiteral $query
18
+     * @param stringLiteral $query
19 19
      */
20 20
     public function __construct(UUID $uuid, StringLiteral $query)
21 21
     {
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
     }
25 25
 
26 26
     /**
27
-     * @return StringLiteral
27
+     * @return string|null
28 28
      */
29 29
     public function getQuery()
30 30
     {
Please login to merge, or discard this patch.
src/Role/Role.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@
 block discarded – undo
116 116
     }
117 117
 
118 118
     /**
119
-     * @return string
119
+     * @return UUID
120 120
      */
121 121
     public function getFileId()
122 122
     {
Please login to merge, or discard this patch.
src/Label/OfferLabelDomainMessageEnricher.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -46,14 +46,14 @@
 block discarded – undo
46 46
 
47 47
             $labelDetail = $this->readRepository->getByName(
48 48
                 new StringLiteral(
49
-                    (string) $payload->getLabel()
49
+                    (string)$payload->getLabel()
50 50
                 )
51 51
             );
52 52
 
53 53
             if ($labelDetail) {
54 54
                 $extraMetadata = new Metadata(
55 55
                     [
56
-                        'labelUuid' => (string) $labelDetail->getUuid(),
56
+                        'labelUuid' => (string)$labelDetail->getUuid(),
57 57
                     ]
58 58
                 );
59 59
 
Please login to merge, or discard this patch.
src/Label/ReadModels/JSON/Projector.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@
 block discarded – undo
142 142
     {
143 143
         $uuid = null;
144 144
 
145
-        $name = new StringLiteral((string) $labelEvent->getLabel());
145
+        $name = new StringLiteral((string)$labelEvent->getLabel());
146 146
 
147 147
         $entity = $this->readRepository->getByName($name);
148 148
         if ($entity !== null) {
Please login to merge, or discard this patch.
src/Label/LabelEventOfferTypeResolver.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,6 +47,6 @@
 block discarded – undo
47 47
      */
48 48
     private function createIllegalArgumentMessage(AbstractLabelEvent $labelEvent)
49 49
     {
50
-        return 'Event with type ' . get_class($labelEvent) . ' can not be converted to a relation type!';
50
+        return 'Event with type '.get_class($labelEvent).' can not be converted to a relation type!';
51 51
     }
52 52
 }
Please login to merge, or discard this patch.
src/Role/ReadModel/Search/Doctrine/DBALRepository.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 
82 82
         if (!empty($query)) {
83 83
             $q->where($expr->like('name', ':role_name'));
84
-            $q->setParameter('role_name', '%' . $query . '%');
84
+            $q->setParameter('role_name', '%'.$query.'%');
85 85
         }
86 86
 
87 87
         $results = $q->execute()->fetchAll(\PDO::FETCH_ASSOC);
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 
97 97
         if (!empty($query)) {
98 98
             $q->where($expr->like('name', ':role_name'));
99
-            $q->setParameter('role_name', '%' . $query . '%');
99
+            $q->setParameter('role_name', '%'.$query.'%');
100 100
         }
101 101
 
102 102
         $total = $q->execute()->fetchColumn();
Please login to merge, or discard this patch.
src/Address/DefaultAddressFormatter.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,9 +12,9 @@
 block discarded – undo
12 12
      */
13 13
     public function format(Address $address)
14 14
     {
15
-        return $address->getStreetAddress() . ', ' .
16
-            $address->getPostalCode() . ' ' .
17
-            $address->getLocality() . ', ' .
15
+        return $address->getStreetAddress().', '.
16
+            $address->getPostalCode().' '.
17
+            $address->getLocality().', '.
18 18
             $address->getCountry();
19 19
     }
20 20
 }
Please login to merge, or discard this patch.
src/Label/ReadModels/Relations/Repository/Doctrine/ReadRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
     public function getOfferLabelRelations(UUID $labelId)
16 16
     {
17 17
         $aliases = $this->getAliases();
18
-        $whereUuid = SchemaConfigurator::UUID_COLUMN . ' = ?';
18
+        $whereUuid = SchemaConfigurator::UUID_COLUMN.' = ?';
19 19
 
20 20
         $queryBuilder = $this->createQueryBuilder()->select($aliases)
21 21
             ->from($this->getTableName()->toNative())
Please login to merge, or discard this patch.
src/StringFilter/NewlineToSpaceStringFilter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
     public function filter($string)
12 12
     {
13 13
         if (!is_string($string)) {
14
-            throw new \InvalidArgumentException('Argument should be string, got ' . gettype($string) . ' instead.');
14
+            throw new \InvalidArgumentException('Argument should be string, got '.gettype($string).' instead.');
15 15
         }
16 16
 
17 17
         return preg_replace("/(\\n)+/", " ", $string);
Please login to merge, or discard this patch.