cultuurnet / udb3-php

src/Media/Serialization/MediaObjectSerializer.php

Unused Use Statements -3 removed lines

@@ -3,12 +3,9 @@
 namespace CultuurNet\UDB3\Media\Serialization;
 
 use CultuurNet\UDB3\Iri\IriGeneratorInterface;
-use CultuurNet\UDB3\Media\MediaObject;
 use CultuurNet\UDB3\Media\Properties\MIMEType;
-use Symfony\Component\HttpFoundation\File\MimeType\ExtensionGuesser;
 use Symfony\Component\Serializer\Exception\UnsupportedException;
 use Symfony\Component\Serializer\SerializerInterface;
-use ValueObjects\Web\Url;
 
 class MediaObjectSerializer implements SerializerInterface
 {

Spacing +5 added lines, -5 removed lines

@@ -36,10 +36,10 @@ 
         $normalizedData = [
             '@id' => $this->iriGenerator->iri($mediaObject->getMediaObjectId()),
             '@type' => $this->serializeMimeType($mediaObject->getMimeType()),
-            'contentUrl' => (string) $mediaObject->getSourceLocation(),
-            'thumbnailUrl' => (string) $mediaObject->getSourceLocation(),
-            'description' => (string) $mediaObject->getDescription(),
-            'copyrightHolder' => (string) $mediaObject->getCopyrightHolder(),
+            'contentUrl' => (string)$mediaObject->getSourceLocation(),
+            'thumbnailUrl' => (string)$mediaObject->getSourceLocation(),
+            'description' => (string)$mediaObject->getDescription(),
+            'copyrightHolder' => (string)$mediaObject->getCopyrightHolder(),
         ];
 
         return $normalizedData;
@@ -47,7 +47,7 @@ 
 
     public function serializeMimeType(MIMEType $mimeType)
     {
-        $typeParts = explode('/', (string) $mimeType);
+        $typeParts = explode('/', (string)$mimeType);
         $type = array_shift($typeParts);
 
         if ($type !== 'image') {

src/Media/MediaManager.php

Spacing +2 added lines, -2 removed lines

@@ -115,7 +115,7 @@ 
             Url::fromNative($destinationIri)
         );
 
-        $jobInfo = ['file_id' => (string) $uploadImage->getFileId()];
+        $jobInfo = ['file_id' => (string)$uploadImage->getFileId()];
         $this->logger->info('job_info', $jobInfo);
     }
 
@@ -125,7 +125,7 @@ 
     public function get(UUID $fileId)
     {
         try {
-            $mediaObject = $this->repository->load((string) $fileId);
+            $mediaObject = $this->repository->load((string)$fileId);
         } catch (AggregateNotFoundException $e) {
             throw new MediaObjectNotFoundException(
                 sprintf("Media object with id '%s' not found", $fileId),

src/Media/Image.php

Spacing +5 added lines, -5 removed lines

@@ -109,11 +109,11 @@
     public function serialize()
     {
         return [
-            'media_object_id' => (string) $this->getMediaObjectId(),
-            'mime_type' => (string) $this->getMimeType(),
-            'description' => (string) $this->getDescription(),
-            'copyright_holder' => (string) $this->getCopyrightHolder(),
-            'source_location' => (string) $this->getSourceLocation()
+            'media_object_id' => (string)$this->getMediaObjectId(),
+            'mime_type' => (string)$this->getMimeType(),
+            'description' => (string)$this->getDescription(),
+            'copyright_holder' => (string)$this->getCopyrightHolder(),
+            'source_location' => (string)$this->getSourceLocation()
         ];
     }
 }

src/Media/Events/MediaObjectCreated.php

Spacing +1 added lines, -1 removed lines

@@ -107,7 +107,7 @@
             'mime_type' => $this->getMimeType()->toNative(),
             'description' => $this->getDescription()->toNative(),
             'copyright_holder' => $this->getCopyrightHolder()->toNative(),
-            'source_location' => (string) $this->getSourceLocation()
+            'source_location' => (string)$this->getSourceLocation()
         );
     }
 

src/Event/Event.php

Spacing +1 added lines, -1 removed lines

@@ -462,7 +462,7 @@
     {
         $duplicateMediaObject = array_filter(
             $this->getMediaObjects(),
-            function ($existingMediaObjectId) use ($image) {
+            function($existingMediaObjectId) use ($image) {
                 return $image
                     ->getMediaObjectId()
                     ->sameValueAs($existingMediaObjectId);

Doc Comments +4 added lines, -6 removed lines

@@ -86,6 +86,7 @@ 
      * @param Location $location
      * @param CalendarInterface $calendar
      * @param Theme/null $theme
+     * @param string $eventId
      *
      * @return Event
      */
@@ -195,9 +196,9 @@ 
 
     /**
      * @param Language $language
-     * @param String|null $title
-     * @param String|null $shortDescription
-     * @param String|null $longDescription
+     * @param null|string $title
+     * @param null|string $shortDescription
+     * @param null|string $longDescription
      */
     public function applyTranslation(
         Language $language,
@@ -394,9 +395,6 @@ 
     /**
      * Updated the contact info.
      *
-     * @param array $phones
-     * @param array $emails
-     * @param array $urls
      */
     public function updateContactPoint(ContactPoint $contactPoint)
     {

Unused Use Statements -8 removed lines

@@ -2,7 +2,6 @@ 
 
 namespace CultuurNet\UDB3\Event;
 
-use Broadway\EventSourcing\EventSourcedAggregateRoot;
 use CultuurNet\UDB3\BookingInfo;
 use CultuurNet\UDB3\CalendarInterface;
 use CultuurNet\UDB3\Cdb\EventItemFactory;
@@ -42,18 +41,11 @@ 
 use CultuurNet\UDB3\Language;
 use CultuurNet\UDB3\Location;
 use CultuurNet\UDB3\Media\Image;
-use CultuurNet\UDB3\Media\MediaObject;
-use CultuurNet\UDB3\Media\Properties\MIMEType;
-use CultuurNet\UDB3\Offer\Events\AbstractDescriptionTranslated;
-use CultuurNet\UDB3\Offer\Events\AbstractLabelAdded;
-use CultuurNet\UDB3\Offer\Events\AbstractLabelDeleted;
-use CultuurNet\UDB3\Offer\Events\AbstractTitleTranslated;
 use CultuurNet\UDB3\Offer\Offer;
 use CultuurNet\UDB3\Title;
 use CultuurNet\UDB3\Translation;
 use ValueObjects\Identity\UUID;
 use ValueObjects\String\String;
-use ValueObjects\Web\Url;
 
 class Event extends Offer
 {

src/Offer/ImageUpdateTrait.php

Spacing +3 added lines, -3 removed lines

@@ -89,9 +89,9 @@
     {
         return array(
             'item_id' => $this->itemId,
-            'media_object_id' => (string) $this->mediaObjectId,
-            'description' => (string) $this->description,
-            'copyright_holder' => (string) $this->copyrightHolder
+            'media_object_id' => (string)$this->mediaObjectId,
+            'description' => (string)$this->description,
+            'copyright_holder' => (string)$this->copyrightHolder
         );
     }
 

src/Event/EventCommandHandler.php

Unused Use Statements -3 removed lines

@@ -4,7 +4,6 @@ 
 namespace CultuurNet\UDB3\Event;
 
 use Broadway\Repository\RepositoryInterface;
-use CultuurNet\UDB3\CommandHandling\Udb3CommandHandler;
 use CultuurNet\UDB3\Event\Commands\AddImage;
 use CultuurNet\UDB3\Event\Commands\AddLabel;
 use CultuurNet\UDB3\Event\Commands\DeleteEvent;
@@ -23,9 +22,7 @@ 
 use CultuurNet\UDB3\Event\Commands\UpdateTypicalAgeRange;
 use CultuurNet\UDB3\Label as Label;
 use CultuurNet\UDB3\Offer\OfferCommandHandler;
-use CultuurNet\UDB3\Search\Results;
 use CultuurNet\UDB3\Search\SearchServiceInterface;
-use Guzzle\Http\Exception\ClientErrorResponseException;
 use Psr\Log\LoggerAwareInterface;
 use Psr\Log\LoggerAwareTrait;
 

src/Event/ReadModel/JSONLD/EventLDProjector.php

Unused Use Statements -6 removed lines

@@ -13,7 +13,6 @@ 
 use CultuurNet\UDB3\CulturefeedSlugger;
 use CultuurNet\UDB3\EntityNotFoundException;
 use CultuurNet\UDB3\Event\DescriptionTranslated;
-use CultuurNet\UDB3\Event\EventEvent;
 use CultuurNet\UDB3\Event\Events\BookingInfoUpdated;
 use CultuurNet\UDB3\Event\Events\ContactPointUpdated;
 use CultuurNet\UDB3\Event\Events\DescriptionUpdated;
@@ -42,20 +41,15 @@ 
 use CultuurNet\UDB3\Event\ReadModel\JSONLD\OrganizerServiceInterface;
 use CultuurNet\UDB3\Event\ReadModel\JSONLD\PlaceServiceInterface;
 use CultuurNet\UDB3\Event\TitleTranslated;
-use CultuurNet\UDB3\EventHandling\DelegateEventHandlingToSpecificMethodTrait;
 use CultuurNet\UDB3\EventServiceInterface;
 use CultuurNet\UDB3\Iri\IriGeneratorInterface;
-use CultuurNet\UDB3\Label;
 use CultuurNet\UDB3\LabelCollection;
 use CultuurNet\UDB3\Offer\ReadModel\JSONLD\CdbXMLItemBaseImporter;
 use CultuurNet\UDB3\Offer\ReadModel\JSONLD\OfferLDProjector;
-use CultuurNet\UDB3\Media\Serialization\MediaObjectSerializer;
 use CultuurNet\UDB3\Organizer\OrganizerProjectedToJSONLD;
 use CultuurNet\UDB3\OrganizerService;
 use CultuurNet\UDB3\Place\PlaceProjectedToJSONLD;
 use CultuurNet\UDB3\PlaceService;
-use CultuurNet\UDB3\ReadModel\JsonDocument;
-use CultuurNet\UDB3\SluggerInterface;
 use CultuurNet\UDB3\StringFilter\StringFilterInterface;
 use CultuurNet\UDB3\Theme;
 use Symfony\Component\Serializer\SerializerInterface;

Doc Comments +4 added lines, -1 removed lines

@@ -369,7 +369,7 @@ 
     /**
      * Return the media of an event if it already exists.
      *
-     * @param $eventId
+     * @param string $eventId
      *  The id of the event.
      *
      * @return array
@@ -867,6 +867,9 @@ 
         return $document;
     }
 
+    /**
+     * @param string $eventId
+     */
     private function generateSameAs($eventId, $name)
     {
         $eventSlug = $this->slugger->slug($name);

Indentation +2 added lines, -2 removed lines

@@ -477,7 +477,7 @@ 
 
         $jsonLD->name->nl = $majorInfoUpdated->getTitle();
         $jsonLD->location = array(
-          '@type' => 'Place',
+            '@type' => 'Place',
         ) + (array)$this->placeJSONLD($majorInfoUpdated->getLocation()->getCdbid());
 
         $calendarJsonLD = $majorInfoUpdated->getCalendar()->toJsonLd();
@@ -683,7 +683,7 @@ 
         $eventLd = $document->getBody();
 
         $eventLd->organizer = array(
-          '@type' => 'Organizer',
+            '@type' => 'Organizer',
         ) + (array)$this->organizerJSONLD($organizerUpdated->getOrganizerId());
 
         $this->repository->save($document->withBody($eventLd));

Spacing +9 added lines, -9 removed lines

@@ -270,7 +270,7 @@ 
     ) {
         $this->saveNewDocument(
             $eventId,
-            function (\stdClass $eventLd) use ($eventId, $cdbXmlNamespaceUri, $cdbXml, $domainMessage) {
+            function(\stdClass $eventLd) use ($eventId, $cdbXmlNamespaceUri, $cdbXml, $domainMessage) {
                 $eventLd = $this->projectEventCdbXmlToObject(
                     $eventLd,
                     $eventId,
@@ -327,13 +327,13 @@ 
     ) {
         $this->saveNewDocument(
             $eventId,
-            function (\stdClass $eventLd) use ($cdbXmlNamespaceUri, $eventId, $cdbXml) {
+            function(\stdClass $eventLd) use ($cdbXmlNamespaceUri, $eventId, $cdbXml) {
                 return $this->projectEventCdbXmlToObject(
                     $eventLd,
                     $eventId,
                     $cdbXmlNamespaceUri,
                     $cdbXml
-                ) ;
+                );
             }
         );
     }
@@ -409,7 +409,7 @@ 
     ) {
         $this->saveNewDocument(
             $eventCreated->getEventId(),
-            function (\stdClass $jsonLD) use ($eventCreated, $domainMessage) {
+            function(\stdClass $jsonLD) use ($eventCreated, $domainMessage) {
                 $jsonLD->{'@id'} = $this->iriGenerator->iri(
                     $eventCreated->getEventId()
                 );
@@ -481,11 +481,11 @@ 
         ) + (array)$this->placeJSONLD($majorInfoUpdated->getLocation()->getCdbid());
 
         $calendarJsonLD = $majorInfoUpdated->getCalendar()->toJsonLd();
-        $jsonLD = (object) array_merge((array) $jsonLD, $calendarJsonLD);
+        $jsonLD = (object)array_merge((array)$jsonLD, $calendarJsonLD);
 
         // Remove old theme and event type.
-        $jsonLD->terms = array_filter($jsonLD->terms, function ($term) {
-            return $term->domain !== EventType::DOMAIN &&  $term->domain !== Theme::DOMAIN;
+        $jsonLD->terms = array_filter($jsonLD->terms, function($term) {
+            return $term->domain !== EventType::DOMAIN && $term->domain !== Theme::DOMAIN;
         });
 
         $eventType = $majorInfoUpdated->getEventType();
@@ -811,7 +811,7 @@ 
             return;
         }
 
-        $imageId = (string) $imageRemoved->getImage()->getMediaObjectId();
+        $imageId = (string)$imageRemoved->getImage()->getMediaObjectId();
 
         /**
          * Matches any object that is not the removed image.
@@ -822,7 +822,7 @@ 
          * @return bool
          *  Returns true when the media object does not match the image to remove.
          */
-        $shouldNotBeRemoved = function ($mediaObject) use ($imageId) {
+        $shouldNotBeRemoved = function($mediaObject) use ($imageId) {
             $containsId = !!strpos($mediaObject->{'@id'}, $imageId);
             return !$containsId;
         };

src/LocalEntityService.php

Doc Comments +3 added lines

@@ -78,6 +78,9 @@
         return $document->getRawBody();
     }
 
+    /**
+     * @param string $id
+     */
     public function iri($id)
     {
         return $this->iriGenerator->iri($id);