cultuurnet / udb3-php

src/Event/ReadModel/History/HistoryProjector.php

Unused Use Statements -5 removed lines

@@ -5,9 +5,7 @@ 
 
 namespace CultuurNet\UDB3\Event\ReadModel\History;
 
-use Broadway\Domain\DateTime;
 use Broadway\Domain\DomainMessage;
-use Broadway\Domain\Metadata;
 use Broadway\EventHandling\EventListenerInterface;
 use CultuurNet\UDB3\Cdb\EventItemFactory;
 use CultuurNet\UDB3\Event\DescriptionTranslated;
@@ -21,11 +19,8 @@ 
 use CultuurNet\UDB3\Event\Events\LabelsMerged;
 use CultuurNet\UDB3\Event\Events\TranslationDeleted;
 use CultuurNet\UDB3\Event\Events\LabelDeleted;
-use CultuurNet\UDB3\Event\ReadModel\DocumentRepositoryInterface;
 use CultuurNet\UDB3\Event\TitleTranslated;
-use CultuurNet\UDB3\EventHandling\DelegateEventHandlingToSpecificMethodTrait;
 use CultuurNet\UDB3\Offer\ReadModel\History\OfferHistoryProjector;
-use CultuurNet\UDB3\ReadModel\JsonDocument;
 use ValueObjects\String\String;
 
 class HistoryProjector extends OfferHistoryProjector implements EventListenerInterface

Spacing +5 added lines, -5 removed lines

@@ -75,7 +75,7 @@ 
                     $domainMessage->getRecordedOn()
                 ),
                 new String(
-                    'Aangemaakt via EntryAPI door consumer "' . $consumerName . '"'
+                    'Aangemaakt via EntryAPI door consumer "'.$consumerName.'"'
                 ),
                 $this->getAuthorFromMetadata($domainMessage->getMetadata())
             )
@@ -95,7 +95,7 @@ 
                     $domainMessage->getRecordedOn()
                 ),
                 new String(
-                    'Geüpdatet via EntryAPI door consumer "' . $consumerName . '"'
+                    'Geüpdatet via EntryAPI door consumer "'.$consumerName.'"'
                 ),
                 $this->getAuthorFromMetadata($domainMessage->getMetadata())
             )
@@ -126,7 +126,7 @@ 
         $labels = $labelsMerged->getLabels()->toStrings();
         // Quote labels.
         $quotedLabels = array_map(
-            function ($label) {
+            function($label) {
                 return "'{$label}'";
             },
             $labels
@@ -138,7 +138,7 @@ 
         $consumerName = $this->getConsumerFromMetadata($domainMessage->getMetadata());
 
         if ($consumerName) {
-            $message .= ' via EntryAPI door consumer "' . $consumerName . '"';
+            $message .= ' via EntryAPI door consumer "'.$consumerName.'"';
         }
 
         $this->writeHistory(
@@ -200,7 +200,7 @@ 
         $consumerName = $this->getConsumerFromMetadata($domainMessage->getMetadata());
 
         if ($consumerName) {
-            $message .= ' via EntryAPI door consumer "' . $consumerName . '"';
+            $message .= ' via EntryAPI door consumer "'.$consumerName.'"';
         }
 
         $this->writeHistory(

src/LocalEntityService.php

Doc Comments +3 added lines

@@ -78,6 +78,9 @@
         return $document->getRawBody();
     }
 
+    /**
+     * @param string $id
+     */
     public function iri($id)
     {
         return $this->iriGenerator->iri($id);

src/Offer/ReadModel/History/OfferHistoryProjector.php

Doc Comments +2 added lines, -2 removed lines

@@ -125,7 +125,7 @@ 
     }
 
     /**
-     * @param $dateString
+     * @param string $dateString
      * @return \DateTime
      */
     private function dateFromUdb2DateString($dateString)
@@ -351,7 +351,7 @@ 
 
     /**
      * @param string $eventId
-     * @param Log[]|Log $logs
+     * @param Log $logs
      */
     protected function writeHistory($eventId, $logs)
     {

Spacing +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
 
             if (preg_match('/^apply(.+)$/', $method, $matches)) {
                 $event = $matches[1];
-                $classNameMethod = 'get' . $event . 'ClassName';
+                $classNameMethod = 'get'.$event.'ClassName';
 
                 if (method_exists($this, $classNameMethod)) {
                     $eventFullClassName = call_user_func(array($this, $classNameMethod));

src/Offer/Events/AbstractLabelEvent.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
     public function serialize()
     {
         return parent::serialize() + array(
-            'label' => (string) $this->label,
+            'label' => (string)$this->label,
         );
     }
 

src/EventExport/EventExportService.php

Doc Comments +2 added lines, -2 removed lines

@@ -91,7 +91,7 @@ 
      *  A selection of items that will be included in the export.
      *  When left empty the whole query will export.
      *
-     * @return bool|string
+     * @return false|string
      *  The destination url of the export file or false if no events were found.
      */
     public function exportEvents(
@@ -263,7 +263,7 @@ 
      * Generator that yields each unique search result.
      *
      * @param int $totalItemCount
-     * @param string|object $query
+     * @param EventExportQuery $query
      * @param LoggerInterface $logger
      *
      * @return \Generator

Spacing +3 added lines, -3 removed lines

@@ -172,7 +172,7 @@ 
 
             if (!$moved) {
                 throw new \RuntimeException(
-                    'Unable to move export file to public directory ' .
+                    'Unable to move export file to public directory '.
                     $this->publicDirectory
                 );
             }
@@ -259,8 +259,8 @@ 
     ) {
         $fileUniqueId = basename($tmpPath);
         $extension = $fileFormat->getFileNameExtension();
-        $finalFileName = $fileUniqueId . '.' . $extension;
-        $finalPath = $this->publicDirectory . '/' . $finalFileName;
+        $finalFileName = $fileUniqueId.'.'.$extension;
+        $finalPath = $this->publicDirectory.'/'.$finalFileName;
 
         return $finalPath;
     }

src/Offer/ReadModel/Permission/Doctrine/DBALRepository.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 use CultuurNet\UDB3\Event\ReadModel\Permission\PermissionQueryInterface;
 use Doctrine\DBAL\Connection;
 use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
-use Doctrine\DBAL\Schema\Schema;
 use CultuurNet\UDB3\Event\ReadModel\Permission\PermissionRepositoryInterface;
 use ValueObjects\String\String;
 

src/Event/EventEditingServiceInterface.php

Unused Use Statements -4 removed lines

@@ -7,12 +7,8 @@
 
 use CultuurNet\UDB3\CalendarInterface;
 use CultuurNet\UDB3\ContactPoint;
-use CultuurNet\UDB3\EventNotFoundException;
-use CultuurNet\UDB3\Label;
-use CultuurNet\UDB3\Language;
 use CultuurNet\UDB3\Location;
 use CultuurNet\UDB3\Media\Image;
-use CultuurNet\UDB3\Media\MediaObject;
 use CultuurNet\UDB3\Title;
 use ValueObjects\String\String;
 

Doc Comments +10 added lines, -2 removed lines

@@ -23,6 +23,7 @@ 
      *
      * @param string $id
      * @param string $description
+     * @return string
      */
     public function updateDescription($id, $description);
 
@@ -31,6 +32,7 @@ 
      *
      * @param string $id
      * @param string $ageRange
+     * @return string
      */
     public function updateTypicalAgeRange($id, $ageRange);
 
@@ -38,6 +40,7 @@ 
      * Delete the typical age range of a place.
      *
      * @param string $id
+     * @return string
      */
     public function deleteTypicalAgeRange($id);
 
@@ -46,6 +49,7 @@ 
      *
      * @param string $id
      * @param string $organizerId
+     * @return string
      */
     public function updateOrganizer($id, $organizerId);
 
@@ -54,6 +58,7 @@ 
      *
      * @param string $id
      * @param string $organizerId
+     * @return string
      */
     public function deleteOrganizer($id, $organizerId);
 
@@ -62,6 +67,7 @@ 
      *
      * @param string $id
      * @param ContactPoint $contactPoint
+     * @return string
      */
     public function updateContactPoint($id, ContactPoint $contactPoint);
 
@@ -70,6 +76,7 @@ 
      *
      * @param string $id
      * @param Image $image
+     * @return string
      */
     public function addImage($id, Image $image);
 
@@ -96,6 +103,7 @@ 
      *
      * @param string $id
      * @param Image $image
+     * @return string
      */
     public function removeImage($id, Image $image);
 
@@ -103,7 +111,7 @@ 
      * @param Title $title
      * @param EventType $eventType
      * @param Location $location
-     * @param CalendarBase $calendar
+     * @param CalendarInterface $calendar
      * @param Theme/null $theme
      *
      * @return string $eventId
@@ -115,7 +123,7 @@ 
      * @param Title $title
      * @param EventType $eventType
      * @param Location $location
-     * @param CalendarBase $calendar
+     * @param CalendarInterface $calendar
      * @param Theme/null $theme
      *
      * @return string $eventId

src/Offer/Events/AbstractDescriptionTranslated.php

Doc Comments +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
     }
 
     /**
-     * @return String
+     * @return string
      */
     public function getDescription()
     {

src/Offer/Commands/AbstractTranslateDescription.php

Doc Comments +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
     }
 
     /**
-     * @return String
+     * @return string
      */
     public function getDescription()
     {