Completed
Pull Request — master (#252)
by Kristof
05:51 queued 49s
created
src/Variations/Model/Events/OfferVariationEvent.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
     public function serialize()
38 38
     {
39 39
         return array(
40
-            'id' => (string) $this->getId(),
40
+            'id' => (string)$this->getId(),
41 41
         );
42 42
     }
43 43
 
Please login to merge, or discard this patch.
src/Variations/Model/Events/OfferVariationCreated.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -94,10 +94,10 @@
 block discarded – undo
94 94
     public function serialize()
95 95
     {
96 96
         return parent::serialize() + array(
97
-            'origin_url' => (string) $this->getOriginUrl(),
98
-            'owner_id' => (string) $this->getOwnerId(),
99
-            'purpose' => (string) $this->getPurpose(),
100
-            'description' => (string) $this->getDescription(),
97
+            'origin_url' => (string)$this->getOriginUrl(),
98
+            'owner_id' => (string)$this->getOwnerId(),
99
+            'purpose' => (string)$this->getPurpose(),
100
+            'description' => (string)$this->getDescription(),
101 101
         );
102 102
     }
103 103
 
Please login to merge, or discard this patch.
src/Variations/ReadModel/Search/Doctrine/DBALRepository.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -49,11 +49,11 @@
 block discarded – undo
49 49
         $this->connection->insert(
50 50
             $this->connection->quoteIdentifier($this->tableName),
51 51
             [
52
-                'id' => (string) $variationId,
53
-                'owner' => (string) $ownerId,
54
-                'purpose' => (string) $purpose,
52
+                'id' => (string)$variationId,
53
+                'owner' => (string)$ownerId,
54
+                'purpose' => (string)$purpose,
55 55
                 'inserted' => time(),
56
-                'origin_url' => (string) $eventUrl,
56
+                'origin_url' => (string)$eventUrl,
57 57
             ]
58 58
         );
59 59
 
Please login to merge, or discard this patch.
src/ReadModel/Index/Doctrine/DBALRepository.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -252,7 +252,7 @@
 block discarded – undo
252 252
 
253 253
         $results = $q->execute();
254 254
         $offerIdentifierArray = array_map(
255
-            function ($resultRow) {
255
+            function($resultRow) {
256 256
                 $offerIdentifier = new IriOfferIdentifier(
257 257
                     $resultRow['entity_id'],
258 258
                     OfferType::fromNative(ucfirst($resultRow['entity_type']))
Please login to merge, or discard this patch.
Doc Comments   +8 added lines, -1 removed lines patch added patch discarded remove patch
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
     }
187 187
 
188 188
     /**
189
-     * @param $id
189
+     * @param string $id
190 190
      * @param EntityType $entityType
191 191
      * @return bool
192 192
      */
@@ -316,6 +316,9 @@  discard block
 block discarded – undo
316 316
         );
317 317
     }
318 318
 
319
+    /**
320
+     * @param string $userId
321
+     */
319 322
     private function getPagedDashboardItems(
320 323
         $userId,
321 324
         Natural $limit,
@@ -340,6 +343,10 @@  discard block
 block discarded – undo
340 343
 
341 344
         $results = $queryBuilder->execute();
342 345
         $offerIdentifierArray = array_map(
346
+
347
+            /**
348
+             * @param string $resultRow
349
+             */
343 350
             function ($resultRow) {
344 351
                 $offerIdentifier = new IriOfferIdentifier(
345 352
                     $resultRow['entity_iri'],
Please login to merge, or discard this patch.
src/ReadModel/Index/Projector.php 3 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
             );
137 137
         }
138 138
 
139
-        return isset($userId) ? (string) $userId : '';
139
+        return isset($userId) ? (string)$userId : '';
140 140
     }
141 141
 
142 142
     /**
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
         $this->updateIndex(
225 225
             $itemId,
226 226
             $itemType,
227
-            (string) $userId,
227
+            (string)$userId,
228 228
             $name,
229 229
             $postalCode,
230 230
             $this->UDB2Domain,
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -421,7 +421,7 @@
 block discarded – undo
421 421
     }
422 422
 
423 423
     /**
424
-     * @param $dateString
424
+     * @param string $dateString
425 425
      *  A UDB2 formatted date string
426 426
      *
427 427
      * @return DateTimeInterface
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,6 @@
 block discarded – undo
15 15
 use CultuurNet\UDB3\EventHandling\DelegateEventHandlingToSpecificMethodTrait;
16 16
 use CultuurNet\UDB3\Offer\Events\AbstractEventWithIri;
17 17
 use CultuurNet\UDB3\Offer\IriOfferIdentifierFactoryInterface;
18
-use CultuurNet\UDB3\Organizer\Events\OrganizerDeleted;
19 18
 use CultuurNet\UDB3\Place\Events\PlaceCreated;
20 19
 use CultuurNet\UDB3\Place\Events\PlaceDeleted;
21 20
 use CultuurNet\UDB3\Place\Events\PlaceImportedFromUDB2;
Please login to merge, or discard this patch.
src/ReadModel/Index/EntityIriGeneratorFactory.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,8 +23,8 @@
 block discarded – undo
23 23
     {
24 24
         $baseUrl = $this->baseUrl;
25 25
         return new CallableIriGenerator(
26
-            function ($cdbid) use ($baseUrl, $entityType) {
27
-                return $baseUrl . '/' . $entityType . '/' . $cdbid;
26
+            function($cdbid) use ($baseUrl, $entityType) {
27
+                return $baseUrl.'/'.$entityType.'/'.$cdbid;
28 28
             }
29 29
         );
30 30
     }
Please login to merge, or discard this patch.
src/Offer/IriOfferIdentifierFactory.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -20,14 +20,14 @@  discard block
 block discarded – undo
20 20
         $this->regex = $regex;
21 21
 
22 22
         $match = @preg_match(
23
-            '@^' . $regex . '$@',
23
+            '@^'.$regex.'$@',
24 24
             '',
25 25
             $matches
26 26
         );
27 27
 
28 28
         if (false === $match) {
29 29
             throw new \InvalidArgumentException(
30
-                'Problem evaluating regular expression pattern ' . $regex
30
+                'Problem evaluating regular expression pattern '.$regex
31 31
             );
32 32
         }
33 33
     }
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
     public function fromIri($iri)
40 40
     {
41 41
         $match = @preg_match(
42
-            '@^' . $this->regex . '$@',
42
+            '@^'.$this->regex.'$@',
43 43
             (string)$iri,
44 44
             $matches
45 45
         );
Please login to merge, or discard this patch.
src/Offer/Events/AbstractEvent.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
     {
20 20
         if (!is_string($itemId)) {
21 21
             throw new \InvalidArgumentException(
22
-                'Expected itemId to be a string, received ' . gettype($itemId)
22
+                'Expected itemId to be a string, received '.gettype($itemId)
23 23
             );
24 24
         }
25 25
 
Please login to merge, or discard this patch.
src/EventHandling/DelegateEventHandlingToSpecificMethodTrait.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,6 +38,6 @@
 block discarded – undo
38 38
     {
39 39
         $classParts = explode('\\', get_class($event));
40 40
 
41
-        return 'apply' . end($classParts);
41
+        return 'apply'.end($classParts);
42 42
     }
43 43
 }
Please login to merge, or discard this patch.