Completed
Pull Request — master (#252)
by Kristof
05:51 queued 49s
created
src/SearchAPI2/Filters/DoesNotHaveKeyword.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
 
14 14
     public function __construct($keyword)
15 15
     {
16
-        $keyword = (string) $keyword;
16
+        $keyword = (string)$keyword;
17 17
 
18 18
         $this->filterQuery = new FilterQuery(
19 19
             sprintf(
Please login to merge, or discard this patch.
src/Event/ReadModel/Relations/Projector.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -110,8 +110,8 @@
 block discarded – undo
110 110
     }
111 111
 
112 112
     /**
113
-    * @param EventUpdatedFromCdbXml $eventUpdatedFromCdbXml
114
-    */
113
+     * @param EventUpdatedFromCdbXml $eventUpdatedFromCdbXml
114
+     */
115 115
     protected function applyEventUpdatedFromCdbXml(EventUpdatedFromCdbXml $eventUpdatedFromCdbXml)
116 116
     {
117 117
         $eventId = $eventUpdatedFromCdbXml->getEventId();
Please login to merge, or discard this patch.
src/EventExport/EventExportService.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -209,7 +209,7 @@
 block discarded – undo
209 209
      * Generator that yields each unique search result.
210 210
      *
211 211
      * @param int $totalItemCount
212
-     * @param string|object $query
212
+     * @param EventExportQuery $query
213 213
      * @param LoggerInterface $logger
214 214
      *
215 215
      * @return \Generator
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
 
158 158
             if (!$moved) {
159 159
                 throw new \RuntimeException(
160
-                    'Unable to move export file to public directory ' .
160
+                    'Unable to move export file to public directory '.
161 161
                     $this->publicDirectory
162 162
                 );
163 163
             }
@@ -244,8 +244,8 @@  discard block
 block discarded – undo
244 244
     ) {
245 245
         $fileUniqueId = basename($tmpPath);
246 246
         $extension = $fileFormat->getFileNameExtension();
247
-        $finalFileName = $fileUniqueId . '.' . $extension;
248
-        $finalPath = $this->publicDirectory . '/' . $finalFileName;
247
+        $finalFileName = $fileUniqueId.'.'.$extension;
248
+        $finalPath = $this->publicDirectory.'/'.$finalFileName;
249 249
 
250 250
         return $finalPath;
251 251
     }
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
         var_dump($events);
265 265
 
266 266
         foreach ($events as $eventIdentifier) {
267
-            $event = $this->getEvent((string) $eventIdentifier->getIri(), $logger);
267
+            $event = $this->getEvent((string)$eventIdentifier->getIri(), $logger);
268 268
 
269 269
             if ($event) {
270 270
                 yield $eventIdentifier->getId() => $event;
Please login to merge, or discard this patch.
src/Media/Serialization/MediaObjectSerializer.php 2 patches
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -3,12 +3,9 @@
 block discarded – undo
3 3
 namespace CultuurNet\UDB3\Media\Serialization;
4 4
 
5 5
 use CultuurNet\UDB3\Iri\IriGeneratorInterface;
6
-use CultuurNet\UDB3\Media\MediaObject;
7 6
 use CultuurNet\UDB3\Media\Properties\MIMEType;
8
-use Symfony\Component\HttpFoundation\File\MimeType\ExtensionGuesser;
9 7
 use Symfony\Component\Serializer\Exception\UnsupportedException;
10 8
 use Symfony\Component\Serializer\SerializerInterface;
11
-use ValueObjects\Web\Url;
12 9
 
13 10
 class MediaObjectSerializer implements SerializerInterface
14 11
 {
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -36,10 +36,10 @@  discard block
 block discarded – undo
36 36
         $normalizedData = [
37 37
             '@id' => $this->iriGenerator->iri($mediaObject->getMediaObjectId()),
38 38
             '@type' => $this->serializeMimeType($mediaObject->getMimeType()),
39
-            'contentUrl' => (string) $mediaObject->getSourceLocation(),
40
-            'thumbnailUrl' => (string) $mediaObject->getSourceLocation(),
41
-            'description' => (string) $mediaObject->getDescription(),
42
-            'copyrightHolder' => (string) $mediaObject->getCopyrightHolder(),
39
+            'contentUrl' => (string)$mediaObject->getSourceLocation(),
40
+            'thumbnailUrl' => (string)$mediaObject->getSourceLocation(),
41
+            'description' => (string)$mediaObject->getDescription(),
42
+            'copyrightHolder' => (string)$mediaObject->getCopyrightHolder(),
43 43
         ];
44 44
 
45 45
         return $normalizedData;
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 
48 48
     public function serializeMimeType(MIMEType $mimeType)
49 49
     {
50
-        $typeParts = explode('/', (string) $mimeType);
50
+        $typeParts = explode('/', (string)$mimeType);
51 51
         $type = array_shift($typeParts);
52 52
 
53 53
         if ($type !== 'image') {
Please login to merge, or discard this patch.
src/Media/Image.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -109,11 +109,11 @@
 block discarded – undo
109 109
     public function serialize()
110 110
     {
111 111
         return [
112
-            'media_object_id' => (string) $this->getMediaObjectId(),
113
-            'mime_type' => (string) $this->getMimeType(),
114
-            'description' => (string) $this->getDescription(),
115
-            'copyright_holder' => (string) $this->getCopyrightHolder(),
116
-            'source_location' => (string) $this->getSourceLocation()
112
+            'media_object_id' => (string)$this->getMediaObjectId(),
113
+            'mime_type' => (string)$this->getMimeType(),
114
+            'description' => (string)$this->getDescription(),
115
+            'copyright_holder' => (string)$this->getCopyrightHolder(),
116
+            'source_location' => (string)$this->getSourceLocation()
117 117
         ];
118 118
     }
119 119
 }
Please login to merge, or discard this patch.
src/Media/Events/MediaObjectCreated.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@
 block discarded – undo
107 107
             'mime_type' => $this->getMimeType()->toNative(),
108 108
             'description' => $this->getDescription()->toNative(),
109 109
             'copyright_holder' => $this->getCopyrightHolder()->toNative(),
110
-            'source_location' => (string) $this->getSourceLocation()
110
+            'source_location' => (string)$this->getSourceLocation()
111 111
         );
112 112
     }
113 113
 
Please login to merge, or discard this patch.
src/Event/ReadModel/History/HistoryProjector.php 2 patches
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -5,9 +5,7 @@  discard block
 block discarded – undo
5 5
 
6 6
 namespace CultuurNet\UDB3\Event\ReadModel\History;
7 7
 
8
-use Broadway\Domain\DateTime;
9 8
 use Broadway\Domain\DomainMessage;
10
-use Broadway\Domain\Metadata;
11 9
 use Broadway\EventHandling\EventListenerInterface;
12 10
 use CultuurNet\UDB3\Cdb\EventItemFactory;
13 11
 use CultuurNet\UDB3\Event\DescriptionTranslated;
@@ -21,11 +19,8 @@  discard block
 block discarded – undo
21 19
 use CultuurNet\UDB3\Event\Events\LabelsMerged;
22 20
 use CultuurNet\UDB3\Event\Events\TranslationDeleted;
23 21
 use CultuurNet\UDB3\Event\Events\LabelDeleted;
24
-use CultuurNet\UDB3\Event\ReadModel\DocumentRepositoryInterface;
25 22
 use CultuurNet\UDB3\Event\TitleTranslated;
26
-use CultuurNet\UDB3\EventHandling\DelegateEventHandlingToSpecificMethodTrait;
27 23
 use CultuurNet\UDB3\Offer\ReadModel\History\OfferHistoryProjector;
28
-use CultuurNet\UDB3\ReadModel\JsonDocument;
29 24
 use ValueObjects\String\String;
30 25
 
31 26
 class HistoryProjector extends OfferHistoryProjector implements EventListenerInterface
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
                     $domainMessage->getRecordedOn()
69 69
                 ),
70 70
                 new String(
71
-                    'Aangemaakt via EntryAPI door consumer "' . $consumerName . '"'
71
+                    'Aangemaakt via EntryAPI door consumer "'.$consumerName.'"'
72 72
                 ),
73 73
                 $this->getAuthorFromMetadata($domainMessage->getMetadata())
74 74
             )
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
                     $domainMessage->getRecordedOn()
89 89
                 ),
90 90
                 new String(
91
-                    'Geüpdatet via EntryAPI door consumer "' . $consumerName . '"'
91
+                    'Geüpdatet via EntryAPI door consumer "'.$consumerName.'"'
92 92
                 ),
93 93
                 $this->getAuthorFromMetadata($domainMessage->getMetadata())
94 94
             )
Please login to merge, or discard this patch.
src/Event/ReadModel/JSONLD/EventLDProjector.php 4 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -799,6 +799,9 @@
 block discarded – undo
799 799
         return $document;
800 800
     }
801 801
 
802
+    /**
803
+     * @param string $eventId
804
+     */
802 805
     private function generateSameAs($eventId, $name)
803 806
     {
804 807
         $eventSlug = $this->slugger->slug($name);
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -481,7 +481,7 @@
 block discarded – undo
481 481
 
482 482
         $jsonLD->name->nl = $majorInfoUpdated->getTitle();
483 483
         $jsonLD->location = array(
484
-          '@type' => 'Place',
484
+            '@type' => 'Place',
485 485
         ) + (array)$this->placeJSONLD($majorInfoUpdated->getLocation()->getCdbid());
486 486
 
487 487
         // Remove old theme and event type.
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
272 272
     ) {
273 273
         $this->saveNewDocument(
274 274
             $eventId,
275
-            function (\stdClass $eventLd) use ($eventId, $cdbXmlNamespaceUri, $cdbXml, $domainMessage) {
275
+            function(\stdClass $eventLd) use ($eventId, $cdbXmlNamespaceUri, $cdbXml, $domainMessage) {
276 276
                 $eventLd = $this->projectEventCdbXmlToObject(
277 277
                     $eventLd,
278 278
                     $eventId,
@@ -329,13 +329,13 @@  discard block
 block discarded – undo
329 329
     ) {
330 330
         $this->saveNewDocument(
331 331
             $eventId,
332
-            function (\stdClass $eventLd) use ($cdbXmlNamespaceUri, $eventId, $cdbXml) {
332
+            function(\stdClass $eventLd) use ($cdbXmlNamespaceUri, $eventId, $cdbXml) {
333 333
                 return $this->projectEventCdbXmlToObject(
334 334
                     $eventLd,
335 335
                     $eventId,
336 336
                     $cdbXmlNamespaceUri,
337 337
                     $cdbXml
338
-                ) ;
338
+                );
339 339
             }
340 340
         );
341 341
     }
@@ -411,7 +411,7 @@  discard block
 block discarded – undo
411 411
     ) {
412 412
         $this->saveNewDocument(
413 413
             $eventCreated->getEventId(),
414
-            function (\stdClass $jsonLD) use ($eventCreated, $domainMessage) {
414
+            function(\stdClass $jsonLD) use ($eventCreated, $domainMessage) {
415 415
                 $jsonLD->{'@id'} = $this->iriGenerator->iri(
416 416
                     $eventCreated->getEventId()
417 417
                 );
@@ -485,8 +485,8 @@  discard block
 block discarded – undo
485 485
         ) + (array)$this->placeJSONLD($majorInfoUpdated->getLocation()->getCdbid());
486 486
 
487 487
         // Remove old theme and event type.
488
-        $jsonLD->terms = array_filter($jsonLD->terms, function ($term) {
489
-            return $term->domain !== EventType::DOMAIN &&  $term->domain !== Theme::DOMAIN;
488
+        $jsonLD->terms = array_filter($jsonLD->terms, function($term) {
489
+            return $term->domain !== EventType::DOMAIN && $term->domain !== Theme::DOMAIN;
490 490
         });
491 491
 
492 492
         $eventType = $majorInfoUpdated->getEventType();
@@ -663,7 +663,7 @@  discard block
 block discarded – undo
663 663
     {
664 664
         $eventSlug = $this->slugger->slug($name);
665 665
         return array(
666
-            'http://www.uitinvlaanderen.be/agenda/e/' . $eventSlug . '/' . $eventId,
666
+            'http://www.uitinvlaanderen.be/agenda/e/'.$eventSlug.'/'.$eventId,
667 667
         );
668 668
     }
669 669
 
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -45,7 +45,6 @@  discard block
 block discarded – undo
45 45
 use CultuurNet\UDB3\Event\ReadModel\DocumentRepositoryInterface;
46 46
 use CultuurNet\UDB3\Event\EventServiceInterface;
47 47
 use CultuurNet\UDB3\Iri\IriGeneratorInterface;
48
-use CultuurNet\UDB3\LabelCollection;
49 48
 use CultuurNet\UDB3\Offer\AvailableTo;
50 49
 use CultuurNet\UDB3\Offer\IriOfferIdentifierFactoryInterface;
51 50
 use CultuurNet\UDB3\Offer\ReadModel\JSONLD\OfferLDProjector;
@@ -56,7 +55,6 @@  discard block
 block discarded – undo
56 55
 use CultuurNet\UDB3\Place\Events\PlaceProjectedToJSONLD;
57 56
 use CultuurNet\UDB3\PlaceService;
58 57
 use CultuurNet\UDB3\ReadModel\JsonDocument;
59
-use CultuurNet\UDB3\StringFilter\StringFilterInterface;
60 58
 use CultuurNet\UDB3\Theme;
61 59
 use Symfony\Component\Serializer\SerializerInterface;
62 60
 use ValueObjects\String\String;
Please login to merge, or discard this patch.
src/LocalEntityService.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -78,6 +78,9 @@
 block discarded – undo
78 78
         return $document->getRawBody();
79 79
     }
80 80
 
81
+    /**
82
+     * @param string $id
83
+     */
81 84
     public function iri($id)
82 85
     {
83 86
         return $this->iriGenerator->iri($id);
Please login to merge, or discard this patch.