cultuurnet / udb3-php

src/Offer/ReadModel/JSONLD/OfferLDProjector.php

Doc Comments +1 added lines, -1 removed lines

@@ -624,7 +624,7 @@
     }
 
     /**
-     * @return callable
+     * @return \Closure
      */
     private function reject()
     {

Spacing +10 added lines, -10 removed lines

@@ -142,7 +142,7 @@ 
 
             if (preg_match('/^apply(.+)$/', $method, $matches)) {
                 $event = $matches[1];
-                $classNameMethod = 'get' . $event . 'ClassName';
+                $classNameMethod = 'get'.$event.'ClassName';
 
                 if (method_exists($this, $classNameMethod)) {
                     $eventFullClassName = call_user_func(array($this, $classNameMethod));
@@ -272,7 +272,7 @@ 
         $labelsProperty = $labelAdded->getLabel()->isVisible() ? 'labels' : 'hiddenLabels';
 
         $labels = isset($offerLd->{$labelsProperty}) ? $offerLd->{$labelsProperty} : [];
-        $label = (string) $labelAdded->getLabel();
+        $label = (string)$labelAdded->getLabel();
 
         $labels[] = $label;
         $offerLd->{$labelsProperty} = array_unique($labels);
@@ -297,7 +297,7 @@ 
             if (isset($offerLd->{$labelsProperty}) && is_array($offerLd->{$labelsProperty})) {
                 $offerLd->{$labelsProperty} = array_filter(
                     $offerLd->{$labelsProperty},
-                    function ($label) use ($labelRemoved) {
+                    function($label) use ($labelRemoved) {
                         return !$labelRemoved->getLabel()->equals(
                             new Label($label)
                         );
@@ -394,7 +394,7 @@ 
             return;
         }
 
-        $imageId = (string) $imageRemoved->getImage()->getMediaObjectId();
+        $imageId = (string)$imageRemoved->getImage()->getMediaObjectId();
 
         /**
          * Matches any object that is not the removed image.
@@ -405,7 +405,7 @@ 
          * @return bool
          *  Returns true when the media object does not match the image to remove.
          */
-        $shouldNotBeRemoved = function ($mediaObject) use ($imageId) {
+        $shouldNotBeRemoved = function($mediaObject) use ($imageId) {
             $containsId = !!strpos($mediaObject->{'@id'}, $imageId);
             return !$containsId;
         };
@@ -443,7 +443,7 @@ 
         $document = $this->loadDocumentFromRepository($mainImageSelected);
         $offerLd = $document->getBody();
         $imageId = $mainImageSelected->getImage()->getMediaObjectId();
-        $mediaObjectMatcher = function ($matchingMediaObject, $currentMediaObject) use ($imageId) {
+        $mediaObjectMatcher = function($matchingMediaObject, $currentMediaObject) use ($imageId) {
             if (!$matchingMediaObject && $this->mediaObjectMatchesId($currentMediaObject, $imageId)) {
                 $matchingMediaObject = $currentMediaObject;
             }
@@ -468,7 +468,7 @@ 
      */
     protected function mediaObjectMatchesId($mediaObject, UUID $mediaObjectId)
     {
-        return strpos($mediaObject->{'@id'}, (string) $mediaObjectId) > 0;
+        return strpos($mediaObject->{'@id'}, (string)$mediaObjectId) > 0;
     }
 
     /**
@@ -649,7 +649,7 @@ 
      */
     protected function applyPublished(AbstractPublished $published)
     {
-        $this->applyEventTransformation($published, function ($offerLd) use ($published) {
+        $this->applyEventTransformation($published, function($offerLd) use ($published) {
             $offerLd->workflowStatus = WorkflowStatus::READY_FOR_VALIDATION()->getName();
 
             $publicationDate = $published->getPublicationDate();
@@ -662,7 +662,7 @@ 
      */
     protected function applyApproved(AbstractApproved $approved)
     {
-        $this->applyEventTransformation($approved, function ($offerLd) {
+        $this->applyEventTransformation($approved, function($offerLd) {
             $offerLd->workflowStatus = WorkflowStatus::APPROVED()->getName();
         });
     }
@@ -698,7 +698,7 @@ 
      */
     private function reject()
     {
-        return function ($offerLd) {
+        return function($offerLd) {
             $offerLd->workflowStatus = WorkflowStatus::REJECTED()->getName();
         };
     }

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 use CultuurNet\UDB3\EntityServiceInterface;
 use CultuurNet\UDB3\Event\ReadModel\DocumentRepositoryInterface;
 use CultuurNet\UDB3\Event\ReadModel\JSONLD\CdbXMLImporter;
-use CultuurNet\UDB3\Event\ReadModel\JSONLD\CdbXMLLongDescriptionFilter;
 use CultuurNet\UDB3\Event\ReadModel\JSONLD\OrganizerServiceInterface;
 use CultuurNet\UDB3\EventHandling\DelegateEventHandlingToSpecificMethodTrait;
 use CultuurNet\UDB3\Iri\IriGeneratorInterface;

src/Offer/Offer.php

Spacing +2 added lines, -2 removed lines

@@ -257,7 +257,7 @@ 
     {
         $equalImages = array_filter(
             $this->mediaObjects,
-            function ($existingMediaObjectId) use ($image) {
+            function($existingMediaObjectId) use ($image) {
                 return $image
                     ->getMediaObjectId()
                     ->sameValueAs($existingMediaObjectId);
@@ -381,7 +381,7 @@ 
             if ($this->rejectedReason && $reason->sameValueAs($this->rejectedReason)) {
                 return true; // nothing left to do if the offer has already been rejected for the same reason
             } else {
-                throw new Exception('The offer has already been rejected for another reason: ' . $this->rejectedReason);
+                throw new Exception('The offer has already been rejected for another reason: '.$this->rejectedReason);
             }
         }
 

src/Security/CommandAuthorizationException.php

Spacing +4 added lines, -4 removed lines

@@ -26,10 +26,10 @@
         StringLiteral $userId,
         AuthorizableCommandInterface $command
     ) {
-        parent::__construct('User with id: ' . $userId->toNative() .
-            ' has no permission: "' . $command->getPermission()->toNative() .
-            '" on item: ' . $command->getItemId() .
-            ' when executing command: ' . get_class($command));
+        parent::__construct('User with id: '.$userId->toNative().
+            ' has no permission: "'.$command->getPermission()->toNative().
+            '" on item: '.$command->getItemId().
+            ' when executing command: '.get_class($command));
 
         $this->userId = $userId;
         $this->command = $command;

src/Location/Location.php

Indentation +3 added lines, -3 removed lines

@@ -66,9 +66,9 @@
     public function serialize()
     {
         return [
-          'cdbid' => $this->cdbid,
-          'name' => $this->name->toNative(),
-          'address' => $this->address->serialize()
+            'cdbid' => $this->cdbid,
+            'name' => $this->name->toNative(),
+            'address' => $this->address->serialize()
         ];
     }
 

src/Event/EventEditingServiceInterface.php

Doc Comments +8 added lines

@@ -20,6 +20,7 @@ 
      *
      * @param string $id
      * @param string $description
+     * @return string
      */
     public function updateDescription($id, $description);
 
@@ -28,6 +29,7 @@ 
      *
      * @param string $id
      * @param string $ageRange
+     * @return string
      */
     public function updateTypicalAgeRange($id, $ageRange);
 
@@ -35,6 +37,7 @@ 
      * Delete the typical age range of a place.
      *
      * @param string $id
+     * @return string
      */
     public function deleteTypicalAgeRange($id);
 
@@ -43,6 +46,7 @@ 
      *
      * @param string $id
      * @param string $organizerId
+     * @return string
      */
     public function updateOrganizer($id, $organizerId);
 
@@ -51,6 +55,7 @@ 
      *
      * @param string $id
      * @param string $organizerId
+     * @return string
      */
     public function deleteOrganizer($id, $organizerId);
 
@@ -59,6 +64,7 @@ 
      *
      * @param string $id
      * @param ContactPoint $contactPoint
+     * @return string
      */
     public function updateContactPoint($id, ContactPoint $contactPoint);
 
@@ -67,6 +73,7 @@ 
      *
      * @param string $id
      * @param Image $image
+     * @return string
      */
     public function addImage($id, Image $image);
 
@@ -93,6 +100,7 @@ 
      *
      * @param string $id
      * @param Image $image
+     * @return string
      */
     public function removeImage($id, Image $image);
 

src/Organizer/Events/OrganizerCreatedWithUniqueWebsite.php

Spacing +2 added lines, -2 removed lines

@@ -148,8 +148,8 @@
         }
 
         return parent::serialize() + array(
-            'website' => (string) $this->getWebsite(),
-            'title' => (string) $this->getTitle(),
+            'website' => (string)$this->getWebsite(),
+            'title' => (string)$this->getTitle(),
             'addresses' => $addresses,
             'phones' => $this->getPhones(),
             'emails' => $this->getEmails(),

src/Address/Address.php

Indentation +4 added lines, -4 removed lines

@@ -81,10 +81,10 @@
     public function serialize()
     {
         return [
-          'streetAddress' => $this->streetAddress->toNative(),
-          'postalCode' => $this->postalCode->toNative(),
-          'addressLocality' => $this->locality->toNative(),
-          'addressCountry' => $this->countryCode,
+            'streetAddress' => $this->streetAddress->toNative(),
+            'postalCode' => $this->postalCode->toNative(),
+            'addressLocality' => $this->locality->toNative(),
+            'addressCountry' => $this->countryCode,
         ];
     }
 

src/Calendar.php

Indentation +4 added lines, -4 removed lines

@@ -84,7 +84,7 @@ 
         );
 
         $calendar = [
-          'type' => $this->type,
+            'type' => $this->type,
         ];
 
         empty($this->startDate) ?: $calendar['startDate'] = $this->startDate->format(DateTime::ATOM);
@@ -167,9 +167,9 @@ 
             $jsonLd['subEvent'] = array();
             foreach ($timestamps as $timestamp) {
                 $jsonLd['subEvent'][] = array(
-                  '@type' => 'Event',
-                  'startDate' => $timestamp->getStartDate()->format(DateTime::ATOM),
-                  'endDate' => $timestamp->getEndDate()->format(DateTime::ATOM),
+                    '@type' => 'Event',
+                    'startDate' => $timestamp->getStartDate()->format(DateTime::ATOM),
+                    'endDate' => $timestamp->getEndDate()->format(DateTime::ATOM),
                 );
             }
         }

Spacing +4 added lines, -4 removed lines

@@ -54,7 +54,7 @@ 
         array $openingHours = array()
     ) {
         if (($type->is(CalendarType::MULTIPLE()) || $type->is(CalendarType::SINGLE())) && empty($startDate)) {
-            throw new \UnexpectedValueException('Start date can not be empty for calendar type: ' . $type . '.');
+            throw new \UnexpectedValueException('Start date can not be empty for calendar type: '.$type.'.');
         }
 
         if ($type->is(CalendarType::PERIODIC()) && (empty($startDate) || empty($endDate))) {
@@ -82,7 +82,7 @@ 
     public function serialize()
     {
         $serializedTimestamps = array_map(
-            function (Timestamp $timestamp) {
+            function(Timestamp $timestamp) {
                 return $timestamp->serialize();
             },
             $this->timestamps
@@ -110,7 +110,7 @@ 
             !empty($data['startDate']) ? self::deserializeDateTime($data['startDate']) : null,
             !empty($data['endDate']) ? self::deserializeDateTime($data['endDate']) : null,
             !empty($data['timestamps']) ? array_map(
-                function ($timestamp) {
+                function($timestamp) {
                     return Timestamp::deserialize($timestamp);
                 },
                 $data['timestamps']
@@ -210,7 +210,7 @@ 
         // Permanent - with openingtimes
         $openingHours = $this->getOpeningHours();
         if (!empty($openingHours)) {
-            $jsonLd['openingHours'] = (array) $openingHours;
+            $jsonLd['openingHours'] = (array)$openingHours;
         }
 
         return $jsonLd;

src/EventExport/Format/TabularData/OOXML/OOXMLFileFormat.php

Doc Comments +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
 
     /**
      * @param EventInfoServiceInterface|null $uitpas
-     * @param string[]|null $include
+     * @param string[] $include
      */
     public function __construct($include = null, EventInfoServiceInterface $uitpas = null)
     {