EventFacilityResolver - Code Metrics - Inspection of "III-2524 Move EventFacilityResolver and PlaceFacil..." - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#347)

by Luc

created 2018-03-20 13:48 UTC

EventFacilityResolver A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	2
dl	0
loc	32
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	getFacilities()	0	26	1

<?php

namespace CultuurNet\UDB3\Event;

use CultuurNet\UDB3\Facility;
use CultuurNet\UDB3\Offer\OfferFacilityResolver;

class EventFacilityResolver extends OfferFacilityResolver
{
    /**
     * @inheritdoc
     */
    final protected function getFacilities()
    {
        return [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            "3.23.2.0.0" => new Facility("3.23.2.0.0", "Assistentie"),
            "3.13.1.0.0" => new Facility("3.13.1.0.0", "Voorzieningen voor assistentiehonden"),
            "3.13.2.0.0" => new Facility("3.13.2.0.0", "Audiodescriptie"),
            "3.17.1.0.0" => new Facility("3.17.1.0.0", "Ringleiding"),
            "3.17.2.0.0" => new Facility("3.17.2.0.0", "Voelstoelen"),
            "3.17.3.0.0" => new Facility("3.17.3.0.0", "Boven- of ondertiteling"),
            "3.26.0.0.0" => new Facility("3.26.0.0.0", "Parkeerplaats"),
            "3.27.0.0.0" => new Facility("3.27.0.0.0", "Rolstoeltoegankelijk"),
            "3.28.0.0.0" => new Facility("3.28.0.0.0", "Alternatieve ingang"),
            "3.29.0.0.0" => new Facility("3.29.0.0.0", "Gegarandeerd zicht"),
            "3.30.0.0.0" => new Facility("3.30.0.0.0", "Rolstoelpodium"),
            "3.32.0.0.0" => new Facility("3.32.0.0.0", "Voorbehouden camping"),
            "3.31.0.0.0" => new Facility("3.31.0.0.0", "Toegankelijk sanitair"),
            "3.33.0.0.0" => new Facility("3.33.0.0.0", "Tolken Vlaamse Gebarentaal"),
            "3.34.0.0.0" => new Facility("3.34.0.0.0", "Vereenvoudigde informatie"),
            "3.35.0.0.0" => new Facility("3.35.0.0.0", "1 begeleider gratis"),
            "3.36.0.0.0" => new Facility("3.36.0.0.0", "Verzorgingsruimte"),
            "3.37.0.0.0" => new Facility("3.37.0.0.0", "Oplaadzone rolstoelen"),
            "3.38.0.0.0" => new Facility("3.38.0.0.0", "Inter-assistentie"),
            "3.39.0.0.0" => new Facility("3.39.0.0.0", "Begeleiderspas"),
            "3.40.0.0.0" => new Facility("3.40.0.0.0", "Inter-events"),
        ];
    }
}


1			<?php
2
3			namespace CultuurNet\UDB3\Event;
4
5			use CultuurNet\UDB3\Facility;
6			use CultuurNet\UDB3\Offer\OfferFacilityResolver;
7
8			class EventFacilityResolver extends OfferFacilityResolver
9			{
10			/**
11			* @inheritdoc
12			*/
13			final protected function getFacilities()
14			{
15			return [
			0 ignored issues – show Bug Best Practice introduced 2018-03-20 13:55 UTC by Report Bug Copy Issue Report The return type of `return array('3.23.2.0.0...0.0', 'Inter-events'));` (`array<string,CultuurNet\UDB3\Facility>`) is incompatible with the return type declared by the abstract method `CultuurNet\UDB3\Offer\Of...Resolver::getFacilities` of type `CultuurNet\UDB3\Facility[]`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
16			"3.23.2.0.0" => new Facility("3.23.2.0.0", "Assistentie"),
17			"3.13.1.0.0" => new Facility("3.13.1.0.0", "Voorzieningen voor assistentiehonden"),
18			"3.13.2.0.0" => new Facility("3.13.2.0.0", "Audiodescriptie"),
19			"3.17.1.0.0" => new Facility("3.17.1.0.0", "Ringleiding"),
20			"3.17.2.0.0" => new Facility("3.17.2.0.0", "Voelstoelen"),
21			"3.17.3.0.0" => new Facility("3.17.3.0.0", "Boven- of ondertiteling"),
22			"3.26.0.0.0" => new Facility("3.26.0.0.0", "Parkeerplaats"),
23			"3.27.0.0.0" => new Facility("3.27.0.0.0", "Rolstoeltoegankelijk"),
24			"3.28.0.0.0" => new Facility("3.28.0.0.0", "Alternatieve ingang"),
25			"3.29.0.0.0" => new Facility("3.29.0.0.0", "Gegarandeerd zicht"),
26			"3.30.0.0.0" => new Facility("3.30.0.0.0", "Rolstoelpodium"),
27			"3.32.0.0.0" => new Facility("3.32.0.0.0", "Voorbehouden camping"),
28			"3.31.0.0.0" => new Facility("3.31.0.0.0", "Toegankelijk sanitair"),
29			"3.33.0.0.0" => new Facility("3.33.0.0.0", "Tolken Vlaamse Gebarentaal"),
30			"3.34.0.0.0" => new Facility("3.34.0.0.0", "Vereenvoudigde informatie"),
31			"3.35.0.0.0" => new Facility("3.35.0.0.0", "1 begeleider gratis"),
32			"3.36.0.0.0" => new Facility("3.36.0.0.0", "Verzorgingsruimte"),
33			"3.37.0.0.0" => new Facility("3.37.0.0.0", "Oplaadzone rolstoelen"),
34			"3.38.0.0.0" => new Facility("3.38.0.0.0", "Inter-assistentie"),
35			"3.39.0.0.0" => new Facility("3.39.0.0.0", "Begeleiderspas"),
36			"3.40.0.0.0" => new Facility("3.40.0.0.0", "Inter-events"),
37			];
38			}
39			}
40

cultuurnet / udb3-php

Pull Request — master (#347)

EventFacilityResolver A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like