DefaultEventEditingService::updateLocation() - Code Metrics - Inspection of "III-2552: Add createApprovedEvent|Place methods on..." - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#362)

unknown

created 2018-04-12 12:11 UTC

DefaultEventEditingService::updateLocation() A

↳ Parent: DefaultEventEditingService

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	2

<?php

namespace CultuurNet\UDB3\Event;

use Broadway\CommandHandling\CommandBusInterface;
use Broadway\Repository\AggregateNotFoundException;
use Broadway\Repository\RepositoryInterface;
use Broadway\UuidGenerator\UuidGeneratorInterface;
use CultuurNet\UDB3\CalendarInterface;
use CultuurNet\UDB3\Event\Commands\UpdateAudience;
use CultuurNet\UDB3\Event\Commands\UpdateLocation;
use CultuurNet\UDB3\Event\Commands\UpdateMajorInfo;
use CultuurNet\UDB3\Event\ReadModel\DocumentRepositoryInterface;
use CultuurNet\UDB3\Event\ValueObjects\Audience;
use CultuurNet\UDB3\Label\LabelServiceInterface;
use CultuurNet\UDB3\Language;
use CultuurNet\UDB3\Location\Location;
use CultuurNet\UDB3\Location\LocationId;
use CultuurNet\UDB3\Offer\Commands\OfferCommandFactoryInterface;
use CultuurNet\UDB3\Offer\DefaultOfferEditingService;
use CultuurNet\UDB3\Theme;
use CultuurNet\UDB3\Title;

class DefaultEventEditingService extends DefaultOfferEditingService implements EventEditingServiceInterface
{
    /**
     * @var EventServiceInterface
     */
    protected $eventService;

    /**
     * @var RepositoryInterface
     */
    protected $writeRepository;

    /**
     * @param EventServiceInterface $eventService
     * @param CommandBusInterface $commandBus
     * @param UuidGeneratorInterface $uuidGenerator
     * @param DocumentRepositoryInterface $readRepository
     * @param OfferCommandFactoryInterface $commandFactory
     * @param RepositoryInterface $writeRepository
     * @param LabelServiceInterface $labelService
     */
    public function __construct(

        EventServiceInterface $eventService,
        CommandBusInterface $commandBus,
        UuidGeneratorInterface $uuidGenerator,
        DocumentRepositoryInterface $readRepository,
        OfferCommandFactoryInterface $commandFactory,
        RepositoryInterface $writeRepository,
        LabelServiceInterface $labelService
    ) {
        parent::__construct(
            $commandBus,
            $uuidGenerator,
            $readRepository,
            $commandFactory,
            $labelService,
            new EventTypeResolver(),
            new EventThemeResolver()
        );
        $this->eventService = $eventService;
        $this->writeRepository = $writeRepository;
    }

    /**
     * {@inheritdoc}
     */
    public function createEvent(

        Language $mainLanguage,
        Title $title,
        EventType $eventType,
        Location $location,
        CalendarInterface $calendar,
        $theme = null
    ) {
        $eventId = $this->uuidGenerator->generate();

        $event = Event::create(
            $eventId,
            $mainLanguage,
            $title,
            $eventType,
            $location,
            $calendar,
            $theme,
            $this->publicationDate
        );

        $this->writeRepository->save($event);

        return $eventId;
    }

    /**
     * @inheritdoc
     */
    public function createApprovedEvent(

        Language $mainLanguage,
        Title $title,
        EventType $eventType,
        Location $location,
        CalendarInterface $calendar,
        Theme $theme = null
    ) {
        $eventId = $this->uuidGenerator->generate();

        $event = Event::create(
            $eventId,
            $mainLanguage,
            $title,
            $eventType,
            $location,
            $calendar,
            $theme
        );

        $publicationDate = $this->publicationDate ? $this->publicationDate : new \DateTimeImmutable();
        $event->publish($publicationDate);
        $event->approve();

        $this->writeRepository->save($event);

        return $eventId;
    }

    /**
     * @inheritdoc
     */
    public function copyEvent($originalEventId, CalendarInterface $calendar)
    {
        if (!is_string($originalEventId)) {
            throw new \InvalidArgumentException(
                'Expected originalEventId to be a string, received ' . gettype($originalEventId)
            );
        }

        try {
            /** @var Event $event */
            $event = $this->writeRepository->load($originalEventId);
        } catch (AggregateNotFoundException $exception) {
            throw new \InvalidArgumentException(
                'No original event found to copy with id ' . $originalEventId
            );
        }

        $eventId = $this->uuidGenerator->generate();

        $newEvent = $event->copy($eventId, $calendar);

        $this->writeRepository->save($newEvent);

        return $eventId;
    }

    /**
     * {@inheritdoc}
     */
    public function updateMajorInfo($eventId, Title $title, EventType $eventType, Location $location, CalendarInterface $calendar, $theme = null)

    {
        $this->guardId($eventId);

        return $this->commandBus->dispatch(
            new UpdateMajorInfo($eventId, $title, $eventType, $location, $calendar, $theme)
        );
    }

    /**
     * @inheritdoc
     */
    public function updateLocation($eventId, LocationId $locationId)
    {
        $this->guardId($eventId);

        return $this->commandBus->dispatch(
            new UpdateLocation($eventId, $locationId)
        );
    }

    /**
     * @inheritdoc
     */
    public function updateAudience($eventId, Audience $audience)
    {
        return $this->commandBus->dispatch(
            new UpdateAudience($eventId, $audience)
        );
    }

    /**
     * {@inheritdoc}
     */
    public function deleteEvent($eventId)
    {
        return $this->delete($eventId);
    }
}


1		<?php
2
3		namespace CultuurNet\UDB3\Event;
4
5		use Broadway\CommandHandling\CommandBusInterface;
6		use Broadway\Repository\AggregateNotFoundException;
7		use Broadway\Repository\RepositoryInterface;
8		use Broadway\UuidGenerator\UuidGeneratorInterface;
9		use CultuurNet\UDB3\CalendarInterface;
10		use CultuurNet\UDB3\Event\Commands\UpdateAudience;
11		use CultuurNet\UDB3\Event\Commands\UpdateLocation;
12		use CultuurNet\UDB3\Event\Commands\UpdateMajorInfo;
13		use CultuurNet\UDB3\Event\ReadModel\DocumentRepositoryInterface;
14		use CultuurNet\UDB3\Event\ValueObjects\Audience;
15		use CultuurNet\UDB3\Label\LabelServiceInterface;
16		use CultuurNet\UDB3\Language;
17		use CultuurNet\UDB3\Location\Location;
18		use CultuurNet\UDB3\Location\LocationId;
19		use CultuurNet\UDB3\Offer\Commands\OfferCommandFactoryInterface;
20		use CultuurNet\UDB3\Offer\DefaultOfferEditingService;
21		use CultuurNet\UDB3\Theme;
22		use CultuurNet\UDB3\Title;
23
24		class DefaultEventEditingService extends DefaultOfferEditingService implements EventEditingServiceInterface
25		{
26		/**
27		* @var EventServiceInterface
28		*/
29		protected $eventService;
30
31		/**
32		* @var RepositoryInterface
33		*/
34		protected $writeRepository;
35
36		/**
37		* @param EventServiceInterface $eventService
38		* @param CommandBusInterface $commandBus
39		* @param UuidGeneratorInterface $uuidGenerator
40		* @param DocumentRepositoryInterface $readRepository
41		* @param OfferCommandFactoryInterface $commandFactory
42		* @param RepositoryInterface $writeRepository
43		* @param LabelServiceInterface $labelService
44		*/
45	View Code Duplication	public function __construct(
		0 ignored issues – show Duplication introduced 2017-07-31 14:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46		EventServiceInterface $eventService,
47		CommandBusInterface $commandBus,
48		UuidGeneratorInterface $uuidGenerator,
49		DocumentRepositoryInterface $readRepository,
50		OfferCommandFactoryInterface $commandFactory,
51		RepositoryInterface $writeRepository,
52		LabelServiceInterface $labelService
53		) {
54		parent::__construct(
55		$commandBus,
56		$uuidGenerator,
57		$readRepository,
58		$commandFactory,
59		$labelService,
60		new EventTypeResolver(),
61		new EventThemeResolver()
62		);
63		$this->eventService = $eventService;
64		$this->writeRepository = $writeRepository;
65		}
66
67		/**
68		* {@inheritdoc}
69		*/
70	View Code Duplication	public function createEvent(
		0 ignored issues – show Duplication introduced 2018-02-13 10:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
71		Language $mainLanguage,
72		Title $title,
73		EventType $eventType,
74		Location $location,
75		CalendarInterface $calendar,
76		$theme = null
77		) {
78		$eventId = $this->uuidGenerator->generate();
79
80		$event = Event::create(
81		$eventId,
82		$mainLanguage,
83		$title,
84		$eventType,
85		$location,
86		$calendar,
87		$theme,
88		$this->publicationDate
89		);
90
91		$this->writeRepository->save($event);
92
93		return $eventId;
94		}
95
96		/**
97		* @inheritdoc
98		*/
99	View Code Duplication	public function createApprovedEvent(
		0 ignored issues – show Duplication introduced 2018-04-12 12:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
100		Language $mainLanguage,
101		Title $title,
102		EventType $eventType,
103		Location $location,
104		CalendarInterface $calendar,
105		Theme $theme = null
106		) {
107		$eventId = $this->uuidGenerator->generate();
108
109		$event = Event::create(
110		$eventId,
111		$mainLanguage,
112		$title,
113		$eventType,
114		$location,
115		$calendar,
116		$theme
117		);
118
119		$publicationDate = $this->publicationDate ? $this->publicationDate : new \DateTimeImmutable();
120		$event->publish($publicationDate);
121		$event->approve();
122
123		$this->writeRepository->save($event);
124
125		return $eventId;
126		}
127
128		/**
129		* @inheritdoc
130		*/
131		public function copyEvent($originalEventId, CalendarInterface $calendar)
132		{
133		if (!is_string($originalEventId)) {
134		throw new \InvalidArgumentException(
135		'Expected originalEventId to be a string, received ' . gettype($originalEventId)
136		);
137		}
138
139		try {
140		/** @var Event $event */
141		$event = $this->writeRepository->load($originalEventId);
142		} catch (AggregateNotFoundException $exception) {
143		throw new \InvalidArgumentException(
144		'No original event found to copy with id ' . $originalEventId
145		);
146		}
147
148		$eventId = $this->uuidGenerator->generate();
149
150		$newEvent = $event->copy($eventId, $calendar);
151
152		$this->writeRepository->save($newEvent);
153
154		return $eventId;
155		}
156
157		/**
158		* {@inheritdoc}
159		*/
160	View Code Duplication	public function updateMajorInfo($eventId, Title $title, EventType $eventType, Location $location, CalendarInterface $calendar, $theme = null)
		0 ignored issues – show Duplication introduced 2015-11-24 14:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
161		{
162		$this->guardId($eventId);
163
164		return $this->commandBus->dispatch(
165		new UpdateMajorInfo($eventId, $title, $eventType, $location, $calendar, $theme)
166		);
167		}
168
169		/**
170		* @inheritdoc
171		*/
172		public function updateLocation($eventId, LocationId $locationId)
173		{
174		$this->guardId($eventId);
175
176		return $this->commandBus->dispatch(
177		new UpdateLocation($eventId, $locationId)
178		);
179		}
180
181		/**
182		* @inheritdoc
183		*/
184		public function updateAudience($eventId, Audience $audience)
185		{
186		return $this->commandBus->dispatch(
187		new UpdateAudience($eventId, $audience)
188		);
189		}
190
191		/**
192		* {@inheritdoc}
193		*/
194		public function deleteEvent($eventId)
195		{
196		return $this->delete($eventId);
197		}
198		}
199

cultuurnet / udb3-php

Pull Request — master (#362)

DefaultEventEditingService::updateLocation() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like