EventCopied::__construct() - Code Metrics - Inspection of "III-1737 Make it possible to copy an event." - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#264)

by Luc

created 2017-01-06 08:22 UTC

EventCopied::__construct() A

↳ Parent: EventCopied

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	10

Duplication

Lines	16
Ratio	100 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	16
loc	16
rs	9.4285
cc	2
eloc	10
nc	2
nop	3

<?php

namespace CultuurNet\UDB3\Event\Events;

use CultuurNet\UDB3\Calendar;
use CultuurNet\UDB3\CalendarInterface;
use CultuurNet\UDB3\Offer\Events\AbstractEvent;

class EventCopied extends AbstractEvent
{
    /**
     * @var string
     */
    private $originalEventId;

    /**
     * @var CalendarInterface|Calendar
     */
    private $calendar;

    /**
     * EventCopied constructor.
     * @param string $eventId
     * @param string $originalEventId
     * @param CalendarInterface $calendar
     */
    public function __construct(

        $eventId,
        $originalEventId,
        CalendarInterface $calendar
    ) {
        parent::__construct($eventId);

        if (!is_string($originalEventId)) {
            throw new \InvalidArgumentException(
                'Expected originalEventId to be a string, received ' . gettype($originalEventId)
            );
        }

        $this->originalEventId = $originalEventId;
        $this->calendar = $calendar;
    }

    /**
     * @return string
     */
    public function getOriginalEventId()
    {
        return $this->originalEventId;
    }

    /**
     * @return CalendarInterface
     */
    public function getCalendar()
    {
        return $this->calendar;
    }

    /**
     * @inheritdoc
     */
    public function serialize()
    {
        return parent::serialize() + [
                'original_event_id' => $this->getOriginalEventId(),
                'calendar' => $this->calendar->serialize()
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ];
    }

    /**
     * @inheritdoc
     */
    public static function deserialize(array $data)
    {
        return new static(
            $data['item_id'],
            $data['original_event_id'],
            Calendar::deserialize($data['calendar'])
        );
    }
}


1		<?php
2
3		namespace CultuurNet\UDB3\Event\Events;
4
5		use CultuurNet\UDB3\Calendar;
6		use CultuurNet\UDB3\CalendarInterface;
7		use CultuurNet\UDB3\Offer\Events\AbstractEvent;
8
9		class EventCopied extends AbstractEvent
10		{
11		/**
12		* @var string
13		*/
14		private $originalEventId;
15
16		/**
17		* @var CalendarInterface\|Calendar
18		*/
19		private $calendar;
20
21		/**
22		* EventCopied constructor.
23		* @param string $eventId
24		* @param string $originalEventId
25		* @param CalendarInterface $calendar
26		*/
27	View Code Duplication	public function __construct(
		0 ignored issues – show Duplication introduced 2017-01-06 08:44 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		$eventId,
29		$originalEventId,
30		CalendarInterface $calendar
31		) {
32		parent::__construct($eventId);
33
34		if (!is_string($originalEventId)) {
35		throw new \InvalidArgumentException(
36		'Expected originalEventId to be a string, received ' . gettype($originalEventId)
37		);
38		}
39
40		$this->originalEventId = $originalEventId;
41		$this->calendar = $calendar;
42		}
43
44		/**
45		* @return string
46		*/
47		public function getOriginalEventId()
48		{
49		return $this->originalEventId;
50		}
51
52		/**
53		* @return CalendarInterface
54		*/
55		public function getCalendar()
56		{
57		return $this->calendar;
58		}
59
60		/**
61		* @inheritdoc
62		*/
63		public function serialize()
64		{
65		return parent::serialize() + [
66		'original_event_id' => $this->getOriginalEventId(),
67		'calendar' => $this->calendar->serialize()
		0 ignored issues – show Bug introduced 2017-01-06 07:34 UTC by Report Bug Copy Issue Report The method `serialize` does only exist in `CultuurNet\UDB3\Calendar`, but not in `CultuurNet\UDB3\CalendarInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
68		];
69		}
70
71		/**
72		* @inheritdoc
73		*/
74		public static function deserialize(array $data)
75		{
76		return new static(
77		$data['item_id'],
78		$data['original_event_id'],
79		Calendar::deserialize($data['calendar'])
80		);
81		}
82		}
83

cultuurnet / udb3-php

Pull Request — master (#264)

EventCopied::__construct() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like