AgeRange::fromUbd3ModelAgeRange() - Code Metrics - Inspection of "Feature/iii 2537" - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#350)

unknown

created 2018-03-21 15:00 UTC

AgeRange::fromUbd3ModelAgeRange() A

↳ Parent: AgeRange

Complexity

Conditions	3
Paths	4

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	8
nc	4
nop	1

<?php

namespace CultuurNet\UDB3\Offer;

use CultuurNet\UDB3\Model\ValueObject\Audience\AgeRange as Udb3ModelAgeRange;
use ValueObjects\Person\Age;

class AgeRange
{
    /**
     * @var null|Age
     */
    private $from;

    /**
     * @var null|Age
     */
    private $to;

    /**
     * AgeRange constructor.
     * @param null|Age $from
     * @param null|Age $to
     */
    public function __construct(Age $from = null, Age $to = null)
    {
        $this->guardValidAgeRange($from, $to);

        $this->from = $from;
        $this->to = $to;
    }

    /**
     * @param null|Age $from
     * @param null|Age $to
     *
     * @throws InvalidAgeRangeException
     */
    private function guardValidAgeRange(Age $from = null, Age $to = null)
    {
        if ($from && $to && $from > $to) {
            throw new InvalidAgeRangeException('"from" age should not exceed "to" age');
        }
    }

    /**
     * @return null|Age
     */
    public function getFrom()
    {
        return $this->from;
    }

    /**
     * @return null|Age
     */
    public function getTo()
    {
        return $this->to;
    }

    /**
     * @return string
     */
    public function __toString()
    {
        $from = $this->from ? (string) $this->from : '';
        $to = $this->to ? (string) $this->to : '';

        return $from . '-' . $to;
    }

    /**
     * @param string $ageRangeString
     * @return AgeRange
     *
     * @throws InvalidAgeRangeException
     */
    public static function fromString($ageRangeString)
    {
        if (!is_string($ageRangeString)) {
            throw new InvalidAgeRangeException(
                'Date-range should be of type string.'
            );
        }

        $stringValues = explode('-', $ageRangeString);

        if (empty($stringValues) || !isset($stringValues[1])) {
            throw new InvalidAgeRangeException(
                'Date-range string is not valid because it is missing a hyphen.'
            );
        }

        if (count($stringValues) !== 2) {
            throw new InvalidAgeRangeException(
                'Date-range string is not valid because it has too many hyphens.'
            );
        }

        $fromString = $stringValues[0];
        $toString = $stringValues[1];

        if (is_numeric($fromString) || empty($fromString)) {

            $from = is_numeric($fromString) ? new Age($fromString) : null;
        } else {
            throw new InvalidAgeRangeException(
                'The "from" age should be a natural number or empty.'
            );
        }

        if (is_numeric($toString) || empty($toString)) {

            $to = is_numeric($toString) ? new Age($toString) : null;
        } else {
            throw new InvalidAgeRangeException(
                'The "to" age should be a natural number or empty.'
            );
        }

        return new self($from, $to);
    }

    /**
     * @param AgeRange $otherAgeRange
     * @return bool
     */
    public function sameAs(AgeRange $otherAgeRange)
    {
        return "$this" === "$otherAgeRange";
    }

    /**
     * @param Udb3ModelAgeRange $udb3ModelAgeRange
     * @return AgeRange
     */
    public static function fromUbd3ModelAgeRange(Udb3ModelAgeRange $udb3ModelAgeRange)
    {
        $from = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if ($from = $udb3ModelAgeRange->getFrom()) {
            $from = new Age($from->toInteger());
        }

        $to = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if ($to = $udb3ModelAgeRange->getTo()) {
            $to = new Age($to->toInteger());
        }

        return new AgeRange($from, $to);
    }
}


1		<?php
2
3		namespace CultuurNet\UDB3\Offer;
4
5		use CultuurNet\UDB3\Model\ValueObject\Audience\AgeRange as Udb3ModelAgeRange;
6		use ValueObjects\Person\Age;
7
8		class AgeRange
9		{
10		/**
11		* @var null\|Age
12		*/
13		private $from;
14
15		/**
16		* @var null\|Age
17		*/
18		private $to;
19
20		/**
21		* AgeRange constructor.
22		* @param null\|Age $from
23		* @param null\|Age $to
24		*/
25		public function __construct(Age $from = null, Age $to = null)
26		{
27		$this->guardValidAgeRange($from, $to);
28
29		$this->from = $from;
30		$this->to = $to;
31		}
32
33		/**
34		* @param null\|Age $from
35		* @param null\|Age $to
36		*
37		* @throws InvalidAgeRangeException
38		*/
39		private function guardValidAgeRange(Age $from = null, Age $to = null)
40		{
41		if ($from && $to && $from > $to) {
42		throw new InvalidAgeRangeException('"from" age should not exceed "to" age');
43		}
44		}
45
46		/**
47		* @return null\|Age
48		*/
49		public function getFrom()
50		{
51		return $this->from;
52		}
53
54		/**
55		* @return null\|Age
56		*/
57		public function getTo()
58		{
59		return $this->to;
60		}
61
62		/**
63		* @return string
64		*/
65		public function __toString()
66		{
67		$from = $this->from ? (string) $this->from : '';
68		$to = $this->to ? (string) $this->to : '';
69
70		return $from . '-' . $to;
71		}
72
73		/**
74		* @param string $ageRangeString
75		* @return AgeRange
76		*
77		* @throws InvalidAgeRangeException
78		*/
79		public static function fromString($ageRangeString)
80		{
81		if (!is_string($ageRangeString)) {
82		throw new InvalidAgeRangeException(
83		'Date-range should be of type string.'
84		);
85		}
86
87		$stringValues = explode('-', $ageRangeString);
88
89		if (empty($stringValues) \|\| !isset($stringValues[1])) {
90		throw new InvalidAgeRangeException(
91		'Date-range string is not valid because it is missing a hyphen.'
92		);
93		}
94
95		if (count($stringValues) !== 2) {
96		throw new InvalidAgeRangeException(
97		'Date-range string is not valid because it has too many hyphens.'
98		);
99		}
100
101		$fromString = $stringValues[0];
102		$toString = $stringValues[1];
103
104	View Code Duplication	if (is_numeric($fromString) \|\| empty($fromString)) {
		0 ignored issues – show Duplication introduced 2017-04-04 13:38 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
105		$from = is_numeric($fromString) ? new Age($fromString) : null;
106		} else {
107		throw new InvalidAgeRangeException(
108		'The "from" age should be a natural number or empty.'
109		);
110		}
111
112	View Code Duplication	if (is_numeric($toString) \|\| empty($toString)) {
		0 ignored issues – show Duplication introduced 2017-04-04 13:38 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
113		$to = is_numeric($toString) ? new Age($toString) : null;
114		} else {
115		throw new InvalidAgeRangeException(
116		'The "to" age should be a natural number or empty.'
117		);
118		}
119
120		return new self($from, $to);
121		}
122
123		/**
124		* @param AgeRange $otherAgeRange
125		* @return bool
126		*/
127		public function sameAs(AgeRange $otherAgeRange)
128		{
129		return "$this" === "$otherAgeRange";
130		}
131
132		/**
133		* @param Udb3ModelAgeRange $udb3ModelAgeRange
134		* @return AgeRange
135		*/
136		public static function fromUbd3ModelAgeRange(Udb3ModelAgeRange $udb3ModelAgeRange)
137		{
138		$from = null;
		0 ignored issues – show Unused Code introduced 2018-03-21 15:21 UTC by Report Bug Copy Issue Report `$from` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
139		if ($from = $udb3ModelAgeRange->getFrom()) {
140		$from = new Age($from->toInteger());
141		}
142
143		$to = null;
		0 ignored issues – show Unused Code introduced 2018-03-21 15:21 UTC by Report Bug Copy Issue Report `$to` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
144		if ($to = $udb3ModelAgeRange->getTo()) {
145		$to = new Age($to->toInteger());
146		}
147
148		return new AgeRange($from, $to);
149		}
150		}
151

cultuurnet / udb3-php

Pull Request — master (#350)

AgeRange::fromUbd3ModelAgeRange() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like