Completed
Push — master ( 296b7c...3c098c )
by Kristof
10s
created
src/Place/Place.php 2 patches
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
     /**
86 86
      * Apply the place created event.
87
-     * @param PlaceCreate $placeCreated
87
+     * @param PlaceCreated $placeCreated
88 88
      */
89 89
     protected function applyPlaceCreated(PlaceCreated $placeCreated)
90 90
     {
@@ -114,6 +114,7 @@  discard block
 block discarded – undo
114 114
 
115 115
     /**
116 116
      * Handle an update command to update organizer.
117
+     * @param string $organizerId
117 118
      */
118 119
     public function updateOrganizer($organizerId)
119 120
     {
@@ -225,7 +226,7 @@  discard block
 block discarded – undo
225 226
      * @param string $cdbXmlNamespaceUri
226 227
      *   The cdb xml namespace uri.
227 228
      *
228
-     * @return Actor
229
+     * @return Place
229 230
      *   The actor.
230 231
      */
231 232
     public static function importFromUDB2Actor(
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -12,14 +12,11 @@  discard block
 block discarded – undo
12 12
 use CultuurNet\UDB3\Offer\Commands\Image\AbstractUpdateImage;
13 13
 use CultuurNet\UDB3\Offer\Offer;
14 14
 use CultuurNet\UDB3\Media\Image;
15
-use CultuurNet\UDB3\Media\MediaObject;
16
-use CultuurNet\UDB3\Place\Commands\UpdateImage;
17 15
 use CultuurNet\UDB3\Place\Events\BookingInfoUpdated;
18 16
 use CultuurNet\UDB3\Place\Events\ContactPointUpdated;
19 17
 use CultuurNet\UDB3\Place\Events\DescriptionUpdated;
20 18
 use CultuurNet\UDB3\Place\Events\FacilitiesUpdated;
21 19
 use CultuurNet\UDB3\Place\Events\ImageAdded;
22
-use CultuurNet\UDB3\Place\Events\ImageDeleted;
23 20
 use CultuurNet\UDB3\Place\Events\ImageRemoved;
24 21
 use CultuurNet\UDB3\Place\Events\ImageUpdated;
25 22
 use CultuurNet\UDB3\Place\Events\LabelAdded;
@@ -36,7 +33,6 @@  discard block
 block discarded – undo
36 33
 use CultuurNet\UDB3\Place\Events\TypicalAgeRangeUpdated;
37 34
 use CultuurNet\UDB3\Theme;
38 35
 use CultuurNet\UDB3\Title;
39
-use Symfony\Component\EventDispatcher\Event;
40 36
 
41 37
 class Place extends Offer implements UpdateableWithCdbXmlInterface
42 38
 {
Please login to merge, or discard this patch.
src/Offer/Events/Image/AbstractImageEvent.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
 
49 49
     /**
50 50
      * @param array $data
51
-     * @return mixed The object instance
51
+     * @return AbstractImageEvent The object instance
52 52
      */
53 53
     public static function deserialize(array $data)
54 54
     {
Please login to merge, or discard this patch.
src/Offer/Events/Image/AbstractImageUpdated.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -79,10 +79,10 @@
 block discarded – undo
79 79
      */
80 80
     public function serialize()
81 81
     {
82
-        return parent::serialize() +  array(
83
-            'media_object_id' => (string) $this->mediaObjectId,
84
-            'description' => (string) $this->description,
85
-            'copyright_holder' => (string) $this->copyrightHolder
82
+        return parent::serialize() + array(
83
+            'media_object_id' => (string)$this->mediaObjectId,
84
+            'description' => (string)$this->description,
85
+            'copyright_holder' => (string)$this->copyrightHolder
86 86
         );
87 87
     }
88 88
 
Please login to merge, or discard this patch.
src/Offer/Offer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -462,7 +462,7 @@
 block discarded – undo
462 462
     {
463 463
         $duplicateMediaObject = array_filter(
464 464
             $this->getMediaObjects(),
465
-            function ($existingMediaObjectId) use ($image) {
465
+            function($existingMediaObjectId) use ($image) {
466 466
                 return $image
467 467
                     ->getMediaObjectId()
468 468
                     ->sameValueAs($existingMediaObjectId);
Please login to merge, or discard this patch.
src/Offer/ReadModel/JSONLD/OfferLDProjector.php 3 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
         $offerLd = $document->getBody();
158 158
 
159 159
         $labels = isset($offerLd->labels) ? $offerLd->labels : [];
160
-        $label = (string) $labelAdded->getLabel();
160
+        $label = (string)$labelAdded->getLabel();
161 161
 
162 162
         $labels[] = $label;
163 163
         $offerLd->labels = array_unique($labels);
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
         if (is_array($offerLd->labels)) {
178 178
             $offerLd->labels = array_filter(
179 179
                 $offerLd->labels,
180
-                function ($label) use ($deleteLabel) {
180
+                function($label) use ($deleteLabel) {
181 181
                     return !$deleteLabel->getLabel()->equals(
182 182
                         new Label($label)
183 183
                     );
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
             return;
265 265
         }
266 266
 
267
-        $imageId = (string) $imageRemoved->getImage()->getMediaObjectId();
267
+        $imageId = (string)$imageRemoved->getImage()->getMediaObjectId();
268 268
 
269 269
         /**
270 270
          * Matches any object that is not the removed image.
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
          * @return bool
276 276
          *  Returns true when the media object does not match the image to remove.
277 277
          */
278
-        $shouldNotBeRemoved = function ($mediaObject) use ($imageId) {
278
+        $shouldNotBeRemoved = function($mediaObject) use ($imageId) {
279 279
             $containsId = !!strpos($mediaObject->{'@id'}, $imageId);
280 280
             return !$containsId;
281 281
         };
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -263,7 +263,7 @@
 block discarded – undo
263 263
     }
264 264
 
265 265
     /**
266
-     * @param AbstractRemoveImage $imageRemoved
266
+     * @param AbstractImageRemoved $imageRemoved
267 267
      */
268 268
     protected function applyImageRemoved(AbstractImageRemoved $imageRemoved)
269 269
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace CultuurNet\UDB3\Offer\ReadModel\JSONLD;
4 4
 
5 5
 use Broadway\Domain\DomainMessage;
6
-use CultuurNet\UDB3\Calendar;
7 6
 use CultuurNet\UDB3\CulturefeedSlugger;
8 7
 use CultuurNet\UDB3\EntityServiceInterface;
9 8
 use CultuurNet\UDB3\Event\ReadModel\DocumentRepositoryInterface;
Please login to merge, or discard this patch.
src/Event/Event.php 2 patches
Doc Comments   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -78,6 +78,7 @@  discard block
 block discarded – undo
78 78
      * @param Location $location
79 79
      * @param CalendarInterface $calendar
80 80
      * @param Theme/null $theme
81
+     * @param string $eventId
81 82
      *
82 83
      * @return Event
83 84
      */
@@ -282,7 +283,7 @@  discard block
 block discarded – undo
282 283
     }
283 284
 
284 285
     /**
285
-     * @return UUID[]
286
+     * @return \CultuurNet\UDB3\Offer\UUID[]
286 287
      */
287 288
     public function getMediaObjects()
288 289
     {
@@ -366,9 +367,6 @@  discard block
 block discarded – undo
366 367
     /**
367 368
      * Updated the contact info.
368 369
      *
369
-     * @param array $phones
370
-     * @param array $emails
371
-     * @param array $urls
372 370
      */
373 371
     public function updateContactPoint(ContactPoint $contactPoint)
374 372
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace CultuurNet\UDB3\Event;
4 4
 
5
-use Broadway\EventSourcing\EventSourcedAggregateRoot;
6 5
 use CultuurNet\UDB3\BookingInfo;
7 6
 use CultuurNet\UDB3\CalendarInterface;
8 7
 use CultuurNet\UDB3\Cdb\EventItemFactory;
Please login to merge, or discard this patch.