CultuurNet\UDB3\Calendar\OpeningHour

Complexity

Total Complexity

6

Size/Duplication

Total Lines	101
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
A	getOpens()	0	4	1
A	getCloses()	0	4	1
A	getWeekDays()	0	4	1
A	deserialize()	0	19	1
A	serialize()	0	15	1

<?php

namespace CultuurNet\UDB3\Calendar;

use Broadway\Serializer\SerializableInterface;
use ValueObjects\DateTime\Time;
use ValueObjects\DateTime\WeekDay;

class OpeningHour implements SerializableInterface
{
    const FORMAT = 'H:i:s';

    /**
     * @var Time
     */
    private $opens;

    /**
     * @var Time
     */
    private $closes;

    /**
     * @var WeekDay[]
     */
    private $weekDays;

    /**
     * OpeningHour constructor.
     * @param Time $opens
     * @param Time $closes
     * @param WeekDay[] $weekDays
     */
    public function __construct(
        Time $opens,
        Time $closes,
        WeekDay ...$weekDays
    ) {
        $this->weekDays = $weekDays;

It seems like $weekDays of type array<integer,array<integer,object<ValueObjects\DateTime\WeekDay>>> is incompatible with the declared type array<integer,object<ValueObjects\DateTime\WeekDay>> of property $weekDays.

        $this->opens = $opens;
        $this->closes = $closes;
    }

    /**
     * @return Time
     */
    public function getOpens()
    {
        return $this->opens;
    }

    /**
     * @return Time
     */
    public function getCloses()
    {
        return $this->closes;
    }

    /**
     * @return WeekDay[]
     */
    public function getWeekDays()
    {
        return $this->weekDays;
    }

    /**
     * @inheritdoc
     */
    public static function deserialize(array $data)
    {
        $weekDays = array_map(
            function ($dayOfWeek) {
                return WeekDay::fromNative($dayOfWeek);
            },
            $data['dayOfWeek']
        );

        return new static(
            Time::fromNativeDateTime(
                \DateTime::createFromFormat(self::FORMAT, $data['opens'])

It seems like \DateTime::createFromFormat(self::FORMAT, $data['opens']) targeting DateTime::createFromFormat() can also be of type false; however, ValueObjects\DateTime\Time::fromNativeDateTime() does only seem to accept object<DateTime>, did you maybe forget to handle an error condition?

            ),
            Time::fromNativeDateTime(
                \DateTime::createFromFormat(self::FORMAT, $data['closes'])

It seems like \DateTime::createFromFormat(self::FORMAT, $data['closes']) targeting DateTime::createFromFormat() can also be of type false; however, ValueObjects\DateTime\Time::fromNativeDateTime() does only seem to accept object<DateTime>, did you maybe forget to handle an error condition?

            ),
            ...$weekDays
        );
    }

    /**
     * @inheritdoc
     */
    public function serialize()
    {
        $serializedWeekDays = array_map(
            function (WeekDay $weekDay) {
                return $weekDay->getValue();
            },
            $this->weekDays
        ) ;

        return [
            'opens' => $this->opens->toNativeDateTime()->format(self::FORMAT),
            'closes' => $this->closes->toNativeDateTime()->format(self::FORMAT),
            'dayOfWeek' => $serializedWeekDays
        ];
    }
}