CopyAwareEventStoreDecorator::identifyParent() - Code Metrics - Inspection of "III-1747: Copy-aware event-store decorator" - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#279)

by Luc

created 2017-01-19 13:56 UTC

CopyAwareEventStoreDecorator::identifyParent() A

↳ Parent: CopyAwareEventStoreDecorator

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	1

<?php

namespace CultuurNet\UDB3\EventSourcing;

use Broadway\Domain\DomainEventStream;
use Broadway\Domain\DomainEventStreamInterface;
use Broadway\Domain\DomainMessage;

class CopyAwareEventStoreDecorator extends AbstractEventStoreDecorator
{
    /**
     * @inheritdoc
     */
    public function load($id)
    {
        return $this->loadCompleteStream(parent::load($id));
    }

    /**
     * @param DomainEventStreamInterface $eventStream
     * @return DomainEventStreamInterface
     */
    private function loadCompleteStream(DomainEventStreamInterface $eventStream)
    {
        $events = iterator_to_array($eventStream);
        /** @var DomainMessage $oldestMessage */
        $oldestMessage = current($events);
        if (intval($oldestMessage->getPlayhead()) === 0) {
            return $eventStream;
        }

        $parentId = $this->identifyParent($oldestMessage);
        $parentEventStream = parent::load($parentId);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}

        $inheritedEvents = $this->limitEventStreamToPlayhead($parentEventStream, $oldestMessage->getPlayhead());
        $combinedEvents = array_merge($inheritedEvents, $events);

        return $this->loadCompleteStream(new DomainEventStream($combinedEvents));
    }

    /**
     * @param DomainMessage $message
     * @return string
     *
     * @throws UnknownParentAggregateException
     */
    private function identifyParent(DomainMessage $message)
    {
        /** @var AggregateCopiedEventInterface $domainEvent */
        $domainEvent = $message->getPayload();

        if (!$domainEvent instanceof AggregateCopiedEventInterface) {
            throw new UnknownParentAggregateException();
        }

        return $domainEvent->getParentAggregateId();
    }

    /**
     * @param DomainEventStreamInterface $eventStream
     * @param int $playhead
     *
     * @return DomainMessage[]
     */
    private function limitEventStreamToPlayhead(DomainEventStreamInterface $eventStream, $playhead)
    {
        return array_filter(
            iterator_to_array($eventStream),
            function (DomainMessage $message) use ($playhead) {
                return intval($message->getPlayhead()) < $playhead;
            }
        );
    }
}


1			<?php
2
3			namespace CultuurNet\UDB3\EventSourcing;
4
5			use Broadway\Domain\DomainEventStream;
6			use Broadway\Domain\DomainEventStreamInterface;
7			use Broadway\Domain\DomainMessage;
8
9			class CopyAwareEventStoreDecorator extends AbstractEventStoreDecorator
10			{
11			/**
12			* @inheritdoc
13			*/
14			public function load($id)
15			{
16			return $this->loadCompleteStream(parent::load($id));
17			}
18
19			/**
20			* @param DomainEventStreamInterface $eventStream
21			* @return DomainEventStreamInterface
22			*/
23			private function loadCompleteStream(DomainEventStreamInterface $eventStream)
24			{
25			$events = iterator_to_array($eventStream);
26			/** @var DomainMessage $oldestMessage */
27			$oldestMessage = current($events);
28			if (intval($oldestMessage->getPlayhead()) === 0) {
29			return $eventStream;
30			}
31
32			$parentId = $this->identifyParent($oldestMessage);
33			$parentEventStream = parent::load($parentId);
			0 ignored issues – show Comprehensibility Bug introduced 2017-01-19 10:44 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`load()` instead of `loadCompleteStream()`). Are you sure this is correct? If so, you might want to change this to `$this->load()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
34
35			$inheritedEvents = $this->limitEventStreamToPlayhead($parentEventStream, $oldestMessage->getPlayhead());
36			$combinedEvents = array_merge($inheritedEvents, $events);
37
38			return $this->loadCompleteStream(new DomainEventStream($combinedEvents));
39			}
40
41			/**
42			* @param DomainMessage $message
43			* @return string
44			*
45			* @throws UnknownParentAggregateException
46			*/
47			private function identifyParent(DomainMessage $message)
48			{
49			/** @var AggregateCopiedEventInterface $domainEvent */
50			$domainEvent = $message->getPayload();
51
52			if (!$domainEvent instanceof AggregateCopiedEventInterface) {
53			throw new UnknownParentAggregateException();
54			}
55
56			return $domainEvent->getParentAggregateId();
57			}
58
59			/**
60			* @param DomainEventStreamInterface $eventStream
61			* @param int $playhead
62			*
63			* @return DomainMessage[]
64			*/
65			private function limitEventStreamToPlayhead(DomainEventStreamInterface $eventStream, $playhead)
66			{
67			return array_filter(
68			iterator_to_array($eventStream),
69			function (DomainMessage $message) use ($playhead) {
70			return intval($message->getPlayhead()) < $playhead;
71			}
72			);
73			}
74			}
75

cultuurnet / udb3-php

Pull Request — master (#279)

CopyAwareEventStoreDecorator::identifyParent() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like