cultuurnet /
udb3-php
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 8 | View Code Duplication | abstract class AbstractUpdateDescription extends AbstractCommand |
|
|
|
|||
| 9 | { |
||
| 10 | /** |
||
| 11 | * Description to be added. |
||
| 12 | * @var Description |
||
| 13 | */ |
||
| 14 | protected $description; |
||
| 15 | |||
| 16 | /** |
||
| 17 | * @var Language |
||
| 18 | */ |
||
| 19 | protected $language; |
||
| 20 | |||
| 21 | /** |
||
| 22 | * @param string $itemId |
||
| 23 | * @param Description $description |
||
| 24 | * @param Language $language |
||
| 25 | */ |
||
| 26 | public function __construct($itemId, Language $language, Description $description) |
||
| 32 | |||
| 33 | /** |
||
| 34 | * @return Description |
||
| 35 | */ |
||
| 36 | public function getDescription() |
||
| 40 | |||
| 41 | /** |
||
| 42 | * @return Language |
||
| 43 | */ |
||
| 44 | public function getLanguage() |
||
| 48 | } |
||
| 49 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.