OfferCommandHandler - Code Metrics - Inspection of "Merge pull request #349 from cultuurnet/feature/II..." - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5ace45...cd9bd4 )

unknown

created 2018-03-29 09:48 UTC

OfferCommandHandler D

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	586
Duplicated Lines	7 %

Coupling/Cohesion

Components	1
Dependencies	34

Importance

Changes

Metric	Value
wmc	37
c	0
b	0
f	0
lcom	1
cbo	34
dl	41
loc	586
rs	4.3

60 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
A	handle()	12	12	2
A	getCommandHandlers()	19	19	4
	getAddLabelClassName()	0	1	?
	getRemoveLabelClassName()	0	1	?
	getImportLabelsClassName()	0	1	?
	getUpdateTitleClassName()	0	1	?
	getAddImageClassName()	0	1	?
	getUpdateImageClassName()	0	1	?
	getRemoveImageClassName()	0	1	?
	getSelectMainImageClassName()	0	1	?
	getUpdateDescriptionClassName()	0	1	?
	getUpdateCalendarClassName()	0	1	?
	getUpdateTypicalAgeRangeClassName()	0	1	?
	getDeleteTypicalAgeRangeClassName()	0	1	?
	getUpdateOrganizerClassName()	0	1	?
	getDeleteOrganizerClassName()	0	1	?
	getDeleteCurrentOrganizerClassName()	0	1	?
	getUpdateContactPointClassName()	0	1	?
	getUpdateBookingInfoClassName()	0	1	?
	getUpdatePriceInfoClassName()	0	1	?
	getDeleteOfferClassName()	0	1	?
	getPublishClassName()	0	1	?
	getApproveClassName()	0	1	?
	getRejectClassName()	0	1	?
	getFlagAsDuplicateClassName()	0	1	?
	getFlagAsInappropriateClassName()	0	1	?
	getUpdateTypeClassName()	0	1	?
	getUpdateThemeClassName()	0	1	?
	getUpdateFacilitiesClassName()	0	1	?
A	handleUpdateType()	0	8	1
A	handleUpdateTheme()	0	8	1
A	handleUpdateFacilities()	0	8	1
A	handleAddLabel()	0	8	1
A	handleRemoveLabel()	0	8	1
A	handleImportLabels()	0	8	1
A	createLabel()	10	10	1
A	handleUpdateTitle()	0	6	1
A	handleAddImage()	0	9	1
A	handleRemoveImage()	0	6	1
A	handleUpdateImage()	0	6	1
A	handleSelectMainImage()	0	6	1
A	handleUpdateDescription()	0	12	1
A	handleUpdateCalendar()	0	8	1
A	handleUpdateTypicalAgeRange()	0	11	1
A	handleDeleteTypicalAgeRange()	0	9	1
A	handleUpdateOrganizer()	0	11	1
A	handleDeleteOrganizer()	0	10	1
A	handleDeleteCurrentOrganizer()	0	8	1
A	handleUpdateContactPoint()	0	11	1
A	handleUpdateBookingInfo()	0	10	1
A	handleUpdatePriceInfo()	0	10	1
A	handleDeleteOffer()	0	6	1
A	handlePublish()	0	6	1
A	handleApprove()	0	6	1
A	handleReject()	0	6	1
A	handleFlagAsDuplicate()	0	6	1
A	handleFlagAsInappropriate()	0	6	1
A	load()	0	4	1
A	loadOrganizer()	0	5	1

How to fix Duplicated Code

<?php

namespace CultuurNet\UDB3\Offer;

use Broadway\Repository\RepositoryInterface;
use CultuurNet\UDB3\CommandHandling\Udb3CommandHandler;
use CultuurNet\UDB3\Label;
use CultuurNet\UDB3\Label\ReadModels\JSON\Repository\ReadRepositoryInterface;
use CultuurNet\UDB3\Label\ValueObjects\Visibility;
use CultuurNet\UDB3\Media\MediaManager;
use CultuurNet\UDB3\Media\MediaManagerInterface;
use CultuurNet\UDB3\Offer\Commands\AbstractAddLabel;
use CultuurNet\UDB3\Offer\Commands\AbstractDeleteCurrentOrganizer;
use CultuurNet\UDB3\Offer\Commands\AbstractImportLabels;
use CultuurNet\UDB3\Offer\Commands\AbstractLabelCommand;
use CultuurNet\UDB3\Offer\Commands\AbstractRemoveLabel;
use CultuurNet\UDB3\Offer\Commands\AbstractDeleteOffer;
use CultuurNet\UDB3\Offer\Commands\AbstractDeleteOrganizer;
use CultuurNet\UDB3\Offer\Commands\AbstractDeleteTypicalAgeRange;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateBookingInfo;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateCalendar;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateContactPoint;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateDescription;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateFacilities;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateOrganizer;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdatePriceInfo;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateTheme;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateType;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateTypicalAgeRange;
use CultuurNet\UDB3\Offer\Commands\Image\AbstractAddImage;
use CultuurNet\UDB3\Offer\Commands\Image\AbstractRemoveImage;
use CultuurNet\UDB3\Offer\Commands\Image\AbstractSelectMainImage;
use CultuurNet\UDB3\Offer\Commands\Image\AbstractUpdateImage;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateTitle;
use CultuurNet\UDB3\Offer\Commands\Moderation\AbstractApprove;
use CultuurNet\UDB3\Offer\Commands\Moderation\AbstractFlagAsDuplicate;
use CultuurNet\UDB3\Offer\Commands\Moderation\AbstractFlagAsInappropriate;
use CultuurNet\UDB3\Offer\Commands\Moderation\AbstractPublish;
use CultuurNet\UDB3\Offer\Commands\Moderation\AbstractReject;
use CultuurNet\UDB3\Organizer\Organizer;
use ValueObjects\StringLiteral\StringLiteral;

abstract class OfferCommandHandler extends Udb3CommandHandler
{
    /**
     * @var RepositoryInterface
     */
    protected $offerRepository;

    /**
     * @var RepositoryInterface
     */
    protected $organizerRepository;

    /**
     * @var RepositoryInterface
     */
    protected $labelRepository;

    /**
     * @var MediaManagerInterface|MediaManager
     */
    protected $mediaManager;

    /**
     * @param RepositoryInterface $offerRepository
     * @param RepositoryInterface $organizerRepository
     * @param ReadRepositoryInterface $labelRepository
     * @param MediaManagerInterface $mediaManager
     */
    public function __construct(
        RepositoryInterface $offerRepository,
        RepositoryInterface $organizerRepository,
        ReadRepositoryInterface $labelRepository,
        MediaManagerInterface $mediaManager
    ) {
        $this->offerRepository = $offerRepository;
        $this->organizerRepository = $organizerRepository;
        $this->labelRepository = $labelRepository;

        $this->mediaManager = $mediaManager;
    }

    /**
     * {@inheritdoc}
     */
    public function handle($command)

    {
        $commandName = get_class($command);
        $commandHandlers = $this->getCommandHandlers();

        if (isset($commandHandlers[$commandName])) {
            $handler = $commandHandlers[$commandName];
            call_user_func(array($this, $handler), $command);
        } else {
            parent::handle($command);
        }
    }

    /**
     * @return string[]
     *   An associative array of commands and their handler methods.
     */
    private function getCommandHandlers()

    {
        $commands = [];

        foreach (get_class_methods($this) as $method) {
            $matches = [];
            if (preg_match('/^handle(.+)$/', $method, $matches)) {
                $command = $matches[1];
                $classNameMethod = 'get' . $command . 'ClassName';

                if (method_exists($this, $classNameMethod)) {
                    $commandFullClassName = call_user_func(array($this, $classNameMethod));
                    $commands[$commandFullClassName] = $method;
                }
            }
        }

        return $commands;
    }

    /**
     * @return string
     */
    abstract protected function getAddLabelClassName();

    /**
     * @return string
     */
    abstract protected function getRemoveLabelClassName();

    /**
     * @return string
     */
    abstract protected function getImportLabelsClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateTitleClassName();

    /**
     * @return string
     */
    abstract protected function getAddImageClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateImageClassName();

    /**
     * @return string
     */
    abstract protected function getRemoveImageClassName();

    /**
     * @return string
     */
    abstract protected function getSelectMainImageClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateDescriptionClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateCalendarClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateTypicalAgeRangeClassName();

    /**
     * @return string
     */
    abstract protected function getDeleteTypicalAgeRangeClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateOrganizerClassName();

    /**
     * @return string
     */
    abstract protected function getDeleteOrganizerClassName();

    /**
     * @return string
     */
    abstract protected function getDeleteCurrentOrganizerClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateContactPointClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateBookingInfoClassName();

    /**
     * @return string
     */
    abstract protected function getUpdatePriceInfoClassName();

    /**
     * @return string
     */
    abstract protected function getDeleteOfferClassName();

    /**
     * @return string
     */
    abstract protected function getPublishClassName();

    /**
     * @return string
     */
    abstract protected function getApproveClassName();

    /**
     * @return string
     */
    abstract protected function getRejectClassName();

    /**
     * @return string
     */
    abstract protected function getFlagAsDuplicateClassName();

    /**
     * @return string
     */
    abstract protected function getFlagAsInappropriateClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateTypeClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateThemeClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateFacilitiesClassName();

    /**
     * @param AbstractUpdateType $updateType
     */
    public function handleUpdateType(AbstractUpdateType $updateType)
    {
        $offer = $this->load($updateType->getItemId());

        $offer->updateType($updateType->getType());

        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractUpdateTheme $updateTheme
     */
    public function handleUpdateTheme(AbstractUpdateTheme $updateTheme)
    {
        $offer = $this->load($updateTheme->getItemId());

        $offer->updateTheme($updateTheme->getTheme());

        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractUpdateFacilities $updateFacilities
     */
    public function handleUpdateFacilities(AbstractUpdateFacilities $updateFacilities)
    {
        $offer = $this->load($updateFacilities->getItemId());

        $offer->updateFacilities($updateFacilities->getFacilities());

        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractAddLabel $addLabel
     */
    private function handleAddLabel(AbstractAddLabel $addLabel)
    {
        $offer = $this->load($addLabel->getItemId());

        $offer->addLabel($this->createLabel($addLabel));

        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractRemoveLabel $removeLabel
     */
    private function handleRemoveLabel(AbstractRemoveLabel $removeLabel)
    {
        $offer = $this->load($removeLabel->getItemId());

        $offer->removeLabel($this->createLabel($removeLabel));

        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractImportLabels $importLabels
     */
    private function handleImportLabels(AbstractImportLabels $importLabels)
    {
        $offer = $this->load($importLabels->getItemId());

        $offer->importLabels($importLabels->getLabels());

        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractLabelCommand $labelCommand
     * @return Label
     */
    private function createLabel(AbstractLabelCommand $labelCommand)

    {
        $labelName = new StringLiteral((string) $labelCommand->getLabel());
        $label = $this->labelRepository->getByName($labelName);


        return new Label(
            $labelName->toNative(),
            $label->getVisibility() === Visibility::VISIBLE()
        );
    }

    /**
     * @param AbstractUpdateTitle $translateTitle
     */
    private function handleUpdateTitle(AbstractUpdateTitle $translateTitle)
    {
        $offer = $this->load($translateTitle->getItemId());
        $offer->updateTitle($translateTitle->getLanguage(), $translateTitle->getTitle());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->offerRepository->save($offer);
    }

    /**
     * Handle an add image command.
     * @param AbstractAddImage $addImage
     */
    public function handleAddImage(AbstractAddImage $addImage)
    {
        $offer = $this->load($addImage->getItemId());

        $image = $this->mediaManager->getImage($addImage->getImageId());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $offer->addImage($image);

        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractRemoveImage $removeImage
     */
    public function handleRemoveImage(AbstractRemoveImage $removeImage)
    {
        $offer = $this->load($removeImage->getItemId());
        $offer->removeImage($removeImage->getImage());
        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractUpdateImage $updateImage
     */
    public function handleUpdateImage(AbstractUpdateImage $updateImage)
    {
        $offer = $this->load($updateImage->getItemId());
        $offer->updateImage($updateImage);
        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractSelectMainImage $selectMainImage
     */
    public function handleSelectMainImage(AbstractSelectMainImage $selectMainImage)
    {
        $offer = $this->load($selectMainImage->getItemId());
        $offer->selectMainImage($selectMainImage->getImage());
        $this->offerRepository->save($offer);
    }

    /**
     * Handle the update of description on a place.
     * @param AbstractUpdateDescription $updateDescription
     */
    public function handleUpdateDescription(AbstractUpdateDescription $updateDescription)
    {
        $offer = $this->load($updateDescription->getItemId());

        $offer->updateDescription(
            $updateDescription->getDescription(),
            $updateDescription->getLanguage()
        );

        $this->offerRepository->save($offer);

    }

    /**
     * @param AbstractUpdateCalendar $updateCalendar
     */
    public function handleUpdateCalendar(AbstractUpdateCalendar $updateCalendar)
    {
        $offer = $this->load($updateCalendar->getItemId());

        $offer->updateCalendar($updateCalendar->getCalendar());

        $this->offerRepository->save($offer);
    }

    /**
     * Handle the update of typical age range on a place.
     * @param AbstractUpdateTypicalAgeRange $updateTypicalAgeRange
     */
    public function handleUpdateTypicalAgeRange(AbstractUpdateTypicalAgeRange $updateTypicalAgeRange)
    {
        $offer = $this->load($updateTypicalAgeRange->getItemId());

        $offer->updateTypicalAgeRange(
            $updateTypicalAgeRange->getTypicalAgeRange()
        );

        $this->offerRepository->save($offer);

    }

    /**
     * Handle the deletion of typical age range on a place.
     * @param AbstractDeleteTypicalAgeRange $deleteTypicalAgeRange
     */
    public function handleDeleteTypicalAgeRange(AbstractDeleteTypicalAgeRange $deleteTypicalAgeRange)
    {
        $offer = $this->load($deleteTypicalAgeRange->getItemId());

        $offer->deleteTypicalAgeRange();

        $this->offerRepository->save($offer);

    }

    /**
     * Handle an update command to update organizer of a place.
     * @param AbstractUpdateOrganizer $updateOrganizer
     */
    public function handleUpdateOrganizer(AbstractUpdateOrganizer $updateOrganizer)
    {
        $offer = $this->load($updateOrganizer->getItemId());
        $this->loadOrganizer($updateOrganizer->getOrganizerId());

        $offer->updateOrganizer(
            $updateOrganizer->getOrganizerId()
        );

        $this->offerRepository->save($offer);
    }

    /**
     * Handle an update command to delete the organizer.
     * @param AbstractDeleteOrganizer $deleteOrganizer
     */
    public function handleDeleteOrganizer(AbstractDeleteOrganizer $deleteOrganizer)
    {
        $offer = $this->load($deleteOrganizer->getItemId());

        $offer->deleteOrganizer(
            $deleteOrganizer->getOrganizerId()
        );

        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractDeleteCurrentOrganizer $deleteCurrentOrganizer
     */
    public function handleDeleteCurrentOrganizer(AbstractDeleteCurrentOrganizer $deleteCurrentOrganizer)
    {
        $offer = $this->load($deleteCurrentOrganizer->getItemId());

        $offer->deleteCurrentOrganizer();

        $this->offerRepository->save($offer);
    }

    /**
     * Handle an update command to updated the contact point.
     * @param AbstractUpdateContactPoint $updateContactPoint
     */
    public function handleUpdateContactPoint(AbstractUpdateContactPoint $updateContactPoint)
    {
        $offer = $this->load($updateContactPoint->getItemId());

        $offer->updateContactPoint(
            $updateContactPoint->getContactPoint()
        );

        $this->offerRepository->save($offer);

    }

    /**
     * Handle an update command to updated the booking info.
     * @param AbstractUpdateBookingInfo $updateBookingInfo
     */
    public function handleUpdateBookingInfo(AbstractUpdateBookingInfo $updateBookingInfo)
    {
        $offer = $this->load($updateBookingInfo->getItemId());

        $offer->updateBookingInfo(
            $updateBookingInfo->getBookingInfo()
        );

        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractUpdatePriceInfo $updatePriceInfo
     */
    private function handleUpdatePriceInfo(AbstractUpdatePriceInfo $updatePriceInfo)
    {
        $offer = $this->load($updatePriceInfo->getItemId());

        $offer->updatePriceInfo(
            $updatePriceInfo->getPriceInfo()
        );

        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractDeleteOffer $deleteOffer
     */
    private function handleDeleteOffer(AbstractDeleteOffer $deleteOffer)
    {
        $offer = $this->load($deleteOffer->getItemId());
        $offer->delete();
        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractPublish $publish
     */
    private function handlePublish(AbstractPublish $publish)
    {
        $offer = $this->load($publish->getItemId());
        $offer->publish($publish->getPublicationDate());
        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractApprove $approve
     */
    private function handleApprove(AbstractApprove $approve)
    {
        $offer = $this->load($approve->getItemId());
        $offer->approve();
        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractReject $reject
     */
    private function handleReject(AbstractReject $reject)
    {
        $offer = $this->load($reject->getItemId());
        $offer->reject($reject->getReason());
        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractFlagAsDuplicate $flagAsDuplicate
     */
    private function handleFlagAsDuplicate(AbstractFlagAsDuplicate $flagAsDuplicate)
    {
        $offer = $this->load($flagAsDuplicate->getItemId());
        $offer->flagAsDuplicate();
        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractFlagAsInappropriate $flagAsInappropriate
     */
    private function handleFlagAsInappropriate(AbstractFlagAsInappropriate $flagAsInappropriate)
    {
        $offer = $this->load($flagAsInappropriate->getItemId());
        $offer->flagAsInappropriate();
        $this->offerRepository->save($offer);
    }

    /**
     * Makes it easier to type-hint to Offer.
     *
     * @param string $id
     * @return Offer
     */
    private function load($id)
    {
        return $this->offerRepository->load($id);
    }

    /**
     * Makes it easier to type-hint to Organizer.
     *
     * @param string $id
     * @return Organizer
     */
    private function loadOrganizer($id)
    {
        return $this->organizerRepository->load($id);

    }
}


cultuurnet / udb3-php

Push — master ( 5ace45...cd9bd4 )

OfferCommandHandler D

Complexity

Size/Duplication

Coupling/Cohesion

Importance

60 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like