CalendarFactory::createFromCdbCalendar() - Code Metrics - Inspection of "III-2074 Add value object OpeningHour." - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#296)

by Luc

created 2017-04-26 08:43 UTC

CalendarFactory::createFromCdbCalendar() F

↳ Parent: CalendarFactory

Complexity

Conditions	23
Paths	15360

Size

Total Lines	132
Code Lines	70

Duplication

Lines	15
Ratio	11.36 %

Importance

Changes

Metric	Value
dl	15
loc	132
rs	2
c	0
b	0
f	0
cc	23
eloc	70
nc	15360
nop	1

How to fix Long Method Complexity

<?php

namespace CultuurNet\UDB3;

use CultuurNet\UDB3\Calendar\DayOfWeek;
use CultuurNet\UDB3\Calendar\OpeningHour;
use CultuurNet\UDB3\Calendar\OpeningTime;
use CultuurNet\UDB3\Cdb\DateTimeFactory;

class CalendarFactory implements CalendarFactoryInterface
{
    /**
     * @inheritdoc
     */
    public function createFromCdbCalendar(\CultureFeed_Cdb_Data_Calendar $cdbCalendar)
    {
        //
        // Get the calendar type.
        //
        $calendarType = '';
        if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_Permanent) {
            $calendarType = 'permanent';
        } else if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_PeriodList) {
            $calendarType = 'periodic';
        } else if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_TimestampList) {
            $calendarType = 'single';
            if (iterator_count($cdbCalendar) > 1) {
                $calendarType = 'multiple';
            }
        }

        //
        // Get the start day.
        //
        $cdbCalendar->rewind();
        $startDateString = '';
        if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_PeriodList) {
            /** @var \CultureFeed_Cdb_Data_Calendar_Period $period */
            $period = $cdbCalendar->current();
            $startDateString = $period->getDateFrom() . 'T00:00:00';
        } else if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_TimestampList) {

            /** @var \CultureFeed_Cdb_Data_Calendar_Timestamp $timestamp */
            $timestamp = $cdbCalendar->current();
            if ($timestamp->getStartTime()) {
                $startDateString = $timestamp->getDate() . 'T' . $timestamp->getStartTime();
            } else {
                $startDateString = $timestamp->getDate() . 'T00:00:00';
            }
        }
        $startDate = !empty($startDateString) ? DateTimeFactory::dateTimeFromDateString($startDateString) : null;

        //
        // Get the end day.
        //
        $cdbCalendar->rewind();
        $endDateString = '';
        if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_PeriodList) {
            /** @var \CultureFeed_Cdb_Data_Calendar_Period $period */
            $period = $cdbCalendar->current();
            $endDateString = $period->getDateTo() . 'T00:00:00';
        } else if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_TimestampList) {
            $firstTimestamp = $cdbCalendar->current();
            /** @var \CultureFeed_Cdb_Data_Calendar_Timestamp $timestamp */
            $cdbCalendarAsArray = iterator_to_array($cdbCalendar);
            $timestamp = iterator_count($cdbCalendar) > 1 ? end($cdbCalendarAsArray) : $firstTimestamp;
            if ($timestamp->getEndTime()) {

                $endDateString = $timestamp->getDate() . 'T' . $timestamp->getEndTime();
            } else {
                $endTime = $timestamp->getStartTime() ? $timestamp->getStartTime() : '00:00:00';
                $endDateString = $timestamp->getDate() . 'T' . $endTime;
            }
        }
        $endDate = !empty($endDateString) ? DateTimeFactory::dateTimeFromDateString($endDateString) : null;

        //
        // Get the time stamps.
        //
        $cdbCalendar->rewind();
        $timestamps = [];
        if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_TimestampList) {
            while ($cdbCalendar->valid()) {
                /** @var \CultureFeed_Cdb_Data_Calendar_Timestamp $timestamp */
                $timestamp = $cdbCalendar->current();
                $cdbCalendar->next();

                $startTime = $timestamp->getStartTime() ? $timestamp->getStartTime() : '00:00:00';
                $startDateString = $timestamp->getDate() . 'T' . $startTime;

                if ($timestamp->getEndTime()) {
                    $endDateString = $timestamp->getDate() . 'T' . $timestamp->getEndTime();
                } else {
                    $endDateString = $timestamp->getDate() . 'T' . $startTime;
                }

                $timestamps[] = $this->createTimestamp(
                    $startDateString,
                    $endDateString
                );
            }
        }

        //
        // Get the opening hours.
        //
        $cdbCalendar->rewind();
        $openingHours = [];

        $weekSchema = null;
        if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_PeriodList) {
            $period = $cdbCalendar->current();
            $weekSchema = $period->getWeekScheme();
        } else if ($cdbCalendar instanceof  \CultureFeed_Cdb_Data_Calendar_Permanent) {
            $weekSchema = $cdbCalendar->getWeekScheme();
        }

        if ($weekSchema) {
            $openingHours = $this->createOpeningHoursFromWeekScheme($weekSchema);
        }

        // End date might be before start date in cdbxml when event takes place
        // between e.g. 9 PM and 3 AM (the next day). UDB3 does not support this
        // and gracefully ignores the end time.
        //
        // Example cdbxml:
        //
        // <timestamp>
        //   <date>2016-12-16</date>
        //   <timestart>21:00:00</timestart>

        //   <timeend>05:00:00</timeend>

        // </timestamp>
        //
        if ($endDate < $startDate) {
            $endDate = $startDate;
        }

        //
        // Create the calendar value object.
        //
        return new Calendar(
            CalendarType::fromNative($calendarType),
            $startDate,
            $endDate,
            $timestamps,
            $openingHours
        );
    }

    /**
     * @param \CultureFeed_Cdb_Data_Calendar_Weekscheme|null $weekScheme
     * @return Calendar
     */
    public function createFromWeekScheme(
        \CultureFeed_Cdb_Data_Calendar_Weekscheme $weekScheme = null
    ) {
        $openingHours = [];

        if ($weekScheme) {
            $openingHours = $this->createOpeningHoursFromWeekScheme($weekScheme);
        }

        return new Calendar(
            CalendarType::PERMANENT(),
            null,
            null,
            [],
            $openingHours
        );
    }

    /**
     * @param \CultureFeed_Cdb_Data_Calendar_Weekscheme $weekScheme
     * @return OpeningHour[]
     */
    private function createOpeningHoursFromWeekScheme(
        \CultureFeed_Cdb_Data_Calendar_Weekscheme $weekScheme
    ) {
        $openingHours = [];

        foreach ($weekScheme->getDays() as $day) {
            if ($day->isOpen()) {
                /** @var \CultureFeed_Cdb_Data_Calendar_OpeningTime[] $openingTimes */
                $openingTimes = $day->getOpeningTimes();

                // A day could be marked as open but without any hours.
                // This means all day open but needs to be mapped to 00:00:00.
                if (count($openingTimes) === 0) {
                    $openingTimes[] = new \CultureFeed_Cdb_Data_Calendar_OpeningTime(
                        '00:00:00',
                        '00:00:00'
                    );
                }

                foreach ($openingTimes as $openingTime) {
                    $opens = \DateTime::createFromFormat(
                        'H:i:s',
                        $openingTime->getOpenFrom()
                    );
                    $closes = \DateTime::createFromFormat(
                        'H:i:s',
                        $openingTime->getOpenTill()
                    );

                    $openingHour = new OpeningHour(
                        OpeningTime::fromNativeDateTime($opens),
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                        $closes ? OpeningTime::fromNativeDateTime($closes) : OpeningTime::fromNativeDateTime($opens),
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                        DayOfWeek::fromNative($day->getDayName())
                    );

                    $openingHours = $this->addToOpeningHours($openingHour, ...$openingHours);
                }
            }
        }

        return $openingHours;
    }

    /**
     * @param OpeningHour $newOpeningHour
     * @param OpeningHour[] ...$openingHours
     * @return OpeningHour[]
     */
    private function addToOpeningHours(
        OpeningHour $newOpeningHour,
        OpeningHour ...$openingHours
    ) {
        foreach ($openingHours as $openingHour) {
            if ($openingHour->hasEqualHours($newOpeningHour)) {

                $openingHour->addDaysOfWeek(...$newOpeningHour->getDaysOfWeek());

                return $openingHours;
            }
        }

        $openingHours[] = $newOpeningHour;
        return $openingHours;
    }

    /**
     * @param string $startDateString
     * @param string $endDateString
     * @return Timestamp
     */
    private function createTimestamp(
        $startDateString,
        $endDateString
    ) {
        $startDate = DateTimeFactory::dateTimeFromDateString($startDateString);
        $endDate = DateTimeFactory::dateTimeFromDateString($endDateString);

        // End date might be before start date in cdbxml when event takes place
        // between e.g. 9 PM and 3 AM (the next day). UDB3 does not support this
        // and gracefully ignores the end time.
        //
        // Example cdbxml:
        //
        // <timestamp>
        //   <date>2016-12-16</date>
        //   <timestart>21:00:00</timestart>

        //   <timeend>05:00:00</timeend>

        // </timestamp>
        //
        if ($endDate < $startDate) {
            $endDate = $startDate;
        }

        return new Timestamp($startDate, $endDate);
    }
}


1		<?php
2
3		namespace CultuurNet\UDB3;
4
5		use CultuurNet\UDB3\Calendar\DayOfWeek;
6		use CultuurNet\UDB3\Calendar\OpeningHour;
7		use CultuurNet\UDB3\Calendar\OpeningTime;
8		use CultuurNet\UDB3\Cdb\DateTimeFactory;
9
10		class CalendarFactory implements CalendarFactoryInterface
11		{
12		/**
13		* @inheritdoc
14		*/
15		public function createFromCdbCalendar(\CultureFeed_Cdb_Data_Calendar $cdbCalendar)
16		{
17		//
18		// Get the calendar type.
19		//
20		$calendarType = '';
21		if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_Permanent) {
22		$calendarType = 'permanent';
23		} else if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_PeriodList) {
24		$calendarType = 'periodic';
25		} else if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_TimestampList) {
26		$calendarType = 'single';
27		if (iterator_count($cdbCalendar) > 1) {
28		$calendarType = 'multiple';
29		}
30		}
31
32		//
33		// Get the start day.
34		//
35		$cdbCalendar->rewind();
36		$startDateString = '';
37		if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_PeriodList) {
38		/** @var \CultureFeed_Cdb_Data_Calendar_Period $period */
39		$period = $cdbCalendar->current();
40		$startDateString = $period->getDateFrom() . 'T00:00:00';
41	View Code Duplication	} else if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_TimestampList) {
		0 ignored issues – show Duplication introduced 2016-11-28 10:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
42		/** @var \CultureFeed_Cdb_Data_Calendar_Timestamp $timestamp */
43		$timestamp = $cdbCalendar->current();
44		if ($timestamp->getStartTime()) {
45		$startDateString = $timestamp->getDate() . 'T' . $timestamp->getStartTime();
46		} else {
47		$startDateString = $timestamp->getDate() . 'T00:00:00';
48		}
49		}
50		$startDate = !empty($startDateString) ? DateTimeFactory::dateTimeFromDateString($startDateString) : null;
51
52		//
53		// Get the end day.
54		//
55		$cdbCalendar->rewind();
56		$endDateString = '';
57		if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_PeriodList) {
58		/** @var \CultureFeed_Cdb_Data_Calendar_Period $period */
59		$period = $cdbCalendar->current();
60		$endDateString = $period->getDateTo() . 'T00:00:00';
61		} else if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_TimestampList) {
62		$firstTimestamp = $cdbCalendar->current();
63		/** @var \CultureFeed_Cdb_Data_Calendar_Timestamp $timestamp */
64		$cdbCalendarAsArray = iterator_to_array($cdbCalendar);
65		$timestamp = iterator_count($cdbCalendar) > 1 ? end($cdbCalendarAsArray) : $firstTimestamp;
66	View Code Duplication	if ($timestamp->getEndTime()) {
		0 ignored issues – show Duplication introduced 2016-11-24 08:41 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
67		$endDateString = $timestamp->getDate() . 'T' . $timestamp->getEndTime();
68		} else {
69		$endTime = $timestamp->getStartTime() ? $timestamp->getStartTime() : '00:00:00';
70		$endDateString = $timestamp->getDate() . 'T' . $endTime;
71		}
72		}
73		$endDate = !empty($endDateString) ? DateTimeFactory::dateTimeFromDateString($endDateString) : null;
74
75		//
76		// Get the time stamps.
77		//
78		$cdbCalendar->rewind();
79		$timestamps = [];
80		if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_TimestampList) {
81		while ($cdbCalendar->valid()) {
82		/** @var \CultureFeed_Cdb_Data_Calendar_Timestamp $timestamp */
83		$timestamp = $cdbCalendar->current();
84		$cdbCalendar->next();
85
86		$startTime = $timestamp->getStartTime() ? $timestamp->getStartTime() : '00:00:00';
87		$startDateString = $timestamp->getDate() . 'T' . $startTime;
88
89		if ($timestamp->getEndTime()) {
90		$endDateString = $timestamp->getDate() . 'T' . $timestamp->getEndTime();
91		} else {
92		$endDateString = $timestamp->getDate() . 'T' . $startTime;
93		}
94
95		$timestamps[] = $this->createTimestamp(
96		$startDateString,
97		$endDateString
98		);
99		}
100		}
101
102		//
103		// Get the opening hours.
104		//
105		$cdbCalendar->rewind();
106		$openingHours = [];
107
108		$weekSchema = null;
109		if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_PeriodList) {
110		$period = $cdbCalendar->current();
111		$weekSchema = $period->getWeekScheme();
112		} else if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_Permanent) {
113		$weekSchema = $cdbCalendar->getWeekScheme();
114		}
115
116		if ($weekSchema) {
117		$openingHours = $this->createOpeningHoursFromWeekScheme($weekSchema);
118		}
119
120		// End date might be before start date in cdbxml when event takes place
121		// between e.g. 9 PM and 3 AM (the next day). UDB3 does not support this
122		// and gracefully ignores the end time.
123		//
124		// Example cdbxml:
125		//
126		// <timestamp>
127		// <date>2016-12-16</date>
128		// <timestart>21:00:00</timestart>
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-12-15 10:42 UTC by Report Bug Copy Issue Report `39%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
129		// <timeend>05:00:00</timeend>
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-12-15 10:42 UTC by Report Bug Copy Issue Report `39%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
130		// </timestamp>
131		//
132		if ($endDate < $startDate) {
133		$endDate = $startDate;
134		}
135
136		//
137		// Create the calendar value object.
138		//
139		return new Calendar(
140		CalendarType::fromNative($calendarType),
141		$startDate,
142		$endDate,
143		$timestamps,
144		$openingHours
145		);
146		}
147
148		/**
149		* @param \CultureFeed_Cdb_Data_Calendar_Weekscheme\|null $weekScheme
150		* @return Calendar
151		*/
152		public function createFromWeekScheme(
153		\CultureFeed_Cdb_Data_Calendar_Weekscheme $weekScheme = null
154		) {
155		$openingHours = [];
156
157		if ($weekScheme) {
158		$openingHours = $this->createOpeningHoursFromWeekScheme($weekScheme);
159		}
160
161		return new Calendar(
162		CalendarType::PERMANENT(),
163		null,
164		null,
165		[],
166		$openingHours
167		);
168		}
169
170		/**
171		* @param \CultureFeed_Cdb_Data_Calendar_Weekscheme $weekScheme
172		* @return OpeningHour[]
173		*/
174		private function createOpeningHoursFromWeekScheme(
175		\CultureFeed_Cdb_Data_Calendar_Weekscheme $weekScheme
176		) {
177		$openingHours = [];
178
179		foreach ($weekScheme->getDays() as $day) {
180		if ($day->isOpen()) {
181		/** @var \CultureFeed_Cdb_Data_Calendar_OpeningTime[] $openingTimes */
182		$openingTimes = $day->getOpeningTimes();
183
184		// A day could be marked as open but without any hours.
185		// This means all day open but needs to be mapped to 00:00:00.
186		if (count($openingTimes) === 0) {
187		$openingTimes[] = new \CultureFeed_Cdb_Data_Calendar_OpeningTime(
188		'00:00:00',
189		'00:00:00'
190		);
191		}
192
193		foreach ($openingTimes as $openingTime) {
194		$opens = \DateTime::createFromFormat(
195		'H:i:s',
196		$openingTime->getOpenFrom()
197		);
198		$closes = \DateTime::createFromFormat(
199		'H:i:s',
200		$openingTime->getOpenTill()
201		);
202
203		$openingHour = new OpeningHour(
204		OpeningTime::fromNativeDateTime($opens),
		0 ignored issues – show Security Bug introduced 2017-04-26 08:48 UTC by Report Bug Copy Issue Report It seems like `$opens` defined by `\DateTime::createFromFor...ingTime->getOpenFrom())` on line `194` can also be of type `false`; however, `CultuurNet\UDB3\Calendar...e::fromNativeDateTime()` does only seem to accept `object<DateTimeInterface>`, did you maybe forget to handle an error condition? This check looks for type mismatches where the missing type is `false`. This is usually indicative of an error condtion. Consider the follow example <?php function getDate($date) { if ($date !== null) { return new DateTime($date); } return false; } This function either returns a new `DateTime` object or false, if there was an error. This is a typical pattern in PHP programming to show that an error has occurred without raising an exception. The calling code should check for this returned `false` before passing on the value to another function or method that may not be able to handle a `false`. Loading history...
205		$closes ? OpeningTime::fromNativeDateTime($closes) : OpeningTime::fromNativeDateTime($opens),
		0 ignored issues – show Security Bug introduced 2017-04-26 08:48 UTC by Report Bug Copy Issue Report It seems like `$opens` defined by `\DateTime::createFromFor...ingTime->getOpenFrom())` on line `194` can also be of type `false`; however, `CultuurNet\UDB3\Calendar...e::fromNativeDateTime()` does only seem to accept `object<DateTimeInterface>`, did you maybe forget to handle an error condition? This check looks for type mismatches where the missing type is `false`. This is usually indicative of an error condtion. Consider the follow example <?php function getDate($date) { if ($date !== null) { return new DateTime($date); } return false; } This function either returns a new `DateTime` object or false, if there was an error. This is a typical pattern in PHP programming to show that an error has occurred without raising an exception. The calling code should check for this returned `false` before passing on the value to another function or method that may not be able to handle a `false`. Loading history...
206		DayOfWeek::fromNative($day->getDayName())
207		);
208
209		$openingHours = $this->addToOpeningHours($openingHour, ...$openingHours);
210		}
211		}
212		}
213
214		return $openingHours;
215		}
216
217		/**
218		* @param OpeningHour $newOpeningHour
219		* @param OpeningHour[] ...$openingHours
220		* @return OpeningHour[]
221		*/
222		private function addToOpeningHours(
223		OpeningHour $newOpeningHour,
224		OpeningHour ...$openingHours
225		) {
226		foreach ($openingHours as $openingHour) {
227		if ($openingHour->hasEqualHours($newOpeningHour)) {
		0 ignored issues – show Bug introduced 2017-04-26 08:48 UTC by Report Bug Copy Issue Report The method `hasEqualHours` cannot be called on `$openingHour` (of type `array<integer,object<Cul...\Calendar\OpeningHour>>`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
228		$openingHour->addDaysOfWeek(...$newOpeningHour->getDaysOfWeek());
		0 ignored issues – show Bug introduced 2017-04-26 08:48 UTC by Report Bug Copy Issue Report The method `addDaysOfWeek` cannot be called on `$openingHour` (of type `array<integer,object<Cul...\Calendar\OpeningHour>>`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
229		return $openingHours;
230		}
231		}
232
233		$openingHours[] = $newOpeningHour;
234		return $openingHours;
235		}
236
237		/**
238		* @param string $startDateString
239		* @param string $endDateString
240		* @return Timestamp
241		*/
242		private function createTimestamp(
243		$startDateString,
244		$endDateString
245		) {
246		$startDate = DateTimeFactory::dateTimeFromDateString($startDateString);
247		$endDate = DateTimeFactory::dateTimeFromDateString($endDateString);
248
249		// End date might be before start date in cdbxml when event takes place
250		// between e.g. 9 PM and 3 AM (the next day). UDB3 does not support this
251		// and gracefully ignores the end time.
252		//
253		// Example cdbxml:
254		//
255		// <timestamp>
256		// <date>2016-12-16</date>
257		// <timestart>21:00:00</timestart>
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-12-15 10:42 UTC by Report Bug Copy Issue Report `39%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
258		// <timeend>05:00:00</timeend>
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-12-15 10:42 UTC by Report Bug Copy Issue Report `39%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
259		// </timestamp>
260		//
261		if ($endDate < $startDate) {
262		$endDate = $startDate;
263		}
264
265		return new Timestamp($startDate, $endDate);
266		}
267		}
268

cultuurnet / udb3-php

Pull Request — master (#296)

CalendarFactory::createFromCdbCalendar() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like