CultuurNet\UDB3\Calendar\OpeningTime

Complexity

Total Complexity

10

Size/Duplication

Total Lines	105
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	fromNativeDateTime()	0	7	1
A	fromNativeString()	0	6	1
A	toNativeString()	0	4	1
A	getHour()	0	4	1
A	getMinute()	0	4	1
A	sameValueAs()	0	5	2
A	__toString()	0	4	1
A	toNativeDateTime()	0	10	1

<?php

namespace CultuurNet\UDB3\Calendar;

use ValueObjects\DateTime\Hour;
use ValueObjects\DateTime\Minute;

class OpeningTime
{
    /**
     * @var Hour
     */
    private $hour;

    /**
     * @var Minute
     */
    private $minute;

    /**
     * Custom value object for opening times without seconds.
     *
     * @param Hour $hour
     * @param Minute $minute
     */
    public function __construct(Hour $hour, Minute $minute)
    {
        $this->hour = $hour;
        $this->minute = $minute;
    }

    /**
     * @param \DateTimeInterface $dateTime
     * @return OpeningTime
     */
    public static function fromNativeDateTime(\DateTimeInterface $dateTime)
    {
        $hour = new Hour(\intval($dateTime->format('H')));
        $minute = new Minute(\intval($dateTime->format('i')));

        return new OpeningTime($hour, $minute);
    }

    /**
     * The supported string format is H:i
     *
     * @param string $time
     * @return OpeningTime
     */
    public static function fromNativeString($time)
    {
        return self::fromNativeDateTime(
            \DateTime::createFromFormat('H:i', $time)

It seems like \DateTime::createFromFormat('H:i', $time) targeting DateTime::createFromFormat() can also be of type false; however, CultuurNet\UDB3\Calendar\OpeningTime::fromNativeDateTime() does only seem to accept object<DateTimeInterface>, did you maybe forget to handle an error condition?

        );
    }

    /**
     * @return string
     */
    public function toNativeString()
    {
        return (string) $this;
    }

    /**
     * @return Hour
     */
    public function getHour()
    {
        return $this->hour;
    }

    /**
     * @return Minute
     */
    public function getMinute()
    {
        return $this->minute;
    }

    /**
     * @param OpeningTime $time
     * @return bool
     */
    public function sameValueAs(OpeningTime $time)
    {
        return $this->getHour()->sameValueAs($time->getHour()) &&
            $this->getMinute()->sameValueAs($time->getMinute());
    }

    /**
     * @return string
     */
    function __toString()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->toNativeDateTime()->format('H:i');
    }

    /**
     * @return \DateTimeInterface
     */
    private function toNativeDateTime()
    {
        $hour   = $this->getHour()->toNative();
        $minute = $this->getMinute()->toNative();

        $time = new \DateTime('now');
        $time->setTime($hour, $minute);

        return $time;
    }
}