Completed
Pull Request — master (#252)
by Kristof
09:20 queued 04:17
created
src/LocalEntityService.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -78,6 +78,9 @@
 block discarded – undo
78 78
         return $document->getRawBody();
79 79
     }
80 80
 
81
+    /**
82
+     * @param string $id
83
+     */
81 84
     public function iri($id)
82 85
     {
83 86
         return $this->iriGenerator->iri($id);
Please login to merge, or discard this patch.
src/Offer/ReadModel/History/OfferHistoryProjector.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
     }
126 126
 
127 127
     /**
128
-     * @param $dateString
128
+     * @param string $dateString
129 129
      * @return \DateTime
130 130
      */
131 131
     private function dateFromUdb2DateString($dateString)
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
 
352 352
     /**
353 353
      * @param string $eventId
354
-     * @param Log[]|Log $logs
354
+     * @param Log $logs
355 355
      */
356 356
     protected function writeHistory($eventId, $logs)
357 357
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
 
63 63
             if (preg_match('/^apply(.+)$/', $method, $matches)) {
64 64
                 $event = $matches[1];
65
-                $classNameMethod = 'get' . $event . 'ClassName';
65
+                $classNameMethod = 'get'.$event.'ClassName';
66 66
 
67 67
                 if (method_exists($this, $classNameMethod)) {
68 68
                     $eventFullClassName = call_user_func(array($this, $classNameMethod));
Please login to merge, or discard this patch.
src/Offer/Events/AbstractLabelEvent.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
     public function serialize()
33 33
     {
34 34
         return parent::serialize() + array(
35
-            'label' => (string) $this->label,
35
+            'label' => (string)$this->label,
36 36
         );
37 37
     }
38 38
 
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
 
46 46
     /**
47 47
      * @param array $data
48
-     * @return mixed The object instance
48
+     * @return AbstractLabelEvent The object instance
49 49
      */
50 50
     public static function deserialize(array $data)
51 51
     {
Please login to merge, or discard this patch.
src/Offer/Events/AbstractDescriptionTranslated.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
     }
25 25
 
26 26
     /**
27
-     * @return String
27
+     * @return string
28 28
      */
29 29
     public function getDescription()
30 30
     {
Please login to merge, or discard this patch.
src/LabelJSONDeserializer.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
 use CultuurNet\UDB3\Variations\Model\Properties\Description;
10 10
 use CultuurNet\UDB3\Variations\Model\Properties\Id;
11 11
 use JsonSchema\Validator;
12
-use ValueObjects\String\String;
13 12
 use stdClass;
14 13
 
15 14
 class EditDescriptionJSONDeserializer extends JSONDeserializer
Please login to merge, or discard this patch.
src/Offer/ReadModel/JSONLD/OfferUpdate.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
      */
24 24
     public static function calendar(Calendar $calendar)
25 25
     {
26
-        $offerCalenderUpdate = function ($body) use ($calendar) {
26
+        $offerCalenderUpdate = function($body) use ($calendar) {
27 27
             // Purge any existing calendar data
28 28
             unset(
29 29
                 $body->calendarType,
@@ -33,8 +33,8 @@  discard block
 block discarded – undo
33 33
                 $body->openingHours
34 34
             );
35 35
 
36
-            return (object) array_merge(
37
-                (array) $body,
36
+            return (object)array_merge(
37
+                (array)$body,
38 38
                 $calendar->toJsonLd()
39 39
             );
40 40
         };
Please login to merge, or discard this patch.
src/Place/ReadModel/JSONLD/PlaceLDProjector.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
         $jsonLD->address = $placeCreated->getAddress()->toJsonLd();
161 161
 
162 162
         $calendarJsonLD = $placeCreated->getCalendar()->toJsonLd();
163
-        $jsonLD = (object) array_merge((array) $jsonLD, $calendarJsonLD);
163
+        $jsonLD = (object)array_merge((array)$jsonLD, $calendarJsonLD);
164 164
 
165 165
         $eventType = $placeCreated->getEventType();
166 166
         $jsonLD->terms = [
@@ -214,8 +214,8 @@  discard block
 block discarded – undo
214 214
         $jsonLD->address = $majorInfoUpdated->getAddress()->toJsonLd();
215 215
 
216 216
         // Remove old theme and event type.
217
-        $jsonLD->terms = array_filter($jsonLD->terms, function ($term) {
218
-            return $term->domain !== EventType::DOMAIN &&  $term->domain !== Theme::DOMAIN;
217
+        $jsonLD->terms = array_filter($jsonLD->terms, function($term) {
218
+            return $term->domain !== EventType::DOMAIN && $term->domain !== Theme::DOMAIN;
219 219
         });
220 220
 
221 221
         $eventType = $majorInfoUpdated->getEventType();
@@ -361,7 +361,7 @@  discard block
 block discarded – undo
361 361
         // Remove all old facilities + get numeric keys.
362 362
         $terms = array_values(array_filter(
363 363
             $terms,
364
-            function ($term) {
364
+            function($term) {
365 365
                 return $term->domain !== Facility::DOMAIN;
366 366
             }
367 367
         ));
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,6 @@
 block discarded – undo
6 6
 use Broadway\Domain\DomainMessage;
7 7
 use Broadway\EventHandling\EventListenerInterface;
8 8
 use CultuurNet\UDB3\Actor\ActorImportedFromUDB2;
9
-use CultuurNet\UDB3\CalendarFactory;
10 9
 use CultuurNet\UDB3\CalendarFactoryInterface;
11 10
 use CultuurNet\UDB3\Cdb\ActorItemFactory;
12 11
 use CultuurNet\UDB3\Cdb\CdbId\EventCdbIdExtractor;
Please login to merge, or discard this patch.
src/Offer/Events/Image/AbstractImageEvent.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
 
49 49
     /**
50 50
      * @param array $data
51
-     * @return mixed The object instance
51
+     * @return AbstractImageEvent The object instance
52 52
      */
53 53
     public static function deserialize(array $data)
54 54
     {
Please login to merge, or discard this patch.
src/Offer/Events/Image/AbstractImageUpdated.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -79,10 +79,10 @@
 block discarded – undo
79 79
      */
80 80
     public function serialize()
81 81
     {
82
-        return parent::serialize() +  array(
83
-            'media_object_id' => (string) $this->mediaObjectId,
84
-            'description' => (string) $this->description,
85
-            'copyright_holder' => (string) $this->copyrightHolder
82
+        return parent::serialize() + array(
83
+            'media_object_id' => (string)$this->mediaObjectId,
84
+            'description' => (string)$this->description,
85
+            'copyright_holder' => (string)$this->copyrightHolder
86 86
         );
87 87
     }
88 88
 
Please login to merge, or discard this patch.