LabelCollection::merge() - Code Metrics - Inspection of "Restore shared code" - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#469)

unknown

created 2020-06-02 15:13 UTC

LabelCollection::merge() A

↳ Parent: LabelCollection

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.6666
c	0
b	0
f	0
cc	3
nc	3
nop	1

<?php

namespace CultuurNet\UDB3;

use CultureFeed_Cdb_Data_Keyword;

class LabelCollection implements \Countable
{
    /**
     * @var Label[]
     */
    private $labels;

    /**
     * @param Label[] $labels
     */
    public function __construct(array $labels = [])
    {
        array_walk(
            $labels,
            function ($item) {
                if (!$item instanceof Label) {
                    throw new \InvalidArgumentException(
                        'Argument $labels should only contain members of type Label'
                    );
                }
            }
        );

        $this->labels = array_values($labels);

    }

    /**
     * @param Label $label
     * @return LabelCollection
     */
    public function with(Label $label)
    {
        if (!$this->contains($label)) {
            $labels = array_merge($this->labels, [$label]);
        } else {
            $labels = $this->labels;
        }

        return new LabelCollection($labels);
    }

    /**
     * @param Label $label
     * @return LabelCollection
     */
    public function without(Label $label)

    {
        $labels = array_filter(
            $this->labels,
            function (Label $existingLabel) use ($label) {
                return !$existingLabel->equals($label);
            }
        );

        return new LabelCollection($labels);
    }

    /**
     * @inheritdoc
     */
    public function count()
    {
        return count($this->labels);
    }

    /**
     * @param Label $label
     * @return bool
     */
    public function contains(Label $label)

    {
        $equalLabels = array_filter(
            $this->labels,
            function (Label $existingLabel) use ($label) {
                return $label->equals($existingLabel);
            }
        );

        return !empty($equalLabels);
    }

    /**
     * @return Label[]
     */
    public function asArray()
    {
        return $this->labels;
    }

    /**
     * @param LabelCollection $labelCollectionToMerge
     * @return LabelCollection
     */
    public function merge(LabelCollection $labelCollectionToMerge)
    {
        $mergedLabels = [];

        // Keep labels from the original collection that are not in the
        // collection to merge.
        foreach ($this->labels as $label) {
            if (!$labelCollectionToMerge->contains($label)) {
                $mergedLabels[] = $label;
            }
        }

        // Add all labels from the collection to merge.
        $add = $labelCollectionToMerge->asArray();
        $mergedLabels = array_merge($mergedLabels, $add);

        return new LabelCollection($mergedLabels);
    }

    /**
     * @param LabelCollection $labelCollection
     * @return LabelCollection
     */
    public function intersect(LabelCollection $labelCollection)
    {
        $intersectLabels = array_filter(
            $this->labels,
            function ($label) use ($labelCollection) {
                return $labelCollection->contains($label);
            }
        );

        return new LabelCollection($intersectLabels);
    }

    /**
     * @param callable $filterFunction
     * @return LabelCollection
     */
    public function filter(callable $filterFunction)
    {
        return new LabelCollection(
            array_filter($this->labels, $filterFunction)
        );
    }

    /**
     * @param string[] $strings
     * @return LabelCollection
     */
    public static function fromStrings(array $strings)
    {
        $labelCollection = new LabelCollection();

        foreach ($strings as $string) {
            try {
                $label = new Label($string);
                $labelCollection = $labelCollection->with($label);
            } catch (\InvalidArgumentException $exception) {

            }
        }

        return $labelCollection;
    }

    /**
     * @param CultureFeed_Cdb_Data_Keyword[] $keywords
     * @return LabelCollection
     */
    public static function fromKeywords($keywords)
    {
        $labelCollection = new LabelCollection();

        foreach ($keywords as $keyword) {
            try {
                $label = new Label($keyword->getValue(), $keyword->isVisible());
                $labelCollection = $labelCollection->with($label);
            } catch (\InvalidArgumentException $exception) {

            }
        }

        return $labelCollection;
    }

    /**
     * @return string[]
     */
    public function toStrings()
    {
        $labels = array_map(
            function (Label $label) {
                return (string) $label;
            },
            $this->labels
        );

        return $labels;
    }
}


1		<?php
2
3		namespace CultuurNet\UDB3;
4
5		use CultureFeed_Cdb_Data_Keyword;
6
7		class LabelCollection implements \Countable
8		{
9		/**
10		* @var Label[]
11		*/
12		private $labels;
13
14		/**
15		* @param Label[] $labels
16		*/
17		public function __construct(array $labels = [])
18		{
19		array_walk(
20		$labels,
21		function ($item) {
22		if (!$item instanceof Label) {
23		throw new \InvalidArgumentException(
24		'Argument $labels should only contain members of type Label'
25		);
26		}
27		}
28		);
29
30		$this->labels = array_values($labels);
		0 ignored issues – show Documentation Bug introduced 2016-11-02 12:15 UTC by Report Bug Copy Issue Report It seems like `array_values($labels)` of type `array<integer,?>` is incompatible with the declared type `array<integer,object<CultuurNet\UDB3\Label>>` of property `$labels`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
31		}
32
33		/**
34		* @param Label $label
35		* @return LabelCollection
36		*/
37		public function with(Label $label)
38		{
39		if (!$this->contains($label)) {
40		$labels = array_merge($this->labels, [$label]);
41		} else {
42		$labels = $this->labels;
43		}
44
45		return new LabelCollection($labels);
46		}
47
48		/**
49		* @param Label $label
50		* @return LabelCollection
51		*/
52	View Code Duplication	public function without(Label $label)
		0 ignored issues – show Duplication introduced 2017-07-31 14:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		{
54		$labels = array_filter(
55		$this->labels,
56		function (Label $existingLabel) use ($label) {
57		return !$existingLabel->equals($label);
58		}
59		);
60
61		return new LabelCollection($labels);
62		}
63
64		/**
65		* @inheritdoc
66		*/
67		public function count()
68		{
69		return count($this->labels);
70		}
71
72		/**
73		* @param Label $label
74		* @return bool
75		*/
76	View Code Duplication	public function contains(Label $label)
		0 ignored issues – show Duplication introduced 2017-07-31 14:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
77		{
78		$equalLabels = array_filter(
79		$this->labels,
80		function (Label $existingLabel) use ($label) {
81		return $label->equals($existingLabel);
82		}
83		);
84
85		return !empty($equalLabels);
86		}
87
88		/**
89		* @return Label[]
90		*/
91		public function asArray()
92		{
93		return $this->labels;
94		}
95
96		/**
97		* @param LabelCollection $labelCollectionToMerge
98		* @return LabelCollection
99		*/
100		public function merge(LabelCollection $labelCollectionToMerge)
101		{
102		$mergedLabels = [];
103
104		// Keep labels from the original collection that are not in the
105		// collection to merge.
106		foreach ($this->labels as $label) {
107		if (!$labelCollectionToMerge->contains($label)) {
108		$mergedLabels[] = $label;
109		}
110		}
111
112		// Add all labels from the collection to merge.
113		$add = $labelCollectionToMerge->asArray();
114		$mergedLabels = array_merge($mergedLabels, $add);
115
116		return new LabelCollection($mergedLabels);
117		}
118
119		/**
120		* @param LabelCollection $labelCollection
121		* @return LabelCollection
122		*/
123		public function intersect(LabelCollection $labelCollection)
124		{
125		$intersectLabels = array_filter(
126		$this->labels,
127		function ($label) use ($labelCollection) {
128		return $labelCollection->contains($label);
129		}
130		);
131
132		return new LabelCollection($intersectLabels);
133		}
134
135		/**
136		* @param callable $filterFunction
137		* @return LabelCollection
138		*/
139		public function filter(callable $filterFunction)
140		{
141		return new LabelCollection(
142		array_filter($this->labels, $filterFunction)
143		);
144		}
145
146		/**
147		* @param string[] $strings
148		* @return LabelCollection
149		*/
150		public static function fromStrings(array $strings)
151		{
152		$labelCollection = new LabelCollection();
153
154		foreach ($strings as $string) {
155		try {
156		$label = new Label($string);
157		$labelCollection = $labelCollection->with($label);
158		} catch (\InvalidArgumentException $exception) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-10-06 08:20 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
159		}
160		}
161
162		return $labelCollection;
163		}
164
165		/**
166		* @param CultureFeed_Cdb_Data_Keyword[] $keywords
167		* @return LabelCollection
168		*/
169		public static function fromKeywords($keywords)
170		{
171		$labelCollection = new LabelCollection();
172
173		foreach ($keywords as $keyword) {
174		try {
175		$label = new Label($keyword->getValue(), $keyword->isVisible());
176		$labelCollection = $labelCollection->with($label);
177		} catch (\InvalidArgumentException $exception) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-11-23 15:31 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
178		}
179		}
180
181		return $labelCollection;
182		}
183
184		/**
185		* @return string[]
186		*/
187		public function toStrings()
188		{
189		$labels = array_map(
190		function (Label $label) {
191		return (string) $label;
192		},
193		$this->labels
194		);
195
196		return $labels;
197		}
198		}
199

cultuurnet / udb3-php

Pull Request — master (#469)

LabelCollection::merge() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like