Completed
Pull Request — master (#255)
by Luc
06:26
created
src/OpeningHours.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
 
14 14
     /**
15 15
      * OpeningHours constructor.
16
-     * @param OpeningHour[]|null $openingHours
16
+     * @param OpeningHour[] $openingHours
17 17
      */
18 18
     public function __construct(array $openingHours = null)
19 19
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace CultuurNet\UDB3;
4 4
 
5
-use ValueObjects\DateTime\WeekDay;
6
-
7 5
 class OpeningHours
8 6
 {
9 7
     /**
Please login to merge, or discard this patch.
src/Label/ReadModels/Relations/Projector.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 
186 186
         foreach ($labelCollection->asArray() as $label) {
187 187
             $this->writeRepository->save(
188
-                new LabelName((string) $label),
188
+                new LabelName((string)$label),
189 189
                 $relationType,
190 190
                 $relationId
191 191
             );
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
     {
201 201
         $labelRelation = null;
202 202
 
203
-        $labelName = new LabelName((string) $labelEvent->getLabel());
203
+        $labelName = new LabelName((string)$labelEvent->getLabel());
204 204
         $relationType = $this->offerTypeResolver->getRelationType($labelEvent);
205 205
         $relationId = new StringLiteral($labelEvent->getItemId());
206 206
 
Please login to merge, or discard this patch.
src/LabelImporter.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,13 +15,13 @@
 block discarded – undo
15 15
         );
16 16
 
17 17
         $visibleLabels = $labelCollection->filter(
18
-            function (Label $label) {
18
+            function(Label $label) {
19 19
                 return $label->isVisible();
20 20
             }
21 21
         )->toStrings();
22 22
 
23 23
         $hiddenLabels = $labelCollection->filter(
24
-            function (Label $label) {
24
+            function(Label $label) {
25 25
                 return !$label->isVisible();
26 26
             }
27 27
         )->toStrings();
Please login to merge, or discard this patch.
src/Offer/Offer.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
     {
270 270
         $equalImages = array_filter(
271 271
             $this->mediaObjects,
272
-            function ($existingMediaObjectId) use ($image) {
272
+            function($existingMediaObjectId) use ($image) {
273 273
                 return $image
274 274
                     ->getMediaObjectId()
275 275
                     ->sameValueAs($existingMediaObjectId);
@@ -444,7 +444,7 @@  discard block
 block discarded – undo
444 444
             if ($this->rejectedReason && $reason->sameValueAs($this->rejectedReason)) {
445 445
                 return true; // nothing left to do if the offer has already been rejected for the same reason
446 446
             } else {
447
-                throw new Exception('The offer has already been rejected for another reason: ' . $this->rejectedReason);
447
+                throw new Exception('The offer has already been rejected for another reason: '.$this->rejectedReason);
448 448
             }
449 449
         }
450 450
 
@@ -586,7 +586,7 @@  discard block
 block discarded – undo
586 586
         $this->mainImageId = $mainImage ? $mainImage->getMediaObjectId() : null;
587 587
 
588 588
         $this->mediaObjects = array_map(
589
-            function (Image $image) {
589
+            function(Image $image) {
590 590
                 return $image->getMediaObjectId();
591 591
             },
592 592
             $imagesEvent->getImages()->toArray()
Please login to merge, or discard this patch.
src/EventSourcing/DBAL/AggregateAwareDBALEventStore.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@
 block discarded – undo
169 169
     }
170 170
 
171 171
     /**
172
-     * @return mixed
172
+     * @return Table
173 173
      */
174 174
     public function configureTable()
175 175
     {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
         $this->payloadSerializer  = $payloadSerializer;
71 71
         $this->metadataSerializer = $metadataSerializer;
72 72
         $this->tableName          = $tableName;
73
-        $this->aggregateType      = (string) $aggregateType;
73
+        $this->aggregateType      = (string)$aggregateType;
74 74
     }
75 75
 
76 76
     /**
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
         $this->guardStream($eventStream);
106 106
 
107 107
         // Make the transaction more robust by using the transactional statement.
108
-        $this->connection->transactional(function (Connection $connection) use ($eventStream) {
108
+        $this->connection->transactional(function(Connection $connection) use ($eventStream) {
109 109
             try {
110 110
                 foreach ($eventStream as $domainMessage) {
111 111
                     $this->insertMessage($connection, $domainMessage);
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
     private function insertMessage(Connection $connection, DomainMessage $domainMessage)
124 124
     {
125 125
         $data = array(
126
-            'uuid'           => (string) $domainMessage->getId(),
126
+            'uuid'           => (string)$domainMessage->getId(),
127 127
             'playhead'       => $domainMessage->getPlayhead(),
128 128
             'metadata'       => json_encode($this->metadataSerializer->serialize($domainMessage->getMetadata())),
129 129
             'payload'        => json_encode($this->payloadSerializer->serialize($domainMessage->getPayload())),
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
     {
229 229
         foreach ($eventStream as $domainMessage) {
230 230
             /** @var DomainMessage $domainMessage */
231
-            $id = (string) $domainMessage->getId();
231
+            $id = (string)$domainMessage->getId();
232 232
         }
233 233
     }
234 234
 }
Please login to merge, or discard this patch.
src/Media/MediaManager.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -76,11 +76,11 @@  discard block
 block discarded – undo
76 76
     ) {
77 77
         try {
78 78
             $existingMediaObject = $this->repository->load($id);
79
-            $this->logger->info('Trying to create media with id: ' .$id . ' but it already exists. Using existing Media Object!');
79
+            $this->logger->info('Trying to create media with id: '.$id.' but it already exists. Using existing Media Object!');
80 80
 
81 81
             return $existingMediaObject;
82 82
         } catch (AggregateNotFoundException $exception) {
83
-            $this->logger->info('No existing media with id: ' .$id . ' found. Creating a new Media Object!');
83
+            $this->logger->info('No existing media with id: '.$id.' found. Creating a new Media Object!');
84 84
         }
85 85
 
86 86
         $mediaObject = MediaObject::create(
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 
115 115
         $this->filesystem->rename(
116 116
             $uploadImage->getFilePath(),
117
-            $this->mediaDirectory . '/' . $destinationPath
117
+            $this->mediaDirectory.'/'.$destinationPath
118 118
         );
119 119
 
120 120
         $this->create(
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
             Url::fromNative($destinationIri)
126 126
         );
127 127
 
128
-        $jobInfo = ['file_id' => (string) $uploadImage->getFileId()];
128
+        $jobInfo = ['file_id' => (string)$uploadImage->getFileId()];
129 129
         $this->logger->info('job_info', $jobInfo);
130 130
     }
131 131
 
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
     public function get(UUID $fileId)
136 136
     {
137 137
         try {
138
-            $mediaObject = $this->repository->load((string) $fileId);
138
+            $mediaObject = $this->repository->load((string)$fileId);
139 139
         } catch (AggregateNotFoundException $e) {
140 140
             throw new MediaObjectNotFoundException(
141 141
                 sprintf("Media object with id '%s' not found", $fileId),
@@ -159,8 +159,8 @@  discard block
 block discarded – undo
159 159
         $image = new Image(
160 160
             $mediaObject->getMediaObjectId(),
161 161
             $mediaObject->getMimeType(),
162
-            new Description((string) $mediaObject->getDescription()),
163
-            new CopyrightHolder((string) $mediaObject->getCopyrightHolder()),
162
+            new Description((string)$mediaObject->getDescription()),
163
+            new CopyrightHolder((string)$mediaObject->getCopyrightHolder()),
164 164
             $mediaObject->getSourceLocation()
165 165
         );
166 166
 
Please login to merge, or discard this patch.
src/Offer/Events/Image/AbstractImagesEvent.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -36,9 +36,9 @@  discard block
 block discarded – undo
36 36
      */
37 37
     public function serialize()
38 38
     {
39
-        $serializedData =  parent::serialize() + array(
39
+        $serializedData = parent::serialize() + array(
40 40
             'images' => array_map(
41
-                function (Image $image) {
41
+                function(Image $image) {
42 42
                     return $image->serialize();
43 43
                 },
44 44
                 $this->images->toArray()
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
     {
62 62
         $images = ImageCollection::fromArray(
63 63
             array_map(
64
-                function ($imageData) {
64
+                function($imageData) {
65 65
                     return Image::deserialize($imageData);
66 66
                 },
67 67
                 $data['images']
Please login to merge, or discard this patch.
src/Media/Properties/MIMEType.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,11 +30,11 @@
 block discarded – undo
30 30
         $typeSupported = array_key_exists($subtypeString, self::$supportedSubtypes);
31 31
 
32 32
         if (!$typeSupported) {
33
-            throw new UnsupportedMIMETypeException('MIME type "' . $subtypeString . '" is not supported!');
33
+            throw new UnsupportedMIMETypeException('MIME type "'.$subtypeString.'" is not supported!');
34 34
         }
35 35
 
36 36
         $type = self::$supportedSubtypes[$subtypeString];
37 37
 
38
-        return new static($type . '/' . $subtypeString);
38
+        return new static($type.'/'.$subtypeString);
39 39
     }
40 40
 }
Please login to merge, or discard this patch.
src/EventSourcing/DBAL/EventStream.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -174,7 +174,7 @@
 block discarded – undo
174 174
                 ]
175 175
             )
176 176
                 ->from($this->tableName)
177
-                ->where($this->primaryKey . ' > :previousId')
177
+                ->where($this->primaryKey.' > :previousId')
178 178
                 ->orderBy($this->primaryKey, 'ASC')
179 179
                 ->setMaxResults(1);
180 180
 
Please login to merge, or discard this patch.