AddLabelToMultipleJSONDeserializer::__construct() - Code Metrics - Inspection of "III-808 Implemented the manipulates for label and..." - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#135)

by Kristof

created 2016-03-03 20:20 UTC

AddLabelToMultipleJSONDeserializer::__construct() A

↳ Parent: AddLabelToMultipleJSONDeserializer

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

namespace CultuurNet\UDB3\Offer\Commands;

use CultuurNet\Deserializer\DeserializerInterface;
use CultuurNet\Deserializer\JSONDeserializer;
use CultuurNet\Deserializer\MissingValueException;
use CultuurNet\Deserializer\NotWellFormedException;
use CultuurNet\UDB3\Label;
use CultuurNet\UDB3\Offer\OfferIdentifierCollection;
use ValueObjects\String\String;

class AddLabelToMultipleJSONDeserializer extends JSONDeserializer
{
    /**
     * @var DeserializerInterface
     */
    private $offerIdentifierDeserializer;

    /**
     * @param DeserializerInterface $offerIdentifierDeserializer
     */
    public function __construct(DeserializerInterface $offerIdentifierDeserializer)
    {
        $this->offerIdentifierDeserializer = $offerIdentifierDeserializer;
    }

    /**
     * @param \ValueObjects\String\String $data
     *
     * @return AddLabelToMultiple
     *
     * @throws NotWellFormedException
     */
    public function deserialize(String $data)
    {
        $data = parent::deserialize($data);

        if (empty($data->label)) {
            throw new MissingValueException('Missing value "label".');
        }
        if (empty($data->offers)) {
            throw new MissingValueException('Missing value "offers".');
        }

        $label = new Label($data->label);
        $offers = new OfferIdentifierCollection();

        foreach ($data->offers as $offer) {
            $offers = $offers->with(
                $this->offerIdentifierDeserializer->deserialize(
                    new String(
                        json_encode($offer)
                    )
                )
            );
        }

        return new AddLabelToMultiple($offers, $label);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1			<?php
2
3			namespace CultuurNet\UDB3\Offer\Commands;
4
5			use CultuurNet\Deserializer\DeserializerInterface;
6			use CultuurNet\Deserializer\JSONDeserializer;
7			use CultuurNet\Deserializer\MissingValueException;
8			use CultuurNet\Deserializer\NotWellFormedException;
9			use CultuurNet\UDB3\Label;
10			use CultuurNet\UDB3\Offer\OfferIdentifierCollection;
11			use ValueObjects\String\String;
12
13			class AddLabelToMultipleJSONDeserializer extends JSONDeserializer
14			{
15			/**
16			* @var DeserializerInterface
17			*/
18			private $offerIdentifierDeserializer;
19
20			/**
21			* @param DeserializerInterface $offerIdentifierDeserializer
22			*/
23			public function __construct(DeserializerInterface $offerIdentifierDeserializer)
24			{
25			$this->offerIdentifierDeserializer = $offerIdentifierDeserializer;
26			}
27
28			/**
29			* @param \ValueObjects\String\String $data
30			*
31			* @return AddLabelToMultiple
32			*
33			* @throws NotWellFormedException
34			*/
35			public function deserialize(String $data)
36			{
37			$data = parent::deserialize($data);
38
39			if (empty($data->label)) {
40			throw new MissingValueException('Missing value "label".');
41			}
42			if (empty($data->offers)) {
43			throw new MissingValueException('Missing value "offers".');
44			}
45
46			$label = new Label($data->label);
47			$offers = new OfferIdentifierCollection();
48
49			foreach ($data->offers as $offer) {
50			$offers = $offers->with(
51			$this->offerIdentifierDeserializer->deserialize(
52			new String(
53			json_encode($offer)
54			)
55			)
56			);
57			}
58
59			return new AddLabelToMultiple($offers, $label);
			0 ignored issues – show Bug Best Practice introduced 2016-02-24 14:21 UTC by Report Bug Copy Issue Report The return type of `return new \CultuurNet\U...tiple($offers, $label);` (`CultuurNet\UDB3\Offer\Commands\AddLabelToMultiple`) is incompatible with the return type of the parent method `CultuurNet\Deserializer\...serializer::deserialize` of type `stdClass`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
60			}
61			}
62

cultuurnet / udb3-php

Pull Request — master (#135)

AddLabelToMultipleJSONDeserializer::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like