cultuurnet / udb3-php

src/Variations/Command/CreateOfferVariationJSONDeserializer.php

Doc Comments +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
     }
 
     /**
-     * @param mixed $json
+     * @param stdClass $json
      *
      * @throws ValidationException
      */

Unused Use Statements -3 removed lines

@@ -3,15 +3,12 @@
 namespace CultuurNet\UDB3\Variations\Command;
 
 use CultuurNet\Deserializer\JSONDeserializer;
-use CultuurNet\UDB3\Offer\IriOfferIdentifierFactory;
-use CultuurNet\UDB3\Offer\IriOfferIdentifierFactoryInterface;
 use CultuurNet\UDB3\Variations\Model\Properties\Description;
 use CultuurNet\UDB3\Variations\Model\Properties\OwnerId;
 use CultuurNet\UDB3\Variations\Model\Properties\Purpose;
 use CultuurNet\UDB3\Variations\Model\Properties\Url;
 use CultuurNet\UDB3\Variations\Model\Properties\UrlValidator;
 use JsonSchema\Validator;
-use ValueObjects\String\String;
 use stdClass;
 
 class CreateOfferVariationJSONDeserializer extends JSONDeserializer

Spacing +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
     private function getErrorMessages($validationErrors)
     {
         $errorMessages = array_map(
-            function ($error) {
+            function($error) {
                 return $error['message'];
             },
             $validationErrors

src/Variations/DefaultOfferVariationService.php

Spacing +2 added lines, -2 removed lines

@@ -69,7 +69,7 @@ 
     public function editDescription(Id $id, Description $description)
     {
         /** @var EventVariation $variation */
-        $variation = $this->eventVariationRepository->load((string) $id);
+        $variation = $this->eventVariationRepository->load((string)$id);
 
         $variation->editDescription($description);
 
@@ -82,7 +82,7 @@ 
     public function deleteEventVariation(Id $id)
     {
         /** @var EventVariation $variation */
-        $variation = $this->eventVariationRepository->load((string) $id);
+        $variation = $this->eventVariationRepository->load((string)$id);
 
         $variation->markDeleted();
 

src/Variations/Model/OfferVariation.php

Spacing +2 added lines, -2 removed lines

@@ -122,7 +122,7 @@ 
     private function guardNotDeleted()
     {
         if ($this->isDeleted()) {
-            throw new AggregateDeletedException((string) $this->id);
+            throw new AggregateDeletedException((string)$this->id);
         }
     }
 
@@ -148,7 +148,7 @@ 
      */
     public function getAggregateRootId()
     {
-        return (string) $this->id;
+        return (string)$this->id;
     }
 
     /**

src/Variations/Model/Events/OfferVariationEvent.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
     public function serialize()
     {
         return array(
-            'id' => (string) $this->getId(),
+            'id' => (string)$this->getId(),
         );
     }
 

src/Variations/Model/Events/OfferVariationCreated.php

Spacing +4 added lines, -4 removed lines

@@ -94,10 +94,10 @@
     public function serialize()
     {
         return parent::serialize() + array(
-            'origin_url' => (string) $this->getOriginUrl(),
-            'owner_id' => (string) $this->getOwnerId(),
-            'purpose' => (string) $this->getPurpose(),
-            'description' => (string) $this->getDescription(),
+            'origin_url' => (string)$this->getOriginUrl(),
+            'owner_id' => (string)$this->getOwnerId(),
+            'purpose' => (string)$this->getPurpose(),
+            'description' => (string)$this->getDescription(),
         );
     }
 

src/Variations/ReadModel/Search/Doctrine/DBALRepository.php

Spacing +4 added lines, -4 removed lines

@@ -49,11 +49,11 @@
         $this->connection->insert(
             $this->connection->quoteIdentifier($this->tableName),
             [
-                'id' => (string) $variationId,
-                'owner' => (string) $ownerId,
-                'purpose' => (string) $purpose,
+                'id' => (string)$variationId,
+                'owner' => (string)$ownerId,
+                'purpose' => (string)$purpose,
                 'inserted' => time(),
-                'origin_url' => (string) $eventUrl,
+                'origin_url' => (string)$eventUrl,
             ]
         );
 

src/ReadModel/Index/Doctrine/DBALRepository.php

Spacing +1 added lines, -1 removed lines

@@ -252,7 +252,7 @@
 
         $results = $q->execute();
         $offerIdentifierArray = array_map(
-            function ($resultRow) {
+            function($resultRow) {
                 $offerIdentifier = new IriOfferIdentifier(
                     $resultRow['entity_id'],
                     OfferType::fromNative(ucfirst($resultRow['entity_type']))

Doc Comments +8 added lines, -1 removed lines

@@ -186,7 +186,7 @@ 
     }
 
     /**
-     * @param $id
+     * @param string $id
      * @param EntityType $entityType
      * @return bool
      */
@@ -316,6 +316,9 @@ 
         );
     }
 
+    /**
+     * @param string $userId
+     */
     private function getPagedDashboardItems(
         $userId,
         Natural $limit,
@@ -340,6 +343,10 @@ 
 
         $results = $queryBuilder->execute();
         $offerIdentifierArray = array_map(
+
+            /**
+             * @param string $resultRow
+             */
             function ($resultRow) {
                 $offerIdentifier = new IriOfferIdentifier(
                     $resultRow['entity_iri'],

src/ReadModel/Index/Projector.php

Spacing +2 added lines, -2 removed lines

@@ -136,7 +136,7 @@ 
             );
         }
 
-        return isset($userId) ? (string) $userId : '';
+        return isset($userId) ? (string)$userId : '';
     }
 
     /**
@@ -224,7 +224,7 @@ 
         $this->updateIndex(
             $itemId,
             $itemType,
-            (string) $userId,
+            (string)$userId,
             $name,
             $postalCode,
             $this->UDB2Domain,

Doc Comments +1 added lines, -1 removed lines

@@ -421,7 +421,7 @@
     }
 
     /**
-     * @param $dateString
+     * @param string $dateString
      *  A UDB2 formatted date string
      *
      * @return DateTimeInterface

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 use CultuurNet\UDB3\EventHandling\DelegateEventHandlingToSpecificMethodTrait;
 use CultuurNet\UDB3\Offer\Events\AbstractEventWithIri;
 use CultuurNet\UDB3\Offer\IriOfferIdentifierFactoryInterface;
-use CultuurNet\UDB3\Organizer\Events\OrganizerDeleted;
 use CultuurNet\UDB3\Place\Events\PlaceCreated;
 use CultuurNet\UDB3\Place\Events\PlaceDeleted;
 use CultuurNet\UDB3\Place\Events\PlaceImportedFromUDB2;

src/ReadModel/Index/EntityIriGeneratorFactory.php

Spacing +2 added lines, -2 removed lines

@@ -23,8 +23,8 @@
     {
         $baseUrl = $this->baseUrl;
         return new CallableIriGenerator(
-            function ($cdbid) use ($baseUrl, $entityType) {
-                return $baseUrl . '/' . $entityType . '/' . $cdbid;
+            function($cdbid) use ($baseUrl, $entityType) {
+                return $baseUrl.'/'.$entityType.'/'.$cdbid;
             }
         );
     }