cultuurnet / udb3-php

src/Role/Commands/RenameRole.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace CultuurNet\UDB3\Role\Commands;
 
 use ValueObjects\Identity\UUID;
-use ValueObjects\String\String as stringLiteral;
 
 class RenameRole extends AbstractCommand
 {

Doc Comments +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
     }
 
     /**
-     * @return StringLiteral
+     * @return stringLiteral
      */
     public function getName()
     {

src/SearchAPI2/ResultSetPullParser.php

Spacing +3 added lines, -3 removed lines

@@ -79,7 +79,7 @@ 
         $items = new OfferIdentifierCollection();
         $totalItems = $cdbId = $elementName = $offerType = $resultXmlString = null;
 
-        $resetCurrentResultValues = function () use (&$cdbId, &$elementName, &$offerType, &$resultXmlString) {
+        $resetCurrentResultValues = function() use (&$cdbId, &$elementName, &$offerType, &$resultXmlString) {
             $cdbId = null;
             $elementName = self::CDBXML_TYPE_UNKNOWN;
             $offerType = self::OFFER_TYPE_UNKNOWN;
@@ -93,13 +93,13 @@ 
 
         while ($r->read()) {
             if ($this->xmlNodeIsNumberOfRecordsTag($r)) {
-                $totalItems = new Integer((int) $r->readString());
+                $totalItems = new Integer((int)$r->readString());
             }
 
             if ($this->xmlNodeIsResultOpeningTag($r)) {
                 $resultXmlString = $r->readOuterXml();
                 $cdbId = $r->getAttribute('cdbid');
-                $elementName = 'cdbxml.' . $r->localName;
+                $elementName = 'cdbxml.'.$r->localName;
 
                 if ($elementName == self::CDBXML_TYPE_EVENT) {
                     $offerType = self::OFFER_TYPE_EVENT;

src/Role/Events/AbstractConstraintEvent.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace CultuurNet\UDB3\Role\Commands;
 
 use ValueObjects\Identity\UUID;
-use ValueObjects\String\String as stringLiteral;
 
 class RenameRole extends AbstractCommand
 {

Doc Comments +2 added lines, -2 removed lines

@@ -15,7 +15,7 @@ 
     /**
      * AbstractPermissionEvent constructor.
      * @param UUID $uuid
-     * @param StringLiteral $query
+     * @param stringLiteral $query
      */
     public function __construct(UUID $uuid, StringLiteral $query)
     {
@@ -24,7 +24,7 @@ 
     }
 
     /**
-     * @return StringLiteral
+     * @return string|null
      */
     public function getQuery()
     {

src/Role/Role.php

Doc Comments +1 added lines, -1 removed lines

@@ -116,7 +116,7 @@
     }
 
     /**
-     * @return string
+     * @return UUID
      */
     public function getFileId()
     {

src/Label/ReadModels/JSON/Projector.php

Spacing +1 added lines, -1 removed lines

@@ -142,7 +142,7 @@
     {
         $uuid = null;
 
-        $name = new StringLiteral((string) $labelEvent->getLabel());
+        $name = new StringLiteral((string)$labelEvent->getLabel());
 
         $entity = $this->readRepository->getByName($name);
         if ($entity !== null) {

src/EventExport/Format/TabularData/TabularDataEventFormatter.php

Doc Comments +4 added lines, -1 removed lines

@@ -124,6 +124,9 @@ 
         return $expandedProperties;
     }
 
+    /**
+     * @param string[] $include
+     */
     protected function includedOrDefaultProperties($include)
     {
         if ($include) {
@@ -462,7 +465,7 @@ 
     }
 
     /**
-     * @param object $event
+     * @param \stdClass $event
      * @param string|null $type
      * @return object
      */

Spacing +40 added lines, -40 removed lines

@@ -173,14 +173,14 @@ 
     protected function columns()
     {
         $formatter = $this;
-        $contactPoint = function (\stdClass $event) use ($formatter) {
+        $contactPoint = function(\stdClass $event) use ($formatter) {
             return $formatter->contactPoint($event);
         };
 
         return [
             'id' => [
                 'name' => 'id',
-                'include' => function ($event) {
+                'include' => function($event) {
                     $eventUri = $event->{'@id'};
                     $uriParts = explode('/', $eventUri);
                     $eventId = array_pop($uriParts);
@@ -191,7 +191,7 @@ 
             ],
             'name' => [
                 'name' => 'titel',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if ($event->name) {
                         return reset($event->name);
                     }
@@ -200,14 +200,14 @@ 
             ],
             'creator' => [
                 'name' => 'auteur',
-                'include' => function ($event) {
+                'include' => function($event) {
                     return $event->creator;
                 },
                 'property' => 'creator'
             ],
             'bookingInfo.price' => [
                 'name' => 'prijs',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (property_exists($event, 'bookingInfo') && is_array($event->bookingInfo)) {
                         $first = reset($event->bookingInfo);
                         if (is_object($first) && property_exists($first, 'price')) {
@@ -219,7 +219,7 @@ 
             ],
             'kansentarief' => [
                 'name' => 'kansentarief',
-                'include' => function ($event) {
+                'include' => function($event) {
                     $eventUri = $event->{'@id'};
                     $uriParts = explode('/', $eventUri);
                     $eventId = array_pop($uriParts);
@@ -228,18 +228,18 @@ 
                     if ($uitpasInfo) {
                         $uitpasInfo = $this->uitpasInfoFormatter->format($uitpasInfo);
 
-                        $cardSystems = array_reduce($uitpasInfo['prices'], function ($cardSystems, $tariff) {
+                        $cardSystems = array_reduce($uitpasInfo['prices'], function($cardSystems, $tariff) {
                             $cardSystem = isset($cardSystems[$tariff['cardSystem']]) ? $cardSystems[$tariff['cardSystem']] : '';
                             $cardSystem = empty($cardSystem)
-                                ? $tariff['cardSystem'] .': € ' . $tariff['price']
-                                : $cardSystem . ' / € ' . $tariff['price'];
+                                ? $tariff['cardSystem'].': € '.$tariff['price']
+                                : $cardSystem.' / € '.$tariff['price'];
 
                             $cardSystems[$tariff['cardSystem']] = $cardSystem;
                             return $cardSystems;
                         }, []);
 
-                        $formattedTariffs = array_reduce($cardSystems, function ($tariffs, $cardSystemPrices) {
-                            return $tariffs ? $tariffs . ' | ' . $cardSystemPrices : $cardSystemPrices;
+                        $formattedTariffs = array_reduce($cardSystems, function($tariffs, $cardSystemPrices) {
+                            return $tariffs ? $tariffs.' | '.$cardSystemPrices : $cardSystemPrices;
                         });
 
                         if (!empty($formattedTariffs)) {
@@ -251,7 +251,7 @@ 
             ],
             'bookingInfo.url' => [
                 'name' => 'ticket link',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (property_exists($event, 'bookingInfo')) {
                         $first = reset($event->bookingInfo);
                         if (is_object($first) && property_exists($first, 'url')) {
@@ -263,7 +263,7 @@ 
             ],
             'description' => [
                 'name' => 'omschrijving',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (property_exists($event, 'description')) {
                         $description = reset($event->description);
 
@@ -283,7 +283,7 @@ 
             ],
             'organizer' => [
                 'name' => 'organisatie',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (property_exists($event, 'organizer') &&
                         isset($event->organizer->name)
                     ) {
@@ -294,14 +294,14 @@ 
             ],
             'calendarSummary' => [
                 'name' => 'tijdsinformatie',
-                'include' => function ($event) {
+                'include' => function($event) {
                     return $event->calendarSummary;
                 },
                 'property' => 'calendarSummary'
             ],
             'labels' => [
                 'name' => 'labels',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (isset($event->labels)) {
                         return implode(';', $event->labels);
                     }
@@ -310,14 +310,14 @@ 
             ],
             'typicalAgeRange' => [
                 'name' => 'leeftijd',
-                'include' => function ($event) {
+                'include' => function($event) {
                     return $event->typicalAgeRange;
                 },
                 'property' => 'typicalAgeRange'
             ],
             'performer' => [
                 'name' => 'uitvoerders',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (property_exists($event, 'performer')) {
                         $performerNames = [];
                         foreach ($event->performer as $performer) {
@@ -331,7 +331,7 @@ 
             ],
             'language' => [
                 'name' => 'taal van het aanbod',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (property_exists($event, 'language')) {
                         return implode(';', $event->language);
                     }
@@ -340,7 +340,7 @@ 
             ],
             'terms.theme' => [
                 'name' => 'thema',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (property_exists($event, 'terms')) {
                         foreach ($event->terms as $term) {
                             if ($term->domain && $term->label && $term->domain == 'theme') {
@@ -353,7 +353,7 @@ 
             ],
             'terms.eventtype' => [
                 'name' => 'soort aanbod',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (property_exists($event, 'terms')) {
                         foreach ($event->terms as $term) {
                             if ($term->domain && $term->label && $term->domain == 'eventtype') {
@@ -366,7 +366,7 @@ 
             ],
             'created' => [
                 'name' => 'datum aangemaakt',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (!empty($event->created)) {
                         return $this->formatDate($event->created);
                     } else {
@@ -377,7 +377,7 @@ 
             ],
             'modified' => [
                 'name' => 'datum laatste aanpassing',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (!empty($event->modified)) {
                         return $this->formatDate($event->modified);
                     } else {
@@ -388,7 +388,7 @@ 
             ],
             'available' => [
                 'name' => 'embargodatum',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (!empty($event->available)) {
                         return $this->formatDateWithoutTime($event->available);
                     } else {
@@ -399,7 +399,7 @@ 
             ],
             'startDate' => [
                 'name' => 'startdatum',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (!empty($event->startDate)) {
                         return $this->formatDate($event->startDate);
                     } else {
@@ -410,7 +410,7 @@ 
             ],
             'endDate' => [
                 'name' => 'einddatum',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (!empty($event->endDate)) {
                         return $this->formatDate($event->endDate);
                     } else {
@@ -421,14 +421,14 @@ 
             ],
             'calendarType' => [
                 'name' => 'tijd type',
-                'include' => function ($event) {
+                'include' => function($event) {
                     return $event->calendarType;
                 },
                 'property' => 'calendarType'
             ],
             'location' => [
                 'name' => 'locatie naam',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (property_exists($event, 'location') && isset($event->location->name)) {
                         return reset($event->location->name);
                     }
@@ -437,7 +437,7 @@ 
             ],
             'address.streetAddress' => [
                 'name' => 'straat',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (isset($event->location->address->streetAddress)) {
                         return $event->location->address->streetAddress;
                     }
@@ -446,7 +446,7 @@ 
             ],
             'address.postalCode' => [
                 'name' => 'postcode',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (isset($event->location->address->postalCode)) {
                         return $event->location->address->postalCode;
                     }
@@ -455,7 +455,7 @@ 
             ],
             'address.addressLocality' => [
                 'name' => 'gemeente',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (isset($event->location->address->addressLocality)) {
                         return $event->location->address->addressLocality;
                     }
@@ -464,7 +464,7 @@ 
             ],
             'address.addressCountry' => [
                 'name' => 'land',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (isset($event->location->address->addressCountry)) {
                         return $event->location->address->addressCountry;
                     }
@@ -473,14 +473,14 @@ 
             ],
             'image' => [
                 'name' => 'afbeelding',
-                'include' => function ($event) {
+                'include' => function($event) {
                     return !empty($event->image) ? $event->image : '';
                 },
                 'property' => 'image'
             ],
             'sameAs' => [
                 'name' => 'externe ids',
-                'include' => function ($event) {
+                'include' => function($event) {
                     if (property_exists($event, 'sameAs')) {
                         $ids = array();
 
@@ -495,7 +495,7 @@ 
             ],
             'contactPoint.email' => [
                 'name' => 'e-mail',
-                'include' => function ($event) use ($contactPoint) {
+                'include' => function($event) use ($contactPoint) {
                     return $this->listJsonldProperty(
                         $contactPoint($event),
                         'email'
@@ -505,7 +505,7 @@ 
             ],
             'contactPoint.telephone' => [
                 'name' => 'telefoon',
-                'include' => function ($event) use ($contactPoint) {
+                'include' => function($event) use ($contactPoint) {
                     return $this->listJsonldProperty(
                         $contactPoint($event),
                         'telephone'
@@ -515,7 +515,7 @@ 
             ],
             'contactPoint.url' => [
                 'name' => 'url',
-                'include' => function ($event) use ($contactPoint) {
+                'include' => function($event) use ($contactPoint) {
                     $contactUrls = $this->listJsonldProperty(
                         $contactPoint($event),
                         'url'
@@ -526,7 +526,7 @@ 
             ],
             'contactPoint.reservations.email' => [
                 'name' => 'e-mail reservaties',
-                'include' => function ($event) use ($contactPoint) {
+                'include' => function($event) use ($contactPoint) {
                     return $this->listJsonldProperty(
                         $contactPoint($event, 'Reservations'),
                         'email'
@@ -536,7 +536,7 @@ 
             ],
             'contactPoint.reservations.telephone' => [
                 'name' => 'telefoon reservaties',
-                'include' => function ($event) use ($contactPoint) {
+                'include' => function($event) use ($contactPoint) {
                     return $this->listJsonldProperty(
                         $contactPoint($event, 'Reservations'),
                         'telephone'
@@ -546,7 +546,7 @@ 
             ],
             'contactPoint.reservations.url' => [
                 'name' => 'online reservaties',
-                'include' => function ($event) use ($contactPoint) {
+                'include' => function($event) use ($contactPoint) {
                     return $this->listJsonldProperty(
                         $contactPoint($event, 'Reservations'),
                         'url'

src/Role/ReadModel/Search/Doctrine/DBALRepository.php

Spacing +2 added lines, -2 removed lines

@@ -81,7 +81,7 @@ 
 
         if (!empty($query)) {
             $q->where($expr->like('name', ':role_name'));
-            $q->setParameter('role_name', '%' . $query . '%');
+            $q->setParameter('role_name', '%'.$query.'%');
         }
 
         $results = $q->execute()->fetchAll(\PDO::FETCH_ASSOC);
@@ -96,7 +96,7 @@ 
 
         if (!empty($query)) {
             $q->where($expr->like('name', ':role_name'));
-            $q->setParameter('role_name', '%' . $query . '%');
+            $q->setParameter('role_name', '%'.$query.'%');
         }
 
         $total = $q->execute()->fetchColumn();

src/Address/DefaultAddressFormatter.php

Spacing +3 added lines, -3 removed lines

@@ -12,9 +12,9 @@
      */
     public function format(Address $address)
     {
-        return $address->getStreetAddress() . ', ' .
-            $address->getPostalCode() . ' ' .
-            $address->getLocality() . ', ' .
+        return $address->getStreetAddress().', '.
+            $address->getPostalCode().' '.
+            $address->getLocality().', '.
             $address->getCountry();
     }
 }

src/StringFilter/NewlineToSpaceStringFilter.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
     public function filter($string)
     {
         if (!is_string($string)) {
-            throw new \InvalidArgumentException('Argument should be string, got ' . gettype($string) . ' instead.');
+            throw new \InvalidArgumentException('Argument should be string, got '.gettype($string).' instead.');
         }
 
         return preg_replace("/(\\n)+/", " ", $string);