| Conditions | 10 | 
| Paths | 8 | 
| Total Lines | 324 | 
| Code Lines | 171 | 
| Lines | 0 | 
| Ratio | 0 % | 
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php  | 
            ||
| 55 | public static function createSerializer(ReadRepositoryInterface $labelRepository)  | 
            ||
| 56 |     { | 
            ||
| 57 | $payloadManipulatingSerializer = new PayloadManipulatingSerializer(  | 
            ||
| 58 | new SimpleInterfaceSerializer()  | 
            ||
| 59 | );  | 
            ||
| 60 | |||
| 61 | /*  | 
            ||
| 62 | * CREATE EVENTS  | 
            ||
| 63 | *  | 
            ||
| 64 | */  | 
            ||
| 65 | |||
| 66 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 67 | 'CultuurNet\UDB3\Event\Events\EventCreated',  | 
            ||
| 68 |             function (array $serializedObject) { | 
            ||
| 69 | return self::addDefaultMainLanguage($serializedObject);  | 
            ||
| 70 | }  | 
            ||
| 71 | );  | 
            ||
| 72 | |||
| 73 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 74 | 'CultuurNet\UDB3\Place\Events\PlaceCreated',  | 
            ||
| 75 |             function (array $serializedObject) { | 
            ||
| 76 | return self::addDefaultMainLanguage($serializedObject);  | 
            ||
| 77 | }  | 
            ||
| 78 | );  | 
            ||
| 79 | |||
| 80 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 81 | 'CultuurNet\UDB3\Organizer\Events\OrganizerCreatedWithUniqueWebsite',  | 
            ||
| 82 |             function (array $serializedObject) { | 
            ||
| 83 | return self::addDefaultMainLanguage($serializedObject);  | 
            ||
| 84 | }  | 
            ||
| 85 | );  | 
            ||
| 86 | |||
| 87 | /*  | 
            ||
| 88 | * TRANSLATION EVENTS  | 
            ||
| 89 | */  | 
            ||
| 90 | |||
| 91 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 92 | 'CultuurNet\UDB3\Event\TitleTranslated',  | 
            ||
| 93 |             function (array $serializedObject) { | 
            ||
| 94 | $serializedObject['class'] = TitleTranslated::class;  | 
            ||
| 95 | |||
| 96 | $serializedObject = self::replaceEventIdWithItemId($serializedObject);  | 
            ||
| 97 | |||
| 98 | return $serializedObject;  | 
            ||
| 99 | }  | 
            ||
| 100 | );  | 
            ||
| 101 | |||
| 102 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 103 | 'CultuurNet\UDB3\Event\DescriptionTranslated',  | 
            ||
| 104 |             function (array $serializedObject) { | 
            ||
| 105 | $serializedObject['class'] = DescriptionTranslated::class;  | 
            ||
| 106 | |||
| 107 | $serializedObject = self::replaceEventIdWithItemId($serializedObject);  | 
            ||
| 108 | |||
| 109 | return $serializedObject;  | 
            ||
| 110 | }  | 
            ||
| 111 | );  | 
            ||
| 112 | |||
| 113 | /*  | 
            ||
| 114 | * LABEL EVENTS  | 
            ||
| 115 | */  | 
            ||
| 116 | |||
| 117 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 118 | 'CultuurNet\UDB3\Label\Events\MadeInvisible',  | 
            ||
| 119 |             function (array $serializedObject) use ($labelRepository) { | 
            ||
| 120 | return self::addLabelName($serializedObject, $labelRepository);  | 
            ||
| 121 | }  | 
            ||
| 122 | );  | 
            ||
| 123 | |||
| 124 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 125 | 'CultuurNet\UDB3\Label\Events\MadeVisible',  | 
            ||
| 126 |             function (array $serializedObject) use ($labelRepository) { | 
            ||
| 127 | return self::addLabelName($serializedObject, $labelRepository);  | 
            ||
| 128 | }  | 
            ||
| 129 | );  | 
            ||
| 130 | |||
| 131 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 132 | 'CultuurNet\UDB3\Label\Events\MadePrivate',  | 
            ||
| 133 |             function (array $serializedObject) use ($labelRepository) { | 
            ||
| 134 | return self::addLabelName($serializedObject, $labelRepository);  | 
            ||
| 135 | }  | 
            ||
| 136 | );  | 
            ||
| 137 | |||
| 138 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 139 | 'CultuurNet\UDB3\Label\Events\MadePublic',  | 
            ||
| 140 |             function (array $serializedObject) use ($labelRepository) { | 
            ||
| 141 | return self::addLabelName($serializedObject, $labelRepository);  | 
            ||
| 142 | }  | 
            ||
| 143 | );  | 
            ||
| 144 | |||
| 145 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 146 | 'CultuurNet\UDB3\Organizer\Events\LabelAdded',  | 
            ||
| 147 |             function (array $serializedObject) use ($labelRepository) { | 
            ||
| 148 | return self::fixOrganizerLabelEvent($serializedObject, $labelRepository);  | 
            ||
| 149 | }  | 
            ||
| 150 | );  | 
            ||
| 151 | |||
| 152 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 153 | 'CultuurNet\UDB3\Organizer\Events\LabelRemoved',  | 
            ||
| 154 |             function (array $serializedObject) use ($labelRepository) { | 
            ||
| 155 | return self::fixOrganizerLabelEvent($serializedObject, $labelRepository);  | 
            ||
| 156 | }  | 
            ||
| 157 | );  | 
            ||
| 158 | |||
| 159 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 160 | 'CultuurNet\UDB3\Event\Events\EventWasLabelled',  | 
            ||
| 161 |             function (array $serializedObject) { | 
            ||
| 162 | $serializedObject['class'] = LabelAdded::class;  | 
            ||
| 163 | |||
| 164 | $serializedObject = self::replaceEventIdWithItemId($serializedObject);  | 
            ||
| 165 | |||
| 166 | return $serializedObject;  | 
            ||
| 167 | }  | 
            ||
| 168 | );  | 
            ||
| 169 | |||
| 170 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 171 | 'CultuurNet\UDB3\Event\EventWasTagged',  | 
            ||
| 172 |             function (array $serializedObject) { | 
            ||
| 173 | $serializedObject['class'] = LabelAdded::class;  | 
            ||
| 174 | |||
| 175 | $serializedObject = self::replaceEventIdWithItemId($serializedObject);  | 
            ||
| 176 | |||
| 177 | $serializedObject = self::replaceKeywordWithLabel($serializedObject);  | 
            ||
| 178 | |||
| 179 | return $serializedObject;  | 
            ||
| 180 | }  | 
            ||
| 181 | );  | 
            ||
| 182 | |||
| 183 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 184 | 'CultuurNet\UDB3\Event\TagErased',  | 
            ||
| 185 |             function (array $serializedObject) { | 
            ||
| 186 | $serializedObject['class'] = LabelRemoved::class;  | 
            ||
| 187 | |||
| 188 | $serializedObject = self::replaceEventIdWithItemId($serializedObject);  | 
            ||
| 189 | |||
| 190 | $serializedObject = self::replaceKeywordWithLabel($serializedObject);  | 
            ||
| 191 | |||
| 192 | return $serializedObject;  | 
            ||
| 193 | }  | 
            ||
| 194 | );  | 
            ||
| 195 | |||
| 196 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 197 | 'CultuurNet\UDB3\Event\Events\Unlabelled',  | 
            ||
| 198 |             function (array $serializedObject) { | 
            ||
| 199 | $serializedObject['class'] = LabelRemoved::class;  | 
            ||
| 200 | |||
| 201 | $serializedObject = self::replaceEventIdWithItemId($serializedObject);  | 
            ||
| 202 | |||
| 203 | return $serializedObject;  | 
            ||
| 204 | }  | 
            ||
| 205 | );  | 
            ||
| 206 | |||
| 207 | /**  | 
            ||
| 208 | * UBD2 IMPORT  | 
            ||
| 209 | */  | 
            ||
| 210 | |||
| 211 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 212 | 'CultuurNet\UDB3\Event\EventImportedFromUDB2',  | 
            ||
| 213 |             function (array $serializedObject) { | 
            ||
| 214 | $serializedObject['class'] = EventImportedFromUDB2::class;  | 
            ||
| 215 | |||
| 216 | return $serializedObject;  | 
            ||
| 217 | }  | 
            ||
| 218 | );  | 
            ||
| 219 | |||
| 220 | /**  | 
            ||
| 221 | * PLACE FACILITIES EVENT  | 
            ||
| 222 | */  | 
            ||
| 223 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 224 | 'CultuurNet\UDB3\Place\Events\FacilitiesUpdated',  | 
            ||
| 225 |             function (array $serializedObject) { | 
            ||
| 226 | $serializedObject = self::replacePlaceIdWithItemId($serializedObject);  | 
            ||
| 227 | |||
| 228 | return $serializedObject;  | 
            ||
| 229 | }  | 
            ||
| 230 | );  | 
            ||
| 231 | |||
| 232 | /**  | 
            ||
| 233 | * GEOCOORDINATES UPDATED EVENT  | 
            ||
| 234 | */  | 
            ||
| 235 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 236 | 'CultuurNet\UDB3\Place\Events\GeoCoordinatesUpdated',  | 
            ||
| 237 |             function (array $serializedObject) { | 
            ||
| 238 | $serializedObject = self::replacePlaceIdWithItemId($serializedObject);  | 
            ||
| 239 | |||
| 240 | return $serializedObject;  | 
            ||
| 241 | }  | 
            ||
| 242 | );  | 
            ||
| 243 | |||
| 244 | /**  | 
            ||
| 245 | * BOOKING INFO EVENT  | 
            ||
| 246 | */  | 
            ||
| 247 |         $manipulateAvailability = function (array $serializedBookingInfo, $propertyName) { | 
            ||
| 248 |             if (!isset($serializedBookingInfo[$propertyName]) || empty($serializedBookingInfo[$propertyName])) { | 
            ||
| 249 | $serializedBookingInfo[$propertyName] = null;  | 
            ||
| 250 | return $serializedBookingInfo;  | 
            ||
| 251 | }  | 
            ||
| 252 | |||
| 253 | $dateTimeString = $serializedBookingInfo[$propertyName];  | 
            ||
| 254 | |||
| 255 | // The new serialized date time format is a string according the ISO 8601 format.  | 
            ||
| 256 | // If this is so return without modifications.  | 
            ||
| 257 | $dateTimeFromAtom = \DateTimeImmutable::createFromFormat(\DATE_ATOM, $dateTimeString);  | 
            ||
| 258 |             if ($dateTimeFromAtom) { | 
            ||
| 259 | return $serializedBookingInfo;  | 
            ||
| 260 | }  | 
            ||
| 261 | |||
| 262 | // For older format a modification is needed to ISO 8601 format.  | 
            ||
| 263 | $dateTimeFromAtomWithMilliseconds = \DateTimeImmutable::createFromFormat(  | 
            ||
| 264 | 'Y-m-d\TH:i:s.uP',  | 
            ||
| 265 | $dateTimeString  | 
            ||
| 266 | );  | 
            ||
| 267 |             if ($dateTimeFromAtomWithMilliseconds) { | 
            ||
| 268 | $serializedBookingInfo[$propertyName] = $dateTimeFromAtomWithMilliseconds->format(\DATE_ATOM);  | 
            ||
| 269 | return $serializedBookingInfo;  | 
            ||
| 270 | }  | 
            ||
| 271 | |||
| 272 | // In case of unknown format clear the available date property.  | 
            ||
| 273 | unset($serializedBookingInfo[$propertyName]);  | 
            ||
| 274 | return $serializedBookingInfo;  | 
            ||
| 275 | };  | 
            ||
| 276 | |||
| 277 |         $manipulateBookingInfoEvent = function (array $serializedEvent) use ($manipulateAvailability) { | 
            ||
| 278 | $serializedEvent = self::replaceEventIdWithItemId($serializedEvent);  | 
            ||
| 279 | $serializedEvent = self::replacePlaceIdWithItemId($serializedEvent);  | 
            ||
| 280 | |||
| 281 | $serializedBookingInfo = $serializedEvent['payload']['bookingInfo'];  | 
            ||
| 282 | $serializedBookingInfo = $manipulateAvailability($serializedBookingInfo, 'availabilityStarts');  | 
            ||
| 283 | $serializedBookingInfo = $manipulateAvailability($serializedBookingInfo, 'availabilityEnds');  | 
            ||
| 284 | $serializedEvent['payload']['bookingInfo'] = $serializedBookingInfo;  | 
            ||
| 285 | |||
| 286 | return $serializedEvent;  | 
            ||
| 287 | };  | 
            ||
| 288 | |||
| 289 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 290 | EventBookingInfoUpdated::class,  | 
            ||
| 291 | $manipulateBookingInfoEvent  | 
            ||
| 292 | );  | 
            ||
| 293 | |||
| 294 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 295 | PlaceBookingInfoUpdated::class,  | 
            ||
| 296 | $manipulateBookingInfoEvent  | 
            ||
| 297 | );  | 
            ||
| 298 | |||
| 299 | /**  | 
            ||
| 300 | * EventEvent to AbstractEvent (Offer)  | 
            ||
| 301 | */  | 
            ||
| 302 | $refactoredEventEvents = [  | 
            ||
| 303 | EventTypicalAgeRangeDeleted::class,  | 
            ||
| 304 | EventTypicalAgeRangeUpdated::class,  | 
            ||
| 305 | EventContactPointUpdated::class,  | 
            ||
| 306 | MajorInfoUpdated::class,  | 
            ||
| 307 | EventOrganizerUpdated::class,  | 
            ||
| 308 | EventOrganizerDeleted::class,  | 
            ||
| 309 | EventDescriptionUpdated::class,  | 
            ||
| 310 | EventDeleted::class,  | 
            ||
| 311 | ];  | 
            ||
| 312 | |||
| 313 |         foreach ($refactoredEventEvents as $refactoredEventEvent) { | 
            ||
| 314 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 315 | $refactoredEventEvent,  | 
            ||
| 316 |                 function (array $serializedObject) { | 
            ||
| 317 | $serializedObject = self::replaceEventIdWithItemId($serializedObject);  | 
            ||
| 318 | return $serializedObject;  | 
            ||
| 319 | }  | 
            ||
| 320 | );  | 
            ||
| 321 | }  | 
            ||
| 322 | |||
| 323 | /**  | 
            ||
| 324 | * PlaceEvent to AbstractEvent (Offer)  | 
            ||
| 325 | */  | 
            ||
| 326 | $refactoredPlaceEvents = [  | 
            ||
| 327 | PlaceOrganizerUpdated::class,  | 
            ||
| 328 | PlaceOrganizerDeleted::class,  | 
            ||
| 329 | PlaceTypicalAgeRangeDeleted::class,  | 
            ||
| 330 | PlaceTypicalAgeRangeUpdated::class,  | 
            ||
| 331 | PlaceContactPointUpdated::class,  | 
            ||
| 332 | PlaceDescriptionUpdated::class,  | 
            ||
| 333 | PlaceDeleted::class,  | 
            ||
| 334 | ];  | 
            ||
| 335 | |||
| 336 |         foreach ($refactoredPlaceEvents as $refactoredPlaceEvent) { | 
            ||
| 337 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 338 | $refactoredPlaceEvent,  | 
            ||
| 339 |                 function (array $serializedObject) { | 
            ||
| 340 | $serializedObject = self::replacePlaceIdWithItemId($serializedObject);  | 
            ||
| 341 | return $serializedObject;  | 
            ||
| 342 | }  | 
            ||
| 343 | );  | 
            ||
| 344 | }  | 
            ||
| 345 | |||
| 346 | /**  | 
            ||
| 347 | * PriceInfoUpdated events  | 
            ||
| 348 | */  | 
            ||
| 349 | $priceInfoEvents = [  | 
            ||
| 350 | EventPriceInfoUpdated::class,  | 
            ||
| 351 | PlacePriceInfoUpdated::class,  | 
            ||
| 352 | ];  | 
            ||
| 353 | |||
| 354 |         foreach ($priceInfoEvents as $priceInfoEvent) { | 
            ||
| 355 | $payloadManipulatingSerializer->manipulateEventsOfClass(  | 
            ||
| 356 | $priceInfoEvent,  | 
            ||
| 357 |                 function (array $serializedObject) { | 
            ||
| 358 | $payload = &$serializedObject['payload'];  | 
            ||
| 359 | $priceInfo = &$payload['price_info'];  | 
            ||
| 360 | $tariffs = array_map(  | 
            ||
| 361 |                         function (array $tariff) { | 
            ||
| 362 | $name = $tariff['name'];  | 
            ||
| 363 |                             if (is_string($name)) { | 
            ||
| 364 | $name = ['nl' => $name];  | 
            ||
| 365 | }  | 
            ||
| 366 | $tariff['name'] = $name;  | 
            ||
| 367 | return $tariff;  | 
            ||
| 368 | },  | 
            ||
| 369 | isset($priceInfo['tariffs']) ? $priceInfo['tariffs'] : []  | 
            ||
| 370 | );  | 
            ||
| 371 | $priceInfo['tariffs'] = $tariffs;  | 
            ||
| 372 | return $serializedObject;  | 
            ||
| 373 | }  | 
            ||
| 374 | );  | 
            ||
| 375 | }  | 
            ||
| 376 | |||
| 377 | return $payloadManipulatingSerializer;  | 
            ||
| 378 | }  | 
            ||
| 379 | |||
| 482 |