EventCopied::__construct() - Code Metrics - Inspection of "III-1747: Copy-aware event-store decorator" - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#279)

by Luc

created 2017-01-19 10:30 UTC

EventCopied::__construct() A

↳ Parent: EventCopied

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	10
nc	2
nop	3

<?php

namespace CultuurNet\UDB3\Event\Events;

use CultuurNet\UDB3\Calendar;
use CultuurNet\UDB3\CalendarInterface;
use CultuurNet\UDB3\EventSourcing\AggregateCopiedEventInterface;
use CultuurNet\UDB3\Offer\Events\AbstractEvent;

class EventCopied extends AbstractEvent implements AggregateCopiedEventInterface
{
    /**
     * @var string
     */
    private $originalEventId;

    /**
     * @var CalendarInterface|Calendar
     */
    private $calendar;

    /**
     * EventCopied constructor.
     * @param string $eventId
     * @param string $originalEventId
     * @param CalendarInterface $calendar
     */
    public function __construct(
        $eventId,
        $originalEventId,
        CalendarInterface $calendar
    ) {
        parent::__construct($eventId);

        if (!is_string($originalEventId)) {
            throw new \InvalidArgumentException(
                'Expected originalEventId to be a string, received ' . gettype($originalEventId)
            );
        }

        $this->originalEventId = $originalEventId;
        $this->calendar = $calendar;
    }

    /**
     * @inheritdoc
     */
    public function getParentAggregateId()
    {
        return $this->originalEventId;
    }

    /**
     * @return string
     */
    public function getOriginalEventId()
    {
        return $this->originalEventId;
    }

    /**
     * @return CalendarInterface
     */
    public function getCalendar()
    {
        return $this->calendar;
    }

    /**
     * @inheritdoc
     */
    public function serialize()
    {
        return parent::serialize() + [
                'original_event_id' => $this->getOriginalEventId(),
                'calendar' => $this->calendar->serialize()
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ];
    }

    /**
     * @inheritdoc
     */
    public static function deserialize(array $data)
    {
        return new static(
            $data['item_id'],
            $data['original_event_id'],
            Calendar::deserialize($data['calendar'])
        );
    }
}


1			<?php
2
3			namespace CultuurNet\UDB3\Event\Events;
4
5			use CultuurNet\UDB3\Calendar;
6			use CultuurNet\UDB3\CalendarInterface;
7			use CultuurNet\UDB3\EventSourcing\AggregateCopiedEventInterface;
8			use CultuurNet\UDB3\Offer\Events\AbstractEvent;
9
10			class EventCopied extends AbstractEvent implements AggregateCopiedEventInterface
11			{
12			/**
13			* @var string
14			*/
15			private $originalEventId;
16
17			/**
18			* @var CalendarInterface\|Calendar
19			*/
20			private $calendar;
21
22			/**
23			* EventCopied constructor.
24			* @param string $eventId
25			* @param string $originalEventId
26			* @param CalendarInterface $calendar
27			*/
28			public function __construct(
29			$eventId,
30			$originalEventId,
31			CalendarInterface $calendar
32			) {
33			parent::__construct($eventId);
34
35			if (!is_string($originalEventId)) {
36			throw new \InvalidArgumentException(
37			'Expected originalEventId to be a string, received ' . gettype($originalEventId)
38			);
39			}
40
41			$this->originalEventId = $originalEventId;
42			$this->calendar = $calendar;
43			}
44
45			/**
46			* @inheritdoc
47			*/
48			public function getParentAggregateId()
49			{
50			return $this->originalEventId;
51			}
52
53			/**
54			* @return string
55			*/
56			public function getOriginalEventId()
57			{
58			return $this->originalEventId;
59			}
60
61			/**
62			* @return CalendarInterface
63			*/
64			public function getCalendar()
65			{
66			return $this->calendar;
67			}
68
69			/**
70			* @inheritdoc
71			*/
72			public function serialize()
73			{
74			return parent::serialize() + [
75			'original_event_id' => $this->getOriginalEventId(),
76			'calendar' => $this->calendar->serialize()
			0 ignored issues – show Bug introduced 2017-01-06 07:34 UTC by Report Bug Copy Issue Report The method `serialize` does only exist in `CultuurNet\UDB3\Calendar`, but not in `CultuurNet\UDB3\CalendarInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
77			];
78			}
79
80			/**
81			* @inheritdoc
82			*/
83			public static function deserialize(array $data)
84			{
85			return new static(
86			$data['item_id'],
87			$data['original_event_id'],
88			Calendar::deserialize($data['calendar'])
89			);
90			}
91			}
92

cultuurnet / udb3-php

Pull Request — master (#279)

EventCopied::__construct() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like