Completed
Pull Request — master (#253)
by Kristof
04:43
created
src/Offer/Events/Image/AbstractImageEvent.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
 
49 49
     /**
50 50
      * @param array $data
51
-     * @return mixed The object instance
51
+     * @return AbstractImageEvent The object instance
52 52
      */
53 53
     public static function deserialize(array $data)
54 54
     {
Please login to merge, or discard this patch.
src/Offer/Events/Image/AbstractImageUpdated.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -79,10 +79,10 @@
 block discarded – undo
79 79
      */
80 80
     public function serialize()
81 81
     {
82
-        return parent::serialize() +  array(
83
-            'media_object_id' => (string) $this->mediaObjectId,
84
-            'description' => (string) $this->description,
85
-            'copyright_holder' => (string) $this->copyrightHolder
82
+        return parent::serialize() + array(
83
+            'media_object_id' => (string)$this->mediaObjectId,
84
+            'description' => (string)$this->description,
85
+            'copyright_holder' => (string)$this->copyrightHolder
86 86
         );
87 87
     }
88 88
 
Please login to merge, or discard this patch.
src/Variations/Command/CreateOfferVariationJSONDeserializer.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
     }
71 71
 
72 72
     /**
73
-     * @param mixed $json
73
+     * @param stdClass $json
74 74
      *
75 75
      * @throws ValidationException
76 76
      */
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -3,15 +3,12 @@
 block discarded – undo
3 3
 namespace CultuurNet\UDB3\Variations\Command;
4 4
 
5 5
 use CultuurNet\Deserializer\JSONDeserializer;
6
-use CultuurNet\UDB3\Offer\IriOfferIdentifierFactory;
7
-use CultuurNet\UDB3\Offer\IriOfferIdentifierFactoryInterface;
8 6
 use CultuurNet\UDB3\Variations\Model\Properties\Description;
9 7
 use CultuurNet\UDB3\Variations\Model\Properties\OwnerId;
10 8
 use CultuurNet\UDB3\Variations\Model\Properties\Purpose;
11 9
 use CultuurNet\UDB3\Variations\Model\Properties\Url;
12 10
 use CultuurNet\UDB3\Variations\Model\Properties\UrlValidator;
13 11
 use JsonSchema\Validator;
14
-use ValueObjects\String\String;
15 12
 use stdClass;
16 13
 
17 14
 class CreateOfferVariationJSONDeserializer extends JSONDeserializer
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@
 block discarded – undo
96 96
     private function getErrorMessages($validationErrors)
97 97
     {
98 98
         $errorMessages = array_map(
99
-            function ($error) {
99
+            function($error) {
100 100
                 return $error['message'];
101 101
             },
102 102
             $validationErrors
Please login to merge, or discard this patch.
src/Variations/DefaultOfferVariationService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
     public function editDescription(Id $id, Description $description)
70 70
     {
71 71
         /** @var EventVariation $variation */
72
-        $variation = $this->eventVariationRepository->load((string) $id);
72
+        $variation = $this->eventVariationRepository->load((string)$id);
73 73
 
74 74
         $variation->editDescription($description);
75 75
 
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
     public function deleteEventVariation(Id $id)
83 83
     {
84 84
         /** @var EventVariation $variation */
85
-        $variation = $this->eventVariationRepository->load((string) $id);
85
+        $variation = $this->eventVariationRepository->load((string)$id);
86 86
 
87 87
         $variation->markDeleted();
88 88
 
Please login to merge, or discard this patch.
src/Variations/Model/OfferVariation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
     private function guardNotDeleted()
123 123
     {
124 124
         if ($this->isDeleted()) {
125
-            throw new AggregateDeletedException((string) $this->id);
125
+            throw new AggregateDeletedException((string)$this->id);
126 126
         }
127 127
     }
128 128
 
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
      */
149 149
     public function getAggregateRootId()
150 150
     {
151
-        return (string) $this->id;
151
+        return (string)$this->id;
152 152
     }
153 153
 
154 154
     /**
Please login to merge, or discard this patch.
src/Variations/Model/Events/OfferVariationEvent.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
     public function serialize()
38 38
     {
39 39
         return array(
40
-            'id' => (string) $this->getId(),
40
+            'id' => (string)$this->getId(),
41 41
         );
42 42
     }
43 43
 
Please login to merge, or discard this patch.
src/Variations/Model/Events/OfferVariationCreated.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -94,10 +94,10 @@
 block discarded – undo
94 94
     public function serialize()
95 95
     {
96 96
         return parent::serialize() + array(
97
-            'origin_url' => (string) $this->getOriginUrl(),
98
-            'owner_id' => (string) $this->getOwnerId(),
99
-            'purpose' => (string) $this->getPurpose(),
100
-            'description' => (string) $this->getDescription(),
97
+            'origin_url' => (string)$this->getOriginUrl(),
98
+            'owner_id' => (string)$this->getOwnerId(),
99
+            'purpose' => (string)$this->getPurpose(),
100
+            'description' => (string)$this->getDescription(),
101 101
         );
102 102
     }
103 103
 
Please login to merge, or discard this patch.
src/Variations/ReadModel/Search/Doctrine/DBALRepository.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -49,11 +49,11 @@
 block discarded – undo
49 49
         $this->connection->insert(
50 50
             $this->connection->quoteIdentifier($this->tableName),
51 51
             [
52
-                'id' => (string) $variationId,
53
-                'owner' => (string) $ownerId,
54
-                'purpose' => (string) $purpose,
52
+                'id' => (string)$variationId,
53
+                'owner' => (string)$ownerId,
54
+                'purpose' => (string)$purpose,
55 55
                 'inserted' => time(),
56
-                'origin_url' => (string) $eventUrl,
56
+                'origin_url' => (string)$eventUrl,
57 57
             ]
58 58
         );
59 59
 
Please login to merge, or discard this patch.
src/ReadModel/Index/Doctrine/DBALRepository.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -252,7 +252,7 @@
 block discarded – undo
252 252
 
253 253
         $results = $q->execute();
254 254
         $offerIdentifierArray = array_map(
255
-            function ($resultRow) {
255
+            function($resultRow) {
256 256
                 $offerIdentifier = new IriOfferIdentifier(
257 257
                     $resultRow['entity_id'],
258 258
                     OfferType::fromNative(ucfirst($resultRow['entity_type']))
Please login to merge, or discard this patch.
Doc Comments   +8 added lines, -1 removed lines patch added patch discarded remove patch
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
     }
187 187
 
188 188
     /**
189
-     * @param $id
189
+     * @param string $id
190 190
      * @param EntityType $entityType
191 191
      * @return bool
192 192
      */
@@ -316,6 +316,9 @@  discard block
 block discarded – undo
316 316
         );
317 317
     }
318 318
 
319
+    /**
320
+     * @param string $userId
321
+     */
319 322
     private function getPagedDashboardItems(
320 323
         $userId,
321 324
         Natural $limit,
@@ -340,6 +343,10 @@  discard block
 block discarded – undo
340 343
 
341 344
         $results = $queryBuilder->execute();
342 345
         $offerIdentifierArray = array_map(
346
+
347
+            /**
348
+             * @param string $resultRow
349
+             */
343 350
             function ($resultRow) {
344 351
                 $offerIdentifier = new IriOfferIdentifier(
345 352
                     $resultRow['entity_iri'],
Please login to merge, or discard this patch.