Completed
Pull Request — master (#253)
by Kristof
04:43
created
src/EventSourcing/DBAL/UniqueConstraintException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
      */
12 12
     public function __construct($uuid, $unique)
13 13
     {
14
-        $message = 'Not unique: uuid = ' . $uuid . ', unique value = ' . $unique;
14
+        $message = 'Not unique: uuid = '.$uuid.', unique value = '.$unique;
15 15
         parent::__construct($message);
16 16
     }
17 17
 }
Please login to merge, or discard this patch.
src/Variations/OfferVariationCommandHandler.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
             $this->logger->info(
57 57
                 'job_info',
58 58
                 [
59
-                    'offer_variation_id' => (string) $editDescription->getId(),
59
+                    'offer_variation_id' => (string)$editDescription->getId(),
60 60
                 ]
61 61
             );
62 62
         }
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
             $this->logger->info(
71 71
                 'job_info',
72 72
                 [
73
-                    'offer_variation_id' => (string) $deleteEventVariation->getId()
73
+                    'offer_variation_id' => (string)$deleteEventVariation->getId()
74 74
                 ]
75 75
             );
76 76
         }
Please login to merge, or discard this patch.
src/Label/ReadModels/JSON/Repository/SimilaritySorter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
      */
14 14
     public function sort(array &$entities, StringLiteral $value)
15 15
     {
16
-        return usort($entities, function ($entity1, $entity2) use ($value) {
16
+        return usort($entities, function($entity1, $entity2) use ($value) {
17 17
             /** @var Entity $entity1 */
18 18
             $weight1 = $this->getWeight($entity1, $value);
19 19
 
Please login to merge, or discard this patch.
src/Label/ReadModels/JSON/Repository/Doctrine/DBALWriteRepository.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
         $queryBuilder = $this->createQueryBuilder()
130 130
             ->update($this->getTableName()->toNative())
131 131
             ->set($column, '?')
132
-            ->where(SchemaConfigurator::UUID_COLUMN . ' = ?')
132
+            ->where(SchemaConfigurator::UUID_COLUMN.' = ?')
133 133
             ->setParameters([
134 134
                 $value ? 1 : 0,
135 135
                 $uuid->toNative()
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
                 SchemaConfigurator::COUNT_COLUMN,
156 156
                 $newCount < 0 ? 0 : $newCount
157 157
             )
158
-            ->where(SchemaConfigurator::UUID_COLUMN . ' = ?')
158
+            ->where(SchemaConfigurator::UUID_COLUMN.' = ?')
159 159
             ->setParameters([$uuid->toNative()]);
160 160
 
161 161
         $queryBuilder->execute();
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
         $queryBuilder = $this->createQueryBuilder()
171 171
             ->select([SchemaConfigurator::COUNT_COLUMN])
172 172
             ->from($this->getTableName()->toNative())
173
-            ->where(SchemaConfigurator::UUID_COLUMN . ' = ?')
173
+            ->where(SchemaConfigurator::UUID_COLUMN.' = ?')
174 174
             ->setParameters([$uuid->toNative()]);
175 175
 
176 176
         $statement = $queryBuilder->execute();
Please login to merge, or discard this patch.
src/Role/Commands/RenameRole.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace CultuurNet\UDB3\Role\Commands;
4 4
 
5 5
 use ValueObjects\Identity\UUID;
6
-use ValueObjects\String\String as stringLiteral;
7 6
 
8 7
 class RenameRole extends AbstractCommand
9 8
 {
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
     }
23 23
 
24 24
     /**
25
-     * @return StringLiteral
25
+     * @return stringLiteral
26 26
      */
27 27
     public function getName()
28 28
     {
Please login to merge, or discard this patch.
src/SearchAPI2/ResultSetPullParser.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
         $items = new OfferIdentifierCollection();
80 80
         $totalItems = $cdbId = $elementName = $offerType = $resultXmlString = null;
81 81
 
82
-        $resetCurrentResultValues = function () use (&$cdbId, &$elementName, &$offerType, &$resultXmlString) {
82
+        $resetCurrentResultValues = function() use (&$cdbId, &$elementName, &$offerType, &$resultXmlString) {
83 83
             $cdbId = null;
84 84
             $elementName = self::CDBXML_TYPE_UNKNOWN;
85 85
             $offerType = self::OFFER_TYPE_UNKNOWN;
@@ -93,13 +93,13 @@  discard block
 block discarded – undo
93 93
 
94 94
         while ($r->read()) {
95 95
             if ($this->xmlNodeIsNumberOfRecordsTag($r)) {
96
-                $totalItems = new Integer((int) $r->readString());
96
+                $totalItems = new Integer((int)$r->readString());
97 97
             }
98 98
 
99 99
             if ($this->xmlNodeIsResultOpeningTag($r)) {
100 100
                 $resultXmlString = $r->readOuterXml();
101 101
                 $cdbId = $r->getAttribute('cdbid');
102
-                $elementName = 'cdbxml.' . $r->localName;
102
+                $elementName = 'cdbxml.'.$r->localName;
103 103
 
104 104
                 if ($elementName == self::CDBXML_TYPE_EVENT) {
105 105
                     $offerType = self::OFFER_TYPE_EVENT;
Please login to merge, or discard this patch.
src/Role/Events/AbstractConstraintEvent.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace CultuurNet\UDB3\Role\Commands;
4 4
 
5 5
 use ValueObjects\Identity\UUID;
6
-use ValueObjects\String\String as stringLiteral;
7 6
 
8 7
 class RenameRole extends AbstractCommand
9 8
 {
Please login to merge, or discard this patch.
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
     /**
16 16
      * AbstractPermissionEvent constructor.
17 17
      * @param UUID $uuid
18
-     * @param StringLiteral $query
18
+     * @param stringLiteral $query
19 19
      */
20 20
     public function __construct(UUID $uuid, StringLiteral $query)
21 21
     {
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
     }
25 25
 
26 26
     /**
27
-     * @return StringLiteral
27
+     * @return string|null
28 28
      */
29 29
     public function getQuery()
30 30
     {
Please login to merge, or discard this patch.
src/Role/Role.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@
 block discarded – undo
116 116
     }
117 117
 
118 118
     /**
119
-     * @return string
119
+     * @return UUID
120 120
      */
121 121
     public function getFileId()
122 122
     {
Please login to merge, or discard this patch.
src/Label/ReadModels/JSON/Projector.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@
 block discarded – undo
142 142
     {
143 143
         $uuid = null;
144 144
 
145
-        $name = new StringLiteral((string) $labelEvent->getLabel());
145
+        $name = new StringLiteral((string)$labelEvent->getLabel());
146 146
 
147 147
         $entity = $this->readRepository->getByName($name);
148 148
         if ($entity !== null) {
Please login to merge, or discard this patch.