CdbXMLImporter::longDescriptionStartsWithShortDescription() - Code Metrics - Inspection of "III-1728 Places also need import of CdbXml contact..." - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#262)

by Luc

created 2017-01-03 13:45 UTC

longDescriptionStartsWithShortDescription() A

↳ Parent: CdbXMLImporter

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	2

<?php

namespace CultuurNet\UDB3\Event\ReadModel\JSONLD;

use CultuurNet\UDB3\CalendarFactoryInterface;
use CultuurNet\UDB3\Cdb\CdbId\EventCdbIdExtractorInterface;
use CultuurNet\UDB3\Cdb\PriceDescriptionParser;
use CultuurNet\UDB3\LabelImporter;
use CultuurNet\UDB3\Offer\ReadModel\JSONLD\CdbXmlContactInfoImporterInterface;
use CultuurNet\UDB3\Offer\ReadModel\JSONLD\CdbXMLItemBaseImporter;
use CultuurNet\UDB3\SluggerInterface;
use CultuurNet\UDB3\StringFilter\BreakTagToNewlineStringFilter;
use CultuurNet\UDB3\StringFilter\CombinedStringFilter;
use CultuurNet\UDB3\StringFilter\ConsecutiveBlockOfTextStringFilter;
use CultuurNet\UDB3\StringFilter\StringFilterInterface;
use CultuurNet\UDB3\StringFilter\StripSourceStringFilter;
use CultuurNet\UDB3\StringFilter\StripSurroundingSpaceStringFilter;

/**
 * Takes care of importing cultural events in the CdbXML format (UDB2)
 * into a UDB3 JSON-LD document.
 */
class CdbXMLImporter
{
    /**
     * @var CdbXMLItemBaseImporter
     */
    private $cdbXMLItemBaseImporter;

    /**
     * @var EventCdbIdExtractorInterface
     */
    private $cdbIdExtractor;

    /**
     * @var PriceDescriptionParser
     */
    private $priceDescriptionParser;

    /**
     * @var StringFilterInterface
     */
    private $longDescriptionFilter;

    /**
     * @var StringFilterInterface
     */
    private $shortDescriptionFilter;

    /**
     * @var CalendarFactoryInterface
     */
    private $calendarFactory;

    /**
     * @var CdbXmlContactInfoImporterInterface
     */
    private $cdbXmlContactInfoImporter;

    /**
     * @param CdbXMLItemBaseImporter $cdbXMLItemBaseImporter
     * @param EventCdbIdExtractorInterface $cdbIdExtractor
     * @param PriceDescriptionParser $priceDescriptionParser
     * @param CalendarFactoryInterface $calendarFactory
     * @param CdbXmlContactInfoImporterInterface $cdbXmlContactInfoImporter
     */
    public function __construct(
        CdbXMLItemBaseImporter $cdbXMLItemBaseImporter,
        EventCdbIdExtractorInterface $cdbIdExtractor,
        PriceDescriptionParser $priceDescriptionParser,
        CalendarFactoryInterface $calendarFactory,
        CdbXmlContactInfoImporterInterface $cdbXmlContactInfoImporter
    ) {
        $this->cdbXMLItemBaseImporter = $cdbXMLItemBaseImporter;
        $this->cdbIdExtractor = $cdbIdExtractor;
        $this->priceDescriptionParser = $priceDescriptionParser;
        $this->calendarFactory = $calendarFactory;
        $this->cdbXmlContactInfoImporter = $cdbXmlContactInfoImporter;

        $consecutiveBlockOfTextFilter = new ConsecutiveBlockOfTextStringFilter();

        $this->longDescriptionFilter = new CombinedStringFilter();
        $this->longDescriptionFilter->addFilter(
            new StripSourceStringFilter()
        );
        $this->longDescriptionFilter->addFilter(
            $consecutiveBlockOfTextFilter
        );
        $this->longDescriptionFilter->addFilter(
            new BreakTagToNewlineStringFilter()
        );
        $this->longDescriptionFilter->addFilter(
            new StripSurroundingSpaceStringFilter()
        );

        $this->shortDescriptionFilter = $consecutiveBlockOfTextFilter;
    }

    /**
     * Imports a UDB2 event into a UDB3 JSON-LD document.
     *
     * @param \stdClass $base
     *   The JSON-LD document to start from.
     * @param \CultureFeed_Cdb_Item_Event $event
     *   The cultural event data from UDB2 to import.
     * @param PlaceServiceInterface $placeManager
     *   The manager from which to retrieve the JSON-LD of a place.
     * @param OrganizerServiceInterface $organizerManager
     *   The manager from which to retrieve the JSON-LD of an organizer.
     * @param SluggerInterface $slugger
     *   The slugger that's used to generate a sameAs reference.
     *
     * @return \stdClass
     *   The document with the UDB2 event data merged in.
     */
    public function documentWithCdbXML(
        $base,
        \CultureFeed_Cdb_Item_Event $event,
        PlaceServiceInterface $placeManager,
        OrganizerServiceInterface $organizerManager,
        SluggerInterface $slugger
    ) {
        $jsonLD = clone $base;

        /** @var \CultureFeed_Cdb_Data_EventDetail $detail */
        $detail = null;

        /** @var \CultureFeed_Cdb_Data_EventDetail[] $details */
        $details = $event->getDetails();

        foreach ($details as $languageDetail) {
            $language = $languageDetail->getLanguage();

            // The first language detail found will be used to retrieve
            // properties from which in UDB3 are not any longer considered
            // to be language specific.
            if (!$detail) {
                $detail = $languageDetail;
            }

            $jsonLD->name[$language] = $languageDetail->getTitle();

            $this->importDescription($languageDetail, $jsonLD, $language);
        }

        $this->cdbXMLItemBaseImporter->importAvailable($event, $jsonLD);

        $labelImporter = new LabelImporter();
        $labelImporter->importLabels($event, $jsonLD);

        $jsonLD->calendarSummary = $detail->getCalendarSummary();

        $this->importLocation($event, $placeManager, $jsonLD);

        $this->importOrganizer($event, $organizerManager, $jsonLD);

        if ($event->getContactInfo()) {
            $this->cdbXmlContactInfoImporter->importBookingInfo(
                $jsonLD,
                $event->getContactInfo(),
                $detail->getPrice(),
                $event->getBookingPeriod()
            );

            $this->cdbXmlContactInfoImporter->importContactPoint(
                $jsonLD,
                $event->getContactInfo()
            );
        }

        $this->importPriceInfo($detail, $jsonLD);

        $this->importTerms($event, $jsonLD);

        $this->cdbXMLItemBaseImporter->importPublicationInfo($event, $jsonLD);

        $calendar = $this->calendarFactory->createFromCdbCalendar($event->getCalendar());
        $jsonLD = (object)array_merge((array)$jsonLD, $calendar->toJsonLd());

        $this->importTypicalAgeRange($event, $jsonLD);

        $this->importPerformers($detail, $jsonLD);

        $this->importLanguages($event, $jsonLD);

        $this->importUitInVlaanderenReference($event, $slugger, $jsonLD);

        $this->cdbXMLItemBaseImporter->importExternalId($event, $jsonLD);

        $this->importSeeAlso($event, $jsonLD);

        $this->cdbXMLItemBaseImporter->importWorkflowStatus($event, $jsonLD);

        return $jsonLD;
    }

    /**
     * @param \CultureFeed_Cdb_Data_EventDetail $languageDetail
     * @param \stdClass $jsonLD
     * @param string $language
     */
    private function importDescription($languageDetail, $jsonLD, $language)
    {
        $longDescription = $languageDetail->getLongDescription();

        if ($longDescription) {
            $longDescription = $this->longDescriptionFilter->filter(
                $longDescription
            );
        }

        $descriptions = [];

        $shortDescription = $languageDetail->getShortDescription();
        if ($shortDescription) {
            $includeShortDescription = true;

            $shortDescription = $this->shortDescriptionFilter->filter(
                $shortDescription
            );

            if ($longDescription) {
                $includeShortDescription =
                    !$this->longDescriptionStartsWithShortDescription(
                        $longDescription,
                        $shortDescription
                    );
            }

            if ($includeShortDescription) {
                $descriptions[] = $shortDescription;
            }
        }

        if ($longDescription) {
            $descriptions[] = $longDescription;
        }

        $description = implode("\n\n", $descriptions);

        $jsonLD->description[$language] = $description;
    }

    /**
     * @param \CultureFeed_Cdb_Item_Event $event
     * @param PlaceServiceInterface $placeManager
     * @param \stdClass $jsonLD
     */
    private function importLocation(\CultureFeed_Cdb_Item_Event $event, PlaceServiceInterface $placeManager, $jsonLD)
    {
        $location = array();
        $location['@type'] = 'Place';

        $location_id = $this->cdbIdExtractor->getRelatedPlaceCdbId($event);

        if ($location_id) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $location += (array)$placeManager->placeJSONLD($location_id);
        } else {
            $location_cdb = $event->getLocation();
            $location['name']['nl'] = $location_cdb->getLabel();
            $address = $location_cdb->getAddress()->getPhysicalAddress();
            if ($address) {
                $location['address'] = array(
                    'addressCountry' => $address->getCountry(),
                    'addressLocality' => $address->getCity(),
                    'postalCode' => $address->getZip(),
                    'streetAddress' =>
                        $address->getStreet() . ' ' . $address->getHouseNumber(
                        ),
                );
            }
        }
        $jsonLD->location = $location;
    }

    /**
     * @param \CultureFeed_Cdb_Item_Event $event
     * @param OrganizerServiceInterface $organizerManager
     * @param \stdClass $jsonLD
     */
    private function importOrganizer(
        \CultureFeed_Cdb_Item_Event $event,
        OrganizerServiceInterface $organizerManager,
        $jsonLD
    ) {
        $organizer = null;
        $organizer_id = $this->cdbIdExtractor->getRelatedOrganizerCdbId($event);
        $organizer_cdb = $event->getOrganiser();
        $contact_info_cdb = $event->getContactInfo();

        if ($organizer_id) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $organizer = (array)$organizerManager->organizerJSONLD($organizer_id);
        } elseif ($organizer_cdb && $contact_info_cdb) {
            $organizer = array();
            $organizer['name'] = $organizer_cdb->getLabel();

            $emails_cdb = $contact_info_cdb->getMails();
            if (count($emails_cdb) > 0) {
                $organizer['email'] = array();
                foreach ($emails_cdb as $email) {
                    $organizer['email'][] = $email->getMailAddress();
                }
            }

            /** @var \CultureFeed_Cdb_Data_Phone[] $phones_cdb */
            $phones_cdb = $contact_info_cdb->getPhones();
            if (count($phones_cdb) > 0) {
                $organizer['phone'] = array();
                foreach ($phones_cdb as $phone) {
                    $organizer['phone'][] = $phone->getNumber();
                }
            }
        }

        if (!is_null($organizer)) {
            $organizer['@type'] = 'Organizer';
            $jsonLD->organizer = $organizer;
        }
    }

    /**
     * @param \CultureFeed_Cdb_Data_EventDetail $detail
     * @param \stdClass $jsonLD
     */
    private function importPriceInfo(
        \CultureFeed_Cdb_Data_EventDetail $detail,
        $jsonLD
    ) {
        $prices = array();

        $price = $detail->getPrice();

        if ($price) {
            $description = $price->getDescription();

            if ($description) {
                $prices = $this->priceDescriptionParser->parse($description);
            }

            // If price description was not interpretable, fall back to
            // price title and value.
            if (empty($prices) && $price->getValue() !== null) {
                $prices['Basistarief'] = floatval($price->getValue());
            }
        }

        if (!empty($prices)) {
            $priceInfo = array();

            /** @var \CultureFeed_Cdb_Data_Price $price */
            foreach ($prices as $title => $value) {
                $priceInfoItem = array(
                    'name' => $title,
                    'priceCurrency' => 'EUR',
                    'price' => $value,
                );

                $priceInfoItem['category'] = 'tariff';

                if ($priceInfoItem['name'] === 'Basistarief') {
                    $priceInfoItem['category'] = 'base';
                }

                $priceInfo[] = $priceInfoItem;
            }

            if (!empty($priceInfo)) {
                $jsonLD->priceInfo = $priceInfo;
            }
        }
    }

    /**
     * @param \CultureFeed_Cdb_Item_Event $event
     * @param \stdClass $jsonLD
     */
    private function importTerms(\CultureFeed_Cdb_Item_Event $event, $jsonLD)
    {
        $themeBlacklist = [
            'Thema onbepaald',
            'Meerder kunstvormen',
            'Meerdere filmgenres'
        ];
        $categories = array();
        foreach ($event->getCategories() as $category) {

            /* @var \Culturefeed_Cdb_Data_Category $category */
            if ($category && !in_array($category->getName(), $themeBlacklist)) {
                $categories[] = array(
                    'label' => $category->getName(),
                    'domain' => $category->getType(),
                    'id' => $category->getId(),
                );
            }
        }
        $jsonLD->terms = $categories;
    }

    /**
     * @param \CultureFeed_Cdb_Item_Event $event
     * @param \stdClass $jsonLD
     */
    private function importTypicalAgeRange(\CultureFeed_Cdb_Item_Event $event, $jsonLD)
    {
        $ageFrom = $event->getAgeFrom();

        if (isset($ageFrom) && is_int($ageFrom)) {
            if ($ageFrom <= 12) {
                $jsonLD->typicalAgeRange = "{$ageFrom}-12";
            } else if ($ageFrom <= 18) {
                $jsonLD->typicalAgeRange = "{$ageFrom}-18";
            } else if ($ageFrom <= 99) {
                $jsonLD->typicalAgeRange = "{$ageFrom}-99";
            } else {
                $jsonLD->typicalAgeRange = '99-99';
            }
        }
    }

    /**
     * @param \CultureFeed_Cdb_Data_EventDetail $detail
     * @param \stdClass $jsonLD
     */
    private function importPerformers(\CultureFeed_Cdb_Data_EventDetail $detail, $jsonLD)
    {
        /** @var \CultureFeed_Cdb_Data_Performer $performer */
        $performers = $detail->getPerformers();
        if ($performers) {
            foreach ($performers as $performer) {
                if ($performer->getLabel()) {
                    $performerData = new \stdClass();
                    $performerData->name = $performer->getLabel();
                    $jsonLD->performer[] = $performerData;
                }
            }
        }
    }

    /**
     * @param \CultureFeed_Cdb_Item_Event $event
     * @param \stdClass $jsonLD
     */
    private function importLanguages(\CultureFeed_Cdb_Item_Event $event, $jsonLD)
    {
        /** @var \CultureFeed_Cdb_Data_Language $udb2Language */
        $languages = $event->getLanguages();
        if ($languages) {
            $jsonLD->language = [];
            foreach ($languages as $udb2Language) {
                $jsonLD->language[] = $udb2Language->getLanguage();
            }
            $jsonLD->language = array_unique($jsonLD->language);
        }
    }

    /**
     * @param \CultureFeed_Cdb_Item_Event $event
     * @param \stdClass $jsonLD
     */
    private function importSeeAlso(
        \CultureFeed_Cdb_Item_Event $event,
        \stdClass $jsonLD
    ) {
        if (!property_exists($jsonLD, 'seeAlso')) {
            $jsonLD->seeAlso = [];
        }

        // Add contact info url, if it's not for reservations.
        if ($contactInfo = $event->getContactInfo()) {
            /** @var \CultureFeed_Cdb_Data_Url[] $contactUrls */
            $contactUrls = $contactInfo->getUrls();
            if (is_array($contactUrls) && count($contactUrls) > 0) {
                foreach ($contactUrls as $contactUrl) {
                    if (!$contactUrl->isForReservations()) {
                        $jsonLD->seeAlso[] = $contactUrl->getUrl();
                    }
                }
            }
        }
    }

    /**
     * @param \CultureFeed_Cdb_Item_Event $event
     * @param SluggerInterface $slugger
     * @param \stdClass $jsonLD
     */
    private function importUitInVlaanderenReference(
        \CultureFeed_Cdb_Item_Event $event,
        SluggerInterface $slugger,
        $jsonLD
    ) {

        // Some events seem to not have a Dutch name, even though this is
        // required. If there's no Dutch name, we just leave the slug empty as
        // that seems to be the behaviour on http://m.uitinvlaanderen.be
        if (isset($jsonLD->name['nl'])) {
            $name = $jsonLD->name['nl'];
            $slug = $slugger->slug($name);
        } else {
            $slug = '';
        }

        $reference = 'http://www.uitinvlaanderen.be/agenda/e/' . $slug . '/' . $event->getCdbId();


        if (!property_exists($jsonLD, 'sameAs')) {
            $jsonLD->sameAs = [];
        }

        if (!in_array($reference, $jsonLD->sameAs)) {
            array_push($jsonLD->sameAs, $reference);
        }
    }

    /**
     * @param string $longDescription
     * @param string $shortDescription
     * @return bool
     */
    private function longDescriptionStartsWithShortDescription(
        $longDescription,
        $shortDescription
    ) {
        $longDescription = strip_tags(html_entity_decode($longDescription));

        return 0 === strncmp($longDescription, $shortDescription, mb_strlen($shortDescription));
    }
}


1		<?php
2
3		namespace CultuurNet\UDB3\Event\ReadModel\JSONLD;
4
5		use CultuurNet\UDB3\CalendarFactoryInterface;
6		use CultuurNet\UDB3\Cdb\CdbId\EventCdbIdExtractorInterface;
7		use CultuurNet\UDB3\Cdb\PriceDescriptionParser;
8		use CultuurNet\UDB3\LabelImporter;
9		use CultuurNet\UDB3\Offer\ReadModel\JSONLD\CdbXmlContactInfoImporterInterface;
10		use CultuurNet\UDB3\Offer\ReadModel\JSONLD\CdbXMLItemBaseImporter;
11		use CultuurNet\UDB3\SluggerInterface;
12		use CultuurNet\UDB3\StringFilter\BreakTagToNewlineStringFilter;
13		use CultuurNet\UDB3\StringFilter\CombinedStringFilter;
14		use CultuurNet\UDB3\StringFilter\ConsecutiveBlockOfTextStringFilter;
15		use CultuurNet\UDB3\StringFilter\StringFilterInterface;
16		use CultuurNet\UDB3\StringFilter\StripSourceStringFilter;
17		use CultuurNet\UDB3\StringFilter\StripSurroundingSpaceStringFilter;
18
19		/**
20		* Takes care of importing cultural events in the CdbXML format (UDB2)
21		* into a UDB3 JSON-LD document.
22		*/
23		class CdbXMLImporter
24		{
25		/**
26		* @var CdbXMLItemBaseImporter
27		*/
28		private $cdbXMLItemBaseImporter;
29
30		/**
31		* @var EventCdbIdExtractorInterface
32		*/
33		private $cdbIdExtractor;
34
35		/**
36		* @var PriceDescriptionParser
37		*/
38		private $priceDescriptionParser;
39
40		/**
41		* @var StringFilterInterface
42		*/
43		private $longDescriptionFilter;
44
45		/**
46		* @var StringFilterInterface
47		*/
48		private $shortDescriptionFilter;
49
50		/**
51		* @var CalendarFactoryInterface
52		*/
53		private $calendarFactory;
54
55		/**
56		* @var CdbXmlContactInfoImporterInterface
57		*/
58		private $cdbXmlContactInfoImporter;
59
60		/**
61		* @param CdbXMLItemBaseImporter $cdbXMLItemBaseImporter
62		* @param EventCdbIdExtractorInterface $cdbIdExtractor
63		* @param PriceDescriptionParser $priceDescriptionParser
64		* @param CalendarFactoryInterface $calendarFactory
65		* @param CdbXmlContactInfoImporterInterface $cdbXmlContactInfoImporter
66		*/
67		public function __construct(
68		CdbXMLItemBaseImporter $cdbXMLItemBaseImporter,
69		EventCdbIdExtractorInterface $cdbIdExtractor,
70		PriceDescriptionParser $priceDescriptionParser,
71		CalendarFactoryInterface $calendarFactory,
72		CdbXmlContactInfoImporterInterface $cdbXmlContactInfoImporter
73		) {
74		$this->cdbXMLItemBaseImporter = $cdbXMLItemBaseImporter;
75		$this->cdbIdExtractor = $cdbIdExtractor;
76		$this->priceDescriptionParser = $priceDescriptionParser;
77		$this->calendarFactory = $calendarFactory;
78		$this->cdbXmlContactInfoImporter = $cdbXmlContactInfoImporter;
79
80		$consecutiveBlockOfTextFilter = new ConsecutiveBlockOfTextStringFilter();
81
82		$this->longDescriptionFilter = new CombinedStringFilter();
83		$this->longDescriptionFilter->addFilter(
84		new StripSourceStringFilter()
85		);
86		$this->longDescriptionFilter->addFilter(
87		$consecutiveBlockOfTextFilter
88		);
89		$this->longDescriptionFilter->addFilter(
90		new BreakTagToNewlineStringFilter()
91		);
92		$this->longDescriptionFilter->addFilter(
93		new StripSurroundingSpaceStringFilter()
94		);
95
96		$this->shortDescriptionFilter = $consecutiveBlockOfTextFilter;
97		}
98
99		/**
100		* Imports a UDB2 event into a UDB3 JSON-LD document.
101		*
102		* @param \stdClass $base
103		* The JSON-LD document to start from.
104		* @param \CultureFeed_Cdb_Item_Event $event
105		* The cultural event data from UDB2 to import.
106		* @param PlaceServiceInterface $placeManager
107		* The manager from which to retrieve the JSON-LD of a place.
108		* @param OrganizerServiceInterface $organizerManager
109		* The manager from which to retrieve the JSON-LD of an organizer.
110		* @param SluggerInterface $slugger
111		* The slugger that's used to generate a sameAs reference.
112		*
113		* @return \stdClass
114		* The document with the UDB2 event data merged in.
115		*/
116		public function documentWithCdbXML(
117		$base,
118		\CultureFeed_Cdb_Item_Event $event,
119		PlaceServiceInterface $placeManager,
120		OrganizerServiceInterface $organizerManager,
121		SluggerInterface $slugger
122		) {
123		$jsonLD = clone $base;
124
125		/** @var \CultureFeed_Cdb_Data_EventDetail $detail */
126		$detail = null;
127
128		/** @var \CultureFeed_Cdb_Data_EventDetail[] $details */
129		$details = $event->getDetails();
130
131		foreach ($details as $languageDetail) {
132		$language = $languageDetail->getLanguage();
133
134		// The first language detail found will be used to retrieve
135		// properties from which in UDB3 are not any longer considered
136		// to be language specific.
137		if (!$detail) {
138		$detail = $languageDetail;
139		}
140
141		$jsonLD->name[$language] = $languageDetail->getTitle();
142
143		$this->importDescription($languageDetail, $jsonLD, $language);
144		}
145
146		$this->cdbXMLItemBaseImporter->importAvailable($event, $jsonLD);
147
148		$labelImporter = new LabelImporter();
149		$labelImporter->importLabels($event, $jsonLD);
150
151		$jsonLD->calendarSummary = $detail->getCalendarSummary();
152
153		$this->importLocation($event, $placeManager, $jsonLD);
154
155		$this->importOrganizer($event, $organizerManager, $jsonLD);
156
157		if ($event->getContactInfo()) {
158		$this->cdbXmlContactInfoImporter->importBookingInfo(
159		$jsonLD,
160		$event->getContactInfo(),
161		$detail->getPrice(),
162		$event->getBookingPeriod()
163		);
164
165		$this->cdbXmlContactInfoImporter->importContactPoint(
166		$jsonLD,
167		$event->getContactInfo()
168		);
169		}
170
171		$this->importPriceInfo($detail, $jsonLD);
172
173		$this->importTerms($event, $jsonLD);
174
175		$this->cdbXMLItemBaseImporter->importPublicationInfo($event, $jsonLD);
176
177		$calendar = $this->calendarFactory->createFromCdbCalendar($event->getCalendar());
178		$jsonLD = (object)array_merge((array)$jsonLD, $calendar->toJsonLd());
179
180		$this->importTypicalAgeRange($event, $jsonLD);
181
182		$this->importPerformers($detail, $jsonLD);
183
184		$this->importLanguages($event, $jsonLD);
185
186		$this->importUitInVlaanderenReference($event, $slugger, $jsonLD);
187
188		$this->cdbXMLItemBaseImporter->importExternalId($event, $jsonLD);
189
190		$this->importSeeAlso($event, $jsonLD);
191
192		$this->cdbXMLItemBaseImporter->importWorkflowStatus($event, $jsonLD);
193
194		return $jsonLD;
195		}
196
197		/**
198		* @param \CultureFeed_Cdb_Data_EventDetail $languageDetail
199		* @param \stdClass $jsonLD
200		* @param string $language
201		*/
202		private function importDescription($languageDetail, $jsonLD, $language)
203		{
204		$longDescription = $languageDetail->getLongDescription();
205
206		if ($longDescription) {
207		$longDescription = $this->longDescriptionFilter->filter(
208		$longDescription
209		);
210		}
211
212		$descriptions = [];
213
214		$shortDescription = $languageDetail->getShortDescription();
215		if ($shortDescription) {
216		$includeShortDescription = true;
217
218		$shortDescription = $this->shortDescriptionFilter->filter(
219		$shortDescription
220		);
221
222		if ($longDescription) {
223		$includeShortDescription =
224		!$this->longDescriptionStartsWithShortDescription(
225		$longDescription,
226		$shortDescription
227		);
228		}
229
230		if ($includeShortDescription) {
231		$descriptions[] = $shortDescription;
232		}
233		}
234
235		if ($longDescription) {
236		$descriptions[] = $longDescription;
237		}
238
239		$description = implode("\n\n", $descriptions);
240
241		$jsonLD->description[$language] = $description;
242		}
243
244		/**
245		* @param \CultureFeed_Cdb_Item_Event $event
246		* @param PlaceServiceInterface $placeManager
247		* @param \stdClass $jsonLD
248		*/
249		private function importLocation(\CultureFeed_Cdb_Item_Event $event, PlaceServiceInterface $placeManager, $jsonLD)
250		{
251		$location = array();
252		$location['@type'] = 'Place';
253
254		$location_id = $this->cdbIdExtractor->getRelatedPlaceCdbId($event);
255
256		if ($location_id) {
		0 ignored issues – show Bug Best Practice introduced 2016-10-21 15:47 UTC by Report Bug Copy Issue Report The expression `$location_id` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
257		$location += (array)$placeManager->placeJSONLD($location_id);
258		} else {
259		$location_cdb = $event->getLocation();
260		$location['name']['nl'] = $location_cdb->getLabel();
261		$address = $location_cdb->getAddress()->getPhysicalAddress();
262		if ($address) {
263		$location['address'] = array(
264		'addressCountry' => $address->getCountry(),
265		'addressLocality' => $address->getCity(),
266		'postalCode' => $address->getZip(),
267		'streetAddress' =>
268		$address->getStreet() . ' ' . $address->getHouseNumber(
269		),
270		);
271		}
272		}
273		$jsonLD->location = $location;
274		}
275
276		/**
277		* @param \CultureFeed_Cdb_Item_Event $event
278		* @param OrganizerServiceInterface $organizerManager
279		* @param \stdClass $jsonLD
280		*/
281		private function importOrganizer(
282		\CultureFeed_Cdb_Item_Event $event,
283		OrganizerServiceInterface $organizerManager,
284		$jsonLD
285		) {
286		$organizer = null;
287		$organizer_id = $this->cdbIdExtractor->getRelatedOrganizerCdbId($event);
288		$organizer_cdb = $event->getOrganiser();
289		$contact_info_cdb = $event->getContactInfo();
290
291		if ($organizer_id) {
		0 ignored issues – show Bug Best Practice introduced 2016-10-21 15:47 UTC by Report Bug Copy Issue Report The expression `$organizer_id` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
292		$organizer = (array)$organizerManager->organizerJSONLD($organizer_id);
293		} elseif ($organizer_cdb && $contact_info_cdb) {
294		$organizer = array();
295		$organizer['name'] = $organizer_cdb->getLabel();
296
297		$emails_cdb = $contact_info_cdb->getMails();
298		if (count($emails_cdb) > 0) {
299		$organizer['email'] = array();
300		foreach ($emails_cdb as $email) {
301		$organizer['email'][] = $email->getMailAddress();
302		}
303		}
304
305		/** @var \CultureFeed_Cdb_Data_Phone[] $phones_cdb */
306		$phones_cdb = $contact_info_cdb->getPhones();
307		if (count($phones_cdb) > 0) {
308		$organizer['phone'] = array();
309		foreach ($phones_cdb as $phone) {
310		$organizer['phone'][] = $phone->getNumber();
311		}
312		}
313		}
314
315		if (!is_null($organizer)) {
316		$organizer['@type'] = 'Organizer';
317		$jsonLD->organizer = $organizer;
318		}
319		}
320
321		/**
322		* @param \CultureFeed_Cdb_Data_EventDetail $detail
323		* @param \stdClass $jsonLD
324		*/
325		private function importPriceInfo(
326		\CultureFeed_Cdb_Data_EventDetail $detail,
327		$jsonLD
328		) {
329		$prices = array();
330
331		$price = $detail->getPrice();
332
333		if ($price) {
334		$description = $price->getDescription();
335
336		if ($description) {
337		$prices = $this->priceDescriptionParser->parse($description);
338		}
339
340		// If price description was not interpretable, fall back to
341		// price title and value.
342		if (empty($prices) && $price->getValue() !== null) {
343		$prices['Basistarief'] = floatval($price->getValue());
344		}
345		}
346
347		if (!empty($prices)) {
348		$priceInfo = array();
349
350		/** @var \CultureFeed_Cdb_Data_Price $price */
351		foreach ($prices as $title => $value) {
352		$priceInfoItem = array(
353		'name' => $title,
354		'priceCurrency' => 'EUR',
355		'price' => $value,
356		);
357
358		$priceInfoItem['category'] = 'tariff';
359
360		if ($priceInfoItem['name'] === 'Basistarief') {
361		$priceInfoItem['category'] = 'base';
362		}
363
364		$priceInfo[] = $priceInfoItem;
365		}
366
367		if (!empty($priceInfo)) {
368		$jsonLD->priceInfo = $priceInfo;
369		}
370		}
371		}
372
373		/**
374		* @param \CultureFeed_Cdb_Item_Event $event
375		* @param \stdClass $jsonLD
376		*/
377		private function importTerms(\CultureFeed_Cdb_Item_Event $event, $jsonLD)
378		{
379		$themeBlacklist = [
380		'Thema onbepaald',
381		'Meerder kunstvormen',
382		'Meerdere filmgenres'
383		];
384		$categories = array();
385	View Code Duplication	foreach ($event->getCategories() as $category) {
		0 ignored issues – show Duplication introduced 2015-11-24 14:43 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
386		/* @var \Culturefeed_Cdb_Data_Category $category */
387		if ($category && !in_array($category->getName(), $themeBlacklist)) {
388		$categories[] = array(
389		'label' => $category->getName(),
390		'domain' => $category->getType(),
391		'id' => $category->getId(),
392		);
393		}
394		}
395		$jsonLD->terms = $categories;
396		}
397
398		/**
399		* @param \CultureFeed_Cdb_Item_Event $event
400		* @param \stdClass $jsonLD
401		*/
402		private function importTypicalAgeRange(\CultureFeed_Cdb_Item_Event $event, $jsonLD)
403		{
404		$ageFrom = $event->getAgeFrom();
405
406		if (isset($ageFrom) && is_int($ageFrom)) {
407		if ($ageFrom <= 12) {
408		$jsonLD->typicalAgeRange = "{$ageFrom}-12";
409		} else if ($ageFrom <= 18) {
410		$jsonLD->typicalAgeRange = "{$ageFrom}-18";
411		} else if ($ageFrom <= 99) {
412		$jsonLD->typicalAgeRange = "{$ageFrom}-99";
413		} else {
414		$jsonLD->typicalAgeRange = '99-99';
415		}
416		}
417		}
418
419		/**
420		* @param \CultureFeed_Cdb_Data_EventDetail $detail
421		* @param \stdClass $jsonLD
422		*/
423		private function importPerformers(\CultureFeed_Cdb_Data_EventDetail $detail, $jsonLD)
424		{
425		/** @var \CultureFeed_Cdb_Data_Performer $performer */
426		$performers = $detail->getPerformers();
427		if ($performers) {
428		foreach ($performers as $performer) {
429		if ($performer->getLabel()) {
430		$performerData = new \stdClass();
431		$performerData->name = $performer->getLabel();
432		$jsonLD->performer[] = $performerData;
433		}
434		}
435		}
436		}
437
438		/**
439		* @param \CultureFeed_Cdb_Item_Event $event
440		* @param \stdClass $jsonLD
441		*/
442		private function importLanguages(\CultureFeed_Cdb_Item_Event $event, $jsonLD)
443		{
444		/** @var \CultureFeed_Cdb_Data_Language $udb2Language */
445		$languages = $event->getLanguages();
446		if ($languages) {
447		$jsonLD->language = [];
448		foreach ($languages as $udb2Language) {
449		$jsonLD->language[] = $udb2Language->getLanguage();
450		}
451		$jsonLD->language = array_unique($jsonLD->language);
452		}
453		}
454
455		/**
456		* @param \CultureFeed_Cdb_Item_Event $event
457		* @param \stdClass $jsonLD
458		*/
459		private function importSeeAlso(
460		\CultureFeed_Cdb_Item_Event $event,
461		\stdClass $jsonLD
462		) {
463		if (!property_exists($jsonLD, 'seeAlso')) {
464		$jsonLD->seeAlso = [];
465		}
466
467		// Add contact info url, if it's not for reservations.
468		if ($contactInfo = $event->getContactInfo()) {
469		/** @var \CultureFeed_Cdb_Data_Url[] $contactUrls */
470		$contactUrls = $contactInfo->getUrls();
471		if (is_array($contactUrls) && count($contactUrls) > 0) {
472		foreach ($contactUrls as $contactUrl) {
473		if (!$contactUrl->isForReservations()) {
474		$jsonLD->seeAlso[] = $contactUrl->getUrl();
475		}
476		}
477		}
478		}
479		}
480
481		/**
482		* @param \CultureFeed_Cdb_Item_Event $event
483		* @param SluggerInterface $slugger
484		* @param \stdClass $jsonLD
485		*/
486		private function importUitInVlaanderenReference(
487		\CultureFeed_Cdb_Item_Event $event,
488		SluggerInterface $slugger,
489		$jsonLD
490		) {
491
492		// Some events seem to not have a Dutch name, even though this is
493		// required. If there's no Dutch name, we just leave the slug empty as
494		// that seems to be the behaviour on http://m.uitinvlaanderen.be
495		if (isset($jsonLD->name['nl'])) {
496		$name = $jsonLD->name['nl'];
497		$slug = $slugger->slug($name);
498		} else {
499		$slug = '';
500		}
501
502		$reference = 'http://www.uitinvlaanderen.be/agenda/e/' . $slug . '/' . $event->getCdbId();
503
504
505		if (!property_exists($jsonLD, 'sameAs')) {
506		$jsonLD->sameAs = [];
507		}
508
509		if (!in_array($reference, $jsonLD->sameAs)) {
510		array_push($jsonLD->sameAs, $reference);
511		}
512		}
513
514		/**
515		* @param string $longDescription
516		* @param string $shortDescription
517		* @return bool
518		*/
519		private function longDescriptionStartsWithShortDescription(
520		$longDescription,
521		$shortDescription
522		) {
523		$longDescription = strip_tags(html_entity_decode($longDescription));
524
525		return 0 === strncmp($longDescription, $shortDescription, mb_strlen($shortDescription));
526		}
527		}
528

cultuurnet / udb3-php

Pull Request — master (#262)

longDescriptionStartsWithShortDescription() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like