Completed
Pull Request — master (#397)
by Kristof
03:55
created

Sapi3SearchQueryFactory   A

Complexity

Total Complexity 1

Size/Duplication

Total Lines 17
Duplicated Lines 52.94 %

Coupling/Cohesion

Components 0
Dependencies 2

Importance

Changes 0
Metric Value
wmc 1
lcom 0
cbo 2
dl 9
loc 17
rs 10
c 0
b 0
f 0

1 Method

Rating   Name   Duplication   Size   Complexity  
A createQueryString() 9 9 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace CultuurNet\UDB3\Offer\Security;
4
5
use CultuurNet\UDB3\ValueObject\SapiVersion;
6
use ValueObjects\StringLiteral\StringLiteral;
7
8
/**
9
 * Implementation of the search query factory for SAPI3.
10
 */
11
class Sapi3SearchQueryFactory extends SearchQueryFactoryBase
12
{
13
    /**
14
     * @param StringLiteral $constraint
15
     * @param StringLiteral $offerId
16
     * @return string
17
     */
18 View Code Duplication
    protected function createQueryString(
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
19
        StringLiteral $constraint,
20
        StringLiteral $offerId
21
    ) {
22
        $constraintStr = '(' . $constraint->toNative() . ')';
23
        $offerIdStr = $offerId->toNative();
24
25
        return '(' . $constraintStr . ' AND id:' . $offerIdStr . ')';
26
    }
27
}
28