Completed
Pull Request — master (#264)
by Kristof
04:49
created
src/Variations/ReadModel/JSONLD/Projector.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
         $variationLD = $variation->getBody();
72 72
         $language = 'nl';
73 73
 
74
-        $variationLD->description->$language = (string) $descriptionEdited->getDescription();
74
+        $variationLD->description->$language = (string)$descriptionEdited->getDescription();
75 75
         $this->repository->save($variation->withBody($variationLD));
76 76
     }
77 77
 
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 
146 146
         // overwrite the description that's already set in the variation
147 147
         if (!$variationLD->description) {
148
-            $variationLD->description = (object) [];
148
+            $variationLD->description = (object)[];
149 149
         }
150 150
         $variationLD->description->nl = (string)$eventVariationCreated->getDescription();
151 151
 
Please login to merge, or discard this patch.
src/Event/ExternalEventService.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,11 +4,9 @@
 block discarded – undo
4 4
 
5 5
 use Exception;
6 6
 use GuzzleHttp\Psr7\Request;
7
-use GuzzleHttp\Psr7\Response;
8 7
 use GuzzleHttp\Psr7\Uri;
9 8
 use Http\Client\Exception as HttpException;
10 9
 use Http\Client\HttpClient;
11
-use Psr\Http\Message\UriInterface;
12 10
 
13 11
 class ExternalEventService implements EventServiceInterface
14 12
 {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
             throw new EventNotFoundException();
42 42
         }
43 43
 
44
-        return (string) $response->getBody();
44
+        return (string)$response->getBody();
45 45
     }
46 46
 
47 47
     public function eventsOrganizedByOrganizer($organizerId)
Please login to merge, or discard this patch.
src/Event/LocalEventService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
      * @param string $id
37 37
      *   A string uniquely identifying an event.
38 38
      *
39
-     * @return array
39
+     * @return string
40 40
      *   An event array.
41 41
      *
42 42
      * @throws EventNotFoundException if an event can not be found for the given id
Please login to merge, or discard this patch.
src/Variations/VariationDecoratedEventService.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
 use CultuurNet\UDB3\Variations\Model\Properties\Url;
10 10
 use CultuurNet\UDB3\Variations\ReadModel\Search\Criteria;
11 11
 use CultuurNet\UDB3\Variations\ReadModel\Search\RepositoryInterface;
12
-use Doctrine\Instantiator\Exception\InvalidArgumentException;
13 12
 use ValueObjects\Exception\InvalidNativeArgumentException;
14 13
 
15 14
 class VariationDecoratedEventService implements EventServiceInterface
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
         // If the id is not a valid url we assume it points to the local installation and generate one ourselves.
69 69
         try {
70 70
             $validUrl = \ValueObjects\Web\Url::fromNative($id);
71
-            $url = new Url((string) $validUrl);
71
+            $url = new Url((string)$validUrl);
72 72
         } catch (InvalidNativeArgumentException $e) {
73 73
             $url = new Url(
74 74
                 $this->eventIriGenerator->iri($id)
Please login to merge, or discard this patch.
src/EventExport/Format/HTML/WebArchive/WebArchiveFileWriter.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -84,8 +84,8 @@  discard block
 block discarded – undo
84 84
             }
85 85
 
86 86
             $this->mountManager->copy(
87
-                $asset['filesystem'] . '://' . $asset['path'],
88
-                'tmp://' . $tmpDir . '/' . $asset['path']
87
+                $asset['filesystem'].'://'.$asset['path'],
88
+                'tmp://'.$tmpDir.'/'.$asset['path']
89 89
             );
90 90
         };
91 91
     }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
                 ),
104 104
                 // @todo make this configurable
105 105
                 'assets' => new Filesystem(
106
-                    new Local(__DIR__ . '/assets')
106
+                    new Local(__DIR__.'/assets')
107 107
                 ),
108 108
             ]
109 109
         );
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 
112 112
     protected function removeTemporaryArchiveDirectory($tmpDir)
113 113
     {
114
-        $this->mountManager->deleteDir('tmp://' . $tmpDir);
114
+        $this->mountManager->deleteDir('tmp://'.$tmpDir);
115 115
     }
116 116
 
117 117
     /**
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
     protected function createTemporaryArchiveDirectory()
123 123
     {
124 124
         $exportDir = uniqid('html-export');
125
-        $path = 'tmp://' . $exportDir;
125
+        $path = 'tmp://'.$exportDir;
126 126
         $this->mountManager->createDir($path);
127 127
 
128 128
         return $exportDir;
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
      */
137 137
     protected function expandTmpPath($tmpPath)
138 138
     {
139
-        return $this->tmpDir . '/' . $tmpPath;
139
+        return $this->tmpDir.'/'.$tmpPath;
140 140
     }
141 141
 
142 142
     /**
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
      */
146 146
     protected function writeHtml($dir, $events)
147 147
     {
148
-        $filePath = $dir . '/index.html';
148
+        $filePath = $dir.'/index.html';
149 149
 
150 150
         // TransformingIteratorIterator requires a Traversable,
151 151
         // so if $events is a regular array we need to wrap it
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 
159 159
         $formattedEvents = new TransformingIteratorIterator(
160 160
             $events,
161
-            function ($event, $eventLocation) use ($formatter) {
161
+            function($event, $eventLocation) use ($formatter) {
162 162
                 $urlParts = explode('/', $eventLocation);
163 163
                 $eventId = array_pop($urlParts);
164 164
                 return $formatter->formatEvent($eventId, $event);
Please login to merge, or discard this patch.
src/Label/Label.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@
 block discarded – undo
116 116
     }
117 117
 
118 118
     /**
119
-     * @return string
119
+     * @return UUID
120 120
      */
121 121
     public function getFileId()
122 122
     {
Please login to merge, or discard this patch.
src/EventSourcing/DBAL/UniqueConstraintException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
      */
12 12
     public function __construct($uuid, $unique)
13 13
     {
14
-        $message = 'Not unique: uuid = ' . $uuid . ', unique value = ' . $unique;
14
+        $message = 'Not unique: uuid = '.$uuid.', unique value = '.$unique;
15 15
         parent::__construct($message);
16 16
     }
17 17
 }
Please login to merge, or discard this patch.
src/Variations/OfferVariationCommandHandler.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
             $this->logger->info(
57 57
                 'job_info',
58 58
                 [
59
-                    'offer_variation_id' => (string) $editDescription->getId(),
59
+                    'offer_variation_id' => (string)$editDescription->getId(),
60 60
                 ]
61 61
             );
62 62
         }
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
             $this->logger->info(
71 71
                 'job_info',
72 72
                 [
73
-                    'offer_variation_id' => (string) $deleteEventVariation->getId()
73
+                    'offer_variation_id' => (string)$deleteEventVariation->getId()
74 74
                 ]
75 75
             );
76 76
         }
Please login to merge, or discard this patch.
src/Label/ReadModels/JSON/Repository/SimilaritySorter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
      */
14 14
     public function sort(array &$entities, StringLiteral $value)
15 15
     {
16
-        return usort($entities, function ($entity1, $entity2) use ($value) {
16
+        return usort($entities, function($entity1, $entity2) use ($value) {
17 17
             /** @var Entity $entity1 */
18 18
             $weight1 = $this->getWeight($entity1, $value);
19 19
 
Please login to merge, or discard this patch.