Completed
Pull Request — master (#264)
by Kristof
04:49
created
src/SavedSearches/UiTIDSavedSearchRepository.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
     {
77 77
         $name = new String($savedSearch->name);
78 78
         $query = QueryString::fromURLQueryString($savedSearch->query);
79
-        $id = new String((string) $savedSearch->id);
79
+        $id = new String((string)$savedSearch->id);
80 80
 
81 81
         return new SavedSearch($name, $query, $id);
82 82
     }
@@ -86,8 +86,8 @@  discard block
 block discarded – undo
86 86
      */
87 87
     public function write(String $userId, String $name, QueryString $queryString)
88 88
     {
89
-        $userId = (string) $userId;
90
-        $name = (string) $name;
89
+        $userId = (string)$userId;
90
+        $name = (string)$name;
91 91
         $query = $queryString->toURLQueryString();
92 92
 
93 93
         $savedSearch = new \CultureFeed_SavedSearches_SavedSearch(
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
                         'error' => $exception->getMessage(),
108 108
                         'userId' => $userId,
109 109
                         'name' => $name,
110
-                        'query' => (string) $queryString,
110
+                        'query' => (string)$queryString,
111 111
                     ]
112 112
                 );
113 113
             }
@@ -119,8 +119,8 @@  discard block
 block discarded – undo
119 119
      */
120 120
     public function delete(String $userId, String $searchId)
121 121
     {
122
-        $userId = (string) $userId;
123
-        $searchId = (string) $searchId;
122
+        $userId = (string)$userId;
123
+        $searchId = (string)$searchId;
124 124
 
125 125
         try {
126 126
             $this->savedSearches->unsubscribe($searchId, $userId);
Please login to merge, or discard this patch.
src/SluggerInterface.php 1 patch
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -13,11 +13,11 @@
 block discarded – undo
13 13
 interface SluggerInterface
14 14
 {
15 15
     /**
16
-    * Returns the slug for a given string
17
-    *
18
-    * @param string $string
19
-    *
20
-    * @return string
21
-    **/
16
+     * Returns the slug for a given string
17
+     *
18
+     * @param string $string
19
+     *
20
+     * @return string
21
+     **/
22 22
     public function slug($string);
23 23
 }
Please login to merge, or discard this patch.
src/Variations/Command/EditDescriptionJSONDeserializer.php 3 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@
 block discarded – undo
96 96
     private function getErrorMessages($validationErrors)
97 97
     {
98 98
         $errorMessages = array_map(
99
-            function ($error) {
99
+            function($error) {
100 100
                 return $error['message'];
101 101
             },
102 102
             $validationErrors
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
 use CultuurNet\UDB3\Variations\Model\Properties\Description;
10 10
 use CultuurNet\UDB3\Variations\Model\Properties\Id;
11 11
 use JsonSchema\Validator;
12
-use ValueObjects\String\String;
13 12
 use stdClass;
14 13
 
15 14
 class EditDescriptionJSONDeserializer extends JSONDeserializer
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
     }
71 71
 
72 72
     /**
73
-     * @param mixed $json
73
+     * @param stdClass $json
74 74
      *
75 75
      * @throws ValidationException
76 76
      */
Please login to merge, or discard this patch.
src/Variations/Model/Events/DescriptionEdited.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
     public function serialize()
40 40
     {
41 41
         return parent::serialize() + array(
42
-            'description' => (string) $this->description,
42
+            'description' => (string)$this->description,
43 43
         );
44 44
     }
45 45
 
Please login to merge, or discard this patch.
src/EventExport/Format/HTML/PDF/PDFWebArchiveFileFormat.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
     /**
17 17
      * @param string $brand
18 18
      * @param string $title
19
-     * @param string|null $subtitle
19
+     * @param string|null $subTitle
20 20
      * @param string|null $footer
21 21
      * @param string|null $publisher
22 22
      * @param EventInfoServiceInterface|null $uitpas
Please login to merge, or discard this patch.
src/Event/ReadModel/JSONLD/Specifications/Labelable.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
 {
9 9
 
10 10
     /**
11
-     * @param $eventLd
11
+     * @param \stdClass $eventLd
12 12
      * @return bool
13 13
      */
14 14
     public function hasLabel($eventLd, String $label)
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace CultuurNet\UDB3\Event\ReadModel\JSONLD\Specifications;
4 4
 
5
-use ValueObjects\String\String;
6
-
7 5
 trait Labelable
8 6
 {
9 7
 
Please login to merge, or discard this patch.
src/SearchAPI2/Filters/DoesNotHaveKeyword.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
 
14 14
     public function __construct($keyword)
15 15
     {
16
-        $keyword = (string) $keyword;
16
+        $keyword = (string)$keyword;
17 17
 
18 18
         $this->filterQuery = new FilterQuery(
19 19
             sprintf(
Please login to merge, or discard this patch.
src/EventExport/EventExportService.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -209,7 +209,7 @@
 block discarded – undo
209 209
      * Generator that yields each unique search result.
210 210
      *
211 211
      * @param int $totalItemCount
212
-     * @param string|object $query
212
+     * @param EventExportQuery $query
213 213
      * @param LoggerInterface $logger
214 214
      *
215 215
      * @return \Generator
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
 
158 158
             if (!$moved) {
159 159
                 throw new \RuntimeException(
160
-                    'Unable to move export file to public directory ' .
160
+                    'Unable to move export file to public directory '.
161 161
                     $this->publicDirectory
162 162
                 );
163 163
             }
@@ -244,8 +244,8 @@  discard block
 block discarded – undo
244 244
     ) {
245 245
         $fileUniqueId = basename($tmpPath);
246 246
         $extension = $fileFormat->getFileNameExtension();
247
-        $finalFileName = $fileUniqueId . '.' . $extension;
248
-        $finalPath = $this->publicDirectory . '/' . $finalFileName;
247
+        $finalFileName = $fileUniqueId.'.'.$extension;
248
+        $finalPath = $this->publicDirectory.'/'.$finalFileName;
249 249
 
250 250
         return $finalPath;
251 251
     }
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
         var_dump($events);
265 265
 
266 266
         foreach ($events as $eventIdentifier) {
267
-            $event = $this->getEvent((string) $eventIdentifier->getIri(), $logger);
267
+            $event = $this->getEvent((string)$eventIdentifier->getIri(), $logger);
268 268
 
269 269
             if ($event) {
270 270
                 yield $eventIdentifier->getId() => $event;
Please login to merge, or discard this patch.
src/Media/Image.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -109,11 +109,11 @@
 block discarded – undo
109 109
     public function serialize()
110 110
     {
111 111
         return [
112
-            'media_object_id' => (string) $this->getMediaObjectId(),
113
-            'mime_type' => (string) $this->getMimeType(),
114
-            'description' => (string) $this->getDescription(),
115
-            'copyright_holder' => (string) $this->getCopyrightHolder(),
116
-            'source_location' => (string) $this->getSourceLocation()
112
+            'media_object_id' => (string)$this->getMediaObjectId(),
113
+            'mime_type' => (string)$this->getMimeType(),
114
+            'description' => (string)$this->getDescription(),
115
+            'copyright_holder' => (string)$this->getCopyrightHolder(),
116
+            'source_location' => (string)$this->getSourceLocation()
117 117
         ];
118 118
     }
119 119
 }
Please login to merge, or discard this patch.