Completed
Pull Request — master (#264)
by Kristof
04:49
created
src/StringFilter/StripNewlineStringFilter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
     public function filter($string)
12 12
     {
13 13
         if (!is_string($string)) {
14
-            throw new \InvalidArgumentException('Argument should be string, got ' . gettype($string) . ' instead.');
14
+            throw new \InvalidArgumentException('Argument should be string, got '.gettype($string).' instead.');
15 15
         }
16 16
 
17 17
         return preg_replace("/(\\n)+/", " ", $string);
Please login to merge, or discard this patch.
src/StringFilter/StripLeadingSpaceStringFilter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
     public function filter($string)
12 12
     {
13 13
         if (!is_string($string)) {
14
-            throw new \InvalidArgumentException('Argument should be string, got ' . gettype($string) . ' instead.');
14
+            throw new \InvalidArgumentException('Argument should be string, got '.gettype($string).' instead.');
15 15
         }
16 16
 
17 17
         return preg_replace("/(\\n)+/", " ", $string);
Please login to merge, or discard this patch.
src/OpeningHours.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
 
14 14
     /**
15 15
      * OpeningHours constructor.
16
-     * @param OpeningHour[]|null $openingHours
16
+     * @param OpeningHour[] $openingHours
17 17
      */
18 18
     public function __construct(array $openingHours = null)
19 19
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace CultuurNet\UDB3;
4 4
 
5
-use ValueObjects\DateTime\WeekDay;
6
-
7 5
 class OpeningHours
8 6
 {
9 7
     /**
Please login to merge, or discard this patch.
src/StringFilter/StripSourceStringFilter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
     public function filter($string)
12 12
     {
13 13
         if (!is_string($string)) {
14
-            throw new \InvalidArgumentException('Argument should be string, got ' . gettype($string) . ' instead.');
14
+            throw new \InvalidArgumentException('Argument should be string, got '.gettype($string).' instead.');
15 15
         }
16 16
 
17 17
         return preg_replace("/(\\n)+/", " ", $string);
Please login to merge, or discard this patch.
src/Label/ReadModels/Relations/Projector.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 
186 186
         foreach ($labelCollection->asArray() as $label) {
187 187
             $this->writeRepository->save(
188
-                new LabelName((string) $label),
188
+                new LabelName((string)$label),
189 189
                 $relationType,
190 190
                 $relationId
191 191
             );
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
     {
201 201
         $labelRelation = null;
202 202
 
203
-        $labelName = new LabelName((string) $labelEvent->getLabel());
203
+        $labelName = new LabelName((string)$labelEvent->getLabel());
204 204
         $relationType = $this->offerTypeResolver->getRelationType($labelEvent);
205 205
         $relationId = new StringLiteral($labelEvent->getItemId());
206 206
 
Please login to merge, or discard this patch.
src/LabelImporter.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,13 +15,13 @@
 block discarded – undo
15 15
         );
16 16
 
17 17
         $visibleLabels = $labelCollection->filter(
18
-            function (Label $label) {
18
+            function(Label $label) {
19 19
                 return $label->isVisible();
20 20
             }
21 21
         )->toStrings();
22 22
 
23 23
         $hiddenLabels = $labelCollection->filter(
24
-            function (Label $label) {
24
+            function(Label $label) {
25 25
                 return !$label->isVisible();
26 26
             }
27 27
         )->toStrings();
Please login to merge, or discard this patch.
src/CalendarFactory.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -36,14 +36,14 @@  discard block
 block discarded – undo
36 36
         if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_PeriodList) {
37 37
             /** @var \CultureFeed_Cdb_Data_Calendar_Period $period */
38 38
             $period = $cdbCalendar->current();
39
-            $startDateString = $period->getDateFrom() . 'T00:00:00';
39
+            $startDateString = $period->getDateFrom().'T00:00:00';
40 40
         } else if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_TimestampList) {
41 41
             /** @var \CultureFeed_Cdb_Data_Calendar_Timestamp $timestamp */
42 42
             $timestamp = $cdbCalendar->current();
43 43
             if ($timestamp->getStartTime()) {
44
-                $startDateString = $timestamp->getDate() . 'T' . $timestamp->getStartTime();
44
+                $startDateString = $timestamp->getDate().'T'.$timestamp->getStartTime();
45 45
             } else {
46
-                $startDateString = $timestamp->getDate() . 'T00:00:00';
46
+                $startDateString = $timestamp->getDate().'T00:00:00';
47 47
             }
48 48
         }
49 49
         $startDate = !empty($startDateString) ? DateTimeFactory::dateTimeFromDateString($startDateString) : null;
@@ -56,17 +56,17 @@  discard block
 block discarded – undo
56 56
         if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_PeriodList) {
57 57
             /** @var \CultureFeed_Cdb_Data_Calendar_Period $period */
58 58
             $period = $cdbCalendar->current();
59
-            $endDateString = $period->getDateTo() . 'T00:00:00';
59
+            $endDateString = $period->getDateTo().'T00:00:00';
60 60
         } else if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_TimestampList) {
61 61
             $firstTimestamp = $cdbCalendar->current();
62 62
             /** @var \CultureFeed_Cdb_Data_Calendar_Timestamp $timestamp */
63 63
             $cdbCalendarAsArray = iterator_to_array($cdbCalendar);
64 64
             $timestamp = iterator_count($cdbCalendar) > 1 ? end($cdbCalendarAsArray) : $firstTimestamp;
65 65
             if ($timestamp->getEndTime()) {
66
-                $endDateString = $timestamp->getDate() . 'T' . $timestamp->getEndTime();
66
+                $endDateString = $timestamp->getDate().'T'.$timestamp->getEndTime();
67 67
             } else {
68 68
                 $endTime = $timestamp->getStartTime() ? $timestamp->getStartTime() : '00:00:00';
69
-                $endDateString = $timestamp->getDate() . 'T' . $endTime;
69
+                $endDateString = $timestamp->getDate().'T'.$endTime;
70 70
             }
71 71
         }
72 72
         $endDate = !empty($endDateString) ? DateTimeFactory::dateTimeFromDateString($endDateString) : null;
@@ -83,12 +83,12 @@  discard block
 block discarded – undo
83 83
                 $cdbCalendar->next();
84 84
 
85 85
                 $startTime = $timestamp->getStartTime() ? $timestamp->getStartTime() : '00:00:00';
86
-                $startDateString = $timestamp->getDate() . 'T' . $startTime;
86
+                $startDateString = $timestamp->getDate().'T'.$startTime;
87 87
 
88 88
                 if ($timestamp->getEndTime()) {
89
-                    $endDateString = $timestamp->getDate() . 'T' . $timestamp->getEndTime();
89
+                    $endDateString = $timestamp->getDate().'T'.$timestamp->getEndTime();
90 90
                 } else {
91
-                    $endDateString = $timestamp->getDate() . 'T' . $startTime;
91
+                    $endDateString = $timestamp->getDate().'T'.$startTime;
92 92
                 }
93 93
 
94 94
                 $timestamps[] = new Timestamp(
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
             $openingHour = $mergedOpeningHour->getOpeningHours()[0];
203 203
             $openingHoursAsArray[] = [
204 204
                 'dayOfWeek' => array_map(
205
-                    function (WeekDay $weekDay) {
205
+                    function(WeekDay $weekDay) {
206 206
                         return strtolower($weekDay->toNative());
207 207
                     },
208 208
                     $mergedOpeningHour->getWeekDays()
Please login to merge, or discard this patch.
src/Offer/Offer.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
     {
270 270
         $equalImages = array_filter(
271 271
             $this->mediaObjects,
272
-            function ($existingMediaObjectId) use ($image) {
272
+            function($existingMediaObjectId) use ($image) {
273 273
                 return $image
274 274
                     ->getMediaObjectId()
275 275
                     ->sameValueAs($existingMediaObjectId);
@@ -444,7 +444,7 @@  discard block
 block discarded – undo
444 444
             if ($this->rejectedReason && $reason->sameValueAs($this->rejectedReason)) {
445 445
                 return true; // nothing left to do if the offer has already been rejected for the same reason
446 446
             } else {
447
-                throw new Exception('The offer has already been rejected for another reason: ' . $this->rejectedReason);
447
+                throw new Exception('The offer has already been rejected for another reason: '.$this->rejectedReason);
448 448
             }
449 449
         }
450 450
 
@@ -586,7 +586,7 @@  discard block
 block discarded – undo
586 586
         $this->mainImageId = $mainImage ? $mainImage->getMediaObjectId() : null;
587 587
 
588 588
         $this->mediaObjects = array_map(
589
-            function (Image $image) {
589
+            function(Image $image) {
590 590
                 return $image->getMediaObjectId();
591 591
             },
592 592
             $imagesEvent->getImages()->toArray()
Please login to merge, or discard this patch.
src/Media/MediaManager.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -76,11 +76,11 @@  discard block
 block discarded – undo
76 76
     ) {
77 77
         try {
78 78
             $existingMediaObject = $this->repository->load($id);
79
-            $this->logger->info('Trying to create media with id: ' .$id . ' but it already exists. Using existing Media Object!');
79
+            $this->logger->info('Trying to create media with id: '.$id.' but it already exists. Using existing Media Object!');
80 80
 
81 81
             return $existingMediaObject;
82 82
         } catch (AggregateNotFoundException $exception) {
83
-            $this->logger->info('No existing media with id: ' .$id . ' found. Creating a new Media Object!');
83
+            $this->logger->info('No existing media with id: '.$id.' found. Creating a new Media Object!');
84 84
         }
85 85
 
86 86
         $mediaObject = MediaObject::create(
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 
115 115
         $this->filesystem->rename(
116 116
             $uploadImage->getFilePath(),
117
-            $this->mediaDirectory . '/' . $destinationPath
117
+            $this->mediaDirectory.'/'.$destinationPath
118 118
         );
119 119
 
120 120
         $this->create(
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
             Url::fromNative($destinationIri)
126 126
         );
127 127
 
128
-        $jobInfo = ['file_id' => (string) $uploadImage->getFileId()];
128
+        $jobInfo = ['file_id' => (string)$uploadImage->getFileId()];
129 129
         $this->logger->info('job_info', $jobInfo);
130 130
     }
131 131
 
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
     public function get(UUID $fileId)
136 136
     {
137 137
         try {
138
-            $mediaObject = $this->repository->load((string) $fileId);
138
+            $mediaObject = $this->repository->load((string)$fileId);
139 139
         } catch (AggregateNotFoundException $e) {
140 140
             throw new MediaObjectNotFoundException(
141 141
                 sprintf("Media object with id '%s' not found", $fileId),
@@ -159,8 +159,8 @@  discard block
 block discarded – undo
159 159
         $image = new Image(
160 160
             $mediaObject->getMediaObjectId(),
161 161
             $mediaObject->getMimeType(),
162
-            new Description((string) $mediaObject->getDescription()),
163
-            new CopyrightHolder((string) $mediaObject->getCopyrightHolder()),
162
+            new Description((string)$mediaObject->getDescription()),
163
+            new CopyrightHolder((string)$mediaObject->getCopyrightHolder()),
164 164
             $mediaObject->getSourceLocation()
165 165
         );
166 166
 
Please login to merge, or discard this patch.