EventThemeResolver::__construct() - Code Metrics - Inspection of "III-2307: Offer type and theme updates" - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#328)

unknown

created 2017-09-05 09:11 UTC

EventThemeResolver::__construct() B

↳ Parent: EventThemeResolver

Complexity

Conditions	3
Paths	1

Size

Total Lines	589
Code Lines	304

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	589
rs	8.2857
c	0
b	0
f	0
cc	3
eloc	304
nc	1
nop	0

How to fix Long Method

1		<?php
2
3		namespace CultuurNet\UDB3\Event;
4
5		use CultuurNet\UDB3\Offer\ThemeResolverInterface;
6		use CultuurNet\UDB3\Theme;
7		use ValueObjects\StringLiteral\StringLiteral;
8
9		class EventThemeResolver implements ThemeResolverInterface
10		{
11		/**
12		* @var Theme[]
13		*/
14		private $themes;
15
16		public function __construct()
17		{
18		$themePerType = [
19		[
20		"label" => "Begeleide rondleiding",
21		"id" => "0.7.0.0.0",
22		"primary" => true,
23		"themes" => [
24		[
25		"id" => "1.2.1.0.0",
26		"label" => "Architectuur",
27		],
28		[
29		"id" => "1.11.0.0.0",
30		"label" => "Geschiedenis",
31		],
32		[
33		"id" => "1.0.9.0.0",
34		"label" => "Meerdere kunstvormen",
35		],
36		[
37		"id" => "1.64.0.0.0",
38		"label" => "Milieu en natuur",
39		],
40		[
41		"id" => "1.37.2.0.0",
42		"label" => "Samenleving",
43		],
44		[
45		"id" => "1.44.0.0.0",
46		"label" => "Zingeving, filosofie en religie",
47		],
48		],
49		],
50		[
51		"label" => "Concert",
52		"id" => "0.50.4.0.0",
53		"primary" => true,
54		"themes" => [
55		[
56		"id" => "1.8.1.0.0",
57		"label" => "Klassieke muziek",
58		],
59		[
60		"id" => "1.8.2.0.0",
61		"label" => "Jazz en blues",
62		],
63		[
64		"id" => "1.8.3.1.0",
65		"label" => "Pop en rock",
66		],
67		[
68		"id" => "1.8.3.2.0",
69		"label" => "Hip hop, rnb en rap",
70		],
71		[
72		"id" => "1.8.3.3.0",
73		"label" => "Dance",
74		],
75		[
76		"id" => "1.8.4.0.0",
77		"label" => "Folk en wereldmuziek",
78		],
79		[
80		"id" => "1.8.3.5.0",
81		"label" => "Amusementsmuziek",
82		],
83		],
84		],
85		[
86		"label" => "Cursus of workshop",
87		"id" => "0.3.1.0.0",
88		"primary" => true,
89		"themes" => [
90		[
91		"id" => "1.42.0.0.0",
92		"label" => "Creativiteit",
93		],
94		[
95		"id" => "1.21.0.0.0",
96		"label" => "Computer en techniek",
97		],
98		[
99		"id" => "1.37.0.0.0",
100		"label" => "Opvoeding",
101		],
102		[
103		"id" => "1.61.0.0.0",
104		"label" => "Persoon en relaties",
105		],
106		[
107		"id" => "1.43.0.0.0",
108		"label" => "Interculturele vorming",
109		],
110		[
111		"id" => "1.41.0.0.0",
112		"label" => "Kunst en kunsteducatie",
113		],
114		[
115		"id" => "1.37.1.0.0",
116		"label" => "Gezondheid en zorg",
117		],
118		[
119		"id" => "1.65.0.0.0",
120		"label" => "Voeding",
121		],
122		[
123		"id" => "1.37.2.0.0",
124		"label" => "Samenleving",
125		],
126		[
127		"id" => "1.64.0.0.0",
128		"label" => "Milieu en natuur",
129		],
130		[
131		"id" => "1.25.0.0.0",
132		"label" => "Wetenschap",
133		],
134		[
135		"id" => "1.44.0.0.0",
136		"label" => "Zingeving, filosofie en religie",
137		],
138		],
139		],
140		[
141		"label" => "Route",
142		"id" => "0.17.0.0.0",
143		"primary" => true,
144		],
145		[
146		"label" => "Film",
147		"id" => "0.50.6.0.0",
148		"primary" => true,
149		"themes" => [
150		[
151		"id" => "1.7.2.0.0",
152		"label" => "Actie en avontuur",
153		],
154		[
155		"id" => "1.7.12.0.0",
156		"label" => "Animatie en kinderfilms",
157		],
158		[
159		"id" => "1.7.1.0.0",
160		"label" => "Documentaires en reportages",
161		],
162		[
163		"id" => "1.7.6.0.0",
164		"label" => "Griezelfilm of horror",
165		],
166		[
167		"id" => "1.7.8.0.0",
168		"label" => "Historische film",
169		],
170		[
171		"id" => "1.7.3.0.0",
172		"label" => "Komedie",
173		],
174		[
175		"id" => "1.7.13.0.0",
176		"label" => "Kortfilm",
177		],
178		[
179		"id" => "1.7.10.0.0",
180		"label" => "Filmmusical",
181		],
182		[
183		"id" => "1.7.4.0.0",
184		"label" => "Drama",
185		],
186		[
187		"id" => "1.7.7.0.0",
188		"label" => "Science fiction",
189		],
190		[
191		"id" => "1.7.11.0.0",
192		"label" => "Cinefiel",
193		],
194		[
195		"id" => "1.7.15.0.0",
196		"label" => "Thriller",
197		],
198		],
199		],
200		[
201		"label" => "Lezing of congres",
202		"id" => "0.3.2.0.0",
203		"primary" => "false",
204		"themes" => [
205		[
206		"id" => "1.21.0.0.0",
207		"label" => "Computer en techniek",
208		],
209		[
210		"id" => "1.42.0.0.0",
211		"label" => "Creativiteit",
212		],
213		[
214		"id" => "1.11.0.0.0",
215		"label" => "Geschiedenis",
216		],
217		[
218		"id" => "1.37.1.0.0",
219		"label" => "Gezondheid en zorg",
220		],
221		[
222		"id" => "1.41.0.0.0",
223		"label" => "Kunst en kunsteducatie",
224		],
225		[
226		"id" => "1.10.0.0.0",
227		"label" => "Literatuur",
228		],
229		[
230		"id" => "1.64.0.0.0",
231		"label" => "Milieu en natuur",
232		],
233		[
234		"id" => "1.37.0.0.0",
235		"label" => "Opvoeding",
236		],
237		[
238		"id" => "1.61.0.0.0",
239		"label" => "Persoon en relaties",
240		],
241		[
242		"id" => "1.37.2.0.0",
243		"label" => "Samenleving",
244		],
245		[
246		"id" => "1.25.0.0.0",
247		"label" => "Wetenschap",
248		],
249		[
250		"id" => "1.44.0.0.0",
251		"label" => "Zingeving, filosofie en religie",
252		],
253		],
254		],
255		[
256		"label" => "Opendeurdag",
257		"id" => "0.12.0.0.0",
258		"primary" => true,
259		],
260		[
261		"label" => "Tentoonstelling",
262		"id" => "0.0.0.0.0",
263		"primary" => true,
264		"themes" => [
265		[
266		"id" => "1.1.0.0.0",
267		"label" => "Audiovisuele kunst",
268		],
269		[
270		"id" => "1.0.2.0.0",
271		"label" => "Beeldhouwkunst",
272		],
273		[
274		"id" => "1.0.5.0.0",
275		"label" => "Decoratieve kunst",
276		],
277		[
278		"id" => "1.0.6.0.0",
279		"label" => "Fotografie",
280		],
281		[
282		"id" => "1.11.0.0.0",
283		"label" => "Geschiedenis",
284		],
285		[
286		"id" => "1.0.4.0.0",
287		"label" => "Grafiek",
288		],
289		[
290		"id" => "1.0.3.0.0",
291		"label" => "Installatiekunst",
292		],
293		[
294		"id" => "1.0.9.0.0",
295		"label" => "Meerdere kunstvormen",
296		],
297		[
298		"id" => "1.37.2.0.0",
299		"label" => "Samenleving",
300		],
301		[
302		"id" => "1.0.1.0.0",
303		"label" => "Schilderkunst",
304		],
305		],
306		],
307		[
308		"label" => "Beurs",
309		"id" => "0.6.0.0.0",
310		"primary" => false,
311		"themes" => [
312		[
313		"id" => "1.17.0.0.0",
314		"label" => "Antiek en brocante",
315		],
316		[
317		"id" => "1.62.0.0.0",
318		"label" => "Gezondheid en wellness",
319		],
320		[
321		"id" => "1.10.0.0.0",
322		"label" => "Literatuur",
323		],
324		[
325		"id" => "1.0.9.0.0",
326		"label" => "Meerdere kunstvormen",
327		],
328		[
329		"id" => "1.37.2.0.0",
330		"label" => "Samenleving",
331		],
332		[
333		"id" => "1.25.0.0.0",
334		"label" => "Wetenschap",
335		],
336		],
337		],
338		[
339		"label" => "Dansvoorstelling",
340		"id" => "0.54.0.0.0",
341		"primary" => false,
342		"themes" => [
343		[
344		"id" => "1.9.1.0.0",
345		"label" => "Ballet en klassieke dans",
346		],
347		[
348		"id" => "1.9.3.0.0",
349		"label" => "Volksdans en werelddans",
350		],
351		[
352		"id" => "1.9.5.0.0",
353		"label" => "Stijl en salondansen",
354		],
355		[
356		"id" => "1.9.2.0.0",
357		"label" => "Moderne dans",
358		],
359		],
360		],
361		[
362		"label" => "Eten en drinken",
363		"id" => "1.50.0.0.0",
364		"primary" => false,
365		],
366		[
367		"label" => "Festival",
368		"id" => "0.5.0.0.0",
369		"primary" => false,
370		"themes" => [
371		[
372		"id" => "1.8.3.5.0",
373		"label" => "Amusementsmuziek",
374		],
375		[
376		"id" => "0.52.0.0.0",
377		"label" => "Circus",
378		],
379		[
380		"id" => "1.8.3.3.0",
381		"label" => "Dance",
382		],
383		[
384		"id" => "1.8.4.0.0",
385		"label" => "Folk en wereldmuziek",
386		],
387		[
388		"id" => "1.3.10.0.0",
389		"label" => "Humor en comedy",
390		],
391		[
392		"id" => "1.8.2.0.0",
393		"label" => "Jazz en blues",
394		],
395		[
396		"id" => "1.8.1.0.0",
397		"label" => "Klassieke muziek",
398		],
399		[
400		"id" => "1.10.0.0.0",
401		"label" => "Literatuur",
402		],
403		[
404		"id" => "1.7.14.0.0",
405		"label" => "Meerdere filmgenres",
406		],
407		[
408		"id" => "1.0.9.0.0",
409		"label" => "Meerdere kunstvormen",
410		],
411		[
412		"id" => "1.8.3.1.0",
413		"label" => "Pop en rock",
414		],
415		[
416		"id" => "1.37.2.0.0",
417		"label" => "Samenleving",
418		],
419		[
420		"id" => "1.3.1.0.0",
421		"label" => "Tekst- en muziektheater",
422		],
423		],
424		],
425		[
426		"label" => "Kamp of vakantie",
427		"id" => "0.57.0.0.0",
428		"primary" => false,
429		],
430		[
431		"label" => "Kermis of feestelijkheid",
432		"id" => "0.28.0.0.0",
433		"primary" => false,
434		],
435		[
436		"label" => "Markt of braderie",
437		"id" => "0.37.0.0.0",
438		"primary" => false,
439		"themes" => [
440		[
441		"id" => "1.17.0.0.0",
442		"label" => "Antiek en brocante",
443		],
444		[
445		"id" => "1.62.0.0.0",
446		"label" => "Gezondheid en wellness",
447		],
448		[
449		"id" => "1.10.0.0.0",
450		"label" => "Literatuur",
451		],
452		[
453		"id" => "1.0.9.0.0",
454		"label" => "Meerdere kunstvormen",
455		],
456		[
457		"id" => "1.64.0.0.0",
458		"label" => "Milieu en natuur",
459		],
460		[
461		"id" => "1.37.2.0.0",
462		"label" => "Samenleving",
463		],
464		],
465		],
466		[
467		"label" => "Party of fuif",
468		"id" => "0.49.0.0.0",
469		"primary" => false,
470		],
471		[
472		"label" => "Spel of quiz",
473		"id" => "0.50.21.0.0",
474		"primary" => false,
475		],
476		[
477		"label" => "Sport en beweging",
478		"id" => "0.59.0.0.0",
479		"primary" => false,
480		"themes" => [
481		[
482		"id" => "1.51.13.0.0",
483		"label" => "Bal en racketsport",
484		],
485		[
486		"id" => "1.51.14.0.0",
487		"label" => "Atletiek, wandelen en fietsen",
488		],
489		[
490		"id" => "1.51.3.0.0",
491		"label" => "Zwemmen en watersport",
492		],
493		[
494		"id" => "1.51.6.0.0",
495		"label" => "Fitness, gymnastiek, dans en vechtsport",
496		],
497		[
498		"id" => "1.51.11.0.0",
499		"label" => "Outdoor en adventure",
500		],
501		[
502		"id" => "1.58.8.0.0",
503		"label" => "Lucht en motorsport",
504		],
505		[
506		"id" => "1.51.10.0.0",
507		"label" => "Volkssporten",
508		],
509		[
510		"id" => "1.51.12.0.0",
511		"label" => "Omnisport en andere",
512		],
513		],
514		],
515		[
516		"label" => "Sportwedstrijd bekijken",
517		"id" => "0.19.0.0.0",
518		"primary" => false,
519		"themes" => [
520		[
521		"id" => "1.51.14.0.0",
522		"label" => "Atletiek, wandelen en fietsen",
523		],
524		[
525		"id" => "1.51.13.0.0",
526		"label" => "Bal en racketsport",
527		],
528		[
529		"id" => "1.51.6.0.0",
530		"label" => "Fitness, gymnastiek, dans en vechtsport",
531		],
532		[
533		"id" => "1.58.8.0.0",
534		"label" => "Lucht en motorsport",
535		],
536		[
537		"id" => "1.51.12.0.0",
538		"label" => "Omnisport en andere",
539		],
540		[
541		"id" => "1.51.11.0.0",
542		"label" => "Outdoor en adventure",
543		],
544		[
545		"id" => "1.51.10.0.0",
546		"label" => "Volkssporten",
547		],
548		[
549		"id" => "1.51.3.0.0",
550		"label" => "Zwemmen en watersport",
551		],
552		],
553		],
554		[
555		"label" => "Theatervoorstelling",
556		"id" => "0.55.0.0.0",
557		"primary" => false,
558		"themes" => [
559		[
560		"id" => "0.52.0.0.0",
561		"label" => "Circus",
562		],
563		[
564		"id" => "1.3.1.0.0",
565		"label" => "Tekst en muziektheater",
566		],
567		[
568		"id" => "1.3.10.0.0",
569		"label" => "Humor comedy",
570		],
571		[
572		"id" => "1.4.0.0.0",
573		"label" => "Musical",
574		],
575		[
576		"id" => "1.3.5.0.0",
577		"label" => "Figuren en poppentheater",
578		],
579		[
580		"id" => "1.5.0.0.0",
581		"label" => "Opera en operette",
582		],
583		[
584		"id" => "1.3.4.0.0",
585		"label" => "Mime en bewegingstheater",
586		],
587		],
588		],
589		];
590
591		$this->themes = array_reduce(
		0 ignored issues – show Documentation Bug introduced 2017-09-05 09:18 UTC by Report Bug Copy Issue Report It seems like `array_reduce($themePerTy...rn $themes; }, array())` of type `*` is incompatible with the declared type `array<integer,object<CultuurNet\UDB3\Theme>>` of property `$themes`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
592		$themePerType,
593		function ($themes, array $type) {
594		if (array_key_exists('themes', $type)) {
595		foreach ($type['themes'] as $themeData) {
596		$themes[$themeData['id']] = new Theme($themeData['id'], $themeData['label']);
597		}
598		}
599
600		return $themes;
601		},
602		[]
603		);
604		}
605
606	View Code Duplication	public function byId(StringLiteral $themeId)
		0 ignored issues – show Duplication introduced 2017-09-05 09:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
607		{
608		if (!array_key_exists((string) $themeId, $this->themes)) {
609		throw new \Exception("Unknown event theme id: " . $themeId);
610		}
611		return $this->themes[(string) $themeId];
612		}
613		}
614

cultuurnet / udb3-php

Pull Request — master (#328)

EventThemeResolver::__construct() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like