OfferCommandHandler - Code Metrics - Inspection of "III-2307: Offer type and theme updates" - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#328)

unknown

created 2017-09-05 09:11 UTC

OfferCommandHandler D

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	524
Duplicated Lines	5.53 %

Coupling/Cohesion

Components	1
Dependencies	31

Importance

Changes

Metric	Value
wmc	34
lcom	1
cbo	31
dl	29
loc	524
rs	4.6
c	0
b	0
f	0

54 Methods

Rating	Name	Duplication	Size	Complexity
	getAddImageClassName()	0	1	?
	getUpdateImageClassName()	0	1	?
	getRemoveImageClassName()	0	1	?
	getSelectMainImageClassName()	0	1	?
	getUpdateDescriptionClassName()	0	1	?
A	__construct()	0	9	1
A	handle()	0	12	2
A	getCommandHandlers()	19	19	4
	getAddLabelClassName()	0	1	?
	getRemoveLabelClassName()	0	1	?
	getUpdateTitleClassName()	0	1	?
	getUpdateCalendarClassName()	0	1	?
	getUpdateTypicalAgeRangeClassName()	0	1	?
	getDeleteTypicalAgeRangeClassName()	0	1	?
	getUpdateOrganizerClassName()	0	1	?
	getDeleteOrganizerClassName()	0	1	?
	getUpdateContactPointClassName()	0	1	?
	getUpdateBookingInfoClassName()	0	1	?
	getUpdatePriceInfoClassName()	0	1	?
	getDeleteOfferClassName()	0	1	?
	getPublishClassName()	0	1	?
	getApproveClassName()	0	1	?
	getRejectClassName()	0	1	?
	getFlagAsDuplicateClassName()	0	1	?
	getFlagAsInappropriateClassName()	0	1	?
	getUpdateTypeClassName()	0	1	?
	getUpdateThemeClassName()	0	1	?
A	handleUpdateType()	0	8	1
A	handleUpdateTheme()	0	8	1
A	handleAddLabel()	0	8	1
A	handleRemoveLabel()	0	8	1
A	createLabel()	10	10	1
A	handleUpdateTitle()	0	6	1
A	handleAddImage()	0	6	1
A	handleRemoveImage()	0	6	1
A	handleUpdateImage()	0	6	1
A	handleSelectMainImage()	0	6	1
A	handleUpdateDescription()	0	12	1
A	handleUpdateCalendar()	0	8	1
A	handleUpdateTypicalAgeRange()	0	11	1
A	handleDeleteTypicalAgeRange()	0	9	1
A	handleUpdateOrganizer()	0	11	1
A	handleDeleteOrganizer()	0	10	1
A	handleUpdateContactPoint()	0	11	1
A	handleUpdateBookingInfo()	0	10	1
A	handleUpdatePriceInfo()	0	10	1
A	handleDeleteOffer()	0	6	1
A	handlePublish()	0	6	1
A	handleApprove()	0	6	1
A	handleReject()	0	6	1
A	handleFlagAsDuplicate()	0	6	1
A	handleFlagAsInappropriate()	0	6	1
A	load()	0	4	1
A	loadOrganizer()	0	5	1

How to fix Duplicated Code

<?php

namespace CultuurNet\UDB3\Offer;

use Broadway\Repository\RepositoryInterface;
use CultuurNet\UDB3\CommandHandling\Udb3CommandHandler;
use CultuurNet\UDB3\Label;
use CultuurNet\UDB3\Label\ReadModels\JSON\Repository\ReadRepositoryInterface;
use CultuurNet\UDB3\Label\ValueObjects\Visibility;
use CultuurNet\UDB3\Offer\Commands\AbstractAddLabel;
use CultuurNet\UDB3\Offer\Commands\AbstractLabelCommand;
use CultuurNet\UDB3\Offer\Commands\AbstractRemoveLabel;
use CultuurNet\UDB3\Offer\Commands\AbstractDeleteOffer;
use CultuurNet\UDB3\Offer\Commands\AbstractDeleteOrganizer;
use CultuurNet\UDB3\Offer\Commands\AbstractDeleteTypicalAgeRange;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateBookingInfo;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateCalendar;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateContactPoint;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateDescription;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateOrganizer;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdatePriceInfo;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateTheme;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateType;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateTypicalAgeRange;
use CultuurNet\UDB3\Offer\Commands\Image\AbstractAddImage;
use CultuurNet\UDB3\Offer\Commands\Image\AbstractRemoveImage;
use CultuurNet\UDB3\Offer\Commands\Image\AbstractSelectMainImage;
use CultuurNet\UDB3\Offer\Commands\Image\AbstractUpdateImage;
use CultuurNet\UDB3\Offer\Commands\AbstractUpdateTitle;
use CultuurNet\UDB3\Offer\Commands\Moderation\AbstractApprove;
use CultuurNet\UDB3\Offer\Commands\Moderation\AbstractFlagAsDuplicate;
use CultuurNet\UDB3\Offer\Commands\Moderation\AbstractFlagAsInappropriate;
use CultuurNet\UDB3\Offer\Commands\Moderation\AbstractPublish;
use CultuurNet\UDB3\Offer\Commands\Moderation\AbstractReject;
use CultuurNet\UDB3\Organizer\Organizer;
use ValueObjects\StringLiteral\StringLiteral;

abstract class OfferCommandHandler extends Udb3CommandHandler
{
    /**
     * @var RepositoryInterface
     */
    protected $offerRepository;

    /**
     * @var RepositoryInterface
     */
    protected $organizerRepository;

    /**
     * @var RepositoryInterface
     */
    protected $labelRepository;

    /**
     * @param RepositoryInterface $offerRepository
     * @param RepositoryInterface $organizerRepository
     * @param ReadRepositoryInterface $labelRepository
     */
    public function __construct(
        RepositoryInterface $offerRepository,
        RepositoryInterface $organizerRepository,
        ReadRepositoryInterface $labelRepository
    ) {
        $this->offerRepository = $offerRepository;
        $this->organizerRepository = $organizerRepository;
        $this->labelRepository = $labelRepository;

    }

    /**
     * {@inheritdoc}
     */
    public function handle($command)
    {
        $commandName = get_class($command);
        $commandHandlers = $this->getCommandHandlers();

        if (isset($commandHandlers[$commandName])) {
            $handler = $commandHandlers[$commandName];
            call_user_func(array($this, $handler), $command);
        } else {
            parent::handle($command);
        }
    }

    /**
     * @return string[]
     *   An associative array of commands and their handler methods.
     */
    private function getCommandHandlers()

    {
        $commands = [];

        foreach (get_class_methods($this) as $method) {
            $matches = [];
            if (preg_match('/^handle(.+)$/', $method, $matches)) {
                $command = $matches[1];
                $classNameMethod = 'get' . $command . 'ClassName';

                if (method_exists($this, $classNameMethod)) {
                    $commandFullClassName = call_user_func(array($this, $classNameMethod));
                    $commands[$commandFullClassName] = $method;
                }
            }
        }

        return $commands;
    }

    /**
     * @return string
     */
    abstract protected function getAddLabelClassName();

    /**
     * @return string
     */
    abstract protected function getRemoveLabelClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateTitleClassName();

    /**
     * @return string
     */
    abstract protected function getAddImageClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateImageClassName();

    /**
     * @return string
     */
    abstract protected function getRemoveImageClassName();

    /**
     * @return string
     */
    abstract protected function getSelectMainImageClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateDescriptionClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateCalendarClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateTypicalAgeRangeClassName();

    /**
     * @return string
     */
    abstract protected function getDeleteTypicalAgeRangeClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateOrganizerClassName();

    /**
     * @return string
     */
    abstract protected function getDeleteOrganizerClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateContactPointClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateBookingInfoClassName();

    /**
     * @return string
     */
    abstract protected function getUpdatePriceInfoClassName();

    /**
     * @return string
     */
    abstract protected function getDeleteOfferClassName();

    /**
     * @return string
     */
    abstract protected function getPublishClassName();

    /**
     * @return string
     */
    abstract protected function getApproveClassName();

    /**
     * @return string
     */
    abstract protected function getRejectClassName();

    /**
     * @return string
     */
    abstract protected function getFlagAsDuplicateClassName();

    /**
     * @return string
     */
    abstract protected function getFlagAsInappropriateClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateTypeClassName();

    /**
     * @return string
     */
    abstract protected function getUpdateThemeClassName();

    /**
     * @param AbstractUpdateType $updateType
     */
    public function handleUpdateType(AbstractUpdateType $updateType)
    {
        $offer = $this->load($updateType->getItemId());

        $offer->updateType($updateType->getType());

        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractUpdateTheme $updateTheme
     */
    public function handleUpdateTheme(AbstractUpdateTheme $updateTheme)
    {
        $offer = $this->load($updateTheme->getItemId());

        $offer->updateTheme($updateTheme->getTheme());

        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractAddLabel $addLabel
     */
    private function handleAddLabel(AbstractAddLabel $addLabel)
    {
        $offer = $this->load($addLabel->getItemId());

        $offer->addLabel($this->createLabel($addLabel));

        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractRemoveLabel $removeLabel
     */
    private function handleRemoveLabel(AbstractRemoveLabel $removeLabel)
    {
        $offer = $this->load($removeLabel->getItemId());

        $offer->removeLabel($this->createLabel($removeLabel));

        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractLabelCommand $labelCommand
     * @return Label
     */
    private function createLabel(AbstractLabelCommand $labelCommand)

    {
        $labelName = new StringLiteral((string) $labelCommand->getLabel());
        $label = $this->labelRepository->getByName($labelName);


        return new Label(
            $labelName->toNative(),
            $label->getVisibility() === Visibility::VISIBLE()
        );
    }

    /**
     * @param AbstractUpdateTitle $translateTitle
     */
    private function handleUpdateTitle(AbstractUpdateTitle $translateTitle)
    {
        $offer = $this->load($translateTitle->getItemId());
        $offer->updateTitle($translateTitle->getLanguage(), $translateTitle->getTitle());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->offerRepository->save($offer);
    }

    /**
     * Handle an add image command.
     * @param AbstractAddImage $addImage
     */
    public function handleAddImage(AbstractAddImage $addImage)
    {
        $offer = $this->load($addImage->getItemId());
        $offer->addImage($addImage->getImage());
        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractRemoveImage $removeImage
     */
    public function handleRemoveImage(AbstractRemoveImage $removeImage)
    {
        $offer = $this->load($removeImage->getItemId());
        $offer->removeImage($removeImage->getImage());
        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractUpdateImage $updateImage
     */
    public function handleUpdateImage(AbstractUpdateImage $updateImage)
    {
        $offer = $this->load($updateImage->getItemId());
        $offer->updateImage($updateImage);
        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractSelectMainImage $selectMainImage
     */
    public function handleSelectMainImage(AbstractSelectMainImage $selectMainImage)
    {
        $offer = $this->load($selectMainImage->getItemId());
        $offer->selectMainImage($selectMainImage->getImage());
        $this->offerRepository->save($offer);
    }

    /**
     * Handle the update of description on a place.
     * @param AbstractUpdateDescription $updateDescription
     */
    public function handleUpdateDescription(AbstractUpdateDescription $updateDescription)
    {
        $offer = $this->load($updateDescription->getItemId());

        $offer->updateDescription(
            $updateDescription->getDescription(),
            $updateDescription->getLanguage()
        );

        $this->offerRepository->save($offer);

    }

    /**
     * @param AbstractUpdateCalendar $updateCalendar
     */
    public function handleUpdateCalendar(AbstractUpdateCalendar $updateCalendar)
    {
        $offer = $this->load($updateCalendar->getItemId());

        $offer->updateCalendar($updateCalendar->getCalendar());

        $this->offerRepository->save($offer);
    }

    /**
     * Handle the update of typical age range on a place.
     * @param AbstractUpdateTypicalAgeRange $updateTypicalAgeRange
     */
    public function handleUpdateTypicalAgeRange(AbstractUpdateTypicalAgeRange $updateTypicalAgeRange)
    {
        $offer = $this->load($updateTypicalAgeRange->getItemId());

        $offer->updateTypicalAgeRange(
            $updateTypicalAgeRange->getTypicalAgeRange()
        );

        $this->offerRepository->save($offer);

    }

    /**
     * Handle the deletion of typical age range on a place.
     * @param AbstractDeleteTypicalAgeRange $deleteTypicalAgeRange
     */
    public function handleDeleteTypicalAgeRange(AbstractDeleteTypicalAgeRange $deleteTypicalAgeRange)
    {
        $offer = $this->load($deleteTypicalAgeRange->getItemId());

        $offer->deleteTypicalAgeRange();

        $this->offerRepository->save($offer);

    }

    /**
     * Handle an update command to update organizer of a place.
     * @param AbstractUpdateOrganizer $updateOrganizer
     */
    public function handleUpdateOrganizer(AbstractUpdateOrganizer $updateOrganizer)
    {
        $offer = $this->load($updateOrganizer->getItemId());
        $this->loadOrganizer($updateOrganizer->getOrganizerId());

        $offer->updateOrganizer(
            $updateOrganizer->getOrganizerId()
        );

        $this->offerRepository->save($offer);
    }

    /**
     * Handle an update command to delete the organizer.
     * @param AbstractDeleteOrganizer $deleteOrganizer
     */
    public function handleDeleteOrganizer(AbstractDeleteOrganizer $deleteOrganizer)
    {
        $offer = $this->load($deleteOrganizer->getItemId());

        $offer->deleteOrganizer(
            $deleteOrganizer->getOrganizerId()
        );

        $this->offerRepository->save($offer);
    }

    /**
     * Handle an update command to updated the contact point.
     * @param AbstractUpdateContactPoint $updateContactPoint
     */
    public function handleUpdateContactPoint(AbstractUpdateContactPoint $updateContactPoint)
    {
        $offer = $this->load($updateContactPoint->getItemId());

        $offer->updateContactPoint(
            $updateContactPoint->getContactPoint()
        );

        $this->offerRepository->save($offer);

    }

    /**
     * Handle an update command to updated the booking info.
     * @param AbstractUpdateBookingInfo $updateBookingInfo
     */
    public function handleUpdateBookingInfo(AbstractUpdateBookingInfo $updateBookingInfo)
    {
        $offer = $this->load($updateBookingInfo->getItemId());

        $offer->updateBookingInfo(
            $updateBookingInfo->getBookingInfo()
        );

        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractUpdatePriceInfo $updatePriceInfo
     */
    private function handleUpdatePriceInfo(AbstractUpdatePriceInfo $updatePriceInfo)
    {
        $offer = $this->load($updatePriceInfo->getItemId());

        $offer->updatePriceInfo(
            $updatePriceInfo->getPriceInfo()
        );

        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractDeleteOffer $deleteOffer
     */
    private function handleDeleteOffer(AbstractDeleteOffer $deleteOffer)
    {
        $offer = $this->load($deleteOffer->getItemId());
        $offer->delete();
        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractPublish $publish
     */
    private function handlePublish(AbstractPublish $publish)
    {
        $offer = $this->load($publish->getItemId());
        $offer->publish($publish->getPublicationDate());
        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractApprove $approve
     */
    private function handleApprove(AbstractApprove $approve)
    {
        $offer = $this->load($approve->getItemId());
        $offer->approve();
        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractReject $reject
     */
    private function handleReject(AbstractReject $reject)
    {
        $offer = $this->load($reject->getItemId());
        $offer->reject($reject->getReason());
        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractFlagAsDuplicate $flagAsDuplicate
     */
    private function handleFlagAsDuplicate(AbstractFlagAsDuplicate $flagAsDuplicate)
    {
        $offer = $this->load($flagAsDuplicate->getItemId());
        $offer->flagAsDuplicate();
        $this->offerRepository->save($offer);
    }

    /**
     * @param AbstractFlagAsInappropriate $flagAsInappropriate
     */
    private function handleFlagAsInappropriate(AbstractFlagAsInappropriate $flagAsInappropriate)
    {
        $offer = $this->load($flagAsInappropriate->getItemId());
        $offer->flagAsInappropriate();
        $this->offerRepository->save($offer);
    }

    /**
     * Makes it easier to type-hint to Offer.
     *
     * @param string $id
     * @return Offer
     */
    private function load($id)
    {
        return $this->offerRepository->load($id);
    }

    /**
     * Makes it easier to type-hint to Organizer.
     *
     * @param string $id
     * @return Organizer
     */
    private function loadOrganizer($id)
    {
        return $this->organizerRepository->load($id);

    }
}


1		<?php
2
3		namespace CultuurNet\UDB3\Offer;
4
5		use Broadway\Repository\RepositoryInterface;
6		use CultuurNet\UDB3\CommandHandling\Udb3CommandHandler;
7		use CultuurNet\UDB3\Label;
8		use CultuurNet\UDB3\Label\ReadModels\JSON\Repository\ReadRepositoryInterface;
9		use CultuurNet\UDB3\Label\ValueObjects\Visibility;
10		use CultuurNet\UDB3\Offer\Commands\AbstractAddLabel;
11		use CultuurNet\UDB3\Offer\Commands\AbstractLabelCommand;
12		use CultuurNet\UDB3\Offer\Commands\AbstractRemoveLabel;
13		use CultuurNet\UDB3\Offer\Commands\AbstractDeleteOffer;
14		use CultuurNet\UDB3\Offer\Commands\AbstractDeleteOrganizer;
15		use CultuurNet\UDB3\Offer\Commands\AbstractDeleteTypicalAgeRange;
16		use CultuurNet\UDB3\Offer\Commands\AbstractUpdateBookingInfo;
17		use CultuurNet\UDB3\Offer\Commands\AbstractUpdateCalendar;
18		use CultuurNet\UDB3\Offer\Commands\AbstractUpdateContactPoint;
19		use CultuurNet\UDB3\Offer\Commands\AbstractUpdateDescription;
20		use CultuurNet\UDB3\Offer\Commands\AbstractUpdateOrganizer;
21		use CultuurNet\UDB3\Offer\Commands\AbstractUpdatePriceInfo;
22		use CultuurNet\UDB3\Offer\Commands\AbstractUpdateTheme;
23		use CultuurNet\UDB3\Offer\Commands\AbstractUpdateType;
24		use CultuurNet\UDB3\Offer\Commands\AbstractUpdateTypicalAgeRange;
25		use CultuurNet\UDB3\Offer\Commands\Image\AbstractAddImage;
26		use CultuurNet\UDB3\Offer\Commands\Image\AbstractRemoveImage;
27		use CultuurNet\UDB3\Offer\Commands\Image\AbstractSelectMainImage;
28		use CultuurNet\UDB3\Offer\Commands\Image\AbstractUpdateImage;
29		use CultuurNet\UDB3\Offer\Commands\AbstractUpdateTitle;
30		use CultuurNet\UDB3\Offer\Commands\Moderation\AbstractApprove;
31		use CultuurNet\UDB3\Offer\Commands\Moderation\AbstractFlagAsDuplicate;
32		use CultuurNet\UDB3\Offer\Commands\Moderation\AbstractFlagAsInappropriate;
33		use CultuurNet\UDB3\Offer\Commands\Moderation\AbstractPublish;
34		use CultuurNet\UDB3\Offer\Commands\Moderation\AbstractReject;
35		use CultuurNet\UDB3\Organizer\Organizer;
36		use ValueObjects\StringLiteral\StringLiteral;
37
38		abstract class OfferCommandHandler extends Udb3CommandHandler
39		{
40		/**
41		* @var RepositoryInterface
42		*/
43		protected $offerRepository;
44
45		/**
46		* @var RepositoryInterface
47		*/
48		protected $organizerRepository;
49
50		/**
51		* @var RepositoryInterface
52		*/
53		protected $labelRepository;
54
55		/**
56		* @param RepositoryInterface $offerRepository
57		* @param RepositoryInterface $organizerRepository
58		* @param ReadRepositoryInterface $labelRepository
59		*/
60		public function __construct(
61		RepositoryInterface $offerRepository,
62		RepositoryInterface $organizerRepository,
63		ReadRepositoryInterface $labelRepository
64		) {
65		$this->offerRepository = $offerRepository;
66		$this->organizerRepository = $organizerRepository;
67		$this->labelRepository = $labelRepository;
		0 ignored issues – show Documentation Bug introduced 2016-08-08 12:19 UTC by Report Bug Copy Issue Report It seems like `$labelRepository` of type `object<CultuurNet\UDB3\L...eadRepositoryInterface>` is incompatible with the declared type `object<Broadway\Repository\RepositoryInterface>` of property `$labelRepository`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
68		}
69
70		/**
71		* {@inheritdoc}
72		*/
73		public function handle($command)
74		{
75		$commandName = get_class($command);
76		$commandHandlers = $this->getCommandHandlers();
77
78		if (isset($commandHandlers[$commandName])) {
79		$handler = $commandHandlers[$commandName];
80		call_user_func(array($this, $handler), $command);
81		} else {
82		parent::handle($command);
83		}
84		}
85
86		/**
87		* @return string[]
88		* An associative array of commands and their handler methods.
89		*/
90	View Code Duplication	private function getCommandHandlers()
		0 ignored issues – show Duplication introduced 2017-07-31 14:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
91		{
92		$commands = [];
93
94		foreach (get_class_methods($this) as $method) {
95		$matches = [];
96		if (preg_match('/^handle(.+)$/', $method, $matches)) {
97		$command = $matches[1];
98		$classNameMethod = 'get' . $command . 'ClassName';
99
100		if (method_exists($this, $classNameMethod)) {
101		$commandFullClassName = call_user_func(array($this, $classNameMethod));
102		$commands[$commandFullClassName] = $method;
103		}
104		}
105		}
106
107		return $commands;
108		}
109
110		/**
111		* @return string
112		*/
113		abstract protected function getAddLabelClassName();
114
115		/**
116		* @return string
117		*/
118		abstract protected function getRemoveLabelClassName();
119
120		/**
121		* @return string
122		*/
123		abstract protected function getUpdateTitleClassName();
124
125		/**
126		* @return string
127		*/
128		abstract protected function getAddImageClassName();
129
130		/**
131		* @return string
132		*/
133		abstract protected function getUpdateImageClassName();
134
135		/**
136		* @return string
137		*/
138		abstract protected function getRemoveImageClassName();
139
140		/**
141		* @return string
142		*/
143		abstract protected function getSelectMainImageClassName();
144
145		/**
146		* @return string
147		*/
148		abstract protected function getUpdateDescriptionClassName();
149
150		/**
151		* @return string
152		*/
153		abstract protected function getUpdateCalendarClassName();
154
155		/**
156		* @return string
157		*/
158		abstract protected function getUpdateTypicalAgeRangeClassName();
159
160		/**
161		* @return string
162		*/
163		abstract protected function getDeleteTypicalAgeRangeClassName();
164
165		/**
166		* @return string
167		*/
168		abstract protected function getUpdateOrganizerClassName();
169
170		/**
171		* @return string
172		*/
173		abstract protected function getDeleteOrganizerClassName();
174
175		/**
176		* @return string
177		*/
178		abstract protected function getUpdateContactPointClassName();
179
180		/**
181		* @return string
182		*/
183		abstract protected function getUpdateBookingInfoClassName();
184
185		/**
186		* @return string
187		*/
188		abstract protected function getUpdatePriceInfoClassName();
189
190		/**
191		* @return string
192		*/
193		abstract protected function getDeleteOfferClassName();
194
195		/**
196		* @return string
197		*/
198		abstract protected function getPublishClassName();
199
200		/**
201		* @return string
202		*/
203		abstract protected function getApproveClassName();
204
205		/**
206		* @return string
207		*/
208		abstract protected function getRejectClassName();
209
210		/**
211		* @return string
212		*/
213		abstract protected function getFlagAsDuplicateClassName();
214
215		/**
216		* @return string
217		*/
218		abstract protected function getFlagAsInappropriateClassName();
219
220		/**
221		* @return string
222		*/
223		abstract protected function getUpdateTypeClassName();
224
225		/**
226		* @return string
227		*/
228		abstract protected function getUpdateThemeClassName();
229
230		/**
231		* @param AbstractUpdateType $updateType
232		*/
233		public function handleUpdateType(AbstractUpdateType $updateType)
234		{
235		$offer = $this->load($updateType->getItemId());
236
237		$offer->updateType($updateType->getType());
238
239		$this->offerRepository->save($offer);
240		}
241
242		/**
243		* @param AbstractUpdateTheme $updateTheme
244		*/
245		public function handleUpdateTheme(AbstractUpdateTheme $updateTheme)
246		{
247		$offer = $this->load($updateTheme->getItemId());
248
249		$offer->updateTheme($updateTheme->getTheme());
250
251		$this->offerRepository->save($offer);
252		}
253
254		/**
255		* @param AbstractAddLabel $addLabel
256		*/
257		private function handleAddLabel(AbstractAddLabel $addLabel)
258		{
259		$offer = $this->load($addLabel->getItemId());
260
261		$offer->addLabel($this->createLabel($addLabel));
262
263		$this->offerRepository->save($offer);
264		}
265
266		/**
267		* @param AbstractRemoveLabel $removeLabel
268		*/
269		private function handleRemoveLabel(AbstractRemoveLabel $removeLabel)
270		{
271		$offer = $this->load($removeLabel->getItemId());
272
273		$offer->removeLabel($this->createLabel($removeLabel));
274
275		$this->offerRepository->save($offer);
276		}
277
278		/**
279		* @param AbstractLabelCommand $labelCommand
280		* @return Label
281		*/
282	View Code Duplication	private function createLabel(AbstractLabelCommand $labelCommand)
		0 ignored issues – show Duplication introduced 2017-07-31 14:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
283		{
284		$labelName = new StringLiteral((string) $labelCommand->getLabel());
285		$label = $this->labelRepository->getByName($labelName);
		0 ignored issues – show Bug introduced 2016-08-08 12:19 UTC by Report Bug Copy Issue Report The method `getByName()` does not seem to exist on `object<Broadway\Repository\RepositoryInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
286
287		return new Label(
288		$labelName->toNative(),
289		$label->getVisibility() === Visibility::VISIBLE()
290		);
291		}
292
293		/**
294		* @param AbstractUpdateTitle $translateTitle
295		*/
296		private function handleUpdateTitle(AbstractUpdateTitle $translateTitle)
297		{
298		$offer = $this->load($translateTitle->getItemId());
299		$offer->updateTitle($translateTitle->getLanguage(), $translateTitle->getTitle());
		0 ignored issues – show Documentation introduced 2017-08-23 09:21 UTC by Report Bug Copy Issue Report `$translateTitle->getTitle()` is of type `string`, but the function expects a `object<CultuurNet\UDB3\Title>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
300		$this->offerRepository->save($offer);
301		}
302
303		/**
304		* Handle an add image command.
305		* @param AbstractAddImage $addImage
306		*/
307		public function handleAddImage(AbstractAddImage $addImage)
308		{
309		$offer = $this->load($addImage->getItemId());
310		$offer->addImage($addImage->getImage());
311		$this->offerRepository->save($offer);
312		}
313
314		/**
315		* @param AbstractRemoveImage $removeImage
316		*/
317		public function handleRemoveImage(AbstractRemoveImage $removeImage)
318		{
319		$offer = $this->load($removeImage->getItemId());
320		$offer->removeImage($removeImage->getImage());
321		$this->offerRepository->save($offer);
322		}
323
324		/**
325		* @param AbstractUpdateImage $updateImage
326		*/
327		public function handleUpdateImage(AbstractUpdateImage $updateImage)
328		{
329		$offer = $this->load($updateImage->getItemId());
330		$offer->updateImage($updateImage);
331		$this->offerRepository->save($offer);
332		}
333
334		/**
335		* @param AbstractSelectMainImage $selectMainImage
336		*/
337		public function handleSelectMainImage(AbstractSelectMainImage $selectMainImage)
338		{
339		$offer = $this->load($selectMainImage->getItemId());
340		$offer->selectMainImage($selectMainImage->getImage());
341		$this->offerRepository->save($offer);
342		}
343
344		/**
345		* Handle the update of description on a place.
346		* @param AbstractUpdateDescription $updateDescription
347		*/
348		public function handleUpdateDescription(AbstractUpdateDescription $updateDescription)
349		{
350		$offer = $this->load($updateDescription->getItemId());
351
352		$offer->updateDescription(
353		$updateDescription->getDescription(),
354		$updateDescription->getLanguage()
355		);
356
357		$this->offerRepository->save($offer);
358
359		}
360
361		/**
362		* @param AbstractUpdateCalendar $updateCalendar
363		*/
364		public function handleUpdateCalendar(AbstractUpdateCalendar $updateCalendar)
365		{
366		$offer = $this->load($updateCalendar->getItemId());
367
368		$offer->updateCalendar($updateCalendar->getCalendar());
369
370		$this->offerRepository->save($offer);
371		}
372
373		/**
374		* Handle the update of typical age range on a place.
375		* @param AbstractUpdateTypicalAgeRange $updateTypicalAgeRange
376		*/
377		public function handleUpdateTypicalAgeRange(AbstractUpdateTypicalAgeRange $updateTypicalAgeRange)
378		{
379		$offer = $this->load($updateTypicalAgeRange->getItemId());
380
381		$offer->updateTypicalAgeRange(
382		$updateTypicalAgeRange->getTypicalAgeRange()
383		);
384
385		$this->offerRepository->save($offer);
386
387		}
388
389		/**
390		* Handle the deletion of typical age range on a place.
391		* @param AbstractDeleteTypicalAgeRange $deleteTypicalAgeRange
392		*/
393		public function handleDeleteTypicalAgeRange(AbstractDeleteTypicalAgeRange $deleteTypicalAgeRange)
394		{
395		$offer = $this->load($deleteTypicalAgeRange->getItemId());
396
397		$offer->deleteTypicalAgeRange();
398
399		$this->offerRepository->save($offer);
400
401		}
402
403		/**
404		* Handle an update command to update organizer of a place.
405		* @param AbstractUpdateOrganizer $updateOrganizer
406		*/
407		public function handleUpdateOrganizer(AbstractUpdateOrganizer $updateOrganizer)
408		{
409		$offer = $this->load($updateOrganizer->getItemId());
410		$this->loadOrganizer($updateOrganizer->getOrganizerId());
411
412		$offer->updateOrganizer(
413		$updateOrganizer->getOrganizerId()
414		);
415
416		$this->offerRepository->save($offer);
417		}
418
419		/**
420		* Handle an update command to delete the organizer.
421		* @param AbstractDeleteOrganizer $deleteOrganizer
422		*/
423		public function handleDeleteOrganizer(AbstractDeleteOrganizer $deleteOrganizer)
424		{
425		$offer = $this->load($deleteOrganizer->getItemId());
426
427		$offer->deleteOrganizer(
428		$deleteOrganizer->getOrganizerId()
429		);
430
431		$this->offerRepository->save($offer);
432		}
433
434		/**
435		* Handle an update command to updated the contact point.
436		* @param AbstractUpdateContactPoint $updateContactPoint
437		*/
438		public function handleUpdateContactPoint(AbstractUpdateContactPoint $updateContactPoint)
439		{
440		$offer = $this->load($updateContactPoint->getItemId());
441
442		$offer->updateContactPoint(
443		$updateContactPoint->getContactPoint()
444		);
445
446		$this->offerRepository->save($offer);
447
448		}
449
450		/**
451		* Handle an update command to updated the booking info.
452		* @param AbstractUpdateBookingInfo $updateBookingInfo
453		*/
454		public function handleUpdateBookingInfo(AbstractUpdateBookingInfo $updateBookingInfo)
455		{
456		$offer = $this->load($updateBookingInfo->getItemId());
457
458		$offer->updateBookingInfo(
459		$updateBookingInfo->getBookingInfo()
460		);
461
462		$this->offerRepository->save($offer);
463		}
464
465		/**
466		* @param AbstractUpdatePriceInfo $updatePriceInfo
467		*/
468		private function handleUpdatePriceInfo(AbstractUpdatePriceInfo $updatePriceInfo)
469		{
470		$offer = $this->load($updatePriceInfo->getItemId());
471
472		$offer->updatePriceInfo(
473		$updatePriceInfo->getPriceInfo()
474		);
475
476		$this->offerRepository->save($offer);
477		}
478
479		/**
480		* @param AbstractDeleteOffer $deleteOffer
481		*/
482		private function handleDeleteOffer(AbstractDeleteOffer $deleteOffer)
483		{
484		$offer = $this->load($deleteOffer->getItemId());
485		$offer->delete();
486		$this->offerRepository->save($offer);
487		}
488
489		/**
490		* @param AbstractPublish $publish
491		*/
492		private function handlePublish(AbstractPublish $publish)
493		{
494		$offer = $this->load($publish->getItemId());
495		$offer->publish($publish->getPublicationDate());
496		$this->offerRepository->save($offer);
497		}
498
499		/**
500		* @param AbstractApprove $approve
501		*/
502		private function handleApprove(AbstractApprove $approve)
503		{
504		$offer = $this->load($approve->getItemId());
505		$offer->approve();
506		$this->offerRepository->save($offer);
507		}
508
509		/**
510		* @param AbstractReject $reject
511		*/
512		private function handleReject(AbstractReject $reject)
513		{
514		$offer = $this->load($reject->getItemId());
515		$offer->reject($reject->getReason());
516		$this->offerRepository->save($offer);
517		}
518
519		/**
520		* @param AbstractFlagAsDuplicate $flagAsDuplicate
521		*/
522		private function handleFlagAsDuplicate(AbstractFlagAsDuplicate $flagAsDuplicate)
523		{
524		$offer = $this->load($flagAsDuplicate->getItemId());
525		$offer->flagAsDuplicate();
526		$this->offerRepository->save($offer);
527		}
528
529		/**
530		* @param AbstractFlagAsInappropriate $flagAsInappropriate
531		*/
532		private function handleFlagAsInappropriate(AbstractFlagAsInappropriate $flagAsInappropriate)
533		{
534		$offer = $this->load($flagAsInappropriate->getItemId());
535		$offer->flagAsInappropriate();
536		$this->offerRepository->save($offer);
537		}
538
539		/**
540		* Makes it easier to type-hint to Offer.
541		*
542		* @param string $id
543		* @return Offer
544		*/
545		private function load($id)
546		{
547		return $this->offerRepository->load($id);
548		}
549
550		/**
551		* Makes it easier to type-hint to Organizer.
552		*
553		* @param string $id
554		* @return Organizer
555		*/
556		private function loadOrganizer($id)
557		{
558		return $this->organizerRepository->load($id);
559
560		}
561		}
562

cultuurnet / udb3-php

Pull Request — master (#328)

OfferCommandHandler D

Complexity

Size/Duplication

Coupling/Cohesion

Importance

54 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like