Completed
Pull Request — master (#105)
by Kristof
16:56 queued 10:23
created
src/Place/Events/BookingInfoUpdated.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
     }
28 28
 
29 29
     /**
30
-     * @return mixed The object instance
30
+     * @return BookingInfoUpdated The object instance
31 31
      */
32 32
     public static function deserialize(array $data)
33 33
     {
Please login to merge, or discard this patch.
src/Place/Events/MajorInfoUpdated.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,6 @@
 block discarded – undo
10 10
 use CultuurNet\UDB3\Calendar;
11 11
 use CultuurNet\UDB3\CalendarInterface;
12 12
 use CultuurNet\UDB3\Event\EventType;
13
-use CultuurNet\UDB3\Location;
14 13
 use CultuurNet\UDB3\Place\PlaceEvent;
15 14
 use CultuurNet\UDB3\Theme;
16 15
 use CultuurNet\UDB3\Title;
Please login to merge, or discard this patch.
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,6 @@
 block discarded – undo
49 49
     /**
50 50
      * @param string $placeId
51 51
      * @param Title $title
52
-     * @param string $location
53 52
      * @param CalendarInterface $calendar
54 53
      */
55 54
     public function __construct($placeId, Title $title, EventType $eventType, Address $address, CalendarInterface $calendar, $theme = null)
Please login to merge, or discard this patch.
src/Place/Place.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
      * @param CalendarInterface $calendar
54 54
      * @param Theme/null $theme
55 55
      *
56
-     * @return Event
56
+     * @return Place
57 57
      */
58 58
     public static function createPlace($id, Title $title, EventType $eventType, Address $address, CalendarInterface $calendar, Theme $theme = null)
59 59
     {
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 
66 66
     /**
67 67
      * Apply the place created event.
68
-     * @param PlaceCreate $placeCreated
68
+     * @param PlaceCreated $placeCreated
69 69
      */
70 70
     protected function applyPlaceCreated(PlaceCreated $placeCreated)
71 71
     {
@@ -95,6 +95,7 @@  discard block
 block discarded – undo
95 95
 
96 96
     /**
97 97
      * Handle an update command to update organizer.
98
+     * @param string $organizerId
98 99
      */
99 100
     public function updateOrganizer($organizerId)
100 101
     {
Please login to merge, or discard this patch.
src/Place/PlaceEditingServiceInterface.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
      * @param Title $title
23 23
      * @param EventType $eventType
24 24
      * @param Address $address
25
-     * @param CalendarBase $calendar
25
+     * @param CalendarInterface $calendar
26 26
      * @param Theme|null $theme
27 27
      *
28 28
      * @return string $eventId
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
      * @param Title $title
44 44
      * @param EventType $eventType
45 45
      * @param Address $address
46
-     * @param CalendarBase $calendar
46
+     * @param CalendarInterface $calendar
47 47
      * @param Theme/null $theme
48 48
      */
49 49
     public function updateMajorInfo($id, Title $title, EventType $eventType, Address $address, CalendarInterface $calendar, $theme = null);
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * @file
4
- */
3
+     * @file
4
+     */
5 5
 
6 6
 namespace CultuurNet\UDB3\Variations;
7 7
 
Please login to merge, or discard this patch.
src/Place/PlaceLDProjector.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
     /**
80 80
      * @param DocumentRepositoryInterface $repository
81 81
      * @param IriGeneratorInterface $iriGenerator
82
-     * @param OrganizerServiceInterface $organiserService
82
+     * @param OrganizerServiceInterface $organizerService
83 83
      */
84 84
     public function __construct(
85 85
         DocumentRepositoryInterface $repository,
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -295,7 +295,7 @@
 block discarded – undo
295 295
         $placeLd = $document->getBody();
296 296
 
297 297
         $placeLd->organizer = array(
298
-          '@type' => 'Organizer',
298
+            '@type' => 'Organizer',
299 299
         ) + (array)$this->organizerJSONLD($organizerUpdated->getOrganizerId());
300 300
 
301 301
         $this->repository->save($document->withBody($placeLd));
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
         $jsonLD->address = $placeCreated->getAddress()->toJsonLd();
151 151
 
152 152
         $calendarJsonLD = $placeCreated->getCalendar()->toJsonLd();
153
-        $jsonLD = (object) array_merge((array) $jsonLD, $calendarJsonLD);
153
+        $jsonLD = (object)array_merge((array)$jsonLD, $calendarJsonLD);
154 154
 
155 155
         $eventType = $placeCreated->getEventType();
156 156
         $jsonLD->terms = [
@@ -197,11 +197,11 @@  discard block
 block discarded – undo
197 197
         $jsonLD->address = $majorInfoUpdated->getAddress()->toJsonLd();
198 198
 
199 199
         $calendarJsonLD = $majorInfoUpdated->getCalendar()->toJsonLd();
200
-        $jsonLD = (object) array_merge((array) $jsonLD, $calendarJsonLD);
200
+        $jsonLD = (object)array_merge((array)$jsonLD, $calendarJsonLD);
201 201
 
202 202
         // Remove old theme and event type.
203
-        $jsonLD->terms = array_filter($jsonLD->terms, function ($term) {
204
-            return $term->domain !== EventType::DOMAIN &&  $term->domain !== Theme::DOMAIN;
203
+        $jsonLD->terms = array_filter($jsonLD->terms, function($term) {
204
+            return $term->domain !== EventType::DOMAIN && $term->domain !== Theme::DOMAIN;
205 205
         });
206 206
 
207 207
         $eventType = $majorInfoUpdated->getEventType();
@@ -347,7 +347,7 @@  discard block
 block discarded – undo
347 347
         // Remove all old facilities + get numeric keys.
348 348
         $terms = array_values(array_filter(
349 349
             $terms,
350
-            function ($term) {
350
+            function($term) {
351 351
                 return $term->domain !== Facility::DOMAIN;
352 352
             }
353 353
         ));
Please login to merge, or discard this patch.
src/Place/ReadModel/JSONLD/EventFactory.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,6 @@
 block discarded – undo
6 6
 namespace CultuurNet\UDB3\Place\ReadModel\JSONLD;
7 7
 
8 8
 use CultuurNet\UDB3\Event\ReadModel\DocumentEventFactory;
9
-use CultuurNet\UDB3\Place\PlaceEvent;
10 9
 use CultuurNet\UDB3\Place\PlaceProjectedToJSONLD;
11 10
 
12 11
 class EventFactory implements DocumentEventFactory
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * @file
4
- */
3
+     * @file
4
+     */
5 5
 
6 6
 namespace CultuurNet\UDB3\Variations;
7 7
 
Please login to merge, or discard this patch.
src/SavedSearches/CombinedSavedSearchRepository.php 1 patch
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -13,8 +13,6 @@
 block discarded – undo
13 13
     protected $repositories;
14 14
 
15 15
     /**
16
-     * @param SavedSearchRepositoryInterface $repository,...
17
-     *   Optionally an unlimited list of repositories to combine.
18 16
      *
19 17
      * @throws \InvalidArgumentException
20 18
      *   When one of the provided arguments does not implement
Please login to merge, or discard this patch.
src/SavedSearches/FixedSavedSearchRepository.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
     protected $user;
17 17
 
18 18
     /**
19
-     * @param String $userId
19
+     * @param String $user
20 20
      */
21 21
     public function __construct(\CultureFeed_User $user)
22 22
     {
Please login to merge, or discard this patch.
src/SavedSearches/Properties/CreatedByQueryString.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,6 @@
 block discarded – undo
12 12
     protected $emailAddress;
13 13
 
14 14
     /**
15
-     * @param String $userId
16 15
      */
17 16
     public function __construct(EmailAddress $emailAddress)
18 17
     {
Please login to merge, or discard this patch.