Completed
Pull Request — master (#241)
by Kristof
07:21 queued 02:55
created
src/Organizer/Organizer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@
 block discarded – undo
98 98
     public function applyOrganizerImportedFromUDB2(
99 99
         OrganizerImportedFromUDB2 $organizerImported
100 100
     ) {
101
-        $this->actorId = (string) $organizerImported->getActorId();
101
+        $this->actorId = (string)$organizerImported->getActorId();
102 102
     }
103 103
 
104 104
     /**
Please login to merge, or discard this patch.
src/Offer/Events/AbstractContactPointUpdated.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
     }
39 39
 
40 40
     /**
41
-     * @return mixed The object instance
41
+     * @return AbstractContactPointUpdated The object instance
42 42
      */
43 43
     public static function deserialize(array $data)
44 44
     {
Please login to merge, or discard this patch.
src/BackwardsCompatiblePayloadSerializerFactory.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 
61 61
         $payloadManipulatingSerializer->manipulateEventsOfClass(
62 62
             'CultuurNet\UDB3\UsedKeywordsMemory\Created',
63
-            function (array $serializedObject) {
63
+            function(array $serializedObject) {
64 64
                 $serializedObject['class'] = UsedLabelsMemoryCreated::class;
65 65
 
66 66
                 return $serializedObject;
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 
70 70
         $payloadManipulatingSerializer->manipulateEventsOfClass(
71 71
             'CultuurNet\UDB3\UsedKeywordsMemory\KeywordUsed',
72
-            function (array $serializedObject) {
72
+            function(array $serializedObject) {
73 73
                 $serializedObject['class'] = LabelUsed::class;
74 74
 
75 75
                 $serializedObject = self::replaceKeywordWithLabel($serializedObject);
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
         $payloadManipulatingSerializer->manipulateEventsOfClass(
86 86
             'CultuurNet\UDB3\Event\TitleTranslated',
87
-            function (array $serializedObject) {
87
+            function(array $serializedObject) {
88 88
                 $serializedObject['class'] = TitleTranslated::class;
89 89
 
90 90
                 $serializedObject = self::replaceEventIdWithItemId($serializedObject);
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 
96 96
         $payloadManipulatingSerializer->manipulateEventsOfClass(
97 97
             'CultuurNet\UDB3\Event\DescriptionTranslated',
98
-            function (array $serializedObject) {
98
+            function(array $serializedObject) {
99 99
                 $serializedObject['class'] = DescriptionTranslated::class;
100 100
 
101 101
                 $serializedObject = self::replaceEventIdWithItemId($serializedObject);
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 
111 111
         $payloadManipulatingSerializer->manipulateEventsOfClass(
112 112
             'CultuurNet\UDB3\Event\Events\EventWasLabelled',
113
-            function (array $serializedObject) {
113
+            function(array $serializedObject) {
114 114
                 $serializedObject['class'] = LabelAdded::class;
115 115
 
116 116
                 $serializedObject = self::replaceEventIdWithItemId($serializedObject);
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 
122 122
         $payloadManipulatingSerializer->manipulateEventsOfClass(
123 123
             'CultuurNet\UDB3\Event\EventWasTagged',
124
-            function (array $serializedObject) {
124
+            function(array $serializedObject) {
125 125
                 $serializedObject['class'] = LabelAdded::class;
126 126
 
127 127
                 $serializedObject = self::replaceEventIdWithItemId($serializedObject);
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 
135 135
         $payloadManipulatingSerializer->manipulateEventsOfClass(
136 136
             'CultuurNet\UDB3\Event\TagErased',
137
-            function (array $serializedObject) {
137
+            function(array $serializedObject) {
138 138
                 $serializedObject['class'] = LabelDeleted::class;
139 139
 
140 140
                 $serializedObject = self::replaceEventIdWithItemId($serializedObject);
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 
148 148
         $payloadManipulatingSerializer->manipulateEventsOfClass(
149 149
             'CultuurNet\UDB3\Event\Events\Unlabelled',
150
-            function (array $serializedObject) {
150
+            function(array $serializedObject) {
151 151
                 $serializedObject['class'] = LabelDeleted::class;
152 152
 
153 153
                 $serializedObject = self::replaceEventIdWithItemId($serializedObject);
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 
159 159
         $payloadManipulatingSerializer->manipulateEventsOfClass(
160 160
             'CultuurNet\UDB3\Event\Events\LabelsApplied',
161
-            function (array $serializedObject) {
161
+            function(array $serializedObject) {
162 162
                 $serializedObject['class'] = LabelsMerged::class;
163 163
 
164 164
                 $keywordsString = $serializedObject['payload']['keywords_string'];
@@ -180,9 +180,9 @@  discard block
 block discarded – undo
180 180
                 }
181 181
 
182 182
                 $labels = array_map(
183
-                    function (Label $label) {
183
+                    function(Label $label) {
184 184
                         return [
185
-                            'text' => (string) $label,
185
+                            'text' => (string)$label,
186 186
                             'visible' => $label->isVisible(),
187 187
                         ];
188 188
                     },
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
 
203 203
         $payloadManipulatingSerializer->manipulateEventsOfClass(
204 204
             'CultuurNet\UDB3\Event\EventImportedFromUDB2',
205
-            function (array $serializedObject) {
205
+            function(array $serializedObject) {
206 206
                 $serializedObject['class'] = EventImportedFromUDB2::class;
207 207
 
208 208
                 return $serializedObject;
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
         foreach ($refactoredEventEvents as $refactoredEventEvent) {
227 227
             $payloadManipulatingSerializer->manipulateEventsOfClass(
228 228
                 $refactoredEventEvent,
229
-                function (array $serializedObject) {
229
+                function(array $serializedObject) {
230 230
                     $serializedObject = self::replaceEventIdWithItemId($serializedObject);
231 231
                     return $serializedObject;
232 232
                 }
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
         foreach ($refactoredPlaceEvents as $refactoredPlaceEvent) {
250 250
             $payloadManipulatingSerializer->manipulateEventsOfClass(
251 251
                 $refactoredPlaceEvent,
252
-                function (array $serializedObject) {
252
+                function(array $serializedObject) {
253 253
                     $serializedObject = self::replacePlaceIdWithItemId($serializedObject);
254 254
                     return $serializedObject;
255 255
                 }
Please login to merge, or discard this patch.
src/Event/EventEditingServiceInterface.php 2 patches
Doc Comments   +10 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,6 +23,7 @@  discard block
 block discarded – undo
23 23
      *
24 24
      * @param string $id
25 25
      * @param string $description
26
+     * @return string
26 27
      */
27 28
     public function updateDescription($id, $description);
28 29
 
@@ -31,6 +32,7 @@  discard block
 block discarded – undo
31 32
      *
32 33
      * @param string $id
33 34
      * @param string $ageRange
35
+     * @return string
34 36
      */
35 37
     public function updateTypicalAgeRange($id, $ageRange);
36 38
 
@@ -38,6 +40,7 @@  discard block
 block discarded – undo
38 40
      * Delete the typical age range of a place.
39 41
      *
40 42
      * @param string $id
43
+     * @return string
41 44
      */
42 45
     public function deleteTypicalAgeRange($id);
43 46
 
@@ -46,6 +49,7 @@  discard block
 block discarded – undo
46 49
      *
47 50
      * @param string $id
48 51
      * @param string $organizerId
52
+     * @return string
49 53
      */
50 54
     public function updateOrganizer($id, $organizerId);
51 55
 
@@ -54,6 +58,7 @@  discard block
 block discarded – undo
54 58
      *
55 59
      * @param string $id
56 60
      * @param string $organizerId
61
+     * @return string
57 62
      */
58 63
     public function deleteOrganizer($id, $organizerId);
59 64
 
@@ -62,6 +67,7 @@  discard block
 block discarded – undo
62 67
      *
63 68
      * @param string $id
64 69
      * @param ContactPoint $contactPoint
70
+     * @return string
65 71
      */
66 72
     public function updateContactPoint($id, ContactPoint $contactPoint);
67 73
 
@@ -70,6 +76,7 @@  discard block
 block discarded – undo
70 76
      *
71 77
      * @param string $id
72 78
      * @param Image $image
79
+     * @return string
73 80
      */
74 81
     public function addImage($id, Image $image);
75 82
 
@@ -96,6 +103,7 @@  discard block
 block discarded – undo
96 103
      *
97 104
      * @param string $id
98 105
      * @param Image $image
106
+     * @return string
99 107
      */
100 108
     public function removeImage($id, Image $image);
101 109
 
@@ -103,7 +111,7 @@  discard block
 block discarded – undo
103 111
      * @param Title $title
104 112
      * @param EventType $eventType
105 113
      * @param Location $location
106
-     * @param CalendarBase $calendar
114
+     * @param CalendarInterface $calendar
107 115
      * @param Theme/null $theme
108 116
      *
109 117
      * @return string $eventId
@@ -115,7 +123,7 @@  discard block
 block discarded – undo
115 123
      * @param Title $title
116 124
      * @param EventType $eventType
117 125
      * @param Location $location
118
-     * @param CalendarBase $calendar
126
+     * @param CalendarInterface $calendar
119 127
      * @param Theme/null $theme
120 128
      *
121 129
      * @return string $eventId
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -7,12 +7,8 @@
 block discarded – undo
7 7
 
8 8
 use CultuurNet\UDB3\CalendarInterface;
9 9
 use CultuurNet\UDB3\ContactPoint;
10
-use CultuurNet\UDB3\Event\EventNotFoundException;
11
-use CultuurNet\UDB3\Label;
12
-use CultuurNet\UDB3\Language;
13 10
 use CultuurNet\UDB3\Location;
14 11
 use CultuurNet\UDB3\Media\Image;
15
-use CultuurNet\UDB3\Media\MediaObject;
16 12
 use CultuurNet\UDB3\Title;
17 13
 use ValueObjects\String\String;
18 14
 
Please login to merge, or discard this patch.
src/Variations/Model/Properties/DefaultUrlValidator.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
     public function validateUrl(Url $url)
49 49
     {
50 50
         $identifier = $this->iriOfferIdentifierFactory->fromIri(
51
-            \ValueObjects\Web\Url::fromNative((string) $url)
51
+            \ValueObjects\Web\Url::fromNative((string)$url)
52 52
         );
53 53
         $offerType = $identifier->getType();
54 54
         $offerId = $identifier->getId();
Please login to merge, or discard this patch.
src/Offer/IriOfferIdentifier.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
     public function jsonSerialize()
67 67
     {
68 68
         return [
69
-            '@id' => (string) $this->iri,
69
+            '@id' => (string)$this->iri,
70 70
             '@type' => $this->type->toNative(),
71 71
         ];
72 72
     }
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
     {
79 79
         return json_encode(
80 80
             [
81
-                'iri' => (string) $this->iri,
81
+                'iri' => (string)$this->iri,
82 82
                 'id' => $this->id,
83 83
                 'type' => $this->type->toNative(),
84 84
             ]
Please login to merge, or discard this patch.
src/Offer/DefaultExternalOfferEditingService.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -39,12 +39,12 @@  discard block
 block discarded – undo
39 39
     public function addLabel(IriOfferIdentifier $identifier, Label $label)
40 40
     {
41 41
         $uri = $this->createUri(
42
-            (string) $identifier->getIri(),
42
+            (string)$identifier->getIri(),
43 43
             'labels'
44 44
         );
45 45
 
46 46
         $data = [
47
-            'label' => (string) $label,
47
+            'label' => (string)$label,
48 48
         ];
49 49
 
50 50
         $request = $this->createJsonPostRequest($uri, $data);
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
     private function createUri($iri, $path)
60 60
     {
61 61
         return $this->psr7Factory->createUri(
62
-            rtrim($iri, '/') . '/' . $path
62
+            rtrim($iri, '/').'/'.$path
63 63
         );
64 64
     }
65 65
 
Please login to merge, or discard this patch.
src/Offer/BulkLabelCommandHandler.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
             $this->externalOfferEditingService->addLabel($offerIdentifier, $label);
92 92
         } catch (\Exception $e) {
93 93
             $logContext = [
94
-                'iri' => (string) $offerIdentifier->getIri(),
94
+                'iri' => (string)$offerIdentifier->getIri(),
95 95
                 'command' => $originalCommandName,
96 96
                 'exception' => get_class($e),
97 97
                 'message' => $e->getMessage(),
Please login to merge, or discard this patch.
src/Offer/Events/AbstractEventWithIri.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
      */
17 17
     public function __construct($iri)
18 18
     {
19
-        $this->iri = (string) $iri;
19
+        $this->iri = (string)$iri;
20 20
     }
21 21
 
22 22
     /**
Please login to merge, or discard this patch.