CultuurNet\UDB3\Cdb\Description\MergedDescription

Complexity

Total Complexity

14

Size/Duplication

Total Lines	104
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	fromCdbDetail()	0	28	7
A	merge()	0	30	3
A	getShortDescriptionUDB2FormattingFilter()	0	7	2
A	getShortDescriptionUDB3FormattingFilter()	0	7	2

<?php

namespace CultuurNet\UDB3\Cdb\Description;

use CultuurNet\UDB3\StringFilter\StringFilterInterface;
use ValueObjects\StringLiteral\StringLiteral;

class MergedDescription extends StringLiteral
{
    /**
     * @var StringFilterInterface
     */
    private static $shortDescriptionUDB2FormattingFilter;

    /**
     * @var StringFilterInterface
     */
    private static $shortDescriptionUDB3FormattingFilter;

    /**
     * @param \CultureFeed_Cdb_Data_Detail $detail
     * @return MergedDescription
     * @throws \InvalidArgumentException
     */
    public static function fromCdbDetail(\CultureFeed_Cdb_Data_Detail $detail)
    {
        $longDescription = $detail->getLongDescription();
        if ($longDescription) {
            $longDescription = LongDescription::fromCdbXmlToJsonLdFormat($longDescription);
        }

        $shortDescription = $detail->getShortDescription();
        if ($shortDescription) {
            $shortDescription = ShortDescription::fromCdbXmlToJsonLdFormat($shortDescription);
        }

        if ($longDescription && $shortDescription) {
            return MergedDescription::merge($shortDescription, $longDescription);

It seems like $shortDescription defined by $detail->getShortDescription() on line 32 can also be of type string; however, CultuurNet\UDB3\Cdb\Description\MergedDescription::merge() does only seem to accept object<CultuurNet\UDB3\Cdb\Description\ShortDescription>, maybe add an additional type check?

It seems like $longDescription defined by $detail->getLongDescription() on line 27 can also be of type string; however, CultuurNet\UDB3\Cdb\Description\MergedDescription::merge() does only seem to accept object<CultuurNet\UDB3\Cdb\Description\LongDescription>, maybe add an additional type check?

        }

        if ($longDescription) {
            return new MergedDescription($longDescription->toNative());
        }

        if ($shortDescription) {
            return new MergedDescription($shortDescription->toNative());
        }

        throw new \InvalidArgumentException(
            'Could not create MergedDescription object from given ' . get_class($detail) . '.'
        );
    }

    /**
     * @param ShortDescription $shortDescription
     * @param LongDescription $longDescription
     * @return MergedDescription $longDescription
     */
    public static function merge(ShortDescription $shortDescription, LongDescription $longDescription)
    {
        $shortAsString = $shortDescription->toNative();
        $longAsString = $longDescription->toNative();

        $shortAsStringWithoutEllipsis = rtrim($shortAsString, '. ');

        $longFormattedAsUdb2Short = self::getShortDescriptionUDB2FormattingFilter()->filter($longAsString);
        $longFormattedAsUdb3Short = self::getShortDescriptionUDB3FormattingFilter()->filter($longAsString);

        $udb2Comparison = strncmp(
            $longFormattedAsUdb2Short,
            $shortAsStringWithoutEllipsis,
            mb_strlen($shortAsStringWithoutEllipsis)
        );

        $udb3Comparison = strncmp(
            $longFormattedAsUdb3Short,
            $shortAsStringWithoutEllipsis,
            mb_strlen($shortAsStringWithoutEllipsis)
        );

        $shortIncludedInLong = $udb2Comparison === 0 || $udb3Comparison === 0;

        if ($shortIncludedInLong) {
            return new MergedDescription($longAsString);
        } else {
            return new MergedDescription($shortAsString . PHP_EOL . PHP_EOL . $longAsString);
        }
    }

    /**
     * @return StringFilterInterface
     */
    private static function getShortDescriptionUDB2FormattingFilter()
    {
        if (!isset(self::$shortDescriptionUDB2FormattingFilter)) {
            self::$shortDescriptionUDB2FormattingFilter = new ShortDescriptionUDB2FormattingFilter();
        }
        return self::$shortDescriptionUDB2FormattingFilter;
    }

    /**
     * @return StringFilterInterface
     */
    private static function getShortDescriptionUDB3FormattingFilter()
    {
        if (!isset(self::$shortDescriptionUDB3FormattingFilter)) {
            self::$shortDescriptionUDB3FormattingFilter = new ShortDescriptionUDB3FormattingFilter();
        }
        return self::$shortDescriptionUDB3FormattingFilter;
    }
}