PreApproval - Code Metrics - Inspection of "Merge pull request #20 from culturekings/in-store-..." - culturekings/afterpay - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 67a5da...c35f7b )

by Jared

created 2017-01-22 23:07 UTC

PreApproval A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	4
c	2
b	0
f	0
lcom	1
cbo	7
dl	0
loc	64
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
B	enquiry()	0	37	3

<?php

namespace CultureKings\Afterpay\Service\InStore;

use CultureKings\Afterpay\Exception\ApiException;
use CultureKings\Afterpay\Model;
use CultureKings\Afterpay\Traits;
use GuzzleHttp\Client;
use GuzzleHttp\Exception\BadResponseException;
use GuzzleHttp\HandlerStack;
use JMS\Serializer\SerializerInterface;

/**
 * Class PreApproval
 * @package CultureKings\Afterpay\Service\InStore
 */
class PreApproval
{
    use Traits\ClientTrait;
    use Traits\AuthorizationTrait;
    use Traits\SerializerTrait;

    /**
     * Device constructor.
     *
     * @param Model\InStore\Authorization $auth
     * @param Client                      $client
     * @param SerializerInterface         $serializer
     */
    public function __construct(Model\InStore\Authorization $auth, Client $client, SerializerInterface $serializer)
    {
        $this->setAuthorization($auth);
        $this->setClient($client);
        $this->setSerializer($serializer);
    }

    /**
     * @param string            $preApprovalCode
     * @param HandlerStack|null $stack
     *
     * @return array|\JMS\Serializer\scalar|object
     */
    public function enquiry($preApprovalCode, HandlerStack $stack = null)
    {
        try {
            $params = [
                'headers' => [
                    'Accept' => 'application/json',
                    'Content-Type' => 'application/json',
                    'Authorization' => sprintf('Bearer %s', $this->getAuthorization()->getDeviceToken()),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    'Operator' => $this->getAuthorization()->getOperator(),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    'User-Agent' => $this->getAuthorization()->getUserAgent()
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                ],
                'body' => $this->getSerializer()->serialize(
                    ['preApprovalCode' => $preApprovalCode],
                    'json'
                ),
            ];
            if ($stack !== null) {
                $params['handler'] = $stack;
            }

            $result = $this->getClient()->post('preapprovals/enquire', $params);

            return $this->getSerializer()->deserialize(
                (string) $result->getBody(),
                Model\InStore\PreApproval::class,
                'json'
            );
        } catch (BadResponseException $e) {
            throw new ApiException(
                $this->getSerializer()->deserialize(
                    (string) $e->getResponse()->getBody(),
                    Model\ErrorResponse::class,
                    'json'
                )
            );
        }
    }
}


Push — master ( 67a5da...c35f7b )

PreApproval A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace CultureKings\Afterpay\Service\InStore;
4
5			use CultureKings\Afterpay\Exception\ApiException;
6			use CultureKings\Afterpay\Model;
7			use CultureKings\Afterpay\Traits;
8			use GuzzleHttp\Client;
9			use GuzzleHttp\Exception\BadResponseException;
10			use GuzzleHttp\HandlerStack;
11			use JMS\Serializer\SerializerInterface;
12
13			/**
14			* Class PreApproval
15			* @package CultureKings\Afterpay\Service\InStore
16			*/
17			class PreApproval
18			{
19			use Traits\ClientTrait;
20			use Traits\AuthorizationTrait;
21			use Traits\SerializerTrait;
22
23			/**
24			* Device constructor.
25			*
26			* @param Model\InStore\Authorization $auth
27			* @param Client $client
28			* @param SerializerInterface $serializer
29			*/
30			public function __construct(Model\InStore\Authorization $auth, Client $client, SerializerInterface $serializer)
31			{
32			$this->setAuthorization($auth);
33			$this->setClient($client);
34			$this->setSerializer($serializer);
35			}
36
37			/**
38			* @param string $preApprovalCode
39			* @param HandlerStack\|null $stack
40			*
41			* @return array\|\JMS\Serializer\scalar\|object
42			*/
43			public function enquiry($preApprovalCode, HandlerStack $stack = null)
44			{
45			try {
46			$params = [
47			'headers' => [
48			'Accept' => 'application/json',
49			'Content-Type' => 'application/json',
50			'Authorization' => sprintf('Bearer %s', $this->getAuthorization()->getDeviceToken()),
			0 ignored issues – show Bug introduced 2017-01-18 05:13 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CultureKings\Afterpay\Co...\AuthorizationInterface` as the method `getDeviceToken()` does only exist in the following implementations of said interface: `CultureKings\Afterpay\Model\InStore\Authorization`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
51			'Operator' => $this->getAuthorization()->getOperator(),
			0 ignored issues – show Bug introduced 2017-01-18 05:13 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CultureKings\Afterpay\Co...\AuthorizationInterface` as the method `getOperator()` does only exist in the following implementations of said interface: `CultureKings\Afterpay\Model\InStore\Authorization`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
52			'User-Agent' => $this->getAuthorization()->getUserAgent()
			0 ignored issues – show Bug introduced 2017-01-18 05:13 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CultureKings\Afterpay\Co...\AuthorizationInterface` as the method `getUserAgent()` does only exist in the following implementations of said interface: `CultureKings\Afterpay\Model\InStore\Authorization`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
53			],
54			'body' => $this->getSerializer()->serialize(
55			['preApprovalCode' => $preApprovalCode],
56			'json'
57			),
58			];
59			if ($stack !== null) {
60			$params['handler'] = $stack;
61			}
62
63			$result = $this->getClient()->post('preapprovals/enquire', $params);
64
65			return $this->getSerializer()->deserialize(
66			(string) $result->getBody(),
67			Model\InStore\PreApproval::class,
68			'json'
69			);
70			} catch (BadResponseException $e) {
71			throw new ApiException(
72			$this->getSerializer()->deserialize(
73			(string) $e->getResponse()->getBody(),
74			Model\ErrorResponse::class,
75			'json'
76			)
77			);
78			}
79			}
80			}
81

culturekings / afterpay

Push — master ( 67a5da...c35f7b )

PreApproval A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like