cubiche / web

Url.php

<?php

/*
 * This file is part of the Cubiche package.
 *
 * Copyright (c) Cubiche
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Cubiche\Domain\Web;

use Cubiche\Domain\System\StringLiteral;

/**
 * Url class.
 *
 * @author Ivannis Suárez Jerez <ivannis.suarez@gmail.com>
 */
class Url extends StringLiteral
{
    /**
     * @var string
     */
    protected $scheme;

    /**
     * @var string
     */
    protected $user;

    /**
     * @var string
     */
    protected $password;

    /**
     * @var Host
     */
    protected $host;

    /**
     * @var string
     */
    protected $path;

    /**
     * @var Port
     */
    protected $port;

    /**
     * @var string
     */
    protected $queryString;

    /**
     * @var string
     */
    protected $fragmentId;

    /**
     * @param string $url
     *
     * @throws \InvalidArgumentException
     */
    public function __construct($url)
    {
        parent::__construct($url);

        $user = \parse_url($url, PHP_URL_USER);
        $this->user = $user ? new StringLiteral($user) : new StringLiteral('');

It seems like $user ? new \Cubiche\Domain\System\StringLiteral($user) : new \Cubiche\Domain\System\StringLiteral('') of type object<Cubiche\Domain\System\StringLiteral> is incompatible with the declared type string of property $user.

        $pass = \parse_url($url, PHP_URL_PASS);
        $this->password = $pass ? new StringLiteral($pass) : new StringLiteral('');

It seems like $pass ? new \Cubiche\Domain\System\StringLiteral($pass) : new \Cubiche\Domain\System\StringLiteral('') of type object<Cubiche\Domain\System\StringLiteral> is incompatible with the declared type string of property $password.

        $this->scheme = $this->parseScheme($url);

It seems like $this->parseScheme($url) of type object<Cubiche\Domain\System\StringLiteral> is incompatible with the declared type string of property $scheme.

        $this->host = $this->parseHost($url);
        $this->path = $this->parsePath($url);

It seems like $this->parsePath($url) of type object<Cubiche\Domain\Web\Path> is incompatible with the declared type string of property $path.

        $this->port = $this->parsePort($url);
        $this->queryString = $this->parseQueryString($url);

It seems like $this->parseQueryString($url) of type object<Cubiche\Domain\System\StringLiteral> is incompatible with the declared type string of property $queryString.

        $this->fragmentId = $this->parseFragmentIdentifier($url);

It seems like $this->parseFragmentIdentifier($url) of type object<Cubiche\Domain\System\StringLiteral> is incompatible with the declared type string of property $fragmentId.

        $this->createUrl();
    }

    protected function createUrl()
    {
        $userPass = '';
        if ($this->user()->isEmpty() === false) {

The method isEmpty cannot be called on $this->user() (of type string).

            $userPass = \sprintf('%s@', $this->user());
            if ($this->password()->isEmpty() === false) {

The method isEmpty cannot be called on $this->password() (of type string).

                $userPass = \sprintf('%s:%s@', $this->user(), $this->password());
            }
        }
        $port = '';
        if ($this->port() !== null) {
            $port = \sprintf(':%d', $this->port()->toNative());
        }

        $this->value = \sprintf(
            '%s://%s%s%s%s%s%s',
            $this->scheme(),
            $userPass,
            $this->host(),
            $port,
            $this->path(),
            $this->queryString(),
            $this->fragmentId()
        );
    }

    /**
     * @param string $url
     *
     * @throws \InvalidArgumentException
     *
     * @return string
     */
    protected function parseScheme($url)
    {
        $scheme = \parse_url($url, PHP_URL_SCHEME);
        if (\preg_match('/^[a-z]([a-z0-9\+\.-]+)?$/i', $scheme) === 0) {
            throw new \InvalidArgumentException(sprintf(
                'Argument "%s" is invalid. Allowed types for argument are "schema".',
                $url
            ));
        }

        return new StringLiteral($scheme);

It seems like $scheme defined by \parse_url($url, PHP_URL_SCHEME) on line 121 can also be of type false; however, Cubiche\Domain\System\StringLiteral::__construct() does only seem to accept string, did you maybe forget to handle an error condition?

    }

    /**
     * @param string $url
     *
     * @throws \InvalidArgumentException
     *
     * @return Host
     */
    protected function parseHost($url)
    {
        $host = \parse_url($url, PHP_URL_HOST);

        return Host::fromNative($host);
    }

    /**
     * @param string $url
     *
     * @throws \InvalidArgumentException
     *
     * @return Path | null
     */
    protected function parsePath($url)
    {
        $path = \parse_url($url, PHP_URL_PATH);
        $filteredValue = parse_url($path, PHP_URL_PATH);
        if ($filteredValue === null || strlen($filteredValue) != strlen($path)) {

This code seems to be duplicated across your project.

            throw new \InvalidArgumentException(sprintf(
                'Argument "%s" is invalid. Allowed types for argument are "url".',
                $url
            ));
        }

        return new Path($filteredValue);

It seems like $filteredValue defined by parse_url($path, PHP_URL_PATH) on line 156 can also be of type false; however, Cubiche\Domain\Web\Path::__construct() does only seem to accept string, did you maybe forget to handle an error condition?

    }

    /**
     * @param string $url
     *
     * @return Port | NULL
     */
    protected function parsePort($url)
    {
        $port = \parse_url($url, PHP_URL_PORT);
        if ($port) {

The expression $port of type integer|false is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

            return new Port($port);
        }

        return;
    }

    /**
     * @param string $url
     *
     * @throws \InvalidArgumentException
     *
     * @return string
     */
    protected function parseQueryString($url)
    {
        $queryString = \parse_url($url, PHP_URL_QUERY);
        if ($queryString) {

The expression $queryString of type string|false is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== false instead.

            $queryString = \sprintf('?%s', $queryString);

            return new StringLiteral($queryString);
        }

        return new StringLiteral('');
    }

    /**
     * @param string $url
     *
     * @throws \InvalidArgumentException
     *
     * @return string
     */
    protected function parseFragmentIdentifier($url)
    {
        $fragmentId = \parse_url($url, PHP_URL_FRAGMENT);
        if ($fragmentId) {

The expression $fragmentId of type string|false is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== false instead.

            $fragment = \sprintf('#%s', $fragmentId);
            if (\preg_match('/^#[?%!$&\'()*+,;=a-zA-Z0-9-._~:@\/]*$/', $fragment) === 0) {
                throw new \InvalidArgumentException(sprintf(
                    'Argument "%s" is invalid. Allowed types for argument are "fragment identifier".',
                    $fragment
                ));
            }

            return new StringLiteral($fragment);
        }

        return new StringLiteral('');
    }

    /**
     * @return Host
     */
    public function host()
    {
        return $this->host;
    }

    /**
     * @return string
     */
    public function fragmentId()
    {
        return $this->fragmentId;
    }

    /**
     * @return string
     */
    public function password()
    {
        return $this->password;
    }

    /**
     * @return string
     */
    public function path()
    {
        return $this->path;
    }

    /**
     * @return int
     */
    public function port()
    {
        return $this->port;
    }

    /**
     * @return string
     */
    public function queryString()
    {
        return $this->queryString;
    }

    /**
     * @return string
     */
    public function scheme()
    {
        return $this->scheme;
    }

    /**
     * @return string
     */
    public function user()
    {
        return $this->user;
    }
}