Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
23 | class EmailAddressTests extends StringLiteralTests |
||
24 | { |
||
25 | /** |
||
26 | * {@inheritdoc} |
||
27 | */ |
||
28 | protected function randomNativeValue() |
||
32 | |||
33 | /** |
||
34 | * {@inheritdoc} |
||
35 | */ |
||
36 | protected function invalidNativeValue() |
||
40 | |||
41 | /** |
||
42 | * {@inheritdoc} |
||
43 | */ |
||
44 | protected function uniqueNativeValue() |
||
48 | |||
49 | /** |
||
50 | * {@inheritdoc} |
||
51 | */ |
||
52 | protected function fromNative($value) |
||
56 | |||
57 | /** |
||
58 | * Test isEmpty method. |
||
59 | */ |
||
60 | View Code Duplication | public function testIsEmpty() |
|
72 | |||
73 | /** |
||
74 | * Test IsValid method. |
||
75 | */ |
||
76 | public function testIsValid() |
||
85 | |||
86 | /** |
||
87 | * Test User method. |
||
88 | */ |
||
89 | public function testUser() |
||
98 | |||
99 | /** |
||
100 | * Test Domain method. |
||
101 | */ |
||
102 | public function testDomain() |
||
111 | } |
||
112 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.