SmartExpressionToStringConverter::visitOperator() - Code Metrics - Inspection of "added dynamic dispatch vivitor" - cubiche/visitor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 59818d...80b14f )

by Ivannis Suárez

created 2016-07-04 22:03 UTC

SmartExpressionToStringConverter::visitOperator() A

↳ Parent: SmartExpressionToStringConverter

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	8
rs	9.4285
cc	2
eloc	5
nc	2
nop	2

<?php

/**
 * This file is part of the Cubiche package.
 *
 * Copyright (c) Cubiche
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Cubiche\Core\Visitor\Tests\Fixtures;

use Cubiche\Core\Visitor\Visitor;

/**
 * Smart Expression to String Converter Class.
 *
 * @author Karel Osorio Ramírez <[email protected]>
 */
class SmartExpressionToStringConverter extends Visitor
{
    /**
     * @param Operator $op
     *
     * @return string
     */
    public function visitOperator(Operator $op, $parentOperator = null)
    {
        $currentOperator = $op->operator();
        $expression = $op->firstOperand()->accept($this, $currentOperator).
            $currentOperator.$op->secondOperand()->accept($this, $currentOperator);

        return $this->requireParentheses($currentOperator, $parentOperator) ? '('.$expression.')' : $expression;
    }

    /**
     * @param Value $value
     *
     * @return string
     */
    public function visitValue(Value $value)
    {
        return (string) $value->value();
    }

    /**
     * @param Variable $variable
     *
     * @return string
     */
    public function visitVariable(Variable $variable)
    {
        return $variable->name();
    }

    /**
     * @param string $currentOperator
     * @param string $parentOperator
     *
     * @return bool
     */
    protected function requireParentheses($currentOperator, $parentOperator)
    {
        return $currentOperator === '+' && $parentOperator === '*';
    }
}


1			<?php
2
3			/**
4			* This file is part of the Cubiche package.
5			*
6			* Copyright (c) Cubiche
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11			namespace Cubiche\Core\Visitor\Tests\Fixtures;
12
13			use Cubiche\Core\Visitor\Visitor;
14
15			/**
16			* Smart Expression to String Converter Class.
17			*
18			* @author Karel Osorio Ramírez <[email protected]>
19			*/
20			class SmartExpressionToStringConverter extends Visitor
21			{
22			/**
23			* @param Operator $op
24			*
25			* @return string
26			*/
27			public function visitOperator(Operator $op, $parentOperator = null)
28			{
29			$currentOperator = $op->operator();
30			$expression = $op->firstOperand()->accept($this, $currentOperator).
31			$currentOperator.$op->secondOperand()->accept($this, $currentOperator);
32
33			return $this->requireParentheses($currentOperator, $parentOperator) ? '('.$expression.')' : $expression;
34			}
35
36			/**
37			* @param Value $value
38			*
39			* @return string
40			*/
41			public function visitValue(Value $value)
42			{
43			return (string) $value->value();
44			}
45
46			/**
47			* @param Variable $variable
48			*
49			* @return string
50			*/
51			public function visitVariable(Variable $variable)
52			{
53			return $variable->name();
54			}
55
56			/**
57			* @param string $currentOperator
58			* @param string $parentOperator
59			*
60			* @return bool
61			*/
62			protected function requireParentheses($currentOperator, $parentOperator)
63			{
64			return $currentOperator === '+' && $parentOperator === '*';
65			}
66			}
67

cubiche / visitor

Push — master ( 59818d...80b14f )

SmartExpressionToStringConverter::visitOperator() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like