Issues in NotSpecification.php - All Issues - Inspection of "refactoring callable and comparable" - cubiche/specification - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 821836...61718d )

by Ivannis Suárez

created 2016-07-09 07:17 UTC

NotSpecification.php (2 issues)

Labels

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * This file is part of the Cubiche package.
 *
 * Copyright (c) Cubiche
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Cubiche\Core\Specification;

/**
 * Not Specification Class.
 *
 * @author Karel Osorio Ramírez <[email protected]>
 */
class NotSpecification extends Specification

{
    /**
     * @var SpecificationInterface
     */
    protected $specification;

    /**
     * @param SpecificationInterface $specification
     */
    public function __construct(SpecificationInterface $specification)
    {
        $this->specification = $specification;
    }

    /**
     * {@inheritdoc}
     */
    public function evaluate($value)
    {
        return !$this->specification()->evaluate($value);
    }

    /**
     * @return \Cubiche\Core\Specification\SpecificationInterface
     */
    public function specification()
    {
        return $this->specification;
    }

    /**
     * {@inheritdoc}
     */
    public function not()
    {
        return $this->specification();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1			<?php
2
3			/**
4			* This file is part of the Cubiche package.
5			*
6			* Copyright (c) Cubiche
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11			namespace Cubiche\Core\Specification;
12
13			/**
14			* Not Specification Class.
15			*
16			* @author Karel Osorio Ramírez <[email protected]>
17			*/
18			class NotSpecification extends Specification
			0 ignored issues – show Bug introduced 2016-07-09 07:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is one abstract method `accept` in this class; you could implement it, or declare this class as abstract. Loading history...
19			{
20			/**
21			* @var SpecificationInterface
22			*/
23			protected $specification;
24
25			/**
26			* @param SpecificationInterface $specification
27			*/
28			public function __construct(SpecificationInterface $specification)
29			{
30			$this->specification = $specification;
31			}
32
33			/**
34			* {@inheritdoc}
35			*/
36			public function evaluate($value)
37			{
38			return !$this->specification()->evaluate($value);
39			}
40
41			/**
42			* @return \Cubiche\Core\Specification\SpecificationInterface
43			*/
44			public function specification()
45			{
46			return $this->specification;
47			}
48
49			/**
50			* {@inheritdoc}
51			*/
52			public function not()
53			{
54			return $this->specification();
			0 ignored issues – show Bug Best Practice introduced 2016-04-20 16:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this->specification();` (`Cubiche\Core\Specification\SpecificationInterface`) is incompatible with the return type declared by the interface `Cubiche\Core\Specificati...ificationInterface::not` of type `Cubiche\Domain\Specifica...\SpecificationInterface`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
55			}
56			}
57

cubiche / specification

Push — master ( 821836...61718d )

NotSpecification.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like