EventListener::postLoadClassMetadata() - Code Metrics - cubiche/model-adapter - Measure and Improve Code Quality continuously with Scrutinizer

EventListener::postLoadClassMetadata() A
last analyzed 2017-05-24 19:14 UTC

↳ Parent: EventListener

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

/**
 * This file is part of the Cubiche package.
 *
 * Copyright (c) Cubiche
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Cubiche\Infrastructure\Model\Doctrine\ODM\MongoDB\EventListener;

use Cubiche\Core\Metadata\PropertyMetadata;
use Cubiche\Infrastructure\Doctrine\ODM\MongoDB\Event\RegisterDriverMetadataEventArgs;
use Cubiche\Infrastructure\Model\Doctrine\ODM\MongoDB\Metadata\Driver\XmlDriver;
use Cubiche\Infrastructure\Model\Doctrine\ODM\MongoDB\Types\DynamicNativeValueObjectType;
use Doctrine\ODM\MongoDB\Event\LoadClassMetadataEventArgs;
use Doctrine\ODM\MongoDB\Mapping\ClassMetadata;
use Doctrine\ODM\MongoDB\Types\Type;

/**
 * Event Listener Class.
 *
 * @author Karel Osorio Ramírez <[email protected]>
 * @author Ivannis Suárez Jerez <[email protected]>
 */
class EventListener
{
    /**
     * @param RegisterDriverMetadataEventArgs $eventArgs
     */
    public function registerDriverMetadata(RegisterDriverMetadataEventArgs $eventArgs)
    {
        $eventArgs->driverFactory()->registerXmlDriver(XmlDriver::class);
    }

    /**
     * @param LoadClassMetadataEventArgs $eventArgs
     */
    public function postLoadClassMetadata(LoadClassMetadataEventArgs $eventArgs)
    {
        $this->checkValueObjectType($eventArgs->getClassMetadata());

    }

    /**
     * @param ClassMetadata $classMetadata
     */
    protected function checkValueObjectType(ClassMetadata $classMetadata)
    {
        foreach ($classMetadata->fieldMappings as $fieldName => $mapping) {
            if (isset($mapping['cubiche:valueobject'])) {
                /** @var PropertyMetadata $propertyMetadata */
                $propertyMetadata = $mapping['cubiche:valueobject'];

                $type = str_replace('\\', '.', $propertyMetadata->getMetadata('type'));
                if (!Type::hasType($type)) {
                    Type::registerType($type, DynamicNativeValueObjectType::class);
                    Type::getType($type)->setTargetClass($propertyMetadata->getMetadata('type'));
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                }

                $classMetadata->fieldMappings[$fieldName]['type'] = $type;
            }
        }
    }
}


1			<?php
2
3			/**
4			* This file is part of the Cubiche package.
5			*
6			* Copyright (c) Cubiche
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Cubiche\Infrastructure\Model\Doctrine\ODM\MongoDB\EventListener;
13
14			use Cubiche\Core\Metadata\PropertyMetadata;
15			use Cubiche\Infrastructure\Doctrine\ODM\MongoDB\Event\RegisterDriverMetadataEventArgs;
16			use Cubiche\Infrastructure\Model\Doctrine\ODM\MongoDB\Metadata\Driver\XmlDriver;
17			use Cubiche\Infrastructure\Model\Doctrine\ODM\MongoDB\Types\DynamicNativeValueObjectType;
18			use Doctrine\ODM\MongoDB\Event\LoadClassMetadataEventArgs;
19			use Doctrine\ODM\MongoDB\Mapping\ClassMetadata;
20			use Doctrine\ODM\MongoDB\Types\Type;
21
22			/**
23			* Event Listener Class.
24			*
25			* @author Karel Osorio Ramírez <[email protected]>
26			* @author Ivannis Suárez Jerez <[email protected]>
27			*/
28			class EventListener
29			{
30			/**
31			* @param RegisterDriverMetadataEventArgs $eventArgs
32			*/
33			public function registerDriverMetadata(RegisterDriverMetadataEventArgs $eventArgs)
34			{
35			$eventArgs->driverFactory()->registerXmlDriver(XmlDriver::class);
36			}
37
38			/**
39			* @param LoadClassMetadataEventArgs $eventArgs
40			*/
41			public function postLoadClassMetadata(LoadClassMetadataEventArgs $eventArgs)
42			{
43			$this->checkValueObjectType($eventArgs->getClassMetadata());
			0 ignored issues – show Compatibility introduced 2016-11-02 13:30 UTC by Report Bug Copy Issue Report `$eventArgs->getClassMetadata()` of type `object<Doctrine\Common\P...\Mapping\ClassMetadata>` is not a sub-type of `object<Doctrine\ODM\Mong...\Mapping\ClassMetadata>`. It seems like you assume a concrete implementation of the interface `Doctrine\Common\Persistence\Mapping\ClassMetadata` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
44			}
45
46			/**
47			* @param ClassMetadata $classMetadata
48			*/
49			protected function checkValueObjectType(ClassMetadata $classMetadata)
50			{
51			foreach ($classMetadata->fieldMappings as $fieldName => $mapping) {
52			if (isset($mapping['cubiche:valueobject'])) {
53			/** @var PropertyMetadata $propertyMetadata */
54			$propertyMetadata = $mapping['cubiche:valueobject'];
55
56			$type = str_replace('\\', '.', $propertyMetadata->getMetadata('type'));
57			if (!Type::hasType($type)) {
58			Type::registerType($type, DynamicNativeValueObjectType::class);
59			Type::getType($type)->setTargetClass($propertyMetadata->getMetadata('type'));
			0 ignored issues – show Bug introduced 2017-05-24 18:07 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Doctrine\ODM\MongoDB\Types\Type` as the method `setTargetClass()` does only exist in the following sub-classes of `Doctrine\ODM\MongoDB\Types\Type`: `Cubiche\Infrastructure\M...icNativeValueObjectType`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
60			}
61
62			$classMetadata->fieldMappings[$fieldName]['type'] = $type;
63			}
64			}
65			}
66			}
67

cubiche / model-adapter

EventListener::postLoadClassMetadata() A last analyzed 2017-05-24 19:14 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

EventListener::postLoadClassMetadata() A
last analyzed 2017-05-24 19:14 UTC