GeoSpecificationVisitorTrait::visitNear()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 11
Code Lines 7

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 11
rs 9.4285
c 0
b 0
f 0
cc 1
eloc 7
nc 1
nop 1
1
<?php
2
3
/**
4
 * This file is part of the Cubiche package.
5
 *
6
 * Copyright (c) Cubiche
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
namespace Cubiche\Infrastructure\Geolocation\Doctrine\ODM\MongoDB\Query;
13
14
use Cubiche\Core\Selector\Property;
15
use Cubiche\Domain\Geolocation\Specification\Constraint\Near;
16
17
/**
18
 * Geo Specification Visitor Trait.
19
 *
20
 * @author Karel Osorio Ramírez <[email protected]>
21
 */
22
trait GeoSpecificationVisitorTrait
23
{
24
    /**
25
     * {@inheritdoc}
26
     */
27
    public function visitNear(Near $near)
28
    {
29
        $field = $this->createField($near->selector()->select(new Property('coordinate')));
0 ignored issues
show
Bug introduced by
It seems like createField() must be provided by classes using this trait. How about adding it as abstract method to this trait?

This check looks for methods that are used by a trait but not required by it.

To illustrate, let’s look at the following code example

trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

The trait Idable provides a method equalsId that in turn relies on the method getId(). If this method does not exist on a class mixing in this trait, the method will fail.

Adding the getId() as an abstract method to the trait will make sure it is available.

Loading history...
30
        $this->queryBuilder->field($field->name())->near(array(
0 ignored issues
show
Bug introduced by
The property queryBuilder does not exist. Did you maybe forget to declare it?

In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:

class MyClass { }

$x = new MyClass();
$x->foo = true;

Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion:

class MyClass {
    public $foo;
}

$x = new MyClass();
$x->foo = true;
Loading history...
31
            'type' => 'Point',
32
            'coordinates' => array(
33
                $near->coordinate()->longitude()->toNative(),
34
                $near->coordinate()->latitude()->toNative(),
35
            ),
36
        ));
37
    }
38
}
39