ComparatorInterfaceTestCase::testOrX() - Code Metrics - Inspection of "refactoring callable and comparable" - cubiche/comparable - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 192638...f858f1 )

by Ivannis Suárez

created 2016-07-09 07:16 UTC

ComparatorInterfaceTestCase::testOrX() A

↳ Parent: ComparatorInterfaceTestCase

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	11
rs	9.4285
cc	1
eloc	7
nc	1
nop	0

<?php

/**
 * This file is part of the Cubiche package.
 *
 * Copyright (c) Cubiche
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Cubiche\Core\Comparable\Tests\Units;

use Cubiche\Core\Comparable\Comparator;
use Cubiche\Core\Comparable\ComparatorInterface;
use Cubiche\Core\Visitor\Tests\Units\VisiteeInterfaceTestCase;

/**
 * Comparator Interface Test Case Class.
 *
 * @author Ivannis Suárez Jerez <[email protected]>
 * @author Karel Osorio Ramírez <[email protected]>
 */
abstract class ComparatorInterfaceTestCase extends VisiteeInterfaceTestCase
{
    /**
     * Test class.
     */
    public function testClass()
    {
        $this
            ->testedClass
                ->implements(ComparatorInterface::class)
        ;
    }

    /**
     * Test compare.
     *
     * @param mixed $a
     * @param mixed $b
     * @param int   $expected
     *
     * @dataProvider compareDataProvider
     */
    public function testCompare($a, $b, $expected)

    {
        $this
            ->assert('The comparision is right')
                /* @var \Cubiche\Core\Comparable\ComparatorInterface $comparator */
                ->given($comparator = $this->newDefaultTestedInstance())
                ->then($this->comparision($comparator, $a, $b, $expected));

        $this
            ->assert('The comparator is a callable')
                ->given($result1 = $comparator->compare($a, $b))
                ->when($result2 = $comparator($a, $b))
                ->then()
                    ->variable($result1)
                        ->isEqualTo($result2);
    }

    /**
     * Test reverse method.
     *
     * @param mixed $a
     * @param mixed $b
     * @param int   $expected
     *
     * @dataProvider compareDataProvider
     */
    public function testReverse($a, $b, $expected)
    {
        $this
            ->assert('Reverse is a comparator')
                /* @var \Cubiche\Core\Comparable\ComparatorInterface $comparator */
                ->given($comparator = $this->newDefaultTestedInstance())
                ->when($reverse = $comparator->reverse())
                    ->then()
                        ->object($reverse)
                            ->isInstanceOf(ComparatorInterface::class)
        ;

        $this
            ->assert('Reverse result is the inverse result')
                ->then($this->comparision($reverse, $a, $b, -1 * $expected))
        ;
    }

    /**
     * Test otherwise method.
     *
     * @param callable $otherwise
     * @param mixed    $a
     * @param mixed    $b
     * @param int      $expected
     *
     * @dataProvider otherwiseDataProvider
     */
    public function testOtherwise(callable $otherwise, $a, $b, $expected)

    {
        $this
            ->assert('The otherwise result is a comparator')
                /* @var \Cubiche\Core\Comparable\ComparatorInterface $comparator */
                ->given($comparator = $this->newDefaultTestedInstance())
                ->when($otherwiseComparator = $comparator->otherwise($otherwise))
                    ->object($otherwiseComparator)
                        ->isInstanceOf(ComparatorInterface::class)
        ;

        $this
            ->assert('The otherwise comparator result is right')
                ->let($expected = $this->sign($expected))
                ->then(
                    $this->comparision($otherwiseComparator, $a, $b, $expected == 0 ? $otherwise($a, $b) : $expected)
                )
        ;
    }

    /**
     * @return array
     */
    abstract protected function compareDataProvider();

    /**
     * @return array
     */
    protected function otherwiseDataProvider()
    {
        foreach ($this->compareDataProvider() as $key => $data) {
            yield $key => \array_merge(array($this->newDefaultOtherwiseComparator()), $data);
        }
    }

    /**
     * @return callable
     */
    abstract protected function newDefaultOtherwiseComparator();

    /**
     * @param ComparatorInterface $comparator
     * @param mixed               $a
     * @param mixed               $b
     * @param int                 $expected
     */
    protected function comparision(ComparatorInterface $comparator, $a, $b, $expected)
    {
        $this
            ->given($comparator)
            ->when($result = $comparator->compare($a, $b))
            ->then()
                ->integer($this->sign($result))
                    ->isEqualTo($this->sign($expected))
        ;
    }

    /**
     * @param float|int $number
     *
     * @return int
     */
    protected function sign($number)
    {
        return $number >= 0 ? ($number == 0 ? 0 : 1) : -1;
    }
}


1		<?php
2
3		/**
4		* This file is part of the Cubiche package.
5		*
6		* Copyright (c) Cubiche
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11		namespace Cubiche\Core\Comparable\Tests\Units;
12
13		use Cubiche\Core\Comparable\Comparator;
14		use Cubiche\Core\Comparable\ComparatorInterface;
15		use Cubiche\Core\Visitor\Tests\Units\VisiteeInterfaceTestCase;
16
17		/**
18		* Comparator Interface Test Case Class.
19		*
20		* @author Ivannis Suárez Jerez <[email protected]>
21		* @author Karel Osorio Ramírez <[email protected]>
22		*/
23		abstract class ComparatorInterfaceTestCase extends VisiteeInterfaceTestCase
24		{
25		/**
26		* Test class.
27		*/
28		public function testClass()
29		{
30		$this
31		->testedClass
32		->implements(ComparatorInterface::class)
33		;
34		}
35
36		/**
37		* Test compare.
38		*
39		* @param mixed $a
40		* @param mixed $b
41		* @param int $expected
42		*
43		* @dataProvider compareDataProvider
44		*/
45	View Code Duplication	public function testCompare($a, $b, $expected)
		0 ignored issues – show Duplication introduced 2016-07-09 07:21 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46		{
47		$this
48		->assert('The comparision is right')
49		/* @var \Cubiche\Core\Comparable\ComparatorInterface $comparator */
50		->given($comparator = $this->newDefaultTestedInstance())
51		->then($this->comparision($comparator, $a, $b, $expected));
52
53		$this
54		->assert('The comparator is a callable')
55		->given($result1 = $comparator->compare($a, $b))
56		->when($result2 = $comparator($a, $b))
57		->then()
58		->variable($result1)
59		->isEqualTo($result2);
60		}
61
62		/**
63		* Test reverse method.
64		*
65		* @param mixed $a
66		* @param mixed $b
67		* @param int $expected
68		*
69		* @dataProvider compareDataProvider
70		*/
71		public function testReverse($a, $b, $expected)
72		{
73		$this
74		->assert('Reverse is a comparator')
75		/* @var \Cubiche\Core\Comparable\ComparatorInterface $comparator */
76		->given($comparator = $this->newDefaultTestedInstance())
77		->when($reverse = $comparator->reverse())
78		->then()
79		->object($reverse)
80		->isInstanceOf(ComparatorInterface::class)
81		;
82
83		$this
84		->assert('Reverse result is the inverse result')
85		->then($this->comparision($reverse, $a, $b, -1 * $expected))
86		;
87		}
88
89		/**
90		* Test otherwise method.
91		*
92		* @param callable $otherwise
93		* @param mixed $a
94		* @param mixed $b
95		* @param int $expected
96		*
97		* @dataProvider otherwiseDataProvider
98		*/
99	View Code Duplication	public function testOtherwise(callable $otherwise, $a, $b, $expected)
		0 ignored issues – show Duplication introduced 2016-07-09 07:21 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
100		{
101		$this
102		->assert('The otherwise result is a comparator')
103		/* @var \Cubiche\Core\Comparable\ComparatorInterface $comparator */
104		->given($comparator = $this->newDefaultTestedInstance())
105		->when($otherwiseComparator = $comparator->otherwise($otherwise))
106		->object($otherwiseComparator)
107		->isInstanceOf(ComparatorInterface::class)
108		;
109
110		$this
111		->assert('The otherwise comparator result is right')
112		->let($expected = $this->sign($expected))
113		->then(
114		$this->comparision($otherwiseComparator, $a, $b, $expected == 0 ? $otherwise($a, $b) : $expected)
115		)
116		;
117		}
118
119		/**
120		* @return array
121		*/
122		abstract protected function compareDataProvider();
123
124		/**
125		* @return array
126		*/
127		protected function otherwiseDataProvider()
128		{
129		foreach ($this->compareDataProvider() as $key => $data) {
130		yield $key => \array_merge(array($this->newDefaultOtherwiseComparator()), $data);
131		}
132		}
133
134		/**
135		* @return callable
136		*/
137		abstract protected function newDefaultOtherwiseComparator();
138
139		/**
140		* @param ComparatorInterface $comparator
141		* @param mixed $a
142		* @param mixed $b
143		* @param int $expected
144		*/
145		protected function comparision(ComparatorInterface $comparator, $a, $b, $expected)
146		{
147		$this
148		->given($comparator)
149		->when($result = $comparator->compare($a, $b))
150		->then()
151		->integer($this->sign($result))
152		->isEqualTo($this->sign($expected))
153		;
154		}
155
156		/**
157		* @param float\|int $number
158		*
159		* @return int
160		*/
161		protected function sign($number)
162		{
163		return $number >= 0 ? ($number == 0 ? 0 : 1) : -1;
164		}
165		}
166

cubiche / comparable

Push — master ( 192638...f858f1 )

ComparatorInterfaceTestCase::testOrX() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like