CollectionTestCase - Code Metrics - Inspection of "refactoring collections" - cubiche/collections - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 52ccab...c20e33 )

by Ivannis Suárez

created 2016-04-29 08:20 UTC

CollectionTestCase A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	324
Duplicated Lines	2.47 %

Coupling/Cohesion

Components	2
Dependencies	5

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	8
loc	324
wmc	17
lcom	2
cbo	5
rs	10

18 Methods

Rating	Name	Duplication	Size	Complexity
A	randomCollection()	0	7	1
A	randomValues()	0	12	3
	emptyCollection()	0	1	?
	randomValue()	0	1	?
	uniqueValue()	0	1	?
A	comparator()	0	4	1
A	testClass()	0	7	1
A	testAdd()	0	13	1
A	testAddAll()	0	12	1
B	testRemove()	0	34	1
A	testClear()	0	14	1
A	testCount()	0	10	1
A	testGetIterator()	0	9	1
B	testFind()	0	42	1
B	testFindOne()	0	42	1
A	testToArray()	8	8	1
A	testSlice()	0	15	1
A	testSorted()	0	16	1

How to fix Duplicated Code

<?php

/**
 * This file is part of the Cubiche package.
 *
 * Copyright (c) Cubiche
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Cubiche\Core\Collections\Tests\Units;

use Cubiche\Core\Collections\CollectionInterface;
use Cubiche\Core\Comparable\Comparator;
use Cubiche\Core\Specification\Criteria;

/**
 * Collection Test Case class.
 *
 * @author Ivannis Suárez Jerez <[email protected]>
 * @author Karel Osorio Ramírez <[email protected]>
 */
abstract class CollectionTestCase extends TestCase
{
    /**
     * @return \Cubiche\Core\Collections\CollectionInterface
     */
    protected function randomCollection($size = null)
    {
        $collection = $this->emptyCollection();
        $collection->addAll($this->randomValues($size));

        return $collection;
    }

    /**
     * @param int $size
     *
     * @return mixed[]
     */
    protected function randomValues($size = null)
    {
        $items = array();
        if ($size === null) {
            $size = \rand(10, 20);
        }
        foreach (\range(0, $size - 1) as $value) {
            $items[$value] = $this->randomValue();
        }

        return $items;
    }

    /**
     * @return CollectionInterface
     */
    abstract protected function emptyCollection();

    /**
     * @return mixed
     */
    abstract protected function randomValue();

    /**
     * @return mixed
     */
    abstract protected function uniqueValue();

    /**
     * @return \Cubiche\Core\Comparable\ComparatorInterface
     */
    protected function comparator()
    {
        return new Comparator();
    }

    /**
     * Test class.
     */
    public function testClass()
    {
        $this
            ->testedClass
                ->implements(CollectionInterface::class)
        ;
    }

    /**
     * Test add.
     */
    public function testAdd()
    {
        $this
            ->given($collection = $this->randomCollection())
            ->given($unique = $this->uniqueValue())
            ->let($count = $collection->count())
            ->when($collection->add($unique))
                ->collection($collection)
                    ->contains($unique)
                    ->size()
                        ->isEqualTo($count + 1)
        ;
    }

    /**
     * Test add.
     */
    public function testAddAll()
    {
        $this
        ->given($collection = $this->emptyCollection())
        ->given($items = $this->randomValues(10))
        ->when($collection->addAll($items))
            ->collection($collection)
                ->containsValues($items)
                ->size()
                    ->isEqualTo(\count($items))
        ;
    }

    /**
     * Test remove.
     */
    public function testRemove()
    {
        $this
            ->given(
                $unique = $this->uniqueValue(),
                $emptyCollection = $this->emptyCollection()
            )
            ->when($emptyCollection->add($unique))
            ->then()
                ->collection($emptyCollection)
                    ->contains($unique)
            ->and()
            ->when($emptyCollection->remove($unique))
            ->then()
                ->collection($emptyCollection)
                    ->notContains($unique)
        ;

        $this
            ->given(
                $unique = $this->uniqueValue(),
                $randomCollection = $this->randomCollection()
            )
            ->when($randomCollection->add($unique))
            ->then()
                ->collection($randomCollection)
                    ->contains($unique)
            ->and()
            ->when($randomCollection->remove($unique))
            ->then()
                ->collection($randomCollection)
                    ->notContains($unique)
        ;
    }

    /**
     * Test clear.
     */
    public function testClear()
    {
        $this
            ->given($randomCollection = $this->randomCollection())
            ->then()
                ->collection($randomCollection)
                    ->isNotEmpty()
            ->and()
            ->when($randomCollection->clear())
            ->then()
                ->collection($randomCollection)
                    ->isEmpty()
        ;
    }

    /**
     * Test count.
     */
    public function testCount()
    {
        $this
            ->given($collection = $this->randomCollection(5))
            ->then()
                ->collection($collection)
                    ->size()
                        ->isEqualTo(5)
        ;
    }

    /**
     * Test getIterator.
     */
    public function testGetIterator()
    {
        $this
            ->given($collection = $this->randomCollection())
            ->then
                ->object($collection->getIterator())
                    ->isInstanceOf(\Traversable::class)
        ;
    }

    /**
     * Test find.
     */
    public function testFind()
    {
        $this
            ->given(
                $unique = $this->uniqueValue(),
                $criteria = Criteria::eq($unique),
                $emptyCollection = $this->emptyCollection()
            )
            ->when($findResult = $emptyCollection->find($criteria))
            ->then
                ->collection($findResult)
                    ->isEmpty()
            ->and()
            ->when(
                $emptyCollection->add($unique),
                $findResult = $emptyCollection->find($criteria)
            )
            ->then
                ->collection($findResult)
                    ->contains($unique)
        ;

        $this
            ->given(
                $unique = $this->uniqueValue(),
                $criteria = Criteria::eq($unique),
                $randomCollection = $this->randomCollection()
            )
            ->when($findResult = $randomCollection->find($criteria))
            ->then
                ->collection($findResult)
                    ->isEmpty()
            ->and()
            ->when(
                $randomCollection->add($unique),
                $findResult = $randomCollection->find($criteria)
            )
            ->then
                ->collection($findResult)
                    ->contains($unique)
        ;
    }

    /**
     * Test findOne.
     */
    public function testFindOne()
    {
        $this
            ->given(
                $unique = $this->uniqueValue(),
                $criteria = Criteria::eq($unique),
                $emptyCollection = $this->emptyCollection()
            )
            ->when($findResult = $emptyCollection->findOne($criteria))
            ->then
                ->variable($findResult)
                    ->isNull()
            ->and()
            ->when(
                $emptyCollection->add($unique),
                $findResult = $emptyCollection->findOne($criteria)
            )
            ->then()
                ->variable($findResult)
                    ->isEqualTo($unique)
        ;

        $this
            ->given(
                $unique = $this->uniqueValue(),
                $criteria = Criteria::eq($unique),
                $randomCollection = $this->randomCollection()
            )
            ->when($findResult = $randomCollection->findOne($criteria))
            ->then()
                ->variable($findResult)
                    ->isNull()
            ->and()
            ->when(
                $randomCollection->add($unique),
                $findResult = $randomCollection->findOne($criteria)
            )
            ->then()
                ->variable($findResult)
                    ->isEqualTo($unique)
        ;
    }

    /**
     * Test toArray.
     */
    public function testToArray()

    {
        $this
            ->given($collection = $this->randomCollection())
            ->when($array = $collection->toArray())
                ->array($array)
                    ->isEqualTo(\iterator_to_array($collection->getIterator()));
    }

    /**
     * Test slice.
     */
    public function testSlice()
    {
        $this
            ->given($collection = $this->randomCollection())
            ->let($count = $collection->count())
            ->let($offset = rand(0, $count / 2))
            ->let($length = rand($count / 2, $count))
            ->let($maxCount = max([$count - $offset, 0]))
            ->when($slice = $collection->slice($offset, $length))
            ->then()
                ->collection($slice)
                    ->size()
                        ->isEqualTo(min($maxCount, $length))
        ;
    }

    /**
     * Test sorted.
     */
    public function testSorted()
    {
        $this
            ->given(
                $comparator = $this->comparator(),
                $reverseComparator = $comparator->reverse(),
                $collection = $this->randomCollection()
            )
            ->when($sortedCollection = $collection->sorted($comparator))
            ->then()
                ->collection($sortedCollection)
                    ->isSortedUsing($comparator)
                ->collection($sortedCollection)
                    ->isNotSortedUsing($reverseComparator)
        ;
    }
}


1		<?php
2
3		/**
4		* This file is part of the Cubiche package.
5		*
6		* Copyright (c) Cubiche
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11		namespace Cubiche\Core\Collections\Tests\Units;
12
13		use Cubiche\Core\Collections\CollectionInterface;
14		use Cubiche\Core\Comparable\Comparator;
15		use Cubiche\Core\Specification\Criteria;
16
17		/**
18		* Collection Test Case class.
19		*
20		* @author Ivannis Suárez Jerez <[email protected]>
21		* @author Karel Osorio Ramírez <[email protected]>
22		*/
23		abstract class CollectionTestCase extends TestCase
24		{
25		/**
26		* @return \Cubiche\Core\Collections\CollectionInterface
27		*/
28		protected function randomCollection($size = null)
29		{
30		$collection = $this->emptyCollection();
31		$collection->addAll($this->randomValues($size));
32
33		return $collection;
34		}
35
36		/**
37		* @param int $size
38		*
39		* @return mixed[]
40		*/
41		protected function randomValues($size = null)
42		{
43		$items = array();
44		if ($size === null) {
45		$size = \rand(10, 20);
46		}
47		foreach (\range(0, $size - 1) as $value) {
48		$items[$value] = $this->randomValue();
49		}
50
51		return $items;
52		}
53
54		/**
55		* @return CollectionInterface
56		*/
57		abstract protected function emptyCollection();
58
59		/**
60		* @return mixed
61		*/
62		abstract protected function randomValue();
63
64		/**
65		* @return mixed
66		*/
67		abstract protected function uniqueValue();
68
69		/**
70		* @return \Cubiche\Core\Comparable\ComparatorInterface
71		*/
72		protected function comparator()
73		{
74		return new Comparator();
75		}
76
77		/**
78		* Test class.
79		*/
80		public function testClass()
81		{
82		$this
83		->testedClass
84		->implements(CollectionInterface::class)
85		;
86		}
87
88		/**
89		* Test add.
90		*/
91		public function testAdd()
92		{
93		$this
94		->given($collection = $this->randomCollection())
95		->given($unique = $this->uniqueValue())
96		->let($count = $collection->count())
97		->when($collection->add($unique))
98		->collection($collection)
99		->contains($unique)
100		->size()
101		->isEqualTo($count + 1)
102		;
103		}
104
105		/**
106		* Test add.
107		*/
108		public function testAddAll()
109		{
110		$this
111		->given($collection = $this->emptyCollection())
112		->given($items = $this->randomValues(10))
113		->when($collection->addAll($items))
114		->collection($collection)
115		->containsValues($items)
116		->size()
117		->isEqualTo(\count($items))
118		;
119		}
120
121		/**
122		* Test remove.
123		*/
124		public function testRemove()
125		{
126		$this
127		->given(
128		$unique = $this->uniqueValue(),
129		$emptyCollection = $this->emptyCollection()
130		)
131		->when($emptyCollection->add($unique))
132		->then()
133		->collection($emptyCollection)
134		->contains($unique)
135		->and()
136		->when($emptyCollection->remove($unique))
137		->then()
138		->collection($emptyCollection)
139		->notContains($unique)
140		;
141
142		$this
143		->given(
144		$unique = $this->uniqueValue(),
145		$randomCollection = $this->randomCollection()
146		)
147		->when($randomCollection->add($unique))
148		->then()
149		->collection($randomCollection)
150		->contains($unique)
151		->and()
152		->when($randomCollection->remove($unique))
153		->then()
154		->collection($randomCollection)
155		->notContains($unique)
156		;
157		}
158
159		/**
160		* Test clear.
161		*/
162		public function testClear()
163		{
164		$this
165		->given($randomCollection = $this->randomCollection())
166		->then()
167		->collection($randomCollection)
168		->isNotEmpty()
169		->and()
170		->when($randomCollection->clear())
171		->then()
172		->collection($randomCollection)
173		->isEmpty()
174		;
175		}
176
177		/**
178		* Test count.
179		*/
180		public function testCount()
181		{
182		$this
183		->given($collection = $this->randomCollection(5))
184		->then()
185		->collection($collection)
186		->size()
187		->isEqualTo(5)
188		;
189		}
190
191		/**
192		* Test getIterator.
193		*/
194		public function testGetIterator()
195		{
196		$this
197		->given($collection = $this->randomCollection())
198		->then
199		->object($collection->getIterator())
200		->isInstanceOf(\Traversable::class)
201		;
202		}
203
204		/**
205		* Test find.
206		*/
207		public function testFind()
208		{
209		$this
210		->given(
211		$unique = $this->uniqueValue(),
212		$criteria = Criteria::eq($unique),
213		$emptyCollection = $this->emptyCollection()
214		)
215		->when($findResult = $emptyCollection->find($criteria))
216		->then
217		->collection($findResult)
218		->isEmpty()
219		->and()
220		->when(
221		$emptyCollection->add($unique),
222		$findResult = $emptyCollection->find($criteria)
223		)
224		->then
225		->collection($findResult)
226		->contains($unique)
227		;
228
229		$this
230		->given(
231		$unique = $this->uniqueValue(),
232		$criteria = Criteria::eq($unique),
233		$randomCollection = $this->randomCollection()
234		)
235		->when($findResult = $randomCollection->find($criteria))
236		->then
237		->collection($findResult)
238		->isEmpty()
239		->and()
240		->when(
241		$randomCollection->add($unique),
242		$findResult = $randomCollection->find($criteria)
243		)
244		->then
245		->collection($findResult)
246		->contains($unique)
247		;
248		}
249
250		/**
251		* Test findOne.
252		*/
253		public function testFindOne()
254		{
255		$this
256		->given(
257		$unique = $this->uniqueValue(),
258		$criteria = Criteria::eq($unique),
259		$emptyCollection = $this->emptyCollection()
260		)
261		->when($findResult = $emptyCollection->findOne($criteria))
262		->then
263		->variable($findResult)
264		->isNull()
265		->and()
266		->when(
267		$emptyCollection->add($unique),
268		$findResult = $emptyCollection->findOne($criteria)
269		)
270		->then()
271		->variable($findResult)
272		->isEqualTo($unique)
273		;
274
275		$this
276		->given(
277		$unique = $this->uniqueValue(),
278		$criteria = Criteria::eq($unique),
279		$randomCollection = $this->randomCollection()
280		)
281		->when($findResult = $randomCollection->findOne($criteria))
282		->then()
283		->variable($findResult)
284		->isNull()
285		->and()
286		->when(
287		$randomCollection->add($unique),
288		$findResult = $randomCollection->findOne($criteria)
289		)
290		->then()
291		->variable($findResult)
292		->isEqualTo($unique)
293		;
294		}
295
296		/**
297		* Test toArray.
298		*/
299	View Code Duplication	public function testToArray()
		0 ignored issues – show Duplication introduced 2016-04-20 16:17 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
300		{
301		$this
302		->given($collection = $this->randomCollection())
303		->when($array = $collection->toArray())
304		->array($array)
305		->isEqualTo(\iterator_to_array($collection->getIterator()));
306		}
307
308		/**
309		* Test slice.
310		*/
311		public function testSlice()
312		{
313		$this
314		->given($collection = $this->randomCollection())
315		->let($count = $collection->count())
316		->let($offset = rand(0, $count / 2))
317		->let($length = rand($count / 2, $count))
318		->let($maxCount = max([$count - $offset, 0]))
319		->when($slice = $collection->slice($offset, $length))
320		->then()
321		->collection($slice)
322		->size()
323		->isEqualTo(min($maxCount, $length))
324		;
325		}
326
327		/**
328		* Test sorted.
329		*/
330		public function testSorted()
331		{
332		$this
333		->given(
334		$comparator = $this->comparator(),
335		$reverseComparator = $comparator->reverse(),
336		$collection = $this->randomCollection()
337		)
338		->when($sortedCollection = $collection->sorted($comparator))
339		->then()
340		->collection($sortedCollection)
341		->isSortedUsing($comparator)
342		->collection($sortedCollection)
343		->isNotSortedUsing($reverseComparator)
344		;
345		}
346		}
347

cubiche / collections

Push — master ( 52ccab...c20e33 )

CollectionTestCase A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

18 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like